[Scripting Question] Problems with changing types of moves

[coollinker]

Hello there,

I'm currently scripting some new starters with a triple type. To make this more manageable and to make it easier for the player to utilize the STAB bonus I want to make an attack that can change its type to one of the three types of the user, which is most effective against the target.

I've been trying to use pbBaseType and pbCalcType and took inspiration of the calculations for effectiveness and the script of judgment.
The script I'm currently at is:

class Battle::Move::TypeDependsOnTargetType < Battle::Move
  def pbBaseType(user,target)
    userTypes = user.pbTypes(true)
    targetTypes = target.pbTypes(true)
    bestType = Normal
    effValue = 0.0
    userTypes.each do |type|
      effectiveness = pbCalcTypeModSingle(type, targetTypes, user, target)
      if effectiveness > effValue
        bestType = type
        effValue = effectiveness
      end
    end
    return bestType
  end
end

Some examples of how the attack should work:

• If Charizard uses it against Heracross it would be flying-type
• If Charizard uses it against Tinkaton it would be fire-type
• If Charizard uses it against a Iron Thorns it would be fire-type due to Iron Thorns 4 times resistance against flying

 

[Umbrellasia]

so what do you wanna ask?
the code seems to be correct.

 

[coollinker]

Programming-wise I don't see a problem either but problem here is that the pbBaseType thrown an exception as it only expects one (user) parameter but gets two (user, target).

So is there a work around on how I can could use to input the target too, or another function that I could use instead of pbBaseType?

 

[Umbrellasia]

Oh, now I see the problem. Your code has several mistakes, but it's not a big deal.
basically u cant pass a target into pbBaseType or pbCalcType which is only accepted a user. tbh its difficult to achieve yr goal.
if u really want to be, check pbCalcDamage(# Get the move's type), its still not an ideal way since there are too many things happen in pbUseMove.

    # Get the move's type
    #===============================================
    if @id == :SURF # change to your condition
      userTypes = user.pbTypes(true)
      targetTypes = target.pbTypes(true)
      bestType = :NORMAL
      effValue = 0.0
      userTypes.each do |type|
        typeMod = pbCalcTypeMod(type, user, target)
        if typeMod > effValue
          bestType = type
          effValue = typeMod
        end
      end
      @calcType = bestType
      target.damageState.typeMod = effValue
    end
    #===============================================
    type = @calcType   # nil is treated as physical