[Audio] Randomized cry?

[Sonikku A]

Basically for a specific Mon, I'd like it to be able to use a set of cries (in this case 3), randomly used every time it appears/is thrown out into battle
Looking at cry_tables.inc and direct_sound_data.inc in the sound folder, and pokemon.c in src. Any ideas?

 

[WiserVisor]

I see two ways of doing this, one that just affects cries in battle, but may not be 100% efficient, and another that will affect battle cries, Pokedex cries, and every other cry that will work 100%.

Regardless of which option you choose, you're obviously going to need to add your cries into the game. I'm not very skilled nor knowledgeable in that area, so if you don't know how to do that, hopefully someone who does will post in here. All I know is that you'll have to add all of your Pokemon's cries to the cry table (obviously). You should only have one of your three cries in the Pokemon's proper position within the cry table. What I mean by that is since Bulbasaur is species 1 within the game, its cry is at the top of the list. Ivysaur is species 2, so it comes after Bulbasaur's cry, and so on down the line. Whatever your Pokemon's species number is, place only one of the Pokemon's cries at that spot. Put the rest of the cries at the bottom of the cry table. You have to put the other ones at the bottom, otherwise if the Pokemon immediately after your special Pokemon were to cry, it would end up using the second cry of your new Pokemon instead of its own. Then all other Pokemon below would have their cries offset by two, causing a great deal of crying chaos. Remember the numbered positions that those other two cries at the bottom have, as well as the position of your Pokemon species, as those will be important later. I'm going to use the names CRY_2_POSITION and CRY_3_POSITION for the numbered locations of the two bottom cries.

Option 1: Just in Battle, Possibly less Efficient

Spoiler:

Assuming you only want the randomness to come into play when the Pokemon is released from the Pokeball and not when you listen to the cry on the Pokedex or if you play the cry through some other script outside of battle, we just need to look at src/pokemon.c. Within src/pokemon.c, there's a function called "DoMonFrontSpriteAnimation". Within this method, you'll see a couple of calls for these lines:

if (!noCry)
            PlayCry1(species, pan);

We are now going to replace "PlayCry1(species, pan);" with an if-else statement. (When you do this, make sure to add curly braces to the "if (!noCry)" statement if it doesn't already have them.) This new if statement should check to see if the current species that is doing the cry is this particular species that you want to have multiple cries. If it isn't things should run as normal. For example, if you wanted to make Bulbasaur have multiple cries, you'd have something like:

if (!noCry)
{
            if (species == 1)
            {
                        (The stuff we'll be adding)
            }
            else
            {
                        PlayCry1(species, pan);
            }
}

Now, within the "if (species == 1)" statement, you'll have to generate your random number, which will then determine which cry to use. Something like this will work quite nicely:

if (species == 1)
{
            switch(Random() % 3)
            {
             case 0:
                        PlayCry1(species, pan);
                        break;
            case 1:
                        PlayCry1(CRY_2_POSITION, pan);
                        break;
            case 2:
                        PlayCry1(CRY_3_POSITION, pan);
                        break;
            }
}

So first, that "Random() % 3" within the switch statement will generate a random number between 0 and 2. If it's 0, then whatever cry was placed at the Pokemon's proper position will play. This is basically having the game run as normal. If the random number was 1, it would then play the second cry, which would be one of the cries that you placed at the bottom of the cry table. Similarly, if the random number is 2, then the other cry that was placed at the bottom would be played. Just replace CRY_2/3_POSITION with whatever the proper number is for those cries. IMPORTANT TO REMEMBER: for the "species == 1" bit, make sure 1 is whatever number your species is. Otherwise you're just messing with little ol' Bulbasaur's cries.

The reason I said this may not be 100% efficient was because I'm nervous about how this method is named DoMonFRONTSpriteAnimation. It makes me think that there may be different code for when a Pokemon makes a cry while their back sprite animation is playing. I don't know if there is, and I didn't find it when I made a quick search.

Option 2: Affects All Possible Cries, Guranteed

Spoiler:

This process will make your special Pokemon have a random cry every single time it cries, whether in or out of battle. We're going to be looking at src/sound.c. At the top of this file, add:

#include "random.h"

This'll let us use the "Random()" method to randomize the cry. Now, look for the method "PlayCryInternal". Scroll down through this method until you see the line:

species--;

Immediately above this line, add this if statement:

if (species == 1)
{
            switch(Random() % 3)
            {
            case 0:
                        species = CRY_2_POSITION;
                        break;
            case 1:
                        species = CRY_3_POSITION;
                        break;
            }
}

Make sure "species == 1" uses the number of your particular Pokemon instead of 1. Otherwise, Bulbasaur is going to have some strange cries. How this works is, the code checks to see if we're dealing with our multi-voiced Pokemon. If not, things run as normal. If we are dealing with our special Pokemon, we generate a random number between 0 and 2. If it's 0, we use one of the cries that we put at the bottom of the cry table. If it's 1, we use the other one. If it's 2, nothing is changed, and we end up using the cry that was placed in the proper position of the cry table based on the Pokemon's number.

With that, you should have a randomized cry for your Pokemon. There's a lot in there, so if anything's unclear or doesn't seem to work, just let me know, and I'll try to clarify a bit more!

 

[Sonikku A]

Several things
-Is cry position just the file directory of the audio bin?
-random .h being included has this error

using Item and Battle Expansion

Edit: Fixed! include random.h just needs to be after global
Also cryposition is just mon ID. I'll use the unused unowns!
Thanks for the help!

 

[WiserVisor]

No prob! Glad to help.