[Scripting Question] Sky Battles for V18?

[DarrylBD99]

OK... so maybe sky battles are kind of dead at this point, but I still think the concept is cool and I was wondering how I can make something similar to sky battles.

 

[Turn20Negate]

Hey, I read your post and even though I'm not the biggest fan of sky battles, I decided to implement them for you. This code supports single, double and triple sky battles but I'm uncertain if it can handle partner trainers. The list of elligible Pokemon for a sky battle is based on Gen 6, so you it may have to be updated.

Script Section: PokeBattle_Battle

Spoiler:

Add this to the other accessors at the top

attr_accessor :skyBattle        # For Sky Battles

Then this inside "def initialize(scene,p1,p2,player,opponent)",

@skyBattle         = false

this function to return if a sky battle is taking place:

def maxBattlerIndex
    return (pbSideSize(0)>pbSideSize(1)) ? (pbSideSize(0)-1)*2 : pbSideSize(1)*2-1
  end
  
  [COLOR="Red"]def skyBattle?
    return @skyBattle
  end[/COLOR]
  
  #=============================================================================
  # Trainers and owner-related methods
  #=============================================================================

Update these functions:

def pbAbleCount(idxBattler=0)
    party = pbParty(idxBattler)
    count = 0
    party.each { |pkmn| count += 1 if pkmn && pkmn.able? [COLOR="Red"]&& (pkmn.skyBattler? || !self.skyBattle?)[/COLOR] }
    return count
  end

def pbAbleNonActiveCount(idxBattler=0)
    party = pbParty(idxBattler)
    inBattleIndices = []
    eachSameSideBattler(idxBattler) { |b| inBattleIndices.push(b.pokemonIndex) }
    count = 0
    party.each_with_index do |pkmn,idxParty|
      next if !pkmn || !pkmn.able?
      [COLOR="Red"]next if !pkmn.skyBattler? && self.skyBattle?[/COLOR]
      next if inBattleIndices.include?(idxParty)
      count += 1
    end
    return count
  end

def pbAbleTeamCounts(side)
    party = pbParty(side)
    partyStarts = pbPartyStarts(side)
    ret = []
    idxTeam = -1
    nextStart = 0
    party.each_with_index do |pkmn,i|
      if i>=nextStart
        idxTeam += 1
        nextStart = (idxTeam<partyStarts.length-1) ? partyStarts[idxTeam+1] : party.length
      end
      next if !pkmn || !pkmn.able?
      [COLOR="Red"]next if !pkmn.skyBattler? && self.skyBattle?[/COLOR]
      ret[idxTeam] = 0 if !ret[idxTeam]
      ret[idxTeam] += 1
    end
    return ret
  end

Script Section: Battle_StartAndEnd

Spoiler:

Change this method:

def pbSetUpSides
    ret = [[],[]]
    for side in 0...2
      # Set up wild Pokémon
      if side==1 && wildBattle?
        pbParty(1).each_with_index do |pkmn,idxPkmn|
          pbCreateBattler(2*idxPkmn+side,pkmn,idxPkmn)
          # Changes the Pokémon's form upon entering battle (if it should)
          @peer.pbOnEnteringBattle(self,pkmn,true)
          pbSetSeen(@battlers[2*idxPkmn+side])
          @usedInBattle[side][idxPkmn] = true
        end
        next
      end
      # Set up player's Pokémon and trainers' Pokémon
      trainer = (side==0) ? @player : @opponent
      requireds = []
      # Find out how many Pokémon each trainer on side needs to have
      for i in 0...@sideSizes[side]
        idxTrainer = pbGetOwnerIndexFromBattlerIndex(i*2+side)
        requireds[idxTrainer] = 0 if requireds[idxTrainer].nil?
        requireds[idxTrainer] += 1
      end
      # For each trainer in turn, find the needed number of Pokémon for them to
      # send out, and initialize them
      battlerNumber = 0
      trainer.each_with_index do |t,idxTrainer|
        ret[side][idxTrainer] = []
        eachInTeam(side,idxTrainer) do |pkmn,idxPkmn|
          next if !pkmn.able?
          [COLOR="Red"]next if !pkmn.skyBattler? && self.skyBattle?[/COLOR]
          idxBattler = 2*battlerNumber+side
          pbCreateBattler(idxBattler,pkmn,idxPkmn)
          ret[side][idxTrainer].push(idxBattler)
          battlerNumber += 1
          break if ret[side][idxTrainer].length>=requireds[idxTrainer]
        end
      end
    end
    return ret
  end

Script Section: Scene_Commands

Spoiler:

Add the marked part:

# Choose a command for the selected Pokémon
      cmdSwitch  = -1
      cmdSummary = -1
      commands = []
      commands[cmdSwitch  = commands.length] = _INTL("Switch In") if modParty[idxParty].able? [COLOR="Red"]&& (modParty[idxParty].skyBattler? || [email protected]?)[/COLOR]
      commands[cmdSummary = commands.length] = _INTL("Summary")
      commands[commands.length]              = _INTL("Cancel")
      command = scene.pbShowCommands(_INTL("Do what with {1}?",modParty[idxParty].name),commands)

Script Section: PField_Battles

Spoiler:

Add this line inside "def recordBattleRule(rule,var=nil)"

when "skybattle";              rules["skybattle"]        = true

Then add this:

# Whether the player is able to switch when an opponent's Pokémon faints
  battle.switchStyle = ($PokemonSystem.battlestyle==0)
  battle.switchStyle = battleRules["switchStyle"] if !battleRules["switchStyle"].nil?
  # Whether battle animations are shown
  battle.showAnims = ($PokemonSystem.battlescene==0)
  battle.showAnims = battleRules["battleAnims"] if !battleRules["battleAnims"].nil?
  [COLOR="Red"]# Sky Battles
  battle.skyBattle = battleRules["skybattle"] if !battleRules["skybattle"].nil?[/COLOR]
  # Terrain
  battle.defaultTerrain = battleRules["defaultTerrain"] if !battleRules["defaultTerrain"].nil?

Then add this function above "#===============================================================================
# After battles
#===============================================================================":

def pbSkyTrainerBattle(trainerID,trainerName,endSpeech=nil,doubleBattle=false,trainerPartyID=0,canLose=false,tripleBattle=false)
  trainer = pbLoadTrainer(trainerID,trainerName,trainerPartyID)
  return false if !trainer
  trainerskypokes=0
  $Trainer.party.each do |b|
    next if !b.able?
    next if !b.skyBattler?
    trainerskypokes+=1
  end
  foeskypokes=0
  trainer[2].each do |b|
    next if !b.able?
    next if !b.skyBattler?
    foeskypokes+=1
  end
  if trainerskypokes<1 || foeskypokes<1
    Kernel.pbMessage(_INTL("A trainer must have at least one elligible Pokemon to participate in a sky battle."))
    return
  elsif (trainerskypokes<2 || foeskypokes<2) && doubleBattle
    Kernel.pbMessage(_INTL("A trainer must have at least two elligible Pokemon to participate in a double sky battle."))
    return
  elsif (trainerskypokes<3 || foeskypokes<3) && tripleBattle
    Kernel.pbMessage(_INTL("A trainer must have at least three elligible Pokemon to participate in a triple sky battle."))
    return
  end
  Events.onTrainerPartyLoad.trigger(nil,trainer)
  setBattleRule("canLose") if canLose
  setBattleRule("double") if doubleBattle 
  setBattleRule("triple") if tripleBattle
  setBattleRule("skybattle")
  decision = pbTrainerBattleCore([trainerID,trainerName,trainerPartyID,endSpeech])
  return (decision==1)
end

Script Section: PokeBattle_Pokemon

Spoiler:

Add this function above "# Changes the happiness of this Pokémon depending on what happened to change it.":

def skyBattler?
    skypokes=[:CHARIZARD,:BUTTERFREE,:PIDGEOTTO,:PIDGEOT,:FEAROW,:ZUBAT,:GOLBAT,
              :GASTLY,:HAUNTER,:KOFFING,:WEEZING,:SCYTHER,:GYARADOS,:AERODACTYL,
              :ARTICUNO,:ZAPDOS,:MOLTRES,:DRAGONITE,:NOCTOWL,:LEDYBA,:LEDIAN,
              :CROBAT,:TOGETIC,:XATU,:HOPPIP,:SKIPLOOM,:JUMPLUFF,:YANMA,
              :MISDREAVUS,:UNOWWN,:GLIGAR,:MANTINE,:SKARMORY,:LUGIA,:HOOH,
              :BEAUTIFLY,:SWELLOW,:WINGULL,:PELIPPER,:MASQUERAIN,:NINJASK,
              :VIBRAVA,:FLYGON,:SWABLU,:ALTARIA,:LUNATONE,:SOLROCK,:BALTOY,
              :CLAYDOLL,:DUSKULL,:TROPIUS,:CHIMECHO,:SALAMENCE,:LATIAS,:LATIOS,
              :RAYQUAZA,:STARAVIA,:STARAPTOR,:MOTHIM,:COMBEE,:VESPIQUEN,
              :DRIFLOON,:DRIFBLIM,:MISMAGIUS,:HONCHKROW,:CHINGLING,:BRONZOR,
              :BRONZONG,:CARNIVINE,:MANTYKE,:TOGEKISS,:YANMEGA,:GLISCOR,:ROTOM,
              :UXIE,:MESPRIT,:AZELF,:CRESSELIA,:ARCEUS,:TRANQUILL,:UNFEZANT,
              :WOOBAT,:SWOOBAT,:SIGILYPH,:ARCHEOPS,:SWANNA,:EMOLGA,:TYNAMO,
              :EELEKTRIK,:EELEKTROSS,:CRYGONAL,:BRAVIARY,:MANDIBUZZ,:HYDREIGON,
              :TORNADUS,:THUNDURUS,:LANDORUS,:FLETCHINDER,:TALONFLAME,:VIVILLON,
              :NOIBAT,:NOIVERN,:YVELTAL]
    skypokes.each do |b|
      return true if isConst?(@species,PBSpecies,b)
    end
    return true if isConst?(@species,PBSpecies,:GIRATINA) && @form==1
    return false
  end

Script Section: Battler_UseMove_SuccessChecks

Spoiler:

Insert this part:

# Two-turn attacks can't fail here in the charging turn
    return true if user.effects[PBEffects::TwoTurnAttack]>0
    # Move-specific failures
    return false if move.pbFailsAgainstTarget?(user,target)
    [COLOR="Red"]# Sky Battle moves
    return false if move.pbFailsInSkyBattles? && @battle.skyBattle?[/COLOR]
    # Crafty Shield
    if target.pbOwnSide.effects[PBEffects::CraftyShield] && user.index!=target.index &&

Script Section: PokeBattle_Move

Spoiler:

Finally add this method above the final "end" in this script section:

  def pbFailsInSkyBattles?
    skymoves=[:BODYSLAM,:BULLDOZE,:DIG,:DIVE,:EARTHPOWER,:EARTHQUAKE,
              :ELECTRICTERRAIN,:FIREPLEDGE,:FISSURE,:FLYINGPRESS,:FRENZYPLANT,
              :GEOMANCY,:GRASSKNOT,:GRASSPLEDGE,:GRASSYTERRAIN,:GRAVITY,
              :HEATCRASH,:HEAVYSLAM,:INGRAIN,:LANDSWRATH,:MAGNITUDE,:MATBLOCK,
              :MISTYTERRAIN,:MUDSPORT,:MUDDYWATER,:ROTOTILLER,:SEISMICTOSS,
              :SLAM,:SMACKDOWN,:SPIKES,:STOMP,:SUBSTITUTE,:SURF,:THOUSANDARROWS,
              :THOUSANDWAVES,:TOXICSPIKES,:WATERPLEDGE,:WATERSPORT]
    skymoves.each do |m|
      if isConst?(self.id,PBMoves,m)
        @battle.pbDisplay(_INTL("But it failed!"))
        return true 
      end
    end
    return false
  end

 

[DarrylBD99]

Hey, I read your post and even though I'm not the biggest fan of sky battles, I decided to implement them for you. This code supports single, double and triple sky battles but I'm uncertain if it can handle partner trainers. The list of elligible Pokemon for a sky battle is based on Gen 6, so you it may have to be updated.

Script Section: PokeBattle_Battle

Spoiler:

Add this to the other accessors at the top

attr_accessor :skyBattle        # For Sky Battles

Then this inside "def initialize(scene,p1,p2,player,opponent)",

@skyBattle         = false

this function to return if a sky battle is taking place:

def maxBattlerIndex
    return (pbSideSize(0)>pbSideSize(1)) ? (pbSideSize(0)-1)*2 : pbSideSize(1)*2-1
  end
  
  [COLOR="Red"]def skyBattle?
    return @skyBattle
  end[/COLOR]
  
  #=============================================================================
  # Trainers and owner-related methods
  #=============================================================================

Update these functions:

def pbAbleCount(idxBattler=0)
    party = pbParty(idxBattler)
    count = 0
    party.each { |pkmn| count += 1 if pkmn && pkmn.able? [COLOR="Red"]&& (pkmn.skyBattler? || !self.skyBattle?)[/COLOR] }
    return count
  end

def pbAbleNonActiveCount(idxBattler=0)
    party = pbParty(idxBattler)
    inBattleIndices = []
    eachSameSideBattler(idxBattler) { |b| inBattleIndices.push(b.pokemonIndex) }
    count = 0
    party.each_with_index do |pkmn,idxParty|
      next if !pkmn || !pkmn.able?
      [COLOR="Red"]next if !pkmn.skyBattler? && self.skyBattle?[/COLOR]
      next if inBattleIndices.include?(idxParty)
      count += 1
    end
    return count
  end

def pbAbleTeamCounts(side)
    party = pbParty(side)
    partyStarts = pbPartyStarts(side)
    ret = []
    idxTeam = -1
    nextStart = 0
    party.each_with_index do |pkmn,i|
      if i>=nextStart
        idxTeam += 1
        nextStart = (idxTeam<partyStarts.length-1) ? partyStarts[idxTeam+1] : party.length
      end
      next if !pkmn || !pkmn.able?
      [COLOR="Red"]next if !pkmn.skyBattler? && self.skyBattle?[/COLOR]
      ret[idxTeam] = 0 if !ret[idxTeam]
      ret[idxTeam] += 1
    end
    return ret
  end

Script Section: Battle_StartAndEnd

Spoiler:

Change this method:

def pbSetUpSides
    ret = [[],[]]
    for side in 0...2
      # Set up wild Pokémon
      if side==1 && wildBattle?
        pbParty(1).each_with_index do |pkmn,idxPkmn|
          pbCreateBattler(2*idxPkmn+side,pkmn,idxPkmn)
          # Changes the Pokémon's form upon entering battle (if it should)
          @peer.pbOnEnteringBattle(self,pkmn,true)
          pbSetSeen(@battlers[2*idxPkmn+side])
          @usedInBattle[side][idxPkmn] = true
        end
        next
      end
      # Set up player's Pokémon and trainers' Pokémon
      trainer = (side==0) ? @player : @opponent
      requireds = []
      # Find out how many Pokémon each trainer on side needs to have
      for i in 0...@sideSizes[side]
        idxTrainer = pbGetOwnerIndexFromBattlerIndex(i*2+side)
        requireds[idxTrainer] = 0 if requireds[idxTrainer].nil?
        requireds[idxTrainer] += 1
      end
      # For each trainer in turn, find the needed number of Pokémon for them to
      # send out, and initialize them
      battlerNumber = 0
      trainer.each_with_index do |t,idxTrainer|
        ret[side][idxTrainer] = []
        eachInTeam(side,idxTrainer) do |pkmn,idxPkmn|
          next if !pkmn.able?
          [COLOR="Red"]next if !pkmn.skyBattler? && self.skyBattle?[/COLOR]
          idxBattler = 2*battlerNumber+side
          pbCreateBattler(idxBattler,pkmn,idxPkmn)
          ret[side][idxTrainer].push(idxBattler)
          battlerNumber += 1
          break if ret[side][idxTrainer].length>=requireds[idxTrainer]
        end
      end
    end
    return ret
  end

Script Section: Scene_Commands

Spoiler:

Add the marked part:

# Choose a command for the selected Pokémon
      cmdSwitch  = -1
      cmdSummary = -1
      commands = []
      commands[cmdSwitch  = commands.length] = _INTL("Switch In") if modParty[idxParty].able? [COLOR="Red"]&& (modParty[idxParty].skyBattler? || [email protected]?)[/COLOR]
      commands[cmdSummary = commands.length] = _INTL("Summary")
      commands[commands.length]              = _INTL("Cancel")
      command = scene.pbShowCommands(_INTL("Do what with {1}?",modParty[idxParty].name),commands)

Script Section: PField_Battles

Spoiler:

Add this line inside "def recordBattleRule(rule,var=nil)"

when "skybattle";              rules["skybattle"]        = true

Then add this:

# Whether the player is able to switch when an opponent's Pokémon faints
  battle.switchStyle = ($PokemonSystem.battlestyle==0)
  battle.switchStyle = battleRules["switchStyle"] if !battleRules["switchStyle"].nil?
  # Whether battle animations are shown
  battle.showAnims = ($PokemonSystem.battlescene==0)
  battle.showAnims = battleRules["battleAnims"] if !battleRules["battleAnims"].nil?
  [COLOR="Red"]# Sky Battles
  battle.skyBattle = battleRules["skybattle"] if !battleRules["skybattle"].nil?[/COLOR]
  # Terrain
  battle.defaultTerrain = battleRules["defaultTerrain"] if !battleRules["defaultTerrain"].nil?

Then add this function above "#===============================================================================
# After battles
#===============================================================================":

def pbSkyTrainerBattle(trainerID,trainerName,endSpeech=nil,doubleBattle=false,trainerPartyID=0,canLose=false,tripleBattle=false)
  trainer = pbLoadTrainer(trainerID,trainerName,trainerPartyID)
  return false if !trainer
  trainerskypokes=0
  $Trainer.party.each do |b|
    next if !b.able?
    next if !b.skyBattler?
    trainerskypokes+=1
  end
  foeskypokes=0
  trainer[2].each do |b|
    next if !b.able?
    next if !b.skyBattler?
    foeskypokes+=1
  end
  if trainerskypokes<1 || foeskypokes<1
    Kernel.pbMessage(_INTL("A trainer must have at least one elligible Pokemon to participate in a sky battle."))
    return
  elsif (trainerskypokes<2 || foeskypokes<2) && doubleBattle
    Kernel.pbMessage(_INTL("A trainer must have at least two elligible Pokemon to participate in a double sky battle."))
    return
  elsif (trainerskypokes<3 || foeskypokes<3) && tripleBattle
    Kernel.pbMessage(_INTL("A trainer must have at least three elligible Pokemon to participate in a triple sky battle."))
    return
  end
  Events.onTrainerPartyLoad.trigger(nil,trainer)
  setBattleRule("canLose") if canLose
  setBattleRule("double") if doubleBattle 
  setBattleRule("triple") if tripleBattle
  setBattleRule("skybattle")
  decision = pbTrainerBattleCore([trainerID,trainerName,trainerPartyID,endSpeech])
  return (decision==1)
end

Script Section: PokeBattle_Pokemon

Spoiler:

Add this function above "# Changes the happiness of this Pokémon depending on what happened to change it.":

def skyBattler?
    skypokes=[:CHARIZARD,:BUTTERFREE,:PIDGEOTTO,:PIDGEOT,:FEAROW,:ZUBAT,:GOLBAT,
              :GASTLY,:HAUNTER,:KOFFING,:WEEZING,:SCYTHER,:GYARADOS,:AERODACTYL,
              :ARTICUNO,:ZAPDOS,:MOLTRES,:DRAGONITE,:NOCTOWL,:LEDYBA,:LEDIAN,
              :CROBAT,:TOGETIC,:XATU,:HOPPIP,:SKIPLOOM,:JUMPLUFF,:YANMA,
              :MISDREAVUS,:UNOWWN,:GLIGAR,:MANTINE,:SKARMORY,:LUGIA,:HOOH,
              :BEAUTIFLY,:SWELLOW,:WINGULL,:PELIPPER,:MASQUERAIN,:NINJASK,
              :VIBRAVA,:FLYGON,:SWABLU,:ALTARIA,:LUNATONE,:SOLROCK,:BALTOY,
              :CLAYDOLL,:DUSKULL,:TROPIUS,:CHIMECHO,:SALAMENCE,:LATIAS,:LATIOS,
              :RAYQUAZA,:STARAVIA,:STARAPTOR,:MOTHIM,:COMBEE,:VESPIQUEN,
              :DRIFLOON,:DRIFBLIM,:MISMAGIUS,:HONCHKROW,:CHINGLING,:BRONZOR,
              :BRONZONG,:CARNIVINE,:MANTYKE,:TOGEKISS,:YANMEGA,:GLISCOR,:ROTOM,
              :UXIE,:MESPRIT,:AZELF,:CRESSELIA,:ARCEUS,:TRANQUILL,:UNFEZANT,
              :WOOBAT,:SWOOBAT,:SIGILYPH,:ARCHEOPS,:SWANNA,:EMOLGA,:TYNAMO,
              :EELEKTRIK,:EELEKTROSS,:CRYGONAL,:BRAVIARY,:MANDIBUZZ,:HYDREIGON,
              :TORNADUS,:THUNDURUS,:LANDORUS,:FLETCHINDER,:TALONFLAME,:VIVILLON,
              :NOIBAT,:NOIVERN,:YVELTAL]
    skypokes.each do |b|
      return true if isConst?(@species,PBSpecies,b)
    end
    return true if isConst?(@species,PBSpecies,:GIRATINA) && @form==1
    return false
  end

Script Section: Battler_UseMove_SuccessChecks

Spoiler:

Insert this part:

# Two-turn attacks can't fail here in the charging turn
    return true if user.effects[PBEffects::TwoTurnAttack]>0
    # Move-specific failures
    return false if move.pbFailsAgainstTarget?(user,target)
    [COLOR="Red"]# Sky Battle moves
    return false if move.pbFailsInSkyBattles?(move)[/COLOR]
    # Crafty Shield
    if target.pbOwnSide.effects[PBEffects::CraftyShield] && user.index!=target.index &&

Script Section: PokeBattle_Move

Spoiler:

Finally add this method above the final "end" in this script section:

  def pbFailsInSkyBattles?(move)
    skymoves=[:BODYSLAM,:BULLDOZE,:DIG,:DIVE,:EARTHPOWER,:EARTHQUAKE,
              :ELECTRICTERRAIN,:FIREPLEDGE,:FISSURE,:FLYINGPRESS,:FRENZYPLANT,
              :GEOMANCY,:GRASSKNOT,:GRASSPLEDGE,:GRASSYTERRAIN,:GRAVITY,
              :HEATCRASH,:HEAVYSLAM,:INGRAIN,:LANDSWRATH,:MAGNITUDE,:MATBLOCK,
              :MISTYTERRAIN,:MUDSPORT,:MUDDYWATER,:ROTOTILLER,:SEISMICTOSS,
              :SLAM,:SMACKDOWN,:SPIKES,:STOMP,:SUBSTITUTE,:SURF,:THOUSANDARROWS,
              :THOUSANDWAVES,:TOXICSPIKES,:WATERPLEDGE,:WATERSPORT]
    skymoves.each do |m|
      if isConst?(move.id,PBMoves,m)
        @battle.pbDisplay(_INTL("But it failed!"))
        return true 
      end
    end
    return false
  end

Thank you so much, I really appreciate it!

 

[Turn20Negate]

Quick update on a bug I found in "Battler_UseMove_SuccessChecks":

return false if move.pbFailsInSkyBattles? [COLOR="Red"]&& @battle.skyBattle?[/COLOR]

The red part needs to be added otherwise these moves fail in all battles. Updated the original post as well.