[Scripting Question] Stuck on abilities and moves

[HeroesFightingFear]

I had a few ability and move ideas that I'm stuck on. If anyone could help me, that'd be great!

Abilities
1. Tidal Tempest - Doubles the power of Electric- and Water-type moves in rain.
2. Another Side - Changes forms depending on the use of Fairy- or Dark-type moves.
3. Charmed One - Doubles the power of Mystical Fire, and doubles the priority of moves like Magic Room, Magic Coat, Hex, etc. (classified as Magical Moves)

Moves
1. Tsunami Rush - 120 Base Power, Water-type, chance to confuse, functions like a non-HM Surf.
2. Sharpened Slash - 140 Base Power, Steel-type, high crit ratio, functions like a non-HM Cut.
3. Blackest Night - One-Hit KO, Dark-type, ignores accuracy drops and checks. (For balancing reasons, only one Pokemon would get this)
4. Harmful Spell - 90 Base Power, Psychic-type, super effective on Dark-types.

 

[HeroesFightingFear]

I had a few ability and move ideas that I'm stuck on. If anyone could help me, that'd be great!

Abilities
1. Tidal Tempest - Doubles the power of Electric- and Water-type moves in rain.
2. Another Side - Changes forms depending on the use of Fairy- or Dark-type moves.
3. Charmed One - Doubles the power of Mystical Fire, and doubles the priority of moves like Magic Room, Magic Coat, Hex, etc. (classified as Magical Moves)

Moves
1. Tsunami Rush - 120 Base Power, Water-type, chance to confuse, functions like a non-HM Surf.
2. Sharpened Slash - 140 Base Power, Steel-type, high crit ratio, functions like a non-HM Cut.
3. Blackest Night - One-Hit KO, Dark-type, ignores accuracy drops and checks. (For balancing reasons, only one Pokemon would get this)
4. Harmful Spell - 90 Base Power, Psychic-type, super effective on Dark-types.

Looking over my post, Blackest Night is the easiest of these, and Another Side is the second easiest. From there, it gets progressively more difficult.

 

[ArchyTheArc]

should be able to help here;
Tidal Tempest is the most simple of the abilites:

Spoiler:

Find sandforce in Pokebattle_move

    if attacker.hasWorkingAbility(:TIDALTEMPEST) &&
       @battle.pbWeather==PBWeather::RAINDANCE&&
       (isConst?(type,PBTypes,:WATER) ||
       isConst?(type,PBTypes,:ELECTRIC))
      damagemult=(damagemult*2).round
    end

for reference sandforce boosts it by 1.3x not 2x so might be very broken in some cases.

Another Side, is not AS easy but not the worst, i've used clefairy as the test subject, replace it with the species that gets the ability:

Spoiler:

Note you went specific so form 1 will be its "fairy" move form and form 0, its base is its "dark" move form.

    # Another Side
    if hasWorkingAbility(:ANOTHERSIDE) && isConst?(species,PBSpecies,:CLEFAIRY) &&
       !@effects[PBEffects::Transform]
      if isConst?(type,PBTypes,:FAIRY) && self.form!=1
        self.form=1
        pbUpdate(true)
        @battle.scene.pbChangePokemon(self,@pokemon)
        @battle.pbDisplay(_INTL("{1} changed to Fairy Forme!",pbThis))
        PBDebug.log("[Form changed] #{pbThis} changed to Fairy Forme")
      elsif isConst?(type,PBTypes,:DARK) && self.form!=0
        self.form=0
        pbUpdate(true)
        @battle.scene.pbChangePokemon(self,@pokemon)
        @battle.pbDisplay(_INTL("{1} changed to Dark Forme!",pbThis))
        PBDebug.log("[Form changed] #{pbThis} changed to Dark Forme")
      end      
    end

Should work, might have issues with it detecting the moves so might need some added changes. also id add another side to any other parts stance change is apart of (in trace and stuff so it cant be copied)

Charmed One isnt that hard, you mention classifying them as magical moves so make sure you have a flag for that and all the wanted moves get that flag.

Spoiler:

I'll be going off it gaining one level of priotity as doubling it might have issues.
easier one, go to mystical fires move code (045) in moveEffects.
before the last end of the code (or before additionaleffects) in its code add this:

def pbModifyDamage(damagemult,attacker,opponent)
    if isConst?(@id,PBMoves,:MYSTICALFIRE) &&~
      attacker.hasWorkingAbility(:CHARMEDONES)
      return (damagemult*2.0).round
    end
    return damagemult
  end

Again this makes mystical fire a base 130 move, with 100% accuracy and lowers stats, your choice but would have it max 1.5x myself.

next find prankster in pokebattle_battler first:

    if user.hasWorkingAbility(:CHARMEDONE) && thismove.isMagicalMove?
      p+=1
    end

Make sure the ismagicalmove? matches your flag name for them.
again find prankster in pokebattle_battle:

        pri+=1 if @battlers[i].hasWorkingAbility(:CHARMEDONE) &&
                  @choices[i][2].isMagicalMove?

Should be it, could find a nerf way like prankster with dark moves but thats your choice.

with the abilities done we can look at the moves, personally non-hm stuff isnt related to move coding and i dont want to mess with it myself, but look for mvoes that just have a chance to confuse for tsunami and make that its move code, and for sharpened slash find the flag for high crit ratio.
for the one hit just copy other one hit move and make the accuracy 0, making it always hit.

shall help with the last in a bit but its the more, long way moves.

 

[HeroesFightingFear]

Had a few more ideas that I'm not sure how to do.

Abilities
1. Accursed Presence - Works like Intimidate, but inflicts a curse on the foe(s).
2. Inky Black - Sets up the Total Darkness weather condition.
3. Unforgiving Cold - Sets up the Hailstorm weather condition.

Moves
1. Shaman Slash - A stronger Slash that's super effective on Ghost-types.
2. Intense Heat - A variation of Blast Burn that's super effective on Water-types.

Weather Conditions New!
1. Total Darkness - A weather condition that protects Dark-types when set up.
2. Hailstorm - A stronger variant of Hail along the lines of Harsh Sun/Heavy Rain.