Your pokemon are too type focused. You're very specialist in your fighting as opposed to generalist, the difference being a specialist focuses on training a pokemon to fight only what it has a type advantage against, and do it very well. Generalists balance their pokemon to take on as many odd-combinations or type-trumping opponnents as possible.
(These are in no specific order)
I fear for your charizard. Might I suggest this instead:
----
Charizard
Charcoal/ Wise Glasses/ Sharp Beak
Roost
Flamethrower/Heat Wave
Dragon Pulse
Air Slash
----
Charizard's speed makes it a good candidate for Air Slash's flinch opportunity (30%) and your outrageously high Sp. Atk. would make a Heat Wave in 1-1 battles devestating. Dragon Pulse is a safe move as not too many types are resistant to it.
*Note, as a breeder, I would have made a charmander learn antientpower over Dragon Pulse.
Your Machamp has the same problem, but because it is a fighting type it may not be as big an issue. Try giving it a little more variety. Also, I strongly advise you NOT to use dynamic punch if Machamp does not have the NO GUARD ability.
----
Machamp
Black belt
- Dynamic Punch/ Close Combat (depending on machamp's ability)
- Ice Punch (egg move/HG/SS move tutor)
- Secret Power
- Earthquake
----
Machamp is an "expend and die" pokemon. It comes out, fights hard, and dies. Focus on dealing as many hard hits as possible before Machamp gets knocked out. Secret Power's 30% chance of a status ailment may keep it alive longer, as will dynamic punch's confusion.
----
Vaporeon
Leftovers
Aqua Ring
Protect
Ice Beam
Brine/ Toxic
----
Having trained a vaporeon, I know this moveset to be a beast. Vaporeon is an HP monster, and a pain in the rear to KO. Blissey beware, Vaporeon's defensive stat is far higher, and it can actually fight back. Use Vaporeon to outlast your opponent before delivering a final attack.
*Note; this strategy for Vaporeon is most effective in double battles where it has a partner to fight during its protect and recover turns.
Jab2033 has pretty good ideas on the rest though, very knowledgable. Let me know which you choose, if either.