[Scripting Question] Updating my custom script to v17

[ArchyTheArc]

So updating to v17 from v16, and i have a custom version of the pokegear, thats heavily different, however i cant load it in the same way as i did in v16 (same script) it was from within a button press in scene_map

      if $Trainer.pokephone || $DEBUG
        pbLoadRpgxpScene(Scene_Pokephone.new)
      elsif $Trainer.pokegear
        pbLoadRpgxpScene(Scene_Pokegear.new)
      end

Now this is actually fine, but when i close the menu i get a crash, now i use "$scene = Scene_Map.new" and that causes a crash with "playersprite". the script is unchanged from v16 its just exiting (tried changing to break but that causes another error.
I'll leave the script below, but subject area is

  def update_command
    if Input.trigger?(Input::B)
      if $game_variables[91]>=1
        $game_variables[91]-=1
        $scene = Scene_Pokephone.new
      else
        pbPlayCancelSE()
        $scene = Scene_Map.new <<< Here
        $game_switches[340] = false
          $game_switches[518] = false
          $game_variables[91]=0
        return
      end
    end

and heres the full code. I also did try rewriting it to the new pokegear code but its met with failed attempts.

Spoiler:

BGPATH="Graphics/Pictures/pokephonebg0_0"
CHARMPATH="Graphics/Pictures/pokephonecharm0"

class PokephoneButton < SpriteWrapper
  attr_reader :index
  attr_reader :name
  attr_accessor :selected

  def initialize(x,y,name="",index=0,viewport=nil)
    super(viewport)
    @index=index
    @name=name
    @selected=false
    fembutton=pbResolveBitmap(sprintf("Graphics/Pictures/pokephoneButtonf"))
    if $Trainer.isFemale? && fembutton
      @button=AnimatedBitmap.new("Graphics/Pictures/pokephoneButtonf")
    else
      @button=AnimatedBitmap.new("Graphics/Pictures/pokephoneButton")
    end
    @contents=BitmapWrapper.new(@button.width,@button.height)
    self.bitmap=@contents
    self.x=x
    self.y=y
    refresh
    update
  end

  def dispose
    @button.dispose
    @contents.dispose
    super
  end

  def refresh
    self.bitmap.clear
    self.bitmap.blt(0,0,@button.bitmap,Rect.new(0,0,@button.width,@button.height))
    base   = Color.new(248,248,248)
    shadow = Color.new(104,104,104)
    displayed=0
    pbSetSystemFont(self.bitmap)
   # textpos=[          # Name is written on both unselected and selected buttons
   #    [@name,self.bitmap.width/2,10,2,Color.new(248,248,248),Color.new(40,40,40)],
   #    [@name,self.bitmap.width/2,62,2,Color.new(248,248,248),Color.new(40,40,40)]
   # ]
   # pbDrawTextPositions(self.bitmap,textpos)
    icon=sprintf("Graphics/Pictures/pokephone"+@name)
    imagepos=[         # Icon is put on both unselected and selected buttons
       [icon,6,122,0,0,-1,-1],
       [icon,6,6,0,0,-1,-1]
       #[icon,18,10,0,0,-1,-1],
       #[icon,18,62,0,0,-1,-1]
    ]
    pbDrawImagePositions(self.bitmap,imagepos)
    
  end

  def update
    if self.selected
      self.src_rect.set(0,self.bitmap.height/2,self.bitmap.width,self.bitmap.height/2)
    else
      self.src_rect.set(0,0,self.bitmap.width,self.bitmap.height/2)
    end
    super
  end
end



#===============================================================================
# - Scene_Pokegear
#-------------------------------------------------------------------------------
# Modified By Harshboy
# Modified by Peter O.
# Also Modified By OblivionMew
# Overhauled by Maruno
#===============================================================================
class Scene_Pokephone
  #-----------------------------------------------------------------------------
  # initialize
  #-----------------------------------------------------------------------------
  def initialize(menu_index = 0)
    @menu_index = menu_index
  end
  #-----------------------------------------------------------------------------
  # main
  #-----------------------------------------------------------------------------
  def main
    commands=[]
# OPTIONS - If you change these, you should also change update_command below.
    @cmdMap=-1
    @cmdContacts=-1
    @cmdJukebox=-1
    @cmdNext1=-1
    @cmdHudskins=-1
    @cmdStorage=-1
    @cmdGames=-1
    @cmdNext2=-1
    @cmdGuideBook=-1
    @cmdVSHunter=-1
    @cmdNext3=-1
    @cmdLandmarks=-1
    @cmdSightings=-1
    #@cmdHistory=-1
    @cmdCases=-1
    @cmdBack=-1
    commands[@cmdMap=commands.length]=_INTL("Map") if !$game_switches[340] && $game_variables[91]==0
    commands[@cmdContacts=commands.length]=_INTL("Contacts") if !$game_switches[340] && $game_variables[91]==0
    commands[@cmdJukebox=commands.length]=_INTL("Jukebox") if !$game_switches[340] && $game_variables[91]==0
    commands[@cmdNext1=commands.length]=_INTL("Next") if !$game_switches[340] && $game_variables[91]==0
    
    
    commands[@cmdHudskins=commands.length]=_INTL("Hudskins") if !$game_switches[340] && $game_variables[91]==1
    commands[@cmdGuideBook=commands.length]=_INTL("Guide Book") if !$game_switches[340] && $game_variables[89]>=1 && $game_variables[91]==1
    commands[@cmdVSHunter=commands.length]=_INTL("VS Hunter") if !$game_switches[340] && $game_variables[89]>=2  && $game_variables[91]==1
    commands[@cmdStorage=commands.length]=_INTL("Storage") if !$game_switches[340] && $game_variables[89]>=3 && $game_variables[91]==1
    commands[@cmdNext2=commands.length]=_INTL("Next") if !$game_switches[340] && $game_variables[91]==1 && $game_variables[89]>=3
    
    commands[@cmdGames=commands.length]=_INTL("Games") if !$game_switches[340] && $game_variables[89]>=3 && $game_variables[91]==2
    commands[@cmdNext3=commands.length]=_INTL("Next") if !$game_switches[340] && $game_variables[91]==2 && $game_variables[89]>=3
    
    commands[@cmdLandmarks=commands.length]=_INTL("Landmarks") if $game_switches[340]
    commands[@cmdSightings=commands.length]=_INTL("Sightings") if $game_switches[340]
    #commands[@cmdHistory=commands.length]=_INTL("History")  if $game_switches[340] 
    commands[@cmdCases=commands.length]=_INTL("Yancy Cases") if $game_switches[340] && $game_switches[403]
    commands[@cmdBack=commands.length]=_INTL("Back") if $game_switches[340] 
    @viewport=Viewport.new(0,0,Graphics.width,Graphics.height)
    @viewport.z=99999
    @button=AnimatedBitmap.new("Graphics/Pictures/pokephoneButton")
    @sprites={}
    #@sprites["background"].setBitmap("Graphics/Pictures/pokephonebg")
    drawBarFromPath = BGPATH  != ""
      if drawBarFromPath
        @sprites["background"]=IconSprite.new(0,0,@viewport)
        @sprites["background"].setBitmap("Graphics/Pictures/pokephonebg#{$game_variables[124]}_#{$game_variables[102]}")
      end
    drawcharmFromPath = CHARMPATH  != ""
      if drawBarFromPath
        @sprites["charm"]=IconSprite.new(0,0,@viewport)
        @sprites["charm"].setBitmap("Graphics/Pictures/pokephonecharm#{$game_variables[121]}")
      end
    @sprites["command_window"] = Window_CommandPokemon.new(commands,160)
    @sprites["command_window"].visible = false
    @sprites["command_window"].index = @menu_index
    for i in 0...commands.length
      x=220 - (6*24) + (i*84)+114
      y=60+48
      @sprites["button#{i}"]=PokephoneButton.new(x,y,commands[i],i,@viewport)
      @sprites["button#{i}"].selected=(i==@sprites["command_window"].index)
      @sprites["button#{i}"].update
    end
    @sprites["overlay"]=BitmapSprite.new(
    Graphics.width,Graphics.height,@viewport)
    pbSetSystemFont(@sprites["overlay"].bitmap)
    @dateString=""
    updateDateIfNecessary
    Graphics.transition
    loop do
      Graphics.update
      Input.update
      update
      if $scene != self
        break
      end
    end
    Graphics.freeze
    pbDisposeSpriteHash(@sprites)
  end
 #-----------------------------------------------------------------------------
  # update the date display if necessary
  #-----------------------------------------------------------------------------
  def updateDateIfNecessary
    showSeconds = true # Make it false to won't show the seconds
    newDate = pbGetTimeNow.strftime(showSeconds ? "%I:%M:%S %p" : "%I:%M %p")
    return false if @dateString==newDate
    @dateString=newDate  
    overlay=@sprites["overlay"].bitmap
    overlay.clear 
    baseColor=Color.new(248,248,248)
    shadowColor=Color.new(106,106,106)
    textPositions = []
    textPositions.push([@dateString,Graphics.width/2,-2+48,2,baseColor,shadowColor])
    #textPositions=[
    #   [@dateString,Graphics.width/2,-2,2,baseColor,shadowColor]]
    displayed=0
    for i in 0...OBJECTIVELIST.length
      newDisplay=OBJECTIVELIST[i]
      next if !$game_switches[newDisplay[0]]
      next if $game_switches[newDisplay[1]]
      break if displayed>=3
      textPositions.push([_INTL("{1}",newDisplay[2]),316+120+114,186+(20*displayed)+48,1,baseColor,shadowColor]) if !$game_switches[newDisplay[1]]
      textPositions.push([_INTL("{1} **",newDisplay[2]),316+120+114,186+(20*displayed)+48,1,baseColor,shadowColor]) if $game_switches[newDisplay[1]]
      #textpos.push([_INTL("Yo"),216,286+(20*displayed),1,base,shadow])
      displayed+=1
    end
    if displayed==0
      textPositions.push([_INTL("All done, for now."),316+120+114,186,1,baseColor,shadowColor])
    end
    pbDrawTextPositions(overlay,textPositions)
    return true
  end
  
  def updateObjectives
    overlay=@sprites["overlay"].bitmap
    overlay.clear 
    base=Color.new(248,248,248)
    shadow=Color.new(106,106,106)
    displayed=0
    textpos = []
    for i in 0...OBJECTIVELIST.length
      newDisplay=OBJECTIVELIST[i]
      #next if $game_switches[newDisplay[0]]==false || $game_switches[newDisplay[1]]==true
      break if displayed>=3
      textpos.push([_INTL("{1}",newDisplay[2]),216+114,286+(20*displayed)+48,1,base,shadow])
      #textpos.push([_INTL("Yo"),216,286+(20*displayed),1,base,shadow])
      displayed+=1
    end
    #textPositions=[
    #   [@dateString,Graphics.width/2,-2,2,baseColor,shadowColor]]
    pbDrawTextPositions(overlay,textpos)
    return true
  end
  #-----------------------------------------------------------------------------
  # update the scene
  #-----------------------------------------------------------------------------
  def update
    updateDateIfNecessary
    #updateObjectives
    for i in 0...@sprites["command_window"].commands.length
      sprite=@sprites["button#{i}"]
      sprite.selected=(i==@sprites["command_window"].index) ? true : false
    end
    pbUpdateSpriteHash(@sprites)
    #update command window and the info if it's active
    if @sprites["command_window"].active
      update_command
      return
    end
  end
  #-----------------------------------------------------------------------------
  # update the command window
  #-----------------------------------------------------------------------------
  def update_command
    if Input.trigger?(Input::B)
      if $game_variables[91]>=1
        $game_variables[91]-=1
        $scene = Scene_Pokephone.new
      else
        pbPlayCancelSE()
        $scene = Scene_Map.new
        $game_switches[340] = false
          $game_switches[518] = false
          $game_variables[91]=0
        return
      end
    end
    if Input.trigger?(Input::X)
        pbPlayDecisionSE()
        Kernel.pbMessage(_INTL("\\c[7]POKEPHONE CHECKING FOR UPDATES."))
        Kernel.pbMessage(_INTL("\\c[7]. . ."))
        Kernel.pbMessage(_INTL("\\c[7]. . . . ."))
        if $game_switches[402]==true && $game_variables[89]==0 
          Kernel.pbMessage(_INTL("\\c[7]NEW APP DOWNLOADED."))
          Kernel.pbMessage(_INTL("\\c[7]GUIDEBOOK DOWNLOADED."))
          $game_variables[89]+=1
        elsif $game_switches[524]==true && $game_variables[89]==1
          Kernel.pbMessage(_INTL("\\c[7]NEW APP DOWNLOADED."))
          Kernel.pbMessage(_INTL("\\c[7]VS HUNTER DOWNLOADED."))
          $game_variables[89]+=1
        elsif $game_switches[523]==true && $game_variables[89]==2
          Kernel.pbMessage(_INTL("\\c[7]NEW APP DOWNLOADED."))
          Kernel.pbMessage(_INTL("\\c[7]STORAGE DOWNLOADED."))
          $game_variables[89]+=1
        elsif $game_switches[522]==true && $game_variables[89]==3
          Kernel.pbMessage(_INTL("\\c[7]NEW APP DOWNLOADED."))
          Kernel.pbMessage(_INTL("\\c[7]GAMES DOWNLOADED."))
          $game_variables[89]+=1
        else
          Kernel.pbMessage(_INTL("\\c[7]NO NEW APPS."))
        end
        $scene = Scene_Pokephone.new
      return
    end
    if Input.trigger?(Input::Z)
      command=[]
      list=[
      _INTL("Cases"),
      _INTL("Wallpaper"),
      _INTL("Charms"),
      _INTL("Cancel")
      ]
      command=Kernel.pbMessage(_INTL("What do you want to customize?"),list,0)
      # Cases
      if command==0
        command=[]
        list=[
        _INTL("Grey Case"),
        _INTL("Red Case"),
        _INTL("Blue Case"),
        _INTL("Yellow Case"),
        _INTL("Green Case"),
        _INTL("Neon Case"),
        _INTL("Fire Case"),
        _INTL("Water Case"),
        _INTL("Grass Case"),
        _INTL("Back")
        ]
        command=Kernel.pbMessage(_INTL("What case do you want on?"),list,0)
        # Grey Case
        if command==0 
          if $PokemonBag.pbHasItem?(:GREYCASE)
            Kernel.pbMessage(_INTL("The grey case is now on."))
            $game_variables[124]=0
            $scene = Scene_Pokephone.new
          else
            Kernel.pbMessage(_INTL("You dont own the grey case."))
          end
        # Red Case
        elsif command==1 
          if $PokemonBag.pbHasItem?(:REDCASE)
            Kernel.pbMessage(_INTL("The red case is now on."))
            $game_variables[124]=1
            $scene = Scene_Pokephone.new
          else
            Kernel.pbMessage(_INTL("You dont own the red case."))
          end
        # Blue Case
        elsif command==2
          if $PokemonBag.pbHasItem?(:BLUECASE)
            Kernel.pbMessage(_INTL("The blue case is now on."))
            $game_variables[124]=2
            $scene = Scene_Pokephone.new
          else
            Kernel.pbMessage(_INTL("You dont own the blue case."))
          end
        # Yellow Case
        elsif command==3
          if $PokemonBag.pbHasItem?(:YELLOWCASE)
            Kernel.pbMessage(_INTL("The yellow case is now on."))
            $game_variables[124]=3
            $scene = Scene_Pokephone.new
          else
            Kernel.pbMessage(_INTL("You dont own the yellow case."))
          end
        # Green Case
        elsif command==4
          if $PokemonBag.pbHasItem?(:GREENCASE)
            Kernel.pbMessage(_INTL("The green case is now on."))
            $game_variables[124]=4
            $scene = Scene_Pokephone.new
          else
            Kernel.pbMessage(_INTL("You dont own the green case."))
          end
        end
      # Wallpaper
      elsif command==1
        command=[]
        list=[
        _INTL("Normal"),
        _INTL("Electric"),
        _INTL("Dark"),
        _INTL("Melody"),
        _INTL("Ghost"),
        _INTL("Reath"),
        _INTL("Cami/Eltesa"),
        _INTL("Ola"),
        _INTL("Tina"),
        _INTL("Back")
        ]
        command=Kernel.pbMessage(_INTL("What wallpaper do you want on?"),list,0)
        # Normal
        if command==0 
          if $PokemonBag.pbHasItem?(:NORMALPAPER)
            Kernel.pbMessage(_INTL("The normal wallpaper is now on."))
            $game_variables[102]=0
            $scene = Scene_Pokephone.new
          else
            Kernel.pbMessage(_INTL("You dont own the normal wallpaper."))
          end
        # Electric
        elsif command==1 
          if $PokemonBag.pbHasItem?(:ELECTRICPAPER)
            Kernel.pbMessage(_INTL("The electric wallpaper is now on."))
            $game_variables[102]=1
            $scene = Scene_Pokephone.new
          else
            Kernel.pbMessage(_INTL("You dont own the electric wallpaper."))
          end
        # Dark
        elsif command==2
          if $PokemonBag.pbHasItem?(:DARKPAPER)
            Kernel.pbMessage(_INTL("The dark wallpaper is now on."))
            $game_variables[102]=2
            $scene = Scene_Pokephone.new
          else
            Kernel.pbMessage(_INTL("You dont own the dark wallpaper."))
          end
        # Melody
        elsif command==3
          if $PokemonBag.pbHasItem?(:MELODYPAPER)
            Kernel.pbMessage(_INTL("The melody wallpaper is now on."))
            $game_variables[102]=3
            $scene = Scene_Pokephone.new
          else
            Kernel.pbMessage(_INTL("You dont own the melody wallpaper."))
          end
        # Ghost
        elsif command==4
          if $PokemonBag.pbHasItem?(:GHOSTPAPER)
            Kernel.pbMessage(_INTL("The ghost wallpaper is now on."))
            $game_variables[102]=4
            $scene = Scene_Pokephone.new
          else
            Kernel.pbMessage(_INTL("You dont own the ghost wallpaper."))
          end
        end
      # Charms
      elsif command==2
        command=[]
        list=[
        _INTL("No Charm"),
        _INTL("Chikorita"),
        _INTL("Cyndaquil"),
        _INTL("Totodile"),
        _INTL("Pikachu"),
        _INTL("Opposite"),
        _INTL("Amp"),
        _INTL("Angler"),
        _INTL("Ho-oh"),
        _INTL("Lugia")
        ]
        command=Kernel.pbMessage(_INTL("What charm do you want on?"),list,0)
        # No Charm
        if command==0 
          if $PokemonBag.pbHasItem?(:NOCHARM)
            Kernel.pbMessage(_INTL("no charm is on."))
            $game_variables[121]=0
            $scene = Scene_Pokephone.new
          else
            Kernel.pbMessage(_INTL("You dont own no charm."))
          end
        # Chiko-Charm
        elsif command==1 
          if $PokemonBag.pbHasItem?(:CHIKOCHARM)
            Kernel.pbMessage(_INTL("The Chiko-Charm is now on."))
            $game_variables[121]=1
            $scene = Scene_Pokephone.new
          else
            Kernel.pbMessage(_INTL("You dont own the Chiko-Charm."))
          end
        # Cynda-Charm
        elsif command==2
          if $PokemonBag.pbHasItem?(:CYNDACHARM)
            Kernel.pbMessage(_INTL("The Cynda-Charm is now on."))
            $game_variables[121]=2
            $scene = Scene_Pokephone.new
          else
            Kernel.pbMessage(_INTL("You dont own the Cynda-Charm."))
          end
        # Toto-Charm
        elsif command==3
          if $PokemonBag.pbHasItem?(:TOTOCHARM)
            Kernel.pbMessage(_INTL("The Toto-Charm is now on."))
            $game_variables[121]=3
            $scene = Scene_Pokephone.new
          else
            Kernel.pbMessage(_INTL("You dont own the Toto-Charm."))
          end
        # Pika-Charm
        elsif command==4
          if $PokemonBag.pbHasItem?(:PIKACHARM)
            Kernel.pbMessage(_INTL("The Pika-Charm is now on."))
            $game_variables[121]=4
            $scene = Scene_Pokephone.new
          else
            Kernel.pbMessage(_INTL("You dont own the Pika-Charm."))
          end
        end
      else
      end
    end
    if Input.trigger?(Input::C)
      if @cmdMap>=0 && @sprites["command_window"].index==@cmdMap
        pbPlayDecisionSE()
        pbShowMap(-1,false)
      end
      if @cmdContacts>=0 && @sprites["command_window"].index==@cmdContacts
        pbPlayDecisionSE()
        pbFadeOutIn(99999) {
           PokemonPhoneScene.new.start
        }
      end
      if @cmdJukebox>=0 && @sprites["command_window"].index==@cmdJukebox
        $game_switches[518] = true
        pbPlayDecisionSE()
        $scene = Scene_Jukebox.new
      end
      if @cmdNext1>=0 && @sprites["command_window"].index==@cmdNext1
        $game_variables[91]=1
        $scene = Scene_Pokephone.new
      end
      if @cmdHudskins>=0 && @sprites["command_window"].index==@cmdHudskins #gearmod
        if $game_switches[70] && $game_switches[460] && $game_switches[330]
              command=[]
              list=[
              _INTL("Silver Version"),
              _INTL("Gold Version"),
              _INTL("Christmas Version"),
              _INTL("Halloween Version"),
              _INTL("Turn On"),
              _INTL("Turn Off"),
              _INTL("Cancel")
              ]
              command=Kernel.pbMessage(_INTL("choose your HUD skin."),list,0)
              if command==0
                $game_variables[98]=0
              elsif command==1
                $game_variables[98]=1
              elsif command==2
                $game_variables[98]=2
              elsif command==3
                $game_variables[98]=3
              elsif command==4
                  $game_switches[364]=true
              elsif command==5
                  $game_switches[364]=false
              elsif command==6
                return
                break
               refreshPartyIcons
            end
        elsif $game_switches[70] && $game_switches[460]
              command=[]
              list=[
              _INTL("Silver Version"),
              _INTL("Gold Version"),
              _INTL("Halloween Version"),
              _INTL("Turn On"),
              _INTL("Turn Off"),
              _INTL("Cancel")
              ]
              command=Kernel.pbMessage(_INTL("choose your HUD skin."),list,0)
              if command==0
                $game_variables[98]=0
              elsif command==1
                $game_variables[98]=1
              elsif command==2
                $game_variables[98]=3
              elsif command==3
                  $game_switches[364]=true
              elsif command==4
                  $game_switches[364]=false
              elsif command==5
                return
                break
                refreshPartyIcons
            end
          elsif $game_switches[70] && $game_switches[330]
              command=[]
              list=[
              _INTL("Silver Version"),
              _INTL("Gold Version"),
              _INTL("Christmas Version"),
              _INTL("Turn On"),
              _INTL("Turn Off"),
              _INTL("Cancel")
              ]
              command=Kernel.pbMessage(_INTL("choose your HUD skin."),list,0)
              if command==0
                $game_variables[98]=0
              elsif command==1
                $game_variables[98]=1
              elsif command==2
                $game_variables[98]=2
              elsif command==3
                  $game_switches[364]=true
              elsif command==4
                  $game_switches[364]=false
              elsif command==5
                return
                break
                refreshPartyIcons
              end
          elsif $game_switches[70]
            command=[]
            list=[
            _INTL("Silver Version"),
            _INTL("Gold Version"),
            _INTL("Turn On"),
            _INTL("Turn Off"),
            _INTL("Cancel")
            ]
            command=Kernel.pbMessage(_INTL("choose your HUD skin."),list,0)
            if command==0
              $game_variables[98]=0
            elsif command==1
              $game_variables[98]=1
            elsif command==2
                $game_switches[364]=true
            elsif command==3
                $game_switches[364]=false
            elsif command==4
              return
              break
              refreshPartyIcons
            end
          else
          end
        $scene = Scene_Map.new
      end
      if @cmdStorage>=0 && @sprites["command_window"].index==@cmdStorage
        pbFadeOutIn(99999){
          scene=PokemonStorageScene.new
          screen=PokemonStorageScreen.new(scene,$PokemonStorage,false) # 3 parameters
          screen.pbStartScreen(2)
        }
      end
      if @cmdGames>=0 && @sprites["command_window"].index==@cmdGames
        command=[]
        list=[
        _INTL("Voltorb Flip"),
        _INTL("Slots"),
        _INTL("Roulette"),
        _INTL("Lucky Wheel"),
        _INTL("Cancel")
        ]
        command=Kernel.pbMessage(_INTL("What game do you want to play?"),list,0)
        if command==0
          pbFadeOutIn(99999) { 
          pbVoltorbFlip
        }
        elsif command==1
          pbFadeOutIn(99999) { 
          pbSlotMachine(1)
        }
        elsif command==2
          pbFadeOutIn(99999) { 
          pbRoulette(10)
        }
        elsif command==3
          if rand(2)==0
            pbFadeOutIn(99999) { 
            pbLuckyWheel(0)
            }
          else
            if rand(2)==1
              pbFadeOutIn(99999) { 
              pbLuckyWheel(1)
              }
            else
              if rand(2)==2
                pbFadeOutIn(99999) { 
                pbLuckyWheel(2)
                }
              else
                pbFadeOutIn(99999) { 
                pbLuckyWheel(0)
                }
              end
            end
          end
        elsif command==4
        return
        break
      end
    end
      if @cmdNext2>=0 && @sprites["command_window"].index==@cmdNext2
        $game_variables[91]=2
        $scene = Scene_Pokephone.new
      end
      if @cmdGuideBook>=0 && @sprites["command_window"].index==@cmdGuideBook
        $game_switches[340] = true
        $scene = Scene_Pokephone.new
      end
      if @cmdVSHunter>=0 && @sprites["command_window"].index==@cmdVSHunter
        pbPlayDecisionSE()
        pbFadeOutIn(99999) {
        pbWait(20)
        break
        }
        $scene = Scene_Map.new
        pbVSSeeker
        $game_variables[91]=0
      end
      if @cmdNext3>=0 && @sprites["command_window"].index==@cmdNext3
        $game_variables[91]=0
        $scene = Scene_Pokephone.new
      end
      if @cmdLandmarks>=0 && @sprites["command_window"].index==@cmdLandmarks
        pbPlayDecisionSE()
        pbFadeOutIn(99999) {
           LandmarksScene.new.start
        }
      end
      if @cmdSightings>=0 && @sprites["command_window"].index==@cmdSightings
        pbPlayDecisionSE()
        pbFadeOutIn(99999) {
           SightingsScene.new.start
        }
      end
      if @cmdCases>=0 && @sprites["command_window"].index==@cmdCases
        pbPlayDecisionSE()
        pbFadeOutIn(99999) {
             CasesScene.new.start
        }
      end
      if @cmdBack>=0 && @sprites["command_window"].index==@cmdBack
        $game_switches[340] = false
        $scene = Scene_Pokephone.new
      end
      return
    end
  end
end

For reference at what it looked like, this was it ingame. (i've changed the games ratio why it looks a larger than normal)

 

[NettoHikari]

Now this is actually fine, but when i close the menu i get a crash, now i use "$scene = Scene_Map.new" and that causes a crash with "playersprite". the script is unchanged from v16 its just exiting (tried changing to break but that causes another error.

Please screenshot and send the errors, just saying the error had "playersprite" isn't helpful. I'm not sure I see any obvious issues with your code, so without seeing the errors I'm really not sure where else to look.

EDIT: Also, why not update to v18.1 instead of v17.2? It's good that you're updating at all, but I think even v17 will be outdated soon as more and more scripts drop support for it.

 

[ArchyTheArc]

Please screenshot and send the errors, just saying the error had "playersprite" isn't helpful. I'm not sure I see any obvious issues with your code, so without seeing the errors I'm really not sure where else to look.

EDIT: Also, why not update to v18.1 instead of v17.2? It's good that you're updating at all, but I think even v17 will be outdated soon as more and more scripts drop support for it.

Im only updating to v17 so im not so far behind and while v18 is new some old scripts might not work/could need rewriting, but i plan to get their eventually.

and sorry about that was kinda dumb not too.

[Pokémon Essentials version 17.2]
Exception: NoMethodError
Message: undefined method `playersprite' for nil:NilClass
Sprite_DynamicShadows:210:in `initializeOldFL'
Simple HUD:419:in `klein_animate_sp_initialize'
KleinAnimatedTiles:162:in `old_initialize'
Footprints:75:in `old_initialize_base'
Secret Bases:789:in `initialize'
Scene_Map:20:in `new'
Scene_Map:20:in `createSpritesets'
Scene_Map:19:in `each'
Scene_Map:19:in `createSpritesets'
PSystem_Utilities:1232:in `pbLoadRpgxpScene'

seems to call any script that uses the same playersprite reference so.
the oldFL reference is from the simple hud so i'll grab that also.

Spoiler:

  alias :initializeOldFL :initialize
  alias :disposeOldFL :dispose
  alias :updateOldFL :update

  def initialize(map=nil)
    initializeOldFL(map)
  end

  def dispose
    @hud.dispose if @hud
    disposeOldFL
  end

  def update
    updateOldFL
    @hud = HUD.new(@viewport1) if !@hud
    @hud.update
  end

Other ones like 'klein_animate_sp_initialize', 'old_initialize_base' are all different alias' for initialize so thats the target area.

 

[NettoHikari]

Okay, I see like 4 different custom scripts in the error message, are you ABSOLUTELY sure that "Secret Bases", "Footprints", "KleinAnimatedTiles", and "Simple HUD" are all compatible with v17? I don't know much about the last two, but the first two have updated v17 versions:

Footprints (by Marin): https://www.pokecommunity.com/showthread.php?p=10183546
Secret Bases (Klein and Vendily): (broken link removed)

I did some poking around with "pbLoadRpgxpScene" on v17, and I think it might have a bug? I don't know if it was present in v16 or not, but either way, there's a new way to call scenes, using the method "pbFadeOutIn". It will automatically take care of returning the scene back to the overworld when it's done. Replace:

if $Trainer.pokephone || $DEBUG
        pbLoadRpgxpScene(Scene_Pokephone.new)
      elsif $Trainer.pokegear
        pbLoadRpgxpScene(Scene_Pokegear.new)
      end

with

if $Trainer.pokephone || $DEBUG
    pbFadeOutIn(99999) {
        scene = Scene_Pokephone.new
        scene.main
    }
elsif $Trainer.pokegear
    pbFadeOutIn(99999) {
        scene = Scene_Pokephone.new
        scene.main
    }
end

 

[ArchyTheArc]

Okay, I see like 4 different custom scripts in the error message, are you ABSOLUTELY sure that "Secret Bases", "Footprints", "KleinAnimatedTiles", and "Simple HUD" are all compatible with v17? I don't know much about the last two, but the first two have updated v17 versions:

Footprints (by Marin): https://www.pokecommunity.com/showthread.php?p=10183546
Secret Bases (Klein and Vendily): (broken link removed)

I did some poking around with "pbLoadRpgxpScene" on v17, and I think it might have a bug? I don't know if it was present in v16 or not, but either way, there's a new way to call scenes, using the method "pbFadeOutIn". It will automatically take care of returning the scene back to the overworld when it's done. Replace:

if $Trainer.pokephone || $DEBUG
        pbLoadRpgxpScene(Scene_Pokephone.new)
      elsif $Trainer.pokegear
        pbLoadRpgxpScene(Scene_Pokegear.new)
      end

with

if $Trainer.pokephone || $DEBUG
    pbFadeOutIn(99999) {
        scene = Scene_Pokephone.new
        scene.main
    }
elsif $Trainer.pokegear
    pbFadeOutIn(99999) {
        scene = Scene_Pokephone.new
        scene.main
    }
end

Okay so that fix "works" it opens fine but immedietly closes out but leaves the graphics on screen. (as i can move around and not interact with the actual graphics)

And could be an issue with them but all they seem to do is use the original initialize for the script itself.
maybe using scene.main (while thats what it should do, it just does it wrong?)

 

[NettoHikari]

Hm, I think you'd need to modify your scenes a little to make it work with "pbFadeOutIn". But actually, Maruno just fixed "pbLoadRpgxpScene" in the latest version of Essentials (https://github.com/Maruno17/pokemon-essentials/commit/579a6cbe2a8b0a9d2068e4a1cd01ea32206a39f5), so you can switch your code back to using that. Basically, replace your entire "def pbLoadRpgxpScene" definition with the following:

def pbLoadRpgxpScene(scene)
  return if !$scene.is_a?(Scene_Map)
  oldscene = $scene
  $scene = scene
  Graphics.freeze
  oldscene.disposeSpritesets
  visibleObjects = pbHideVisibleObjects
  Graphics.transition(20)
  Graphics.freeze
  while $scene && !$scene.is_a?(Scene_Map)
    $scene.main
  end
  Graphics.transition(20)
  Graphics.freeze
  $scene = oldscene
  $scene.createSpritesets
  pbShowObjects(visibleObjects)
  Graphics.transition(20)
end

Then you can switch the code that calls your scenes with this (exactly what you had before):

if $Trainer.pokephone || $DEBUG
    pbLoadRpgxpScene(Scene_Pokephone.new)
elsif $Trainer.pokegear
    pbLoadRpgxpScene(Scene_Pokegear.new)
end

 

[ArchyTheArc]

Hm, I think you'd need to modify your scenes a little to make it work with "pbFadeOutIn". But actually, Maruno just fixed "pbLoadRpgxpScene" in the latest version of Essentials (https://github.com/Maruno17/pokemon-essentials/commit/579a6cbe2a8b0a9d2068e4a1cd01ea32206a39f5), so you can switch your code back to using that. Basically, replace your entire "def pbLoadRpgxpScene" definition with the following:

def pbLoadRpgxpScene(scene)
  return if !$scene.is_a?(Scene_Map)
  oldscene = $scene
  $scene = scene
  Graphics.freeze
  oldscene.disposeSpritesets
  visibleObjects = pbHideVisibleObjects
  Graphics.transition(20)
  Graphics.freeze
  while $scene && !$scene.is_a?(Scene_Map)
    $scene.main
  end
  Graphics.transition(20)
  Graphics.freeze
  $scene = oldscene
  $scene.createSpritesets
  pbShowObjects(visibleObjects)
  Graphics.transition(20)
end

Then you can switch the code that calls your scenes with this (exactly what you had before):

if $Trainer.pokephone || $DEBUG
    pbLoadRpgxpScene(Scene_Pokephone.new)
elsif $Trainer.pokegear
    pbLoadRpgxpScene(Scene_Pokegear.new)
end

Perfect! thanks for the help even if it was more directing me to the fixes, was last thing really stopping me from a beta test