[Scripting Question] [V18.1] Syntax Error on Item Effect

[ValiantTrainer94]

Hey peeps,

I'm creating an item that turns on a switch when you use it, and off when you use it again. It functions fine! Until I add in the pbMessage function. Currently the script looks like this:

ItemHandlers::UseInField.add(:ULTRAMAXREPEL,proc { |item|
if $game_switches[225]==true
   $game_switches[225] = false
   pbMessage(_INTL("The powerful Repel dissapates... Wild Pokemon have returned!"))
  next 1
end
if $game_switches[225]==false
   $game_switches[225] = true  
   pbMessage(_INTL("The powerful Repel wafts around... Wild Pokemon have fled!")
  next 1
 end
})

And it is without fail the second pbMessage that throws up an error. If I remove that one, it functions fine. Does anyone have the expertise to point out the fault here? I'm tearing my hair out!
Cheers in advance!

 

[Jazzy]

You're missing a ')' in the pbMessage bit.

However, you can also optimize your code a bit, and make it easier to read.

ItemHandlers::UseInField.add(:ULTRAMAXREPEL,proc { |item|
    $game_switches[225] = !$game_switches[225]
    if $game_switches[225] == true
      pbMessage(_INTL("The powerful Repel dissapates... Wild Pokemon have returned!"))
    else
      pbMessage(_INTL("The powerful Repel wafts around... Wild Pokemon have fled!"))
    end
    next 1
})

You can just set your switch to the opposite value of the switch. Looks a bit nicer.

The code can actually be cleaned up further:

Spoiler:

ItemHandlers::UseInField.add(:ULTRAMAXREPEL,proc { |item|
    $game_switches[225] = !$game_switches[225]
    pbMessage(_INTL("The powerful Repel dissapates... Wild Pokemon have returned!")) if $game_switches[225] == true
    pbMessage(_INTL("The powerful Repel wafts around... Wild Pokemon have fled!")) if $game_switches[225] == false
    next 1
})

 

[ValiantTrainer94]

Amazing! Thank you so much :)