[Scripting Question] what am I doing wrong?

[Eight7]

So I've been working on a move that does double damage is the user or ally is grass type but it won't work or atleast when I test it on an npc trainer that has the same stats it doesn't work is there something I can do to make this work or does anyone know how I can fit a pbDisplay or something so that a message drops when the effect happens?

################################################################################
# Power is boosted if ally or user is grass (Shimmer Ray)
################################################################################
class PokeBattle_Move_223 < PokeBattle_Move

def pbBaseDamage(basedmg,attacker,opponent)
if attacker.pbHasType?(:GRASS) || attacker.pbPartner.pbHasType?(:GRASS)
return basedmg*2
return basedmg
end
end
end

 

[DarrylBD99]

You should mention which version of essentials you are using, but I am pretty sure you put the first end in the wrong place

corrected

################################################################################
# Power is boosted if ally or user is grass (Shimmer Ray)
################################################################################
class PokeBattle_Move_223 < PokeBattle_Move
   def pbBaseDamage(basedmg,attacker,opponent)
      if attacker.pbHasType?(:GRASS) || attacker.pbPartner.pbHasType?(:GRASS)
         return basedmg*2
      end
      return basedmg
   end
end

I haven't tested it yet, so you should probably tell me if it is working.

 

[Eight7]

You should mention which version of essentials you are using, but I am pretty sure you put the first end in the wrong place

corrected

################################################################################
# Power is boosted if ally or user is grass (Shimmer Ray)
################################################################################
class PokeBattle_Move_223 < PokeBattle_Move
   def pbBaseDamage(basedmg,attacker,opponent)
      if attacker.pbHasType?(:GRASS) || attacker.pbPartner.pbHasType?(:GRASS)
         return basedmg*2
      end
      return basedmg
   end
end

I haven't tested it yet, so you should probably tell me if it is working.

Thanks I'm gonna test this right now and essentials version is something I forget to include a lot my bad

 

[Eight7]

also just tested it and it works many thanks