Checking the team for a certain type

Franzo · Dec 24, 2013

Like the pbHasSpecies?(:BULBASAUR), I wanted to make a function that checks the team for a certain type.

I added this in PokemonUtilities:

def pbHasType?(types) # Searches team for certain type
if types.is_a?(String)
types=getID(PBTypes,types)
end
for pokemon in $Trainer.party
next if pokemon.egg?
return true if pokemon.getID(PBTypes,types)==types
end
return false
end

I made a test event. it's page has this in it:

Conditional Branch: Script: pbHasType?(:BUG)
Text: BUG type in team.

else

Text: No BUG type in team.

Branch End

But whatever pokémon I have in the party, it always says "No BUG type in team." I'm pretty sure the Utitlities code is incorrect but i'm not very experienced with Ruby. Any help?

Maruno · Dec 24, 2013

The line where you check the type of each Pokémon in the party is definitely incorrect. Use this:

Code:

def pbHasTypeInParty?(type)
  if type.is_a?(String) || type.is_a?(Symbol)
    return false if !hasConst?(PBTypes,type)
    type=getID(PBTypes,type)
  end
  for pokemon in $Trainer.party
    next if pokemon.egg?
    return true if pokemon.hasType?(type)
  end
  return false
end

The method name is different and more descriptive. There's also a check to make sure you're looking for a type that exists - without this check, any non-existent type would be treated as type 0 (Normal). It's there for completeness.

Franzo · Dec 24, 2013

Yep, that did it. I see what I did wrong.
Thank you very much!

Checking the team for a certain type

More options

Franzo

Developing something...

Maruno

Lead Dev of Pokémon Essentials

Franzo

Developing something...