Red hack: Shin Pokemon Red/Blue/Green/JP builds (Bugfix, AI, and QoL patch)

jastolze007 said:

Normally, I can continue progress. But this rom specifically erased my save when I updated a few months ago. Same rom name and all. I had a backup fortunately.

I appreciate all the help you've given me regardless.

Click to expand...

• There's goombasav (I use GoombasavCore.WinForms.x64.exe).
• Also the Revo save converter.
• Goomba color.
• And finally the good ol' VBA emulator.

1. As before, I use goombasav to extract a raw gbc sav from your k101 sav.
2. I use goomba color to compile the updated gbc rom into a gba rom.
3. I open VBA, check my save type settings (automatic & 64k flash), and load the goombafied rom. I start a new game and then save the game after it drops me into the player's room. This generates a dummy VBA sav.
4. I use goombasav again to load the VBA dummy sav. This time I use the raw gbc sav from before to replace the saved data in the dummy sav.
5. I take the modified dummy sav and use it to fire up VBA with the goombafied rom. The saved game is detected and loads with invisible walls. Softlock teleport clears the invisible walls. Game is saved again. So far so good.
6. I go into the gooba options (L + R) and go into and out of the save manager. This is just so that goomba updates its own save structure. This results in a cleaned VBA sav for the goombafied rom.
7. Finally I use the Revo save converter to convert the cleaned VBA sav into a K101 sav. See attached.

jojobear13 said:

I think this is an issue with your K101 doing some kind of hash check. I'll see if I can bypass it.

I'm using a few different tools:

• There's goombasav (I use GoombasavCore.WinForms.x64.exe).
• Also the Revo save converter.
• Goomba color.
• And finally the good ol' VBA emulator.

1. As before, I use goombasav to extract a raw gbc sav from your k101 sav.
2. I use goomba color to compile the updated gbc rom into a gba rom.
3. I open VBA, check my save type settings (automatic & 64k flash), and load the goombafied rom. I start a new game and then save the game after it drops me into the player's room. This generates a dummy VBA sav.
4. I use goombasav again to load the VBA dummy sav. This time I use the raw gbc sav from before to replace the saved data in the dummy sav.
5. I take the modified dummy sav and use it to fire up VBA with the goombafied rom. The saved game is detected and loads with invisible walls. Softlock teleport clears the invisible walls. Game is saved again. So far so good.
6. I go into the gooba options (L + R) and go into and out of the save manager. This is just so that goomba updates its own save structure. This results in a cleaned VBA sav for the goombafied rom.
7. Finally I use the Revo save converter to convert the cleaned VBA sav into a K101 sav. See attached.

So the file I ended up with is the same size as the file you initially posted. That's a good sign. But what a task it is to cut through not one but two special save structures. 136KB K101 save --> 32KB raw gbc save --> 64KB goomba GBA save --> 136 KB K101 save.

EDIT: You might want to replicate this process using your own compiled rom update just to make sure everything is consistent between the rom and the sav.

Click to expand...

jastolze007 said:

Thanks for the help. I actually use the revo K save manager. But, what command line did you use to get it to work with gbc saves? For gba, I do a "Converter.exe" "Pokemon Mod" 128. And that allows me to use Revo GBA saves on VBA.

Click to expand...

• Fixed a minor bug where the first byte of pokedex "owned" gets cleared on a new game+
• Fixed minor desync with abbreviated rival music
• Fixed poison/burn/leechseed damage sometimes being applied twice
• Minor changes to support external randomizer
• Updated title screen to use kanji instead of katakana
• Fixed an artifact when title screen 'mons scroll left in GBC-mode
• Fixed a bug in AI roster scoring when evaluating type matchups for switching
• Tweaked item usage for cooltrainers and Giovanni
• Increased encounter rate from 3/256 to 11/256 for the following pokemon
  • charmander, bulbasaur, squirtle, eevee
  • bellsprout (red), oddish (blue), vulpix (red), oddish (blue)
  • farfetch'd (route 12)
• Increased mew's encounter rate from 1.5/256 to 3/256
• Improved exp calculation for developers who want a level cap between 101 and 255
  • EXP calculation routine now does math in 4 bytes instead of 3 bytes
  • Exp calculation result is still capped to 3 bytes regardless of level cap to prevent overflow
  • The byte cap on the exp result means that certain growth rates may have a level cap
  • For example, the "slow" growth rate is theorized to cap at level 237
• Trainer battle prize money uses 3 bytes instead of 2, lifting the 9999 cap on winnings
• To prevent infinite loops, Rage ends after 2 to 3 turns (attack boosts are kept)
• AI will not do actions during Rage or when recharging

• fixed minor desync with abbreviated rival music
• fixed poison/burn/leechseed damage sometimes being applied twice
• minor changes to support external randomizer
• AI will not do actions during Rage or when recharging
• Improved exp calculation for developers who want a level cap between 101 and 255
  • EXP calculation routine now does math in 4 bytes instead of 3 bytes
  • Exp calculation result is still capped to 3 bytes regardless of level cap to prevent overflow
  • The byte cap on the exp result means that certain growth rates may have a level cap
  • For example, the "slow" growth rate is theorized to cap at level 237
• Trainer battle prize money uses 3 bytes instead of 2, lifting the 9999 cap on winnings
• To prevent infinite loops, Rage ends after 2 to 3 turns (attack boosts are kept)
• Fixed an artifact when title screen 'mons scroll left in GBC-mode
• Fixed a bug in AI roster scoring when evaluating type matchups for switching

darthbr said:

for legendaries respawm. i took out this 2 parts in script route 25, follow the image, i just left the above red part, is that ok??? (game wont bug)?

my doubt it, the game compiled... like i left in image

Click to expand...

ld a, $3
ld [wRoute25CurScript], a
ld [wCurMapScript], a

jojobear13 said:

You missed one detail. Go to the "Route25TextRed:" function and near the bottom remove these lines.

Code:

ld a, $3
ld [wRoute25CurScript], a
ld [wCurMapScript], a

This tells the map script routine to load script pointer #3 (that being Route25Script3) on the next frame refresh. Since you removed Route25Script3, you must remove these lines as well or else the game will jump into garbage data and crash.

Click to expand...

darthbr said:

oh thank you for help, so deleting this last part, i dont have to worry?

Click to expand...

jastolze007 said:

Hey, so I'm likely to start a fresh playthrough of this mod on the most recent version once I finish playing Unbound. Can you confirm that leveling up past 100 works in battle? Rare candies seem to work according to the set level cap but battle EXP is a different story.

Click to expand...

jojobear13 said:

See the v1.19 changelog. The exp calculation function has been modified to handle the math better. It also won't let you overflow the exp.

It's been working okay so far, but I really need to sit down sometime and grind from 100 to 255 on a few different growth rate 'mons.

Click to expand...

jastolze007 said:

Well, I modified the usual team I use to have a Medium Slow growth rate. I'm sure that can reach at least 250 (The set cap) before the overflow.

Thanks for helping me with this man. I appreciate all the work you do. Hopefully this does in fact solve the issues I was having with leveling past 100.

I'll report to you what happens. I never use rare candies so it'll be at least a month before I hit a team of 6 at level 100+.

More people should incorporate the rematch system like you implemented. It really gives the game fresh post game life. Also, the randomized scaling trainer is amazing.

Click to expand...

• medium-slow - 245
• slow - 237
• medium-fast - 255
• fast - 255

jastolze007 said:

I got a really lucky roll for my Magikarp's DV's: 15 HP, 13 ATK, 14 DEF, 14 SPD 15 SPC

Anyways, I can't remember, but does EV growth ever stop at Level 100? I thought I heard somewhere it does.

Also, regarding the randomized scaled trainer: How will the game handle an opponent PKMN if it's a slow growth rate and my PKMN is level 240 or higher? Would be interesting to see how the game would react.

Click to expand...

darthbr said:

Can you explain this in item usage part: (im changing some, i created one for Erika, instead of super potion)

cp $20
jr nc, .sabrinareturn
ld a, $A
call AICheckIfHPBelowFraction
jp c, AIUseHyperPotion
.sabrinareturn
ret

(she will use hyper potion when pkmn reach 20% of life? ) -- i want make Erika use Hyper Potion when reach red life, so, wich one is correct, Sabrina os erika?

cp $80
jr nc, .erikareturn
ld a, $A
call AICheckIfHPBelowFraction
jp c, AIUseHyperPotion
.erikareturn
ret

________________

; unused? joenote - repurposing for a new vendor on celadon dept store floor 3
CeladonMart3ClerkText::

(is this guy in game, or no?) if not, how do i activate him? is it too hard?

Click to expand...

charphantom96 said:

Any chance of you making a shin Pokemon yellow hack?

Click to expand...

jojobear13 said:

EVs do not exist until gen 3. Instead you have stat experience. There is no cap on the total or with level. For each stat, it starts at $0000 and can go all the way to $ffff. Grinding still nets you stat exp regardless of level. Back when I was a kid, my friends and I would do the box trick to recalculate our higher stats after hitting lvl 100.

The experience cap does not apply to AI teams because they do not have experience nor do they level-up. Their level is set to whatever and it's used for calculating stats and other things. I'm pretty sure I capped the random trainer to 255 some months. I'll have to double check that later.



Here's how to read the item usage code. Note that '$' signifies a hex number. I prefer to work in hex since it makes bits line up nicely in debugging tools.

If the value in register 'a' is less than $20 (basically a $20 out of $ff random chance), then check to see if hp is less than 1/$A of max (basically check if hp is down to 1/10th). If hp is in fact that low, use a hyper potion.

The extra celadon vendor is only in the master branch. You would have to re-add all the needed scripts for that map and add his sprite to the map's object header file. I'm stuck phone-posting for a while, so I can't really provide detailed instruction at this time.

Click to expand...