[v16/v17/v18] Cable Club (Online Trades/Battles) [Abandonware]

mgriffin · Mar 19, 2021

This has been sitting on my computer for idk, like 6 months or something. It does trades and battles via a server that you'll need to host. The title says [Abandonware], and that's accurate. I haven't touched Essentials for a long time, and I don't intend to use it again.

[April 22, 2021] Vendily added v18 support and eggs are now tradeable.

Credits to Khaikaa for commissioning it, and Vendily for porting to v18.

There's two parts:

a plug and play script for Essentials in cable_club.rb. I call mine CableClub and put it directly above Main. You need to edit the HOST and PORT constants at the top to be the address and port of your server.
a Python3 server in cable_club.py. It needs your PBS files to run, by default it looks in the directory you run it from, but you can pass --pbs_dir to change that. You can also pass --host and --port or alter the HOST and PORT constants at the top.

Connections are established via Trainer IDs, which can be found on the trainer card screen. Think of them as a bit like friend codes.

For hosting the server you could try free-tier on Google Cloud. It shouldn't use much processing power (but I'd recommend setting up some sensible limits, because there's nothing in the protocol to stop somebody DDOSing it).

https://www.mediafire.com/file/sj658t5py06o98r/cable_club.zip/file

MessiDuvidoso · Mar 19, 2021

Wait for someone awesome to upgrade this script to v18. It will make the joy of many!

Khaikaa · Mar 19, 2021

I feel a bit ashamed that it took this long to share this. Sadly I've been very busy, and even forgot about it for some months. We were a bit unlucky that the newer version of pokemon essentials(v18) was launched just a few days after we stop working on it. I hope this helps anyone wanting to give online features to their games.

The cool Treecko · Mar 22, 2021

this looks so cool, sadly its for v16... but somehow it can be converted to v18 and it will be a huge pleasure

MessiDuvidoso · Mar 25, 2021

I trust few people like Vendily to make this upgrade happen

DarrylBD99 · Mar 29, 2021

So um... is there suppose to be an instruction manual for the set up?

mgriffin · Mar 29, 2021

DarrylBD99 said:
So um... is there suppose to be an instruction manual for the set up?

mgriffin said:
There's two parts:

a plug and play script for Essentials in cable_club.rb. I call mine CableClub and put it directly above Main. You need to edit the HOST and PORT constants at the top to be the address and port of your server.

a Python3 server in cable_club.py. It needs your PBS files to run, by default it looks in the directory you run it from, but you can pass --pbs_dir to change that. You can also pass --host and --port or alter the HOST and PORT constants at the top.

You can test with "localhost" or "127.0.0.1" as the host if you run the server locally, i.e. on your PC, during development. But for setting up a publicly-available server you'll need more technical know-how. Like I say in the post, you could try a free-tier cloud hosting service for that.

Icebird45 · Apr 4, 2021

I'm getting the following error, when trying to start des script:

Code:

Traceback (most recent call last):
  File "E:\Testserver\cable_club.py", line 387, in <module>
    Server(args.host, args.port, args.pbs_dir).run()
  File "E:\Testserver\cable_club.py", line 18, in __init__
    self.valid_party = make_party_validator(pbs_dir)
  File "E:\Testserver\cable_club.py", line 302, in make_party_validator
    moves = {moves_by_name[m] for m in moves_.split(',')[1::2] if m}
  File "E:\Testserver\cable_club.py", line 302, in <setcomp>
    moves = {moves_by_name[m] for m in moves_.split(',')[1::2] if m}
KeyError: 'LOVELYKISS'

Don't know, what exactly that means, I'm not that familiar with Python, but realy would want to get it work, so is there someone who can help me?^^

mgriffin · Apr 4, 2021

Icebird45 said:
I'm getting the following error, when trying to start des script:

Code:

Traceback (most recent call last): File "E:\Testserver\cable_club.py", line 387, in <module> Server(args.host, args.port, args.pbs_dir).run() File "E:\Testserver\cable_club.py", line 18, in __init__ self.valid_party = make_party_validator(pbs_dir) File "E:\Testserver\cable_club.py", line 302, in make_party_validator moves = {moves_by_name[m] for m in moves_.split(',')[1::2] if m} File "E:\Testserver\cable_club.py", line 302, in <setcomp> moves = {moves_by_name[m] for m in moves_.split(',')[1::2] if m} KeyError: 'LOVELYKISS'

Don't know, what exactly that means, I'm not that familiar with Python, but realy would want to get it work, so is there someone who can help me?^^

So make_party_validator is the thing that parses your PBS files and creates a data structure that can check that any Pokémon that are used online are actually valid (i.e. consistent with the PBS files). So your error seems to me like there's a move in your pokemon.txt (LOVELYKISS) that isn't in your moves.txt.

Icebird45 · Apr 4, 2021

mgriffin said:
So make_party_validator is the thing that parses your PBS files and creates a data structure that can check that any Pokémon that are used online are actually valid (i.e. consistent with the PBS files). So your error seems to me like there's a move in your pokemon.txt (LOVELYKISS) that isn't in your moves.txt.

I checked that and the move is in both my files, pokemon.txt and moves.txt.

mgriffin · Apr 4, 2021

Icebird45 said:
I checked that and the move is in both my files, pokemon.txt and moves.txt.

I don't know then. This is the code that loads moves:

Code:

    with io.open(os.path.join(pbs_dir, r'moves.txt'), 'r', encoding='utf-8-sig') as moves_pbs:
        for row in csv.reader(moves_pbs):
            if len(row) >= 2:
                moves_by_name[row[1]] = int(row[0])

moves_by_name doesn't contain LOVELYKISS as per the error. Perhaps you could add a print(moves_by_name) like so:

Code:

                moves_by_name[row[1]] = int(row[0])

    print(moves_by_name)
    with io.open(os.path.join(pbs_dir, r'items.txt'), 'r', encoding='utf-8-sig') as items_pbs:

and check what moves are parsed. If it's empty, then I'd assume that your file isn't (effectively) a CSV file? Or is formatted differently to any PBS files I've seen out in the wild.

Icebird45 · Apr 6, 2021

So, now I got the server to work. But when I battle against another person, I have a few issues:
1. When I use Mega Evolution, this is not visible for my opponent. I mega-evolve on my screen, but it will not mega evolve on my opponents screen.
2. Sometimes, I get this Runtime Errors (see the screenshot).
3. I had it one time, that I used a attack and the opponents Pokemon fainted, but at my opponents screen, he attacked first and my pokemon fainted. After this, we both had the message "Waiting..." and nothing happens on this point, until one of us closed the game, so that the connection closed.

I realy dont know, why this happens. Trade works fine without any issue.

mgriffin · Apr 6, 2021

Icebird45 said:
So, now I got the server to work. But when I battle against another person, I have a few issues:
1. When I use Mega Evolution, this is not visible for my opponent. I mega-evolve on my screen, but it will not mega evolve on my opponents screen.
2. Sometimes, I get this Runtime Errors (see the screenshot).
3. I had it one time, that I used a attack and the opponents Pokemon fainted, but at my opponents screen, he attacked first and my pokemon fainted. After this, we both had the message "Waiting..." and nothing happens on this point, until one of us closed the game, so that the connection closed.

I realy dont know, why this happens. Trade works fine without any issue.

1. Ah. Yeah, I never checked (or even thought about) mega evolution. It probably doesn't get sent to the other client which would cause the battles to desync and eventually crash.
2. I'm not sure. Sounds like your client was not expecting an attack, but your friend sent one. Maybe you thought their Pokémon fainted, but it didn't on their screen (i.e. a desync occurred sometime), and so when they chose their move your client was like "hey, I was expecting you to send in a Pokémon!"
3. That's another desync. Basically it's caused by random numbers being generated in a different order on both clients. It shouldn't happen but, e.g. your mega evolution thing would do that because the turn order will be different on each client.

Icebird45 · Apr 6, 2021

mgriffin said:
1. Ah. Yeah, I never checked (or even thought about) mega evolution. It probably doesn't get sent to the other client which would cause the battles to desync and eventually crash.
2. I'm not sure. Sounds like your client was not expecting an attack, but your friend sent one. Maybe you thought their Pokémon fainted, but it didn't on their screen (i.e. a desync occurred sometime), and so when they chose their move your client was like "hey, I was expecting you to send in a Pokémon!"
3. That's another desync. Basically it's caused by random numbers being generated in a different order on both clients. It shouldn't happen but, e.g. your mega evolution thing would do that because the turn order will be different on each client.

So basicly, Mega Evolution is the problem, hmm. Is there an easy way to fix this, or is this more complex?

LuisMRL · Apr 6, 2021

Hello, and excuse me... I'm getting a Syntax error in the line 16, and i don't understeand whats happening u.u.

Script 'Server' line 16: SyntaxError occurred.

The line 16 is: class Server:

So... I don't know... I'm sorry if this a kind of basic question but I truly don't understeand and i really like the idead of online :(.

Than

mgriffin · Apr 6, 2021

Icebird45 said:
So basicly, Mega Evolution is the problem, hmm. Is there an easy way to fix this, or is this more complex?

It's probably quite easy to fix if you're a relatively strong coder, you'd need to find the bit of code that's responsible for sending the choice (I think it might be pbDefaultChooseEnemyCommand, writer.sym(:choice) is the start of the sending code) and extend it to send both the choices and any mega evolution details. Then you'd need to update the parsing code in the same function (which starts @connection.update do |record|) to extract your mega evolution data, and set the appropriate information to make the mega evolution happen. This will probably be the same data that you read in the sending step.

LuisMRL said:
Hello, and excuse me... I'm getting a Syntax error in the line 16, and i don't understeand whats happening u.u.

Script 'Server' line 16: SyntaxError occurred.

The line 16 is: class Server:

So... I don't know... I'm sorry if this a kind of basic question but I truly don't understeand and i really like the idead of online :(.

Than

I think you've copied the Python server code into RMXP. But what you needed to do was copy the Ruby code (in the cable_club.rb file) into RMXP, and use Python 3 to run the server.

mgriffin · Apr 6, 2021

Icebird45 said:
So basicly, Mega Evolution is the problem, hmm. Is there an easy way to fix this, or is this more complex?

It's probably not too tricky if you know where Essentials stores the information about which Pokémon are waiting to mega evolve. Basically all you'd need to do is edit pbDefaultChooseEnemyCommand to send and receive that information. The sending code starts with @connection.send do |writer| and the receiving code starts with @connection.update do |record|. They both manipulate @choices which I had hoped would encapsulate all the state needed to deal with battle choices, but I guess the details about mega evolution are found elsewhere.

LuisMRL said:
Hello, and excuse me... I'm getting a Syntax error in the line 16, and i don't understeand whats happening u.u.

Script 'Server' line 16: SyntaxError occurred.

The line 16 is: class Server:

So... I don't know... I'm sorry if this a kind of basic question but I truly don't understeand and i really like the idead of online :(.

Than

Sounds like you've copied the Python server code into RMXP (from cable_club.py), but you only want to copy the Ruby client code (from cable_club.rb). The Python server you need to run using Python 3.

Canal_do_Lontra · Apr 6, 2021

It works with v18.1? I am needing so much online battle and trade, I am making my fan game on essentials v18.1

mgriffin · Apr 6, 2021

Canal_do_Lontra said:
It works with v18.1? I am needing so much online battle and trade, I am making my fan game on essentials v18.1

Sorry, no. :(

Canal_do_Lontra · Apr 7, 2021

thanks I need to wait

[v16/v17/v18] Cable Club (Online Trades/Battles) [Abandonware]

More options

mgriffin

MessiDuvidoso

Khaikaa

The cool Treecko

Wild Treecko appeared!

MessiDuvidoso

DarrylBD99

Content Creator and Game Developer

mgriffin

Icebird45

mgriffin

Icebird45

mgriffin

Icebird45

Attachments

mgriffin

Icebird45

LuisMRL

mgriffin

mgriffin

Canal_do_Lontra

Oshawott uses Razor Shell

mgriffin

Canal_do_Lontra

Oshawott uses Razor Shell