Can someone confirm I added Tough Claws correctly?

[Rayd12smitty]

    if isConst?(attacker.ability,PBAbilities,:TOUGHCLAWS) && # Added Ability
       (@flags&0x01)!=0 # Makes direct contact
      basedmg=(basedmg*1.3).floor
    end

I put it in Pokebattle_Move right below

    if isConst?(attacker.ability,PBAbilities,:RIVALRY) &&
       attacker.gender!=2 && opponent.gender!=2
      if attacker.gender==opponent.gender
        basedmg=(basedmg*1.25).floor
      else
        basedmg=(basedmg*0.75).floor
      end
    end

I'm almost positive I did this correctly. Just want to make sure though.

 

[LenSho]

I did some tests, and these were the results:

Opponent's Pokémon:
Mew#1, Has Tough Claws, Shiny, knows Seed Bomb and Waterfall
Mew#2, Has Synchronize, knows Seed Bomb and Waterfall

Damage received by:
Mew#1's
Seed Bomb: 64,75,72,69,70,72,76 (Average: 71.1)
Waterfall: 86,97,84,93,83,91,97 (Average: 90.1)

Mew#2's
Seed Bomb: 66,60,59,58,65,65,57 (Average: 61.4)
Waterfall: 59,59,66,59,63,57,61 (Average: 60.6)

If you multiply 71.1 by 1.3 you get 92.5, that's pretty close to 90.1.

So, I'd say it does work correctly.

(I know a Mew with Tough Claws sounds ridiculous, it was only for testing purposes xD)

 

[Rayd12smitty]

I did some tests, and these were the results:

Opponent's Pokémon:
Mew#1, Has Tough Claws, Shiny, knows Seed Bomb and Waterfall
Mew#2, Has Synchronize, knows Seed Bomb and Waterfall

Damage received by:
Mew#1's
Seed Bomb: 64,75,72,69,70,72,76 (Average: 71.1)
Waterfall: 86,97,84,93,83,91,97 (Average: 90.1)

Mew#2's
Seed Bomb: 66,60,59,58,65,65,57 (Average: 61.4)
Waterfall: 59,59,66,59,63,57,61 (Average: 60.6)

If you multiply 71.1 by 1.3 you get 92.5, that's pretty close to 90.1.

So, I'd say it does work correctly.

(I know a Mew with Tough Claws sounds ridiculous, it was only for testing purposes xD)

Lol thanks for double checking for me! I did lot's of tests my self and the damage ratio seemed correct. I just haven't ever added an ability like this so I wanted to be sure

 

[northrone]

Oh /u/rayd12smitty, you told me you added these moves by yourself ;)

 

[Rayd12smitty]

Oh /u/rayd12smitty, you told me you added these moves by yourself ;)

Adding it myself and having someone double check doesn't mean I didn't add it myself...