Creating a move that poisons the user if you're poisoned

[Mutant Yoshi]

I'm having difficulty trying to create a new move. It's supposed to poison the opponent, but only if you're poisoned. It also has a chance to slow the opponent down. However, when I try to use it, it doesn't work. Here's what the code looks like:

################################################################################
# If user is poisoned, then it poisons the foe. (Sneeze)
################################################################################
class PokeBattle_Move_159 < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    return false if !opponent.pbCanPoison?(attacker,false,self)
    if attacker.status==PBStatuses::POISON && opponent.status!=PBStatuses::POISON
    opponent.pbPoison(attacker)
    @battle.pbDisplay(_INTL("{1} was poisoned!",opponent.pbThis))
    return true
    end
  end

  def pbAdditionalEffect(attacker,opponent)
    if opponent.pbCanReduceStatStage?(PBStats::SPEED,false)
      opponent.pbReduceStat(PBStats::SPEED,1,false)
    end
    return true
  end
end

Can anyone help me clean it up?

 

[Rot8er_ConeX]

I'm having difficulty trying to create a new move. It's supposed to poison the opponent, but only if you're poisoned. It also has a chance to slow the opponent down. However, when I try to use it, it doesn't work. Here's what the code looks like:

################################################################################
# If user is poisoned, then it poisons the foe. (Sneeze)
################################################################################
class PokeBattle_Move_159 < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    success=false
    if attacker.status==PBStatuses::POISON && opponent.pbCanPoison?(attacker,false,self)
      opponent.pbPoison(attacker)
      @battle.pbDisplay(_INTL("{1} was poisoned!",opponent.pbThis))
      success=true
[COLOR="Blue"]    end[/COLOR]
    if opponent.pbCanReduceStatStage?(PBStats::SPEED,false) && rand(100)<[COLOR="Red"]chance[/COLOR]
      opponent.pbReduceStat(PBStats::SPEED,1,false)
[COLOR="blue"]      success=true[/COLOR]
[COLOR="Lime"]    end[/COLOR]
    return success
  end
end

Can anyone help me clean it up?

pbAdditionalEffect will only trigger for damaging moves. Change the red "chance" to the actual chance you want the move to have of making the target's Speed drop, and it should work.

If you want the Speed drop to only happen if the target gets poisoned, then get rid of the blue lines and add a second end after the green one.

 

[Mutant Yoshi]

That's the thing though. It actually is meant to be a damaging move. Not a strong one, but still, a damaging move.

 

[The Master]

This could do the job.

class PokeBattle_Move_159 < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    ret=super(attacker,opponent,hitnum,alltargets,showanimation)
    if attacker.status==PBStatuses::POISON && opponent.status!=PBStatuses::POISON &&
      opponent.pbCanPoison?(attacker,true,self)
      opponent.pbPoison(attacker,_INTL("{1} was poisoned!",opponent.pbThis)) if !opponent.isFainted?
    end
    return ret
  end

  def pbAdditionalEffect(attacker,opponent)
    if opponent.pbCanReduceStatStage?(PBStats::SPEED,attacker,false,self)
      opponent.pbReduceStat(PBStats::SPEED,2,attacker,false,self)
    end
    return true
  end
end

 

[Mutant Yoshi]

Tested the code out. It worked while poisoned, but then this error popped up:

Exception: ArgumentError

Message: wrong number of arguments(3 for 4)

PokeBattle_MoveEffects:1334:in `pbReduceStat'

PokeBattle_MoveEffects:1334:in `pbAdditionalEffect'

PokeBattle_Battler:2738:in `pbProcessMoveAgainstTarget'

PokeBattle_Battler:2661:in `each'

PokeBattle_Battler:2661:in `pbProcessMoveAgainstTarget'

PokeBattle_Battler:3149:in `pbUseMove'

PokeBattle_Battler:3129:in `loop'

PokeBattle_Battler:3152:in `pbUseMove'

PokeBattle_Battler:3348:in `pbProcessTurn'

PokeBattle_Battler:3347:in `logonerr'

Also tested it while not poisoned, and it just went straight into the enemy's turn instead.

 

[The Master]

My mistake. I used an old version of the def pbReduceStats. I updated the post and now it should work.

 

[Mutant Yoshi]

My mistake. I used an old version of the def pbReduceStats. I updated the post and now it should work.

Thanks! That fixed the second problem I have, but the move's still not doing anything when the user's not poisoned.

 

[The Master]

Oops, i misunderstood your question. I updated the post again!

 

[The Master]

I forgot one thing, sorry. I make the last update!

 

[Mutant Yoshi]

That worked! Thanks for your help!