[Scripting Question] Editing Pokémon in a Double Battle Event Encounter [SOLVED]

[WLD42]

I'm a scripting super-newbie who's been doing my best to self-teach, and reaching out for help when I need it, and now's one of those times I could use a quick lesson.

My end goal is to have an Event Encounter that is a double battle, with one wild Pokémon always being male and the other always being female.

Looking at the "Modifying the Pokémon" section of the Essentials Wiki's Event Encounters page, I understand the concept of creating a switch and editing the PField_EncounterModifiers section of the script. What I need assistance with is how to make one thing happen to one Pokémon, and a different thing happen to the other.

I tried the following:

Events.onWildPokemonCreate+=proc {|sender,e|
   pokemon=e[0]
   if $game_switches[61]
     pokemon1.makeMale
     pokemon2.makeFemale
   end
}

The error message I get when the event runs is as follows:

Spoiler:

Exception: RuntimeError

Message: Script error within event 4, map 42 (Forest):

Exception: NameError

Message: Section104:20undefined local variable or method `pokemon1' for nil:NilClass

***Full script:

pbDoubleWildBattle(PBSpecies::NIDORAN,1,PBSpecies::NIDORAN,1,26,FALSE,TRUE)


Interpreter:243:in `pbExecuteScript'

PField_EncounterModifiers:17:in `call'

Event:54:in `trigger'

Event:49:in `each'

Event:49:in `trigger'

PField_Field:868:in `pbGenerateWildPokemon'

PField_Field:956:in `pbDoubleWildBattle'

(eval):1:in `pbExecuteScript'

Interpreter:1606:in `eval'

Interpreter:243:in `pbExecuteScript'



Interpreter:276:in `pbExecuteScript'

Interpreter:1606:in `command_355'

Interpreter:494:in `execute_command'

Interpreter:193:in `update'

Interpreter:106:in `loop'

Interpreter:198:in `update'

Scene_Map:103:in `updateold'

Scene_Map:101:in `loop'

Scene_Map:114:in `updateold'

Unreal_Time:151:in `update'

And yes, I combined NIDORANm and NIDORANf into a single NIDORAN species in my heavily-edited Pokédex, which is why I'm needing to figure out how to do this at all. Although my game is going to be Double Battle-centric, so I'm sure I'll need to figure out how to modify double battle Event Encounters eventually.

The part of the error message reading "Message: Section104:20undefined local variable or method `pokemon1' for nil:NilClass" makes me figure that it's my naming of "pokemon1" and "pokemon2" that's incorrect, but I'm not sure where to find the proper way to refer to them.

Any help would be appreciated. Thanks!

 

[Rot8er_ConeX]

The encounter modifiers only work on one Pokemon at a time. You'd probably have to directly edit the wild double battle code rather than an encounter modifier.

 

[WLD42]

Thanks, Rot8er_ConeX. I should've known it wouldn't be that easy!

Is there any chance it would be as simple as adding new comma-separated sections to def pbWildBattle and def pbDoubleWildBattle in the PField_Field script section? For instance, changing

def pbDoubleWildBattle(species1,level1,species2,level2,variable=nil,canescape=true,canlose=false)

to

def pbDoubleWildBattle(species1,level1,[COLOR="Red"]gender1,[/COLOR]species2,level2,[COLOR="red"]gender2,[/COLOR]variable=nil,canescape=true,canlose=false)

Or would I need to add other new pieces to the script to make changes like that work?

 

[Rot8er_ConeX]

Thanks, Rot8er_ConeX. I should've known it wouldn't be that easy!

Is there any chance it would be as simple as adding new comma-separated sections to def pbWildBattle and def pbDoubleWildBattle in the PField_Field script section? For instance, changing

def pbDoubleWildBattle(species1,level1,species2,level2,variable=nil,canescape=true,canlose=false)

to

def pbDoubleWildBattle(species1,level1,[COLOR="Red"]gender1,[/COLOR]species2,level2,[COLOR="red"]gender2,[/COLOR]variable=nil,canescape=true,canlose=false)

Or would I need to add other new pieces to the script to make changes like that work?

Do not add new arguments. Doing so means you would need to find every instance of the pbDoubleWildBattle function and edit it as well.

However, since you found that function, might I suggest placing this below line 954:

  if $game_switches[61]
    genwildpoke.makeMale
    genwildpoke2.makeFemale
  end

 

[WLD42]

Do not add new arguments. Doing so means you would need to find every instance of the pbDoubleWildBattle function and edit it as well.

However, since you found that function, might I suggest placing this below line 954:

  if $game_switches[61]
    genwildpoke.makeMale
    genwildpoke2.makeFemale
  end

Hmm... I tried it and got an error message:

Exception: NameError

Message: Section098:957:in `pbDoubleWildBattle'undefined local variable or method `genwildpoke' for #<Interpreter:0x9e57f60>

(I did learn the term "argument" instead of "comma-separated section", though, so that's something! Can you tell how new I am to this?)

 

[Rot8er_ConeX]

Hmm... I tried it and got an error message:

Exception: NameError

Message: Section098:957:in `pbDoubleWildBattle'undefined local variable or method `genwildpoke' for #<Interpreter:0x9e57f60>

(I did learn the term "argument" instead of "comma-separated section", though, so that's something! Can you tell how new I am to this?)

Hmm...what's your pbDoubleWildBattle look like? And could you highlight line 957?

 

[WLD42]

Spoiler:

def pbDoubleWildBattle(species1,level1,species2,level2,variable=nil,canescape=true,canlose=false)
  if (Input.press?(Input::CTRL) && $DEBUG) || $Trainer.pokemonCount==0
    if $Trainer.pokemonCount>0
      Kernel.pbMessage(_INTL("SKIPPING BATTLE..."))
    end
    pbSet(variable,1)
    $PokemonGlobal.nextBattleBGM=nil
    $PokemonGlobal.nextBattleME=nil
    $PokemonGlobal.nextBattleBack=nil
    return true
  end
  if species1.is_a?(String) || species1.is_a?(Symbol)
    species1=getID(PBSpecies,species1)
  end
  if species2.is_a?(String) || species2.is_a?(Symbol)
    species2=getID(PBSpecies,species2)
  end
  currentlevels=[]
  for i in $Trainer.party
    currentlevels.push(i.level)
  end
[COLOR="Red"]  if $game_switches[61] # CHANGED - added
    genwildpoke.makeMale
    genwildpoke2.makeFemale
  end[/COLOR]
  genwildpoke=pbGenerateWildPokemon(species1,level1)
  genwildpoke2=pbGenerateWildPokemon(species2,level2)
  Events.onStartBattle.trigger(nil,genwildpoke)
  scene=pbNewBattleScene
  if $PokemonGlobal.partner
    othertrainer=PokeBattle_Trainer.new(
       $PokemonGlobal.partner[1],$PokemonGlobal.partner[0])
    othertrainer.id=$PokemonGlobal.partner[2]
    othertrainer.party=$PokemonGlobal.partner[3]
    combinedParty=[]
    for i in 0...$Trainer.party.length
      combinedParty[i]=$Trainer.party[i]
    end
    for i in 0...othertrainer.party.length
      combinedParty[6+i]=othertrainer.party[i]
    end
    battle=PokeBattle_Battle.new(scene,combinedParty,[genwildpoke,genwildpoke2],
       [$Trainer,othertrainer],nil)
    battle.fullparty1=true
  else
    battle=PokeBattle_Battle.new(scene,$Trainer.party,[genwildpoke,genwildpoke2],
       $Trainer,nil)
    battle.fullparty1=false
  end
  battle.internalbattle=true
  battle.doublebattle=battle.pbDoubleBattleAllowed?()
  battle.cantescape=!canescape
  pbPrepareBattle(battle)
  decision=0
  pbBattleAnimation(pbGetWildBattleBGM(species1)) { 
     pbSceneStandby {
        decision=battle.pbStartBattle(canlose)
     }
     for i in $Trainer.party; (i.makeUnmega rescue nil); end
     if $PokemonGlobal.partner
       pbHealAll
       for i in $PokemonGlobal.partner[3]
         i.heal
         i.makeUnmega rescue nil
       end
     end
     if decision==2 || decision==5
       if canlose
         for i in $Trainer.party; i.heal; end
         for i in 0...10
           Graphics.update
         end
#       else
#         $game_system.bgm_unpause
#         $game_system.bgs_unpause
#         Kernel.pbStartOver
       end
     end
     Events.onEndBattle.trigger(nil,decision,canlose)
  }
  Input.update
  pbSet(variable,decision)
  return (decision!=2 && decision!=5)
end

def pbCheckAllFainted()
  if pbAllFainted
    Kernel.pbMessage(_INTL("{1} has no usable Pokémon!\1",$Trainer.name))
    Kernel.pbMessage(_INTL("{1} blacked out!",$Trainer.name))
    pbBGMFade(1.0)
    pbBGSFade(1.0)
    pbFadeOutIn(99999){
       Kernel.pbStartOver
    }
  end
end

I put lines 956-959 in red; they're the ones you suggested adding. 957 specifically is genwildpoke.makeMale.

By the way, thank you so much for taking the time to work through this with me. It's a lot more than I would have expected, and I'm very appreciative.

 

[Rot8er_ConeX]

Spoiler:

def pbDoubleWildBattle(species1,level1,species2,level2,variable=nil,canescape=true,canlose=false)
  if (Input.press?(Input::CTRL) && $DEBUG) || $Trainer.pokemonCount==0
    if $Trainer.pokemonCount>0
      Kernel.pbMessage(_INTL("SKIPPING BATTLE..."))
    end
    pbSet(variable,1)
    $PokemonGlobal.nextBattleBGM=nil
    $PokemonGlobal.nextBattleME=nil
    $PokemonGlobal.nextBattleBack=nil
    return true
  end
  if species1.is_a?(String) || species1.is_a?(Symbol)
    species1=getID(PBSpecies,species1)
  end
  if species2.is_a?(String) || species2.is_a?(Symbol)
    species2=getID(PBSpecies,species2)
  end
  currentlevels=[]
  for i in $Trainer.party
    currentlevels.push(i.level)
  end
[COLOR="Red"]  if $game_switches[61] # CHANGED - added
    genwildpoke.makeMale
    genwildpoke2.makeFemale
  end[/COLOR]
  genwildpoke=pbGenerateWildPokemon(species1,level1)
  genwildpoke2=pbGenerateWildPokemon(species2,level2)
  Events.onStartBattle.trigger(nil,genwildpoke)
  scene=pbNewBattleScene
  if $PokemonGlobal.partner
    othertrainer=PokeBattle_Trainer.new(
       $PokemonGlobal.partner[1],$PokemonGlobal.partner[0])
    othertrainer.id=$PokemonGlobal.partner[2]
    othertrainer.party=$PokemonGlobal.partner[3]
    combinedParty=[]
    for i in 0...$Trainer.party.length
      combinedParty[i]=$Trainer.party[i]
    end
    for i in 0...othertrainer.party.length
      combinedParty[6+i]=othertrainer.party[i]
    end
    battle=PokeBattle_Battle.new(scene,combinedParty,[genwildpoke,genwildpoke2],
       [$Trainer,othertrainer],nil)
    battle.fullparty1=true
  else
    battle=PokeBattle_Battle.new(scene,$Trainer.party,[genwildpoke,genwildpoke2],
       $Trainer,nil)
    battle.fullparty1=false
  end
  battle.internalbattle=true
  battle.doublebattle=battle.pbDoubleBattleAllowed?()
  battle.cantescape=!canescape
  pbPrepareBattle(battle)
  decision=0
  pbBattleAnimation(pbGetWildBattleBGM(species1)) { 
     pbSceneStandby {
        decision=battle.pbStartBattle(canlose)
     }
     for i in $Trainer.party; (i.makeUnmega rescue nil); end
     if $PokemonGlobal.partner
       pbHealAll
       for i in $PokemonGlobal.partner[3]
         i.heal
         i.makeUnmega rescue nil
       end
     end
     if decision==2 || decision==5
       if canlose
         for i in $Trainer.party; i.heal; end
         for i in 0...10
           Graphics.update
         end
#       else
#         $game_system.bgm_unpause
#         $game_system.bgs_unpause
#         Kernel.pbStartOver
       end
     end
     Events.onEndBattle.trigger(nil,decision,canlose)
  }
  Input.update
  pbSet(variable,decision)
  return (decision!=2 && decision!=5)
end

def pbCheckAllFainted()
  if pbAllFainted
    Kernel.pbMessage(_INTL("{1} has no usable Pokémon!\1",$Trainer.name))
    Kernel.pbMessage(_INTL("{1} blacked out!",$Trainer.name))
    pbBGMFade(1.0)
    pbBGSFade(1.0)
    pbFadeOutIn(99999){
       Kernel.pbStartOver
    }
  end
end

I put lines 956-959 in red; they're the ones you suggested adding. 957 specifically is genwildpoke.makeMale.

By the way, thank you so much for taking the time to work through this with me. It's a lot more than I would have expected, and I'm very appreciative.

Okay. Take the two lines below the red, and move them up above the red. That should fix the problem

 

[WLD42]

I haven't tested it enough to know for sure that it's not just the natural probability of the Pokémon gender, but it didn't give an error message, and I tried switching it to have the first one female and the second one male, and they indeed swapped places in the battle, so I'm calling this a success.

Thank you so much for your help! I've added a comment to these lines in the script crediting you.