Editing Type Effectiveness chart and STAB bonus

[HarveySlayer]

I am trying to locate the parts of the code that deal with applying the 50% power boost from STAB and also the code that tells what types are effective against what types. I want to edit the type effectiveness around, and edit the effectiveness amount and STAB bonus. I have looked around for awhile now in the code and I cannot recognize it.

 

[WiserVisor]

I am trying to locate the parts of the code that deal with applying the 50% power boost from STAB and also the code that tells what types are effective against what types. I want to edit the type effectiveness around, and edit the effectiveness amount and STAB bonus. I have looked around for awhile now in the code and I cannot recognize it.

If you are using the battle engine expansion, STAB is accounted for in src/battle_util.c, within this function:

static u32 CalcFinalDmg(u32 dmg, u16 move, u8 battlerAtk, u8 battlerDef, u8 moveType, u16 typeEffectivenessModifier, bool32 isCrit, bool32 updateFlags)
{
...........................................
    if (IS_BATTLER_OF_TYPE(battlerAtk, moveType) && move != MOVE_STRUGGLE)
    {
        if (abilityAtk == ABILITY_ADAPTABILITY)
            MulModifier(&finalModifier, UQ_4_12(2.0));
        else
            MulModifier(&finalModifier, UQ_4_12(1.5));
    }

The type effectiveness table will be found in the same file, the table being named sTypeEffectivenessTable.


If you are using pret pokeemerald instead, STAB calculations are found in src/battle_script_commands.c in the function u8 TypeCalc(u16 move, u8 attacker, u8 defender), as well as static void Cmd_typecalc(void). The important section of both of these functions will look like this:

    if (IS_BATTLER_OF_TYPE(attacker, moveType))
    {
        gBattleMoveDamage = gBattleMoveDamage * 15;
        gBattleMoveDamage = gBattleMoveDamage / 10;
    }

The effectiveness table will be found in src/battle_main.c in the table gTypeEffectiveness.

 

[HarveySlayer]

I am using pokefirered. I am sorry, I should have clarified. I found the critical hit damage multiplier in the pokemon.h file. I changed it from 2 to 3/2.

 

[WiserVisor]

I am using pokefirered. I am sorry, I should have clarified.

Lucky for you, pokefirered has all of the data I listed in the same places as pret pokeemerald.

 

[HarveySlayer]

I found the table, but where do I edit the multiplier for the different effectiveness?

 

[WiserVisor]

I found the table, but where do I edit the multiplier for the different effectiveness?

It looks like you might be able to edit and/or create new multipliers in include/battle_main.h. Looking at this section here:

// defines for the gTypeEffectiveness multipliers
#define TYPE_MUL_NO_EFFECT          0
#define TYPE_MUL_NOT_EFFECTIVE      5
#define TYPE_MUL_NORMAL             10
#define TYPE_MUL_SUPER_EFFECTIVE    20

The multiplier values seems to be what ever the multiplication should be multiplied by 10. So if you wanted something like a 0.3x multiplier, you'd change one of the multipliers to 3. You could also create your own constants with whatever value you want, and then add that to whatever row(s) you want in gTypeEffectiveness.

 

[HarveySlayer]

Thank you so much! There is just so much code to try and navigate.