[Essentials v16.2+] Water Bubble

[SMC23]

It all works fine but the water animation passes through the following animation sprite, for example in the posted video the following pokemon isn´t high enough and thats why this "error" doesn´t happen to you.
What could be the solution??? Thanks in advance.

 

[WolfPP]

It all works fine but the water animation passes through the following animation sprite, for example in the posted video the following pokemon isn´t high enough and thats why this "error" doesn´t happen to you.
What could be the solution??? Thanks in advance.

I didn't undestand your problem. Rec a video to show me.

 

[WolfPP]

Too hard to see that pic with low quality. Put medium size and send again.

 

[SMC23]

 

[WolfPP]

What is your Essentials Version? Also, do you have some custom script about overworld effect? I just copied and edited how Surf Base works and put Klein's effect inside the script. This is the code to check about priority:

Spoiler:

    # Just-in-time creation of sprite
    @sprite = Sprite.new(@viewport) if !@sprite
    if @sprite
      cw = @cws; ch = @chs
      updateAnim
      @wateranim=false if @sprite && @sprite.disposed?
      x = @[email protected]; y = @[email protected]
      createWaterAnim(x,y)
      @sprite.update if @sprite
      @sprite.x = @rsprite.x; @sprite.y = @rsprite.y
      @sprite.ox = cw/2; @sprite.oy = ch -4
      @sprite.z       = @rsprite.z
      @sprite.zoom_x = @rsprite.zoom_x; @sprite.zoom_y = @rsprite.zoom_y
      @sprite.tone    = @rsprite.tone
      @sprite.color   = @rsprite.color
      @sprite.opacity = @rsprite.opacity
    end

But maybe you need to make some editions inside 'createWaterAnim' too.

 

[SMC23]

My version is the 16.2, the script is correct and the only overworld effect i have is yours.
What do you mean with ("createWaterAnim" too)?

 

[WolfPP]

Well, I used v17.2 to make the script, like I wrote in the title. Check how surf base works to v16.2 and make one for you.

 

[Richard PT]

WolfPP I detect an error in this part of your post:

Inside 'def visible=(value)', below '@reflection.visible = value if @reflection' add:

@waterbubble.visible = value if @waterbubblebitmap

The game gives me an error and it points me that line. Then i rechecked that line here in your post, when i saw your Sprite_Character codes here, i realized that "bitmap" part don't belong there. After that i tested again and no error appears. Now its fixed. Please edit the main post for others.

This is the way it should be:

Inside 'def visible=(value)', below '@reflection.visible = value if @reflection' add:

@waterbubble.visible = value if @waterbubble

And thx for sharing your scripts, i not have any more errors to report. See ya. XD

EDIT: If i play through debug, all birthsigns works fine, if i play the "normal" way, (using exe), that error appears. My guess is: Script clashing with each other? I will run more tests to see what's causing this error. When i have results i'll inform you.

 

[WolfPP]

Added '|| event.transparent' inside 'def update':

  def update
    return if disposed? || !$scene || !$scene.is_a?(Scene_Map)
    return jump_sprite if event.jumping?
    if pbGetTerrainTag(event)!=PBTerrain::Beach ||
    event.character_name =="" || event.character_name == "nil" ||
    event!=$game_player && pbEventCommentInput(event,0,"NoWater") || event.transparent
      # Just-in-time disposal of sprite
      if @sprite; @sprite.dispose; @sprite = nil; end
      return
    end

Edited the main post.

 

[FaperJr]

Hi! If anyone wants to use this script in v16.2, I found a way to adapt it:

The first step is the same, put this script below "Sprite_Character" and above "Main":

Spoiler:

class Sprite_WaterBubble
  attr_reader :visible
  attr_accessor :event
  
  def initialize(sprite,event,viewport=nil)
    @rsprite  = sprite
    @sprite   = nil
    @event    = event
    @viewport = viewport   
    @wateranim=false
    @frame = 0
    @frames = 4
    @totalFrames = 0
    @currentIndex = 0
    @disposed = false
    @bitmapFile=BitmapCache.load_bitmap("Graphics/Pictures/water")
    @water=Bitmap.new(@bitmapFile.width,@bitmapFile.height)
    @water.blt(0,0,@bitmapFile,Rect.new(0,0,@bitmapFile.width,@bitmapFile.height))
    @cws = @water.height*2
    @chs = @water.height*2
    @[email protected]/@water.height
    @animationFrames=@totalFrames*@frames
    @loop_points=[0,@totalFrames]
    @actualBitmap=Bitmap.new(@cws,@chs)
    @actualBitmap.clear
    @actualBitmap.stretch_blt(Rect.new(0,0,@cws,@chs),@water,Rect.new(@currentIndex*(@cws/2),0,@cws/2,@chs/2))
    update
  end

  def dispose
    if !@disposed
      @actualBitmap.dispose if @actualBitmap && [email protected]?
      @sprite.dispose if @sprite
      @sprite   = nil
      @disposed = true
      @wateranim=false
    end
  end

  def disposed?; @disposed; end

  def createWaterAnim(x2,y2)
    return if @wateranim
    @sprite=Sprite.new(@viewport)
    @sprite.bitmap=@actualBitmap
    @sprite.x=x2
    @sprite.y=y2
    pbDayNightTint(@sprite)
    @wateranim=true
  end
  
  def updateAnim
    return if !@wateranim || @sprite && @sprite.disposed?
    @frames=4
    @frame+=1
    if @frame >=@frames
      @currentIndex+=1
      @currentIndex=@loop_points[0] if @currentIndex >=@loop_points[1]
      @currentIndex=@loop_points[1]-1 if @currentIndex < @loop_points[0]
      @frame=0
    end
    @actualBitmap.clear
    @actualBitmap.stretch_blt(Rect.new(0,0,@cws,@chs),@water,Rect.new(@currentIndex*(@cws/2),0,@cws/2,@chs/2))
    @sprite.bitmap=@actualBitmap
  end

  def visible=(value); @visible = value; @sprite.visible = value if @sprite && [email protected]?; end

  def jump_sprite
    return unless @sprite
    x = (@event.real_x - @event.map.display_x + 3) / 4 + (Game_Map::TILEWIDTH / 2)
    y = (@event.real_y - @event.map.display_y + 3) / 4 + (Game_Map::TILEHEIGHT)
    @sprite.x = x
    @sprite.y = y
    @sprite.z = @rsprite.z
  end
    
  def update
    return if disposed? || !$scene || !$scene.is_a?(Scene_Map)
    return jump_sprite if event.jumping?
    if pbGetTerrainTag(event)!=PBTerrain::Beach ||
    event.character_name =="" || event.character_name == "nil" ||
    event!=$game_player && pbEventCommentInput(event,0,"NoWater") || event.transparent
      # Just-in-time disposal of sprite
      if @sprite; @sprite.dispose; @sprite = nil; end
      return
    end
    # Just-in-time creation of sprite
    @sprite = Sprite.new(@viewport) if !@sprite
    if @sprite
      cw = @cws; ch = @chs
      updateAnim
      @wateranim=false if @sprite && @sprite.disposed?
      x = @[email protected]; y = @[email protected]
      createWaterAnim(x,y)
      @sprite.update if @sprite
      @sprite.x = @rsprite.x; @sprite.y = @rsprite.y
      @sprite.ox = cw/2; @sprite.oy = ch -4
      @sprite.z       = @rsprite.z
      @sprite.zoom_x = @rsprite.zoom_x; @sprite.zoom_y = @rsprite.zoom_y
      @sprite.tone    = @rsprite.tone
      @sprite.color   = @rsprite.color
      @sprite.opacity = @rsprite.opacity
    end
  end
end

Then, inside "Sprite_Character":

Spoiler:

Under

@bobframetime=1.0/15

add

@waterbubblebitmap=Sprite_WaterBubble.new(self,character,viewport)

Under

def groundY
    return @character.screen_y_ground
end

add

def visible=(value)
    super(value)
    @waterbubblebitmap.visible = value if @waterbubblebitmap
end

Under

@charbitmap=nil

add

@waterbubblebitmap.dispose if @waterbubblebitmap
@waterbubblebitmap = nil

Under

if @character.animation_id != 0
    animation = $data_animations[@character.animation_id]
    animation(animation, true)
    @character.animation_id = 0
end

add

@waterbubblebitmap.update if @waterbubblebitmap

And that's it! You're welcome :)

 

[MQuetzal]

Wolf I have a strange issue with this script. All works great but, when I move my character left or right in the terrain with the "bubbles", it moves diagonally. If I move up or down it works perfectly. This only happens if I go left or right.

The script doesn't crash or anything, is just that my character moves diagonally.

 

[WolfPP]

LOL? Rec a GIF to show it to us please.

 

[MQuetzal]

It's a test map. If you were asking why are things floating and a shiny venusaur.

 

[WolfPP]

Did you try to install it on a new/fresh Essentials version? You're the first one that had that kind if bug.

 

[MQuetzal]

I tried it on a new essentials version and everything works correctly, so is something in my essentials but I don't know exactly what.

I'll check it and try to discover what is happening.

Thanks for answering.