Definitely Ecruteak City. I loved the music that went with it. The gym was also pretty fun, too, though it took me TWO months to figure out the gym. The towers were also fun to explore, and the theater where the Kimono Girls resided was fun, also....
Definitely my favorite town in Johto, perhaps in all the regions.