That's an awesome story, and I'm glad you framed the card. And I like the picture! It does make me wonder if I have any promo cards like that in my cards binder (I've kept all of my Pokemon cards in the same binder that I got back in 1999).
I've never stopped liking Pokemon, so my experience is probably a bit different. I have a lot of older Pokemon stuff, ranging from stuffed toys and posters to cards and games, but I don't consider most of it to be particularly rare (just sentimental). My favorite Pokemon card is a first edition Blastoise that I have from the base set. It's still in the upper left corner of the first page of the aforementioned card binder, and I got it out and took a look at it the last time I visited my parents. I wouldn't want to frame it, as I think it's better-protected in the binder (and I guess I'm also a little shy about liking Pokemon publicly, even though, as you said, it really doesn't matter), but I do enjoy admiring it.
I tend to be a pack rat in general, so I still have a lot of stuff from my childhood, including a lot of more sentimental things than my Pokemon card collection. But I realize that if I think about it, Pokemon has played a pretty significant role in my life, and has been a constant as the rest of my world has changed. Having enjoyed Pokemon for about 2/3 of my life, first as a social pursuit and then as solitary form of relaxation, I can't really imagine what my life would have been like without it.