[Other✓] Function Help

[Meister_anon~Master_o f_None]

Made a new ability and got it working just need some helping getting it to work with my custom health functions.

What i did was in the pokemon.c I changed the shedinja health equation. First I flipped the two, so shedinja has normal health, and everything else has the old shedinja max 1 hp, and no growth on lvl up. Then I set it so instead of it being based on species shedinja, its on shedinja's ability wonder guard.

That's worked fine, But now that I've added a new ability and with an "OR" statement to my function I can't get my second logical argument to use the same function as the first, while leaving everything else to use the second function.

I gave up on using "else" in the first part, since I read that else applies itself to the innermost if function, so that just ensured that my second statement used the health function I didn't want it to. Right now I'm trying to get it work with specific statements and != operands.



Attached is my file with a summary txt, with the lines for the relevant functions.
I'm close to it being right, I just need a little help.

 

[WiserVisor]

I'm close to it being right, I just need a little help.

Here's your issue. Let's walk through the code, imagining we're looking at a Shedinja with the ability Dispirit Guard.

	#ifdef ABILITY_WONDERGUARD
	if (GetMonAbility(mon) == ABILITY_WONDERGUARD)
	{

We would not enter this if-statement, since this Shedinja doesn't have Wonderguard. This would then mean that we would jump over this statement:

                        #ifdef SPECIES_SHEDINJA
			#ifdef ABILITY_DISPIRITGUARD
		if (GetMonAbility(mon) == ABILITY_DISPIRITGUARD && species == SPECIES_SHEDINJA)
		{

This statement is within the "if (GetMonAbility(mon) == ABILITY_WONDERGUARD)" statement, so we don't get a chance to enter it. In fact, you will never enter this statement, because you would need a Pokemon that has the ability Wonderguard to enter the first statement, and then that same Pokemon would also need the ability Dispiritguard to enter the second if-statement. It is impossible for this to occur.
Then, once we are beyond the scope of the "if (GetMonAbility(mon) == ABILITY_WONDERGUARD)" statement, we see this statement:

if ((GetMonAbility(mon) != ABILITY_WONDERGUARD) || (GetMonAbility(mon) != ABILITY_DISPIRITGUARD && species != SPECIES_SHEDINJA))
	{
		newMaxHP = 1;
	}

The logic in this if-statement is as follows: If the Pokemon does not have the ability Wonderguard, it will have a new max hp of 1. This Pokemon will also have a new max hp of 1 if the Pokemon does not have Dispiritguard and is also not Shedinja. This statement would mean that our Shedinja, which has the ability Dispritguard, would have a max hp of 1 due to the first half of this if-statement. Our Shedinja doesn't have Wonderguard, thus it has 1 hp.

Now, here's how I would rewrite this section of code:

#ifdef ABILITY_WONDERGUARD
	if (GetMonAbility(mon) == ABILITY_WONDERGUARD)
	{
		u32 n = 2 * baseHP + ivs[STAT_HP];
		newMaxHP = MathMin((((n + evs[STAT_HP] / 4) * level) / 100) + level + 10, 0xFFFF);
        }
	#ifdef SPECIES_SHEDINJA
	#ifdef ABILITY_DISPIRITGUARD
	else if (GetMonAbility(mon) == ABILITY_DISPIRITGUARD && species == SPECIES_SHEDINJA)
	{
		u32 n = 2 * baseHP + ivs[STAT_HP];
		newMaxHP = MathMin((((n + evs[STAT_HP] / 4) * level) / 100) + level, 0xFFFF);
	}
	else
	{
		newMaxHP = 1;
	}
		#endif
		#endif
	#endif

If you want to be sure that this code works, I've provided a few examples in the spoiler below that you can walk through to see the process this code would go through with different Pokemon.

Examples

Spoiler:

Shedinja with Dispiritguard

Spoiler:

Now let's walk through this new code and see what happens with our Shedinja with the ability Dispiritguard. We first go to this statement:

if (GetMonAbility(mon) == ABILITY_WONDERGUARD)
	{

Our Shedinja does not have Wonderguard, so we don't enter this statement. We then look at this statement:

else if (GetMonAbility(mon) == ABILITY_DISPIRITGUARD && species == SPECIES_SHEDINJA)
	{

Our Pokemon does indeed have the ability Dispiritguard, and it is also a Shedinja, so we enter this statment.

                        u32 n = 2 * baseHP + ivs[STAT_HP];
			newMaxHP = MathMin((((n + evs[STAT_HP] / 4) * level) / 100) + level, 0xFFFF);
		}

This is the new hp of our Shedinja. We now skip over that final section of code, due to it being an else-statement and the fact that we enter a prior connected if-statement.

Shedinja with Wonderguard

Spoiler:

Now, what would happen if we gave Shedinja its normal ability, Wonderguard? We look at the first statement:

if (GetMonAbility(mon) == ABILITY_WONDERGUARD)
	{

Our Shedinja does indeed have Wonderguard, so we enter this statment.

u32 n = 2 * baseHP + ivs[STAT_HP];
		newMaxHP = MathMin((((n + evs[STAT_HP] / 4) * level) / 100) + level + 10, 0xFFFF);
        }

This is our Shedinja's new max hp. We then skip over both the "else if (GetMonAbility(mon) == ABILITY_DISPIRITGUARD && species == SPECIES_SHEDINJA)" and the last else-statement, since these two else-statements are connected to the first if-statement, and we entered the first if-statement.

Gardevoir with Wonderguard

Spoiler:

Now, lets say we had....I dunno, a Gardevoir with Wonderguard. Here's how the code would react to that Pokemon. We look at the first statement:

if (GetMonAbility(mon) == ABILITY_WONDERGUARD)
	{

Our Gardevoir does indeed have Wonderguard, so we enter this statment.

u32 n = 2 * baseHP + ivs[STAT_HP];
		newMaxHP = MathMin((((n + evs[STAT_HP] / 4) * level) / 100) + level + 10, 0xFFFF);
        }

This is our Gardevoir's new max hp. We then skip over both the "else if (GetMonAbility(mon) == ABILITY_DISPIRITGUARD && species == SPECIES_SHEDINJA)" and the last else-statement, since these two else-statements are connected to the first if-statement, and we entered the first if-statement.

Gardevoir with Dispiritguard

Spoiler:

Let's see what happens if our Gardevoir has the ability Dispiritguard. We look at that first if-statement:

if (GetMonAbility(mon) == ABILITY_WONDERGUARD)
	{

We don't enter this statement, since our Gardevoir does not have Wonderguard. Then we look at this statement:

else if (GetMonAbility(mon) == ABILITY_DISPIRITGUARD && species == SPECIES_SHEDINJA)
	{

We don't enter this statement either. Our Gardevoir does have Dispiritguard, but it isn't a Shedinja, so it's a no-go. That means we enter the final else-statement, giving our Gardevoir a max hp of 1.

Gardevoir with Trace

Spoiler:

Let's see what would happen if a Gardevoir with one of its normal abilities, Trace, went through this code. We look at that first if-statement:

if (GetMonAbility(mon) == ABILITY_WONDERGUARD)
	{

Our Gardevoir doesn't have Wonderguard, so we don't go in here. We go to the next statement:

else if (GetMonAbility(mon) == ABILITY_DISPIRITGUARD && species == SPECIES_SHEDINJA)
	{

Our Gardevoir doesn't have Dispritguard, nor is it a Shedinja, so we skip over this statement as well. That leaves us with the final else-statement, which gives our Gardevoir a max hp of 1.

 

[Meister_anon~Master_o f_None]

..

Ok got it, works now, so the problem was nesting functions makes the inside one rely on the first being true beforehand, or it gets skipped over.

And that OR functions work different when ! not is involved. The first argument is much more important.

Thanks.