Just a reminder that providing specifics on, sharing links to, or naming websites where ROMs can be accessed is against the rules. If your post has any of this information it will be removed.
Welcome to PokéCommunity! Register now and join one of the best fan communities on the 'net to talk Pokémon and more! We are not affiliated with The Pokémon Company or Nintendo.
Hi Guys
I used some move script that I found on the community but some of them are giving me an error
Please help me, I am new to scripting and Ruby language
The first one is Spotlight:
Spoiler:
This is the code I found
Code:
################################################################################
# This round, target becomes the target of attacks that have single targets. (Spotlight)
################################################################################
class PokeBattle_Move_1A6 < PokeBattle_Move
def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
if [email protected]
@battle.pbDisplay(_INTL("But it failed!"))
return -1
end
pbShowAnimation(@id,attacker,nil,hitnum,alltargets,showanimation)
opponent.effects[PBEffects::FollowMe]=true
if !opponent.pbPartner.isFainted?
opponent.pbPartner.effects[PBEffects::FollowMe]=false
end
@battle.pbDisplay(_INTL("{1} shone a spotlight on {2}!",attacker.pbThis,opponent.pbThis))
return 0
end
end
But throat chop seems pretty straight forward, like a combination of imprison and healblock is how I did it (avoided looking into disable because it was referenced too many times lol)
First thing you need to do is add an effect to PBEffects
Code:
ThroatChop = 109 # use whatever is the next lowest value for you
And obviously add a def to Move_effects:
Code:
class PokeBattle_Move_CF15 < PokeBattle_Move
def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
ret=super(attacker,opponent,hitnum,alltargets,showanimation)
if opponent.damagestate.calcdamage>0 && !opponent.damagestate.substitute &&
!opponent.isFainted?
opponent.effects[PBEffects::ThroatChop]=2
@battle.pbDisplay(_INTL("{1} can't use sound based moves!",opponent.pbThis))
end
return ret
end
end
Then you just have a few things left to
first find pbTryUseMove in PokeBattle_battler and add this (I added mine below the imprison code)
Code:
if @effects[PBEffects::ThroatChop]>0 && !pbOpposing1.fainted?
if thismove.isSoundBased?
@battle.pbDisplay(_INTL("{1} can't use {2} because they were Throat Chopped!",pbThis,thismove.name))
PBDebug.log("[Move failed] #{pbThis} can't use #{thismove.name} because they were Throat chopped!")
return false
end
end
The previous block prevents an already selected move from being used. This next block will prevent them from choosing it: put in PokeBattle_Battle in pbCanChooseMove (again I put it below imprison)
Code:
if thispkmn.effects[PBEffects::ThroatChop]>0 && thismove.isSoundBased?
if showMessages
pbDisplayPaused(_INTL("{1} can't use {2} because they are throat chopped!",thispkmn.pbThis,thismove.name))
end
return false
end
And lastly decrement the value if it's more than 0 in PokeBattle_Battle in pbEndofRoundPhase (this time I put it below Heal bell because it works similar)
Code:
# Throat Chop
for i in priority
next if i.fainted?
if i.effects[PBEffects::ThroatChop]>0
i.effects[PBEffects::ThroatChop]-=1
if i.effects[PBEffects::ThroatChop]==0
pbDisplay(_INTL("{1}'s can use sound based moves again!",i.pbThis))
PBDebug.log("[End of effect] #{i.pbThis} is no longer Throat chopped")
end
end
end
I just tested on an Exploud that knows only sound moves and it prevented an already selected move and also prevented move selection causing it to struggle. If anyone happens to know the real lines pokemon displays when throat chop effects happen please let me know!
This is two errors that pops up one after the other
################################################################################
# The user's next move will be a critical hit
################################################################################
class PokeBattle_Move_CF18 < PokeBattle_Move
def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
if attacker.effects[PBEffects::LaserFocus]>0
@battle.pbDisplay(_INTL("But it failed!"))
return -1
else
attacker.effects[PBEffects::LaserFocus]=1
@battle.pbDisplay(_INTL("{1} began focusing hard!",attacker.pbThis))
return 0
end
end
end
# Next, paste this line in PBEffects (Change the number to the lowest number that's not used)
LaserFocus = 113
# In PokeBattle_Battler, paste this line directly under "def pbEffectsOnMoveEnd":
user.effects[PBEffects::LaserFocus]-=1
# In PokeBattle_Move, paste this uner "def isCritical?":
return true if attacker.effects[PBEffects::LaserFocus]>0
I think you probably have to initialize the effects value for your abilities. I keep noticing ">" and "=" in your errors. So I think that might be the problem. For example, for Laser Focus it would look like this:
Code:
@effects[PBEffects::LaserFocus] = 0
I think the place to put it is in PokeBattle_Battler, under @effects[PBEffects::Yawn]. I did so for Laser Focus and it works correctly. I have not tried Throat Chop or Spotlight, yet, but I think the same method should work.
Then, add a new def after/below 'def pbProcessTurn(choice)' code:
Spoiler:
Code:
def pbEffectsOnMoveEnd(move,user,target,damage)
user.effects[PBEffects::LaserFocus]-=1
damage=0 if damage==nil
if damage>0
if !target.damagestate.substitute
if target.hasWorkingAbility(:WIMPOUT) &&
target.hp<target.totalhp/2 && target.hp+damage>target.totalhp/2
@battle.pbDisplayEffect(target)
PBDebug.log("[#{target.pbThis}'s #{PBAbilities.getName(target.ability)} triggered]")
choices=[]
[email protected](target.index)
for i in 0...party.length
choices[choices.length]=i if @battle.pbCanSwitchLax?(target.index,i,false)
end
if choices.length>0
newpoke=choices[@battle.pbRandom(choices.length)]
target.pbResetForm
@battle.pbReplace(target.index,newpoke,false)
@battle.pbDisplay(_INTL("{1} was dragged out!",target.pbThis))
@battle.pbOnActiveOne(target)
target.pbAbilitiesOnSwitchIn(true)
elsif [email protected]
@battle.decision=3
end
elsif target.hasWorkingAbility(:EMERGENCYEXIT) && target.hp<target.totalhp/2 &&
target.hp+damage>target.totalhp/2
@battle.pbDisplayEffect(target)
PBDebug.log("[#{target.pbThis}'s #{PBAbilities.getName(target.ability)} triggered]")
choices=[]
[email protected](target.index)
for i in 0...party.length
choices[choices.length]=i if @battle.pbCanSwitchLax?(target.index,i,false)
end
if choices.length>0
newpoke=choices[@battle.pbRandom(choices.length)]
target.pbResetForm
@battle.pbReplace(target.index,newpoke,false)
@battle.pbDisplay(_INTL("{1} was dragged out!",target.pbThis))
@battle.pbOnActiveOne(target)
target.pbAbilitiesOnSwitchIn(true)
elsif [email protected]
@battle.decision=3
end
end
end
end
end
In 'PokeBattle_MoveEffect' script, add:
Spoiler:
Code:
################################################################################
# The user's next move will be a critical hit (Laser Focus)
################################################################################
class PokeBattle_Move_19A < PokeBattle_Move
def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
if attacker.effects[PBEffects::LaserFocus]>0
@battle.pbDisplay(_INTL("But it failed!"))
return -1
else
attacker.effects[PBEffects::LaserFocus]=1
@battle.pbDisplay(_INTL("{1} began focusing hard!",attacker.pbThis))
return 0
end
end
end
19A will be your code here and into move.txt too.
Finally, 'PokeBattle_Move' script, add below 'return true if pbCritialOverride(attacker,opponent)'
Code:
return true if attacker.effects[PBEffects::LaserFocus]>0
Throat Chop:
Spoiler:
In PBEffects add (111 and 112 will be your last number. Edit if not):
ThroatChop = 111
LastMoveFailed = 112
if @effects[PBEffects::ThroatChop]>0 && !pbOpposing1.fainted?
if thismove.isSoundBased?
@battle.pbDisplay(_INTL("{1} can't use {2} because they were Throat Chopped!",pbThis,thismove.name))
PBDebug.log("[Move failed] #{pbThis} can't use #{thismove.name} because they were Throat chopped!")
return false
end
end
Now, in 'PokeBattle_MoveEffects' script, add a new code to the move:
Spoiler:
Code:
################################################################################
# Throat Chop
################################################################################
class PokeBattle_Move_CF15 < PokeBattle_Move
def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
ret=super(attacker,opponent,hitnum,alltargets,showanimation)
if opponent.damagestate.calcdamage>0 && !opponent.damagestate.substitute &&
!opponent.isFainted?
opponent.effects[PBEffects::ThroatChop]=2
@battle.pbDisplay(_INTL("{1} can't use sound based moves!",opponent.pbThis))
end
return ret
end
end
CF15 will be your code for that here and inside move.txt too
In 'PokeBattle_Battle' script, below 'if opp2.effects[PBEffects::Imprison]' code, paste (like that):
Spoiler:
Code:
if opp2.effects[PBEffects::Imprison]
if thismove.id==opp2.moves[0].id ||
thismove.id==opp2.moves[1].id ||
thismove.id==opp2.moves[2].id ||
thismove.id==opp2.moves[3].id
if showMessages
pbDisplayPaused(_INTL("{1} can't use the sealed {2}!",thispkmn.pbThis,thismove.name))
end
#PBDebug.log("[CanChoose][#{opp2.pbThis} has: #{opp2.moves[0].name}, #{opp2.moves[1].name},#{opp2.moves[2].name},#{opp2.moves[3].name}]")
return false
end
end
if thispkmn.effects[PBEffects::ThroatChop]>0 && thismove.isSoundBased?
if showMessages
pbDisplayPaused(_INTL("{1} can't use {2} because they are throat chopped!",thispkmn.pbThis,thismove.name))
end
return false
end
Then, inside '# Ice Body' code, paste:
Code:
# Throat Chop
for i in priority
next if i.fainted?
if i.effects[PBEffects::ThroatChop]>0
i.effects[PBEffects::ThroatChop]-=1
if i.effects[PBEffects::ThroatChop]==0
pbDisplay(_INTL("{1}'s can use sound based moves again!",i.pbThis))
PBDebug.log("[End of effect] #{i.pbThis} is no longer Throat chopped")
end
end
end
Now, to add about 'LastMoveFailed', inside 'PokeBattle_Battler', add below 'user.effects[PBEffects::Stockpile]=0 if thismove.function==0x113':
Code:
user.effects[PBEffects::LastMoveFailed]=true
Inside 'def pbProcessMoveAgainstTarget(thismove,user,target,numhits,turneffects,nocheck=false,alltargets=nil,showanimation=true,dancercheck=false)' add (use CTRL SHIFT F to find the code):
Code:
user.pbFaint if user.fainted? # no return
#return if numhits>1 && target.damagestate.calcdamage<=0
if numhits>1 && target.damagestate.calcdamage<=0
user.effects[PBEffects::LastMoveFailed]=true
return
end
@battle.pbJudgeCheckpoint(user,thismove)
# Additional effect
Finally, add (use CTRL SHIFT F to find the code):
Code:
# Berry check
for j in 0...4
@battle.battlers[j].pbBerryCureCheck
end
target.pbUpdateTargetedMove(thismove,user)
user.effects[PBEffects::LastMoveFailed]=false
end
Then, add a new def after/below 'def pbProcessTurn(choice)' code:
Spoiler:
Code:
def pbEffectsOnMoveEnd(move,user,target,damage)
user.effects[PBEffects::LaserFocus]-=1
damage=0 if damage==nil
if damage>0
if !target.damagestate.substitute
if target.hasWorkingAbility(:WIMPOUT) &&
target.hp<target.totalhp/2 && target.hp+damage>target.totalhp/2
@battle.pbDisplayEffect(target)
PBDebug.log("[#{target.pbThis}'s #{PBAbilities.getName(target.ability)} triggered]")
choices=[]
[email protected](target.index)
for i in 0...party.length
choices[choices.length]=i if @battle.pbCanSwitchLax?(target.index,i,false)
end
if choices.length>0
newpoke=choices[@battle.pbRandom(choices.length)]
target.pbResetForm
@battle.pbReplace(target.index,newpoke,false)
@battle.pbDisplay(_INTL("{1} was dragged out!",target.pbThis))
@battle.pbOnActiveOne(target)
target.pbAbilitiesOnSwitchIn(true)
elsif [email protected]
@battle.decision=3
end
elsif target.hasWorkingAbility(:EMERGENCYEXIT) && target.hp<target.totalhp/2 &&
target.hp+damage>target.totalhp/2
@battle.pbDisplayEffect(target)
PBDebug.log("[#{target.pbThis}'s #{PBAbilities.getName(target.ability)} triggered]")
choices=[]
[email protected](target.index)
for i in 0...party.length
choices[choices.length]=i if @battle.pbCanSwitchLax?(target.index,i,false)
end
if choices.length>0
newpoke=choices[@battle.pbRandom(choices.length)]
target.pbResetForm
@battle.pbReplace(target.index,newpoke,false)
@battle.pbDisplay(_INTL("{1} was dragged out!",target.pbThis))
@battle.pbOnActiveOne(target)
target.pbAbilitiesOnSwitchIn(true)
elsif [email protected]
@battle.decision=3
end
end
end
end
end
In 'PokeBattle_MoveEffect' script, add:
Spoiler:
Code:
################################################################################
# The user's next move will be a critical hit (Laser Focus)
################################################################################
class PokeBattle_Move_19A < PokeBattle_Move
def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
if attacker.effects[PBEffects::LaserFocus]>0
@battle.pbDisplay(_INTL("But it failed!"))
return -1
else
attacker.effects[PBEffects::LaserFocus]=1
@battle.pbDisplay(_INTL("{1} began focusing hard!",attacker.pbThis))
return 0
end
end
end
19A will be your code here and into move.txt too.
Finally, 'PokeBattle_Move' script, add below 'return true if pbCritialOverride(attacker,opponent)'
Code:
return true if attacker.effects[PBEffects::LaserFocus]>0
Throat Chop:
Spoiler:
In PBEffects add (111 and 112 will be your last number. Edit if not):
ThroatChop = 111
LastMoveFailed = 112
if @effects[PBEffects::ThroatChop]>0 && !pbOpposing1.fainted?
if thismove.isSoundBased?
@battle.pbDisplay(_INTL("{1} can't use {2} because they were Throat Chopped!",pbThis,thismove.name))
PBDebug.log("[Move failed] #{pbThis} can't use #{thismove.name} because they were Throat chopped!")
return false
end
end
Now, in 'PokeBattle_MoveEffects' script, add a new code to the move:
Spoiler:
Code:
################################################################################
# Throat Chop
################################################################################
class PokeBattle_Move_CF15 < PokeBattle_Move
def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
ret=super(attacker,opponent,hitnum,alltargets,showanimation)
if opponent.damagestate.calcdamage>0 && !opponent.damagestate.substitute &&
!opponent.isFainted?
opponent.effects[PBEffects::ThroatChop]=2
@battle.pbDisplay(_INTL("{1} can't use sound based moves!",opponent.pbThis))
end
return ret
end
end
CF15 will be your code for that here and inside move.txt too
In 'PokeBattle_Battle' script, below 'if opp2.effects[PBEffects::Imprison]' code, paste (like that):
Spoiler:
Code:
if opp2.effects[PBEffects::Imprison]
if thismove.id==opp2.moves[0].id ||
thismove.id==opp2.moves[1].id ||
thismove.id==opp2.moves[2].id ||
thismove.id==opp2.moves[3].id
if showMessages
pbDisplayPaused(_INTL("{1} can't use the sealed {2}!",thispkmn.pbThis,thismove.name))
end
#PBDebug.log("[CanChoose][#{opp2.pbThis} has: #{opp2.moves[0].name}, #{opp2.moves[1].name},#{opp2.moves[2].name},#{opp2.moves[3].name}]")
return false
end
end
if thispkmn.effects[PBEffects::ThroatChop]>0 && thismove.isSoundBased?
if showMessages
pbDisplayPaused(_INTL("{1} can't use {2} because they are throat chopped!",thispkmn.pbThis,thismove.name))
end
return false
end
Then, inside '# Ice Body' code, paste:
Code:
# Throat Chop
for i in priority
next if i.fainted?
if i.effects[PBEffects::ThroatChop]>0
i.effects[PBEffects::ThroatChop]-=1
if i.effects[PBEffects::ThroatChop]==0
pbDisplay(_INTL("{1}'s can use sound based moves again!",i.pbThis))
PBDebug.log("[End of effect] #{i.pbThis} is no longer Throat chopped")
end
end
end
Now, to add about 'LastMoveFailed', inside 'PokeBattle_Battler', add below 'user.effects[PBEffects::Stockpile]=0 if thismove.function==0x113':
Code:
user.effects[PBEffects::LastMoveFailed]=true
Inside 'def pbProcessMoveAgainstTarget(thismove,user,target,numhits,turneffects,nocheck=false,alltargets=nil,showanimation=true,dancercheck=false)' add (use CTRL SHIFT F to find the code):
Code:
user.pbFaint if user.fainted? # no return
#return if numhits>1 && target.damagestate.calcdamage<=0
if numhits>1 && target.damagestate.calcdamage<=0
user.effects[PBEffects::LastMoveFailed]=true
return
end
@battle.pbJudgeCheckpoint(user,thismove)
# Additional effect
Finally, add (use CTRL SHIFT F to find the code):
Code:
# Berry check
for j in 0...4
@battle.battlers[j].pbBerryCureCheck
end
target.pbUpdateTargetedMove(thismove,user)
user.effects[PBEffects::LastMoveFailed]=false
end
