Help for Custom Ability: Soul Reaper (v.18)

[Test_BR]

Hello! I hope this is the right thread to post.

Edit: 15.10.2020
The issues have now been solved, thanks to Turn20Negate.

Content:
With Turn20Negate's help, I've created an ability that works similarly to Leech Seed. So long as the user is in the battle, it will drain 1/8 HP of opposing Pokémon near to it.

Code in BattleHandlers_Abilities (below Bad Dreams):

BattleHandlers::EOREffectAbility.add(:SOULREAPER,
  proc { |ability,battler,battle|
    splashshown = false
    battle.eachOtherSideBattler(battler.index) do |b|
      next if !battler || battler.fainted?
      next if !b.near?(battler) || !b.takesIndirectDamage?(PokeBattle_SceneConstants::USE_ABILITY_SPLASH)
      next if b.pbHasType?(:GHOST) || b.pbHasType?(:NORMAL)
      if !splashshown
        battle.pbShowAbilitySplash(battler)
        splashshown = true
      end
      oldHP = b.hp;oldHPRecipient = battler.hp
      hpLoss = b.totalhp/8
      b.pbReduceHP(hpLoss)
      battler.pbRecoverHPFromDrain(hpLoss,b,
         _INTL("{1}'s health was drained!",b.pbThis))
      battler.pbAbilitiesOnDamageTaken(oldHPRecipient);b.pbAbilitiesOnDamageTaken(oldHP)
      b.pbItemHPHealCheck
      b.pbFaint if b.fainted?
      battler.pbFaint if battler.fainted?
    end
    battle.pbHideAbilitySplash(battler)
  }
)

 

[Turn20Negate]

Try changing this line:

next if !b.near?(battler) && !(b.pbHasType?(:GHOST) || b.pbHasType?(:Normal))

to this:

next if !b.near?(battler) || b.pbHasType?(:GHOST) || b.pbHasType?(:NORMAL)

 

[Test_BR]

Try changing this line:

next if !b.near?(battler) && !(b.pbHasType?(:GHOST) || b.pbHasType?(:Normal))

to this:

next if !b.near?(battler) || b.pbHasType?(:GHOST) || b.pbHasType?(:NORMAL)

Thanks for your suggestion!I've tried it out, but unfortunately, Ghost and Normal Pokémon are still affected by the ability.

 

[Turn20Negate]

I'd suggest you to test, if this ability also affects battlers that are far away (in triple battles). That way you can determine if the error lies somewhere outside this line.

 

[mgriffin]

Hello! I hope this is the right thread to post.

Not a big deal, but it wasn't. The right place for asking questions is Pokémon Essentials.

Scripts, Tutorials & Tools is for posting your completed things for other people to use :)

 

[Test_BR]

I'd suggest you to test, if this ability also affects battlers that are far away (in triple battles). That way you can determine if the error lies somewhere outside this line.

I've tried it out. Only opposing Pokémon that are near the user are affected by the ability. Opposing Pokémon that are too far away are not affected. Does that mean the error likely lies in said line?

 

[Turn20Negate]

You could try if this version works for you. :)

Spoiler:

BattleHandlers::EOREffectAbility.add(:SOULREAPER,
  proc { |ability,battler,battle|
    splashshown = false
    battle.eachOtherSideBattler(battler.index) do |b|
      next if !battler || battler.fainted?
      next if !b.near?(battler) || !b.takesIndirectDamage?(PokeBattle_SceneConstants::USE_ABILITY_SPLASH)
      next if b.pbHasType?(:GHOST) || b.pbHasType?(:NORMAL)
      if !splashshown
        battle.pbShowAbilitySplash(battler)
        splashshown = true
      end
      oldHP = b.hp;oldHPRecipient = battler.hp
      hpLoss = b.totalhp/8
      b.pbReduceHP(hpLoss)
      battler.pbRecoverHPFromDrain(hpLoss,b,
         _INTL("{1}'s health was drained!",b.pbThis))
      battler.pbAbilitiesOnDamageTaken(oldHPRecipient);b.pbAbilitiesOnDamageTaken(oldHP)
      b.pbItemHPHealCheck
      b.pbFaint if b.fainted?
      battler.pbFaint if battler.fainted?
    end
    battle.pbHideAbilitySplash(battler)
  }
)

 

[Test_BR]

You could try if this version works for you. :)

Spoiler:

BattleHandlers::EOREffectAbility.add(:SOULREAPER,
  proc { |ability,battler,battle|
    splashshown = false
    battle.eachOtherSideBattler(battler.index) do |b|
      next if !battler || battler.fainted?
      next if !b.near?(battler) || !b.takesIndirectDamage?(PokeBattle_SceneConstants::USE_ABILITY_SPLASH)
      next if b.pbHasType?(:GHOST) || b.pbHasType?(:NORMAL)
      if !splashshown
        battle.pbShowAbilitySplash(battler)
        splashshown = true
      end
      oldHP = b.hp;oldHPRecipient = battler.hp
      hpLoss = b.totalhp/8
      b.pbReduceHP(hpLoss)
      battler.pbRecoverHPFromDrain(hpLoss,b,
         _INTL("{1}'s health was drained!",b.pbThis))
      battler.pbAbilitiesOnDamageTaken(oldHPRecipient);b.pbAbilitiesOnDamageTaken(oldHP)
      b.pbItemHPHealCheck
      b.pbFaint if b.fainted?
      battler.pbFaint if battler.fainted?
    end
    battle.pbHideAbilitySplash(battler)
  }
)

Thanks so much! It works perfectly. :]
If you don't mind, I'll mention your name in the credits once I've created a bunch of custom moves/abilities for everyone to share.