[Scripting Question] How do I change non-critical hit moves' crit ratio to 0?

[Tommaniacal]

So, in Pokebattle_Move, under def pbIsCritical?

    ratios=(USENEWBATTLEMECHANICS) ? [16,8,2,1,1] : [16,8,4,3,2]

I'm assuming the 16,8,2,1 means the crit stages are 1/16, 1/8, 1/2 and 100%, however, I want the first stage to be a 0% chance (This means that non crit moves like tackle will never crit unless things like Focus Energy or Scope lens are used). How would I go about doing this? I don't want to break the universe by dividing by 0

Thanks!

 

[Vendily]

Well, for starters, there's no division involved, it'd just end up calling rand(0), which picks a random floating point between 0 (inclusive) and 1 (exclusive). though you could instead put a line above the return that returns false if ratios[c] is 0. that'd be simplest.
return false if ratios[c]==0

 

[Tommaniacal]

Well, for starters, there's no division involved, it'd just end up calling rand(0), which picks a random floating point between 0 (inclusive) and 1 (exclusive). though you could instead put a line above the return that returns false if ratios[c] is 0. that'd be simplest.
return false if ratios[c]==0

When you say above the return, do you mean above return @battle.pbRandom(ratios[c])==0? So like:

Spoiler:

    ratios=(USENEWBATTLEMECHANICS) ? [16,8,2,1,1] : [16,8,4,3,2]
    c+=attacker.effects[PBEffects::FocusEnergy]
    c+=1 if hasHighCriticalRate?
    if (attacker.inHyperMode? rescue false) && isConst?(self.type,PBTypes,:SHADOW)
      c+=1
    end
    c+=1 if attacker.hasWorkingAbility(:SUPERLUCK)
    if attacker.hasWorkingItem(:STICK) &&
       isConst?(attacker.species,PBSpecies,:FARFETCHD)
      c+=2
    end
    if attacker.hasWorkingItem(:STICK) &&
       isConst?(attacker.species,PBSpecies,:MALLARKEE)
      c+=2
    end
    if attacker.hasWorkingItem(:LUCKYPUNCH) &&
       isConst?(attacker.species,PBSpecies,:CHANSEY)
      c+=2
    end
    if attacker.hasWorkingItem(:LUCKYPUNCH) &&
       isConst?(attacker.species,PBSpecies,:BLISSEY)
      c+=2
    end
    if attacker.hasWorkingItem(:CURSEDPIN) &&
       isConst?(attacker.species,PBSpecies,:BANETTE)
      c+=2
    end
    if attacker.hasWorkingItem(:CURSEDPIN) &&
       isConst?(attacker.species,PBSpecies,:SCARIONETTE)
      c+=2
    end
    c+=1 if attacker.hasWorkingItem(:RAZORCLAW)
    c+=1 if attacker.hasWorkingItem(:SCOPELENS)
    c=4 if c>4
    return false if ratios[c]==0
    return @battle.pbRandom(ratios[c])==0
  end

 

[Vendily]

yep, exactly!

 

[Tommaniacal]

yep, exactly!

Cool, Thank you very much!