How does applysandstorm work?

[Seenit45]

Hey there, I found two errors regarding the 17.2 version of Pokemon Essentials.

The first one is pretty simple:The move Petal Blizzard is written to be a special attack in the PBS files, even though it should be a physical attack.
^Disregard this one.I just realised Petal Blizzard is a gen 6 move that I got from a different PBS file,so it has nothing to do with the normal Essentials version....

For the second one, however, I'm not sure if it's an actual error or it's just me misunderstanding the script, but, in the script editor, in the PokeBattle_Move folder, around the line 931, it is written so that Sandstorm raises the DEFENSE or Rock Types, even though it should raise their Special Defense.Here's how it looks:

    defense=opponent.defense
    if @battle.pbWeather==PBWeather::SANDSTORM &&
       opponent.pbHasType?(:ROCK) && applysandstorm
      defense=(defense*1.5).round
    end

This is how I tried to fix it,although I'm not 100% sure it worked:

    spdef=opponent.spdef
    if @battle.pbWeather==PBWeather::SANDSTORM &&
       opponent.pbHasType?(:ROCK) && applysandstorm
      spdef=(spdef*1.5).round

Please let me know if I'm wrong.

 

[Maruno]

You're wrong on all three counts.

Firstly, there's no such version as 1.7. The latest version is 17.2.

Secondly, Petal Blizzard is a move from Gen 6, and the PBS files that come with Essentials only go up to Gen 5. It's not my problem.

Thirdly, the variable defense contains the target's Defense stat if the move is physical, or the target's Special Defense if the move is special. Think of it as the defensive stat, rather than specifically Defense. atk is the same; it's the attacking stat (which is either Attack or Special Attack as appropriate). The code for Sandstorm is correct, so don't worry about it.

 

[Seenit45]

You're wrong on all three counts.

Firstly, there's no such version as 1.7. The latest version is 17.2.

Secondly, Petal Blizzard is a move from Gen 6, and the PBS files that come with Essentials only go up to Gen 5. It's not my problem.

Yep, I apologize. I just realised those 2 were wrong right before I read your reply.

Thirdly, the variable defense contains the target's Defense stat if the move is physical, or the target's Special Defense if the move is special. Think of it as the defensive stat, rather than specifically Defense. atk is the same; it's the attacking stat (which is either Attack or Special Attack as appropriate).

But if that's the case, won't Sandstorm buff the Pokemon's defense or special defense depending on whether it has been hit by a physical or special attack? Shouldn't it be changed so that the buff activates only when the Pokemon's hit by a special attack?

 

[Maruno]

But if that's the case, won't Sandstorm buff the Pokemon's defense or special defense depending on whether it has been hit by a physical or special attack? Shouldn't it be changed so that the buff activates only when the Pokemon's hit by a special attack?

That's the point of the variable applysandstorm. It's only true if it's a special move, and thus defense happens to contain the target's Special Defense stat.

 

[Seenit45]

Okay, I understand now. Thanks!