[Scripting Question] How to make an Item that boost a moves Base Power

[DonaldRTS]

Hello, I am wondering how do I implement an item that boosts the base power of a move. At first, I thought it would be quite simple, in that all I had to do was edit the PPup code a bit, but then I realized that it doesn't effect the move at all. I spent a whole week trying to figure out how to make it work, but ultimately i decided to swallow my pride and ask here. So please, can someone help me?

 

[mgriffin]

Permanently increase the base power? Hmm. I think you're right that you could do that with something similar to the PPup code. Can you post what you've got so far?

 

[DonaldRTS]

So far this is what my PBmove script looks like now:

Spoiler:

class PokemonTemp
  attr_accessor :pokemonMoveData

  def pbOpenMoveData
    if !self.pokemonMoveData
      pbRgssOpen("Data/moves.dat","rb"){|f|
        self.pokemonMoveData=f.read
      }
    end
    if block_given?
      StringInput.open(self.pokemonMoveData) {|f| yield f }
    else
      return StringInput.open(self.pokemonMoveData)
    end
  end
end



class PBMoveData
  attr_reader :function,:basedamage,:type,:accuracy
  attr_reader :totalpp,:addlEffect,:target,:priority
  attr_reader :flags
  attr_reader :category

  def initializeOld(moveid)
    movedata = pbRgssOpen("Data/rsattacks.dat")
    movedata.pos = moveid*9
    @function   = movedata.fgetb
    @basedamage = movedata.fgetb
    @type       = movedata.fgetb
    @accuracy   = movedata.fgetb
    @totalpp    = movedata.fgetb
    @addlEffect = movedata.fgetb
    @target     = movedata.fgetb
    @priority   = movedata.fgetsb
    @flags      = movedata.fgetb
    movedata.close
  end

  def initialize(moveid)
    movedata = nil
    if $PokemonTemp
      movedata = $PokemonTemp.pbOpenMoveData
    else
      movedata = pbRgssOpen("Data/moves.dat")
    end
    movedata.pos = moveid*14
    @function   = movedata.fgetw
    @basedamage = movedata.fgetb
    @type       = movedata.fgetb
    @category   = movedata.fgetb
    @accuracy   = movedata.fgetb
    @totalpp    = movedata.fgetb
    @addlEffect = movedata.fgetb
    @target     = movedata.fgetw
    @priority   = movedata.fgetsb
    @flags      = movedata.fgetw
    movedata.close
  end
end



class PBMove
  attr_reader(:id)       # This move's ID
  attr_accessor(:pp)     # The amount of PP remaining for this move
  attr_accessor(:ppup)   # The number of PP Ups used for this move
  attr_accessor(:dmup)   # The number of Damage Ups used for this move

# Gets this move's type.
  def type
    movedata = PBMoveData.new(@id)
    return movedata.type
  end

# Gets the maximum PP for this move.
  def totalpp
    movedata = PBMoveData.new(@id)
    tpp = movedata.totalpp
    return tpp+(tpp*@ppup/5).floor
  end
  
# Gets the maximum Power for this move.
  def basedamage
    movedata = PBMoveData.new(@id)
    tdm = movedata.basedamage
    return tdm+(tdm*@dmup/10).floor
  end

# Initializes this object to the specified move ID.
  def initialize(moveid)
    movedata = PBMoveData.new(moveid)
    @id   = moveid
    @pp   = movedata.totalpp
    @ppup = 0
    @dmup = 0
  end
end

And in PItem_ItemEffects I added:

Spoiler:

ItemHandlers::UseOnPokemon.add(:POWERUP,proc{|item,pokemon,scene|
   move=scene.pbChooseMove(pokemon,_INTL("Boost Power of which move?"))
   if move>=0
     if pokemon.moves[move].basedamage==0 || pokemon.moves[move].dmup>=5
       scene.pbDisplay(_INTL("It won't have any effect."))
       next false
     else
       pokemon.moves[move].dmup+=1
       movename=PBMoves.getName(pokemon.moves[move].id)
       scene.pbDisplay(_INTL("{1}'s Power increased.",movename))
       scene.pbRefresh
       next true
     end
   end
})

ItemHandlers::UseOnPokemon.add(:POWERMAX,proc{|item,pokemon,scene|
   move=scene.pbChooseMove(pokemon,_INTL("Boost Power of which move?"))
   if move>=0
     if pokemon.moves[move].basedamage==0 || pokemon.moves[move].dmup>=5
       scene.pbDisplay(_INTL("It won't have any effect."))
       next false
     else
       pokemon.moves[move].dmup=5
       movename=PBMoves.getName(pokemon.moves[move].id)
       scene.pbDisplay(_INTL("{1}'s Power increased.",movename))
       scene.pbRefresh
       next true
     end
   end
})

 

[mgriffin]

Right, you've introduced a new def basedamage but none of the existing code is using it so that effectively does nothing. You'll need to find the places in the code where the base damage is computed and alter those instead. That's probably somewhere in PokeBattle_Move.

 

[DonaldRTS]

Oh ok, Thanks I'll see if I can make it work.