In my Pokemon Leaf Green, I can't beat the Elite Four. My current Party is (I'm trying to get them all the level 50 right now)
Charizard: Level 50
Moves:
Blast Burn Aerial Ace
Cut Earthquake
Flamethrower Swords Dance
Fire Blast
Rule number 1: all recharge moves suck, especially the elemental H-Beams. Also, Charizard's strongest suit is physical attacks, so go with that. Aerial Ace for STAB and Earthquake for the power with Swords Dance to boost them further and Fire Blast to exploit 'Blaze' and STAB and help against physical walls.
Vaporeon: Level 50
Moves:
Acid Armor
Surf
Attract Baton Pass/Rest
Aurora Beam Ice Beam
Acid armor is not much fun if you don't pass it on, although this one might benefit more from Rest because it lacks HP recovery due to the lack of Wish. Also, Ice Beam > Aurora Beam since it's so much stronger.
Snorlax: Level 42
Moves:
Body Slam/Double-Edge
Psychic Earthquake/Shadow Ball
Rest
Strength Sleep Talk
No...just no. Never, EVER put a psychic attack on a non-psychic pokémon (Except possibly ingame Shiftry), it's a waste of space, especially on Snorlax, and never use a HM move that isn't called Surf (The others suck). Earthquake or Shadow Ball to complement the normal move (You could try Double-Edge for more power) and Sleep Talk to keep it fighting even during Rest. Curse is also an option for that slot, but since it requires breeding I won't bother.
Pidgeot: Level 43
Moves:
Wing Attack Steel Wing
Aerial Ace
Fly Quick Attack
Double Edge
If it doesn't have a Choice Band give it one now. Also, there's no point in stocking up multiple moves of the same type. Quick Attack for finishing blows against faster opponents and Steel Wing to help against troublesome Rock types. I really wouldn't recommend keeping this one, though, as there are far better flying types (Like Fearow and Dodrio) out there.
Kadabra: Level 43
Moves:
RecoverFire Punch/Ice Punch
Psychic
Flash Fire Punch/Ice Punch
Psybeam Calm Mind
Now what did I say about doubling up on moves and using HM moves that aren't called Surf? Recover is kind of lol on Kadabra since it has such a terribly weak defense, but it can work for half-arsed spec. walling with Calm Mind. Anyways, you'll need at least one of the elemental punches in order to make Kadabra any good, so if you don't have trading capability you'll have to breed them in from a Hitmonchan (Which learns them all by level up) and start over.
Raichu: Level 45
Thunderbolt
Slam Thunder Wave
Rock Smash Iron Tail/Focus Punch
Thunder Substitute
Meh, Raichu...:\ It really doesn't take hits that well, so T-Wave and Substitute for protection, with a hard-hitting physical move (Focus Punch and Iron Tail are the best you get, I'm afraid) to give it at least a vague fighting chance against ground types. Most things will still trash it, though, so I'd suggest going for a cooler pokémon like Starmie. In case you're wondering about the moveset, that one would be:
Surf
Thunderbolt
Ice Beam/Reflect
Recover
Nice and efficient, with plenty of speed and Sp.Attack which should allow it to sweep through Bruno and Lance quite efficiently.
Mostly now due to laziness I have been using my Articuno, Zapdos and Moltres in place of Kadabra, Pidgeot and Raichu but they aint much good either, all three being levels 51 and 50 but it just about useless.
Any tips and stuff? I really wanna thrash these guys so I can do the remaining Sevii Islands and stuff. :D