[Script] I'm having odd script issues.

[Zelly_9191]

This has been driving me crazy but I'm making a script on the ground and setting the variable at 8002.
I'm then using the following script in the script square.
Pksv UI script:

Spoiler:

#dyn 0x740000
#org @start
'-----------------------------------
lockall
setvar 0x8002 0x0
checkflag 0x21A
if true jump @finished ' Flag is set
checkflag 0x21C
if true jump @afterwarp ' Flag is set
checkflag 0x219
if true jump @staycave ' Flag is set
message @voice ' You hear a raspy voi...
callstd MSG_NORMAL
compare PLAYERFACING DOWN
if == call @sup
compare PLAYERFACING UP
if == call @sdown
releaseall
end

#org @finished
'-----------------------------------
releaseall
end

#org @afterwarp
'-----------------------------------
message @serious ' Seriously?
callstd MSG_NORMAL
compare PLAYERFACING DOWN
if == call @sup
compare PLAYERFACING UP
if == call @sdown
releaseall
end

#org @sdown
'-----------------------------------
applymovement PLAYER @down
pauseevent 0x0
return

#org @sup
'-----------------------------------
applymovement PLAYER @up
pauseevent 0x0
return

#org @staycave
'-----------------------------------
compare PLAYERFACING UP
if == jump @finished ' Equal To
message @waterhere ' Maybe someone here\n...
callstd MSG_NORMAL
call @sup
releaseall
end


#org @voice
= You hear a raspy voice\nto your right.\pHelp me.....\nplease.....

#org @serious
= Seriously?

#org @waterhere
= Maybe someone here\nhas some fresh water.

#org @down
m walk_down look_up end

#org @up
m walk_up look_down end

Sorry for my spaghetti code.

However, it seems the first time the script is walked on the player isn't moved. After the first flag (219), the player is always moved down regardless of the direction the script was walked on, and the second flag (21C ), once again won't move the player after going through the text it just releases all and ends. The final flag (21A) is working as intended it locks then releases and ends. can anyone tell me why this is happening? I just don't understand, it makes no sense.
If anyone can help me it would be very much appreciated. Thanks!

 

[Zelly_9191]

I'm going to try bumping this thread as I still need help sorry if it's against the rules. I couldn't find anything on it being disallowed.

 

[Bela]

.

Oh man. That is very spaghetti scripting there.

I think your issue may have something to do with relying on PLAYERFACING to trigger your player's movement, which btw I think is a weird thing to do in a script anyway. Usually, you just allow the player to move the player on their own, not force them to move in a direction. That's just a minor game design critique for you, though. PLAYERFACING (var 0x800C in FireRed) only updates when you press the A button, so you can't reliably use it in event tiles like this.

I think you should rewrite this event, and use a single var instead of flags for the conditions. Tile scripts are more suited to var use anyway! I think it would look something like this:

(This is in XSE format, and assumes your script uses var 4001, a temp var used in events like the Safari Zone entrance scripts)

#org @event
lockall
compare 0x4050 0x3
if 0x4 goto @finished
compare 0x4050 0x2
if 0x1 goto @afterwarp
compare 0x4050 0x1
if 0x1 goto @staycave
msgbox @voice 0x4 'This is a preference of mine, used with closeonkeypress
closeonkeypress
setvar 0x4001 0x1
releaseall
end

#org @afterwarp
msgbox @serious 0x4
closeonkeypress
setvar 0x4001 0x1
releaseall
end

#org @afterwarp
msgbox @water 0x4
closeonkeypress
setvar 0x4050 0x2
setvar 0x4001 0x1
releaseall
end

 

[Zelly_9191]

Ahh, thanks for the response I've been busy and didn't have a chance to reply. (Sorry about the bump. Mods, feel free to lock if this was against the rules.)