[Scripting Question] Liquid Voice in Pokemon Essentials

[xac95]

Anyone can tell me why it doesn't works?

def pbModifyType(type,attacker,opponent)
    if type>=0
      if attacker.hasWorkingAbility(:NORMALIZE) && hasConst?(PBTypes,:NORMAL)
        type=getConst(PBTypes,:NORMAL)
  [COLOR="Red"]    if attacker.hasWorkingAbility(:LIQUIDVOICE) && thismove.hasFlags?(k)
        type=getConst(PBTypes,:WATER) || 0
      end[/COLOR]
      elsif isConst?(type,PBTypes,:NORMAL)
        if attacker.hasWorkingAbility(:AERILATE) && hasConst?(PBTypes,:FLYING)
          type=getConst(PBTypes,:FLYING)
          @powerboost=true
        elsif attacker.hasWorkingAbility(:REFRIGERATE) && hasConst?(PBTypes,:ICE)
          type=getConst(PBTypes,:ICE)
          @powerboost=true
        elsif attacker.hasWorkingAbility(:PIXILATE) && hasConst?(PBTypes,:FAIRY)
          type=getConst(PBTypes,:FAIRY)
          @powerboost=true
        end
      end
    end
    return type
  end

 

[khkramer]

You didn't end the previous 'if' statement before your added code.
Your code is now only reached when the attacker hase the ability Normalize, in other words it will never reach your code..

 

[xac95]

I've solved it, thank youu! ^^

 

[Rot8er_ConeX]

  def pbModifyType(type,attacker,opponent)
    if type>=0
      if attacker.hasWorkingAbility(:NORMALIZE) && hasConst?(PBTypes,:NORMAL)
        type=getConst(PBTypes,:NORMAL)
      [COLOR="Red"]elsif attacker.hasWorkingAbility(:LIQUIDVOICE) && thismove.isSoundBased?
        type=getConst(PBTypes,:WATER)[/COLOR]
      elsif isConst?(type,PBTypes,:NORMAL)
        if attacker.hasWorkingAbility(:AERILATE) && hasConst?(PBTypes,:FLYING)
          type=getConst(PBTypes,:FLYING)
          @powerboost=true
        elsif attacker.hasWorkingAbility(:REFRIGERATE) && hasConst?(PBTypes,:ICE)
          type=getConst(PBTypes,:ICE)
          @powerboost=true
        elsif attacker.hasWorkingAbility(:PIXILATE) && hasConst?(PBTypes,:FAIRY)
          type=getConst(PBTypes,:FAIRY)
          @powerboost=true
        end
      end
    end
    return type
  end

A more human-readable version.