[Essentials Tutorial] New Field Effects

[Turn20Negate]

There is a V18 script adaptation ?

Don't worry I'm working on a V18 Field Effect system right now. It just isn't quite finished yet.

 

[TheBIGFriv]

Depending on how you want to do it, most of the tutorial here will work for v18 too.
I'm currently also porting part of it, and trying to make it as plug and play as possible.
But its hard to add most of the battle changes in in a plug and play fashion

 

[Luxinaj]

Mm something like reborn, where the tile field define the effect. I see the tutorials, but the v18 change a lot of the script section and are parts that i cant find.

 

[hirokimura]

Ctrl + f + shift and you look for ELECTRICTERRAIN

 

[Luxinaj]

It's more like the syntaxis, it's changed in v18.

For example, i try to adapt why said in step 1:

def pbAnimation(move,user,targets,hitNum=0)
@scene.pbAnimation(move,user,targets,hitNum) if @showAnims
def pbChangeBGSprite
case $fieldeffectsbg
when 0 # Interior Field
@scene.sprites["battlebg"].setBitmap("Graphics/Battlebacks/battlebgIndoorA.png")
@scene.sprites["playerbase"].setBitmap("Graphics/Battlebacks/playerbaseIndoorA.png")
@scene.sprites["enemybase"].setBitmap("Graphics/Battlebacks/enemybaseIndoorA.png")
when 1 # Scorched Ground
@scene.sprites["battlebg"].setBitmap("Graphics/Battlebacks/corrosive_bg.png")
@scene.sprites["enemybase"].setBitmap("Graphics/Battlebacks/corrosive_base1.png.png")
@scene.sprites["playerbase"].setBitmap("Graphics/Battlebacks/corrosive_base0.png")
#To add more just make more when's like [when 2]
end
end



In step 2 it's said to add this code for extra effect:

if !attacker.isAirborne? && isConst?(type,PBTypes,:GRASS)
damagemult=(damagemult*0.5).round
@battle.pbDisplay(_INTL("The ground burned the attack!",opponent.pbThis))
end

but !attacker.isAirborne? it's not found in any of the script list.
So, i delete it and left it the isConst?(type,PBTypes,:GRASS):

case $fieldeffectsbg
when 1 # Scorched
if isConst?(type,PBTypes,:FIRE)
damagemult=(damagemult*1.5).round
@battle.pbDisplay(_INTL("The ground boosted the fire power of the attack!",opponent.pbThis))
end
if isConst?(type,PBTypes,:GRASS)
damagemult=(damagemult*0.5).round
@battle.pbDisplay(_INTL("The ground burned the attack!",opponent.pbThis))
end
end

But return Syntaxis error in:

maps=[5]#the maps that use the field

if $game_map && maps.include?($game_map.map_id)
if @environment==PBEnvironment::Grass || @environment==PBEnvironment::TallGrass || @environment==PBEnvironment::None
$fieldeffectsbg=1 #Scorched
pbDisplayPaused(_INTL("The ground is super-heated!")
end
end

My point is there are codes that i can't find because the syntaxis change in this version. i found the effect of electric terrain, but when i try to add it to an automatic field start the errors.

 

[Turn20Negate]

Try using this code.(closing brackets is important)

pbDisplayPaused(_INTL("The ground is super-heated!")[COLOR="Red"])[/COLOR]

And look for this function instead.

def airborne?

Some of these functions names have been changed while their functionality stayed the same.

 

[Luxinaj]

Try using this code.(closing brackets is important)

pbDisplayPaused(_INTL("The ground is super-heated!")[COLOR="Red"])[/COLOR]

And look for this function instead.

def airborne?

Some of these functions names have been changed while their functionality stayed the same.

I found airborne, the problem now it's whit attacker

I try to change it with:

if @target.airborne? && isConst?(type,PBTypes,:GRASS)
if pkmn.airborne? && isConst?(type,PBTypes,:GRASS)
if user.airborne? && isConst?(type,PBTypes,:GRASS)

But didn't work.

This is how i have my script section:

https://ibb.co/Y0QV8Kn
https://ibb.co/wcvwwLP
https://ibb.co/4j5KMgm

 

[Turn20Negate]

I'd heaviliy advise you to read an introduction to the ruby language else you'll stumble into these small mistakes all the time. There is one pinned at the top of the scripts section.https://www.pokecommunity.com/showthread.php?t=410026
Regarding your problem there are a few points:
1.You creating a lonely case outside a class or even a method, in your second picture wouldn't do anything, even if it didn't raise a syntax error. The move will only do what's inside its class(PokeBattle_Move_155) and parent class(PokeBattle_Move). Secondly, you have different predefined methods you're able to use inside PokeBattle_Move classes f.ex.:

Spoiler:

This method is called at the beginning of the move before it plays its animation.Often used to modify the move's effects.

def pbOnStartUse(user,targets)

This one is called to apply effects to the move f.ex. summoning terrain.

def pbEffectGeneral(user)

The following function is similar to the previous one but is used to apply effects on the move's target.

def pbEffectAgainstTarget(user,target)

Notice how each of these methods has one or multiple arguments(the words in brackets). These are the local variables you get to use in here. Which means if you are inside the "def pbEffectGeneral(user)" function and try to ask "target.airborne?" it will raise an error, because the system doesn't know what "target" is. You can also use class variables (the ones with @ in front of them) f.ex. "@battle" to refer to the battle class. These don't have to be in the list of arguments for the move. Additionally you can (as you already did) use global variables (the ones with $ in front of it) because they can be applied anywhere in the code. But I'd advise you to keep the number of these to a minimum, due to them slowing down your code.
Lastly think about what having the code on your second image in that place means. If you used this move it would check if grassy terrain was a fire or grass move then boost its power (which does nothing because it's a status move) and then read the message. I think you'd rather want this to apply in the damage calculation regarding moves used after applying grassy terrain. In the script section "Move_Usage_Calculations" you can ctrl+f to find "case @battle.field.terrain". Try applying your damage modifiers here.
I need a little more time to make my field system available so this'll have to do for now.:)

Be sure to ask if you notice any more inconveniences.

 

[Luxinaj]

I'd heaviliy advise you to read an introduction to the ruby language else you'll stumble into these small mistakes all the time. There is one pinned at the top of the scripts section.https://www.pokecommunity.com/showthread.php?t=410026
Regarding your problem there are a few points:
1.You creating a lonely case outside a class or even a method, in your second picture wouldn't do anything, even if it didn't raise a syntax error. The move will only do what's inside its class(PokeBattle_Move_155) and parent class(PokeBattle_Move). Secondly, you have different predefined methods you're able to use inside PokeBattle_Move classes f.ex.:

Spoiler:

This method is called at the beginning of the move before it plays its animation.Often used to modify the move's effects.

def pbOnStartUse(user,targets)

This one is called to apply effects to the move f.ex. summoning terrain.

def pbEffectGeneral(user)

The following function is similar to the previous one but is used to apply effects on the move's target.

def pbEffectAgainstTarget(user,target)

Notice how each of these methods has one or multiple arguments(the words in brackets). These are the local variables you get to use in here. Which means if you are inside the "def pbEffectGeneral(user)" function and try to ask "target.airborne?" it will raise an error, because the system doesn't know what "target" is. You can also use class variables (the ones with @ in front of them) f.ex. "@battle" to refer to the battle class. These don't have to be in the list of arguments for the move. Additionally you can (as you already did) use global variables (the ones with $ in front of it) because they can be applied anywhere in the code. But I'd advise you to keep the number of these to a minimum, due to them slowing down your code.
Lastly think about what having the code on your second image in that place means. If you used this move it would check if grassy terrain was a fire or grass move then boost its power (which does nothing because it's a status move) and then read the message. I think you'd rather want this to apply in the damage calculation regarding moves used after applying grassy terrain. In the script section "Move_Usage_Calculations" you can ctrl+f to find "case @battle.field.terrain". Try applying your damage modifiers here.
I need a little more time to make my field system available so this'll have to do for now.:)

Be sure to ask if you notice any more inconveniences.

It's getting better, or at least didn't crash.
What i did is create a new terrain to prove (AKA corrosion field) in Move_Usage_Calculations, add a poison bonus and the grass damage reduce:

Spoiler:

if user.affectedByTerrain?
case @battle.field.terrain
when PBBattleTerrains::Electric
if isConst?(type,PBTypes,:ELECTRIC)
multipliers[BASE_DMG_MULT] *= 1.5
end
when PBBattleTerrains::Grassy
if isConst?(type,PBTypes,:GRASS)
multipliers[BASE_DMG_MULT] *= 1.5
end
when PBBattleTerrains::Psychic
if isConst?(type,PBTypes,:PSYCHIC)
multipliers[BASE_DMG_MULT] *= 1.5
end
when PBBattleTerrains::Poison
if isConst?(type,PBTypes,:POISON)
multipliers[BASE_DMG_MULT] *= 1.5
@battle.pbDisplay(_INTL("Corrosion power the attack!",opponent.pbThis))
end
if isConst?(type,PBTypes,:GRASS)
damagemult=(damagemult*0.5).round
@battle.pbDisplay(_INTL("Corrosion weakness the attack",opponent.pbThis))
end
end
end

I tried to change the background with @scene.sprites["battlebg"].setBitmap in def pbCommonAnimation(name,attacker,opponent,hitnum=0) but the code it's not the same and i can't addap it, so i remove it.

Also i add the code to locate the map in Battle_StartAndEnd i add the Step 1 code under the "end" on the weather code (as said in the Step 1):

Spoiler:

maps=[5]#the maps that use the field

if $game_map && maps.include?($game_map.map_id)
if @environment==PBEnvironment::Grass || @environment==PBEnvironment::TallGrass || @environment==PBEnvironment::None
pbDisplay(_INTL("The field is filled with corrosion"))
end
end

At the start of the battle, the message show "the field is filled..." but when an attack of poison or grass happen, it did't show the message of the bonus.

Also, thanxs for the ruby tutorial, i read it, it's just difficult to aplly whitout crash anything.

 

[Turn20Negate]

In "Move_Usage_Calculations" you ask the code if "@battle.field.terrain" is "PBBattleTerrains::Poison" but I think you forgot to set that terrain at the beginning of the battle. Instead you just showed a message.
Maybe add this above your message:

@field.terrain=PBBattleTerrains::Poison

And also check if the terrain is even defined in PBTerrain.

 

[Luxinaj]

Still don't work. I add it to PBBattleTerrains

Spoiler:

begin
module PBBattleTerrains
None = 0
Electric = 1
Grassy = 2
Misty = 3
Psychic = 4
Poison = 5

def self.animationName(terrain)
case terrain
when Electric; return "ElectricTerrain"
when Grassy; return "GrassyTerrain"
when Misty; return "MistyTerrain"
when Psychic; return "PsychicTerrain"
when Poison; return "CorrosiveField"
end
return nil
end
end

rescue Exception
if $!.is_a?(SystemExit) || "#{$!.class}"=="Reset"
raise $!
end
end

 

[HeroesFightingFear]

remove the opponent.pbthis, that will no longer work when assigning messages to terrain/field boosts and what not.
in addition to that, the files and battle backgrounds have changed.
example:
indoor1_base0, indoor1_base1, indoor1_bg, indoor1_message

to be able to change the battlefield with terrains, you would need to make graphics with all four of these file name bases

terrain example:
aura_terrain_base0, aura_terrain_base1, aura_terrain_bg, aura_terrain_message