[pokeemerald] Need help "AI controls my pokemon" script

[Novembre]

Hi everyone, I recently became interested in decomp romhacking.
I would like to do this:
when you select "fight" during a battle, ai chooses the move to make.

I think I found the point where I can insert the code:
in battle_main_c
case B_ACTION_USE_MOVE:
...

and maybe can i copy the code from:
battle_controller_opponent
static void OpponentHandleChooseMove(void)
{
....


any suggestions?

Thx.

 

[Anon822]

Hi everyone, I recently became interested in decomp romhacking.
I would like to do this:
when you select "fight" during a battle, ai chooses the move to make.

I think I found the point where I can insert the code:
in battle_main_c
case B_ACTION_USE_MOVE:
...

and maybe can i copy the code from:
battle_controller_opponent
static void OpponentHandleChooseMove(void)
{
....


any suggestions?

Thx.

The game already has the logic for doing that in battle palace. See PlayerHandleChooseMove in src/battle_controller_player.c.

 

[Novembre]

found, tested and....work! dude you changed my day.
THX!

edit:
sorry, have this problem:
sometimes (random) my pokemon hits itself.
Is there any value to set to prevent this from happening?

 

[Novembre]

The game already has the logic for doing that in battle palace. See PlayerHandleChooseMove in src/battle_controller_player.c.

sorry, have this problem:
sometimes (random) my pokemon hits itself.
Is there any value to set to prevent this from happening?

 

[Novembre]

update:
I have to test more to be sure but...
I think I found the problem:
in the Battle Place when the pokemon does not find a move compatible with nature, use a random move. this used move is put in the list of moves "won't be used anymore".
if that move is used again in the following turn, the "penalty" reaction is triggered and the pokemon hits itself.
this happens especially in low level pokemon with only 2 moves to use.
so to avoid this I eliminated the logic "won't be used anymore".
Now I seem to have solved the problem.

 

[Nightofday]

update:
I have to test more to be sure but...
I think I found the problem:
in the Battle Place when the pokemon does not find a move compatible with nature, use a random move. this used move is put in the list of moves "won't be used anymore".
if that move is used again in the following turn, the "penalty" reaction is triggered and the pokemon hits itself.
this happens especially in low level pokemon with only 2 moves to use.
so to avoid this I eliminated the logic "won't be used anymore".
Now I seem to have solved the problem.

Is there a way to do this for pokémon fire red

 

[Novembre]

Is there a way to do this for pokémon fire red

Quick answer:
No.

long answer:
In FireRed there are no basic rules that I used to implement this mechanic in combat system.
So you have to create from scratch, then you can intervene on the combat system.

Recreating all the rules is long and I think a bit complicated.
Sure, you could always create a quick rule that takes a random move from those available... but well, that's a whole different thing from what I realized in Emerald with the existing rules.