[Script] [Pokeruby/Pokeemerald] Script to let Pokémon use HM without knowing them

[McPaul]

Hey yo!

After months of crazy depression I'm kinda back in the ROM hack game.

I'm still randomly trying some things to see if I can manage to get through. I want to get rid of HM slaves by letting mons use HM if they can learn them but without them having the move. How could I script that?

I'm currently in pokeruby in the file pokeruby\data\field_move_scripts.inc and take for example the cut script:

Spoiler:

S_CuttableTree:: @ 81B0DCC
lockall
goto_if_unset FLAG_BADGE01_GET, CannotUseCut
checkpartymove MOVE_CUT
compare VAR_RESULT, 6
goto_if_eq CannotUseCut
setfieldeffectargument 0, VAR_RESULT
bufferpartymonnick 0, VAR_RESULT
buffermovename 1, MOVE_CUT
msgbox UseCutPromptText, MSGBOX_YESNO
compare VAR_RESULT, NO
goto_if_eq Cut_ChoseNo
msgbox UsedCutRockSmashText, MSGBOX_DEFAULT
closemessage
dofieldeffect FLDEFF_USE_CUT_ON_TREE
waitstate
goto DoTreeCutMovement
end

DoCutFieldEffectScript:: @ 81B0E16
lockall
dofieldeffect FLDEFF_USE_CUT_ON_TREE
waitstate
goto DoTreeCutMovement
end

DoTreeCutMovement: @ 81B0E21
applymovement VAR_LAST_TALKED, TreeCutMovement @ tree cut animation
waitmovement 0
removeobject VAR_LAST_TALKED @ tree disappears
releaseall
end

TreeCutMovement: @ 81B0E30
cut_tree
step_end

CannotUseCut: @ 81B0E32
msgbox CannotUseCutText, MSGBOX_SIGN
releaseall
end

Cut_ChoseNo: @ 81B0E3C
closemessage
releaseall
end

UseCutPromptText: @ 81B0E3F
.string "This tree looks like it can be CUT down.\p"
.string "Would you like to CUT it?$"

UsedCutRockSmashText: @ 81B0E82
.string "{STR_VAR_1} used {STR_VAR_2}.$"

CannotUseCutText: @ 81B0E8E
.string "This tree looks like it can be CUT down.$"

The interesting part there would be checkpartymove MOVE_CUT, it could be replaced by something like (I'm inventing there but let's be creative) checkifpartymoncanlearnmove MOVE_CUT but well I don't know how to do such a thing.

The second part would me making HM moves appear in the Pokémon party menu even if they don't have the move and once the required badge is obtained (for HM moves like FLY for example)

Could maybe someone help me?

Thanks a lot!

 

[mgriffin]

There's a function called CanMonLearnTMHM that you could use for TM/HM moves. If you don't care about preserving the old way, you could change checkpartymove by altering the ScrCmd_checkpartymove function in src/scrcmd.c to call that. I don't know if any of the field moves aren't TMs/HMs, if they are, you'd need to use a more sophisticated approach. If you want to add a command instead, that's the same src/scrcmd.c plus data/script_cmd_table.inc and asm/macros/event.inc. As for the party menu, that's in src/party_menu.c, try searching for sFieldMoves or SetPartyMonFieldSelectionActions. But that's as helpful as I can be.

 

[McPaul]

Hello, thanks a lot! Exploring this might be a key to the solution!

 

[McPaul]

I've made this code:

Spoiler:

bool8 ScrCmd_checkpartymove(struct ScriptContext *ctx)
{
u8 i;
u16 moveId = ScriptReadHalfword(ctx);

gSpecialVar_Result = 6;
for (i = 0; i < PARTY_SIZE; i++)
{
u16 species = GetMonData(&gPlayerParty, MON_DATA_SPECIES, NULL);
if (!species)
break;
// UB: GetMonData() arguments don't match function definition
if (!GetMonData(&gPlayerParty, MON_DATA_IS_EGG) && !CanMonLearnTMHM(&gPlayerParty, moveId) == TRUE)
{
gSpecialVar_Result = i;
gSpecialVar_0x8004 = species;
break;
}
}
return FALSE;
}

But now the problem is that EVERYONE can cut even Wurmple! Looks like it doesn't check the "canmonlearnTMHM" part.

Tried with

Spoiler:

bool8 ScrCmd_checkpartymove(struct ScriptContext *ctx)
{
u8 i;
u16 itemId = VarGet(ScriptReadHalfword(ctx));

gSpecialVar_Result = 6;
for (i = 0; i < PARTY_SIZE; i++)
{
u16 species = GetMonData(&gPlayerParty, MON_DATA_SPECIES, NULL);
if (!species)
break;
// UB: GetMonData() arguments don't match function definition
if (!GetMonData(&gPlayerParty, MON_DATA_IS_EGG) &&CanMonLearnTMHM(&gPlayerParty, itemId) == TRUE)
{
gSpecialVar_Result = i;
gSpecialVar_0x8004 = species;
break;
}
}
return FALSE;
}

and changing checkpartymove MOVE_CUT to checkpartymove ITEM_HM_01_CUT but that still doesn't work.

 

[Buffel Saft]

CanMonLearnTMHM expects a TM/HM number as input, not an item ID or move ID. If you look at its other uses or the function definition you'll see the input should be something like CanMonLearnTMHM(mon, itemId - ITEM_TM01_FOCUS_PUNCH).

itemId - ITEM_TM01_FOCUS_PUNCH will calculate the TM number from the TM's item ID.

 

[McPaul]

I've wrotten it like this:

Spoiler:

bool8 ScrCmd_checkpartymove(struct ScriptContext *ctx)
{
u8 i;
u16 itemId - ITEM_TM01_FOCUS_PUNCH = ScriptReadHalfword(ctx);

gSpecialVar_Result = 6;
for (i = 0; i < PARTY_SIZE; i++)
{
u16 species = GetMonData(&gPlayerParty, MON_DATA_SPECIES, NULL);
if (!species)
break;
// UB: GetMonData() arguments don't match function definition
if (!GetMonData(&gPlayerParty, MON_DATA_IS_EGG) && CanMonLearnTMHM(&gPlayerParty, itemId - ITEM_TM01_FOCUS_PUNCH)
{
gSpecialVar_Result = i;
gSpecialVar_0x8004 = species;
break;
}
}
return FALSE;
}

But can't manage to compile.

 

[WiserVisor]

What error shows up when you try to compile?

 

[McPaul]

 

[WiserVisor]

This line is not syntactically correct:

u16 itemId - ITEM_TM01_FOCUS_PUNCH = ScriptReadHalfword(ctx);

You can't have operations on the left side of a variable declaration. You can only have the data type (u16) and the variable name (I assume "itemId") on the left side.

The other errors may all be affected by this one, so fixing that will help clear some stuff up and see which of the other errors are real errors and which aren't.

 

[McPaul]

Ok thanks let's try my new code:

Spoiler:

bool8 ScrCmd_checkpartymove(struct ScriptContext *ctx)
{
u8 i;
u16 itemId

gSpecialVar_Result = 6;
for (i = 0; i < PARTY_SIZE; i++)
{
u16 species = GetMonData(&gPlayerParty, MON_DATA_SPECIES, NULL);
if (!species)
break;
// UB: GetMonData() arguments don't match function definition
if (!GetMonData(&gPlayerParty, MON_DATA_IS_EGG) && !CanMonLearnTMHM(&gPlayerParty, itemId - ITEM_TM01_FOCUS_PUNCH)
{
gSpecialVar_Result = i;
gSpecialVar_0x8004 = species;
break;
}
}
return FALSE;
}

Error:

Spoiler:

root@McPC:/mnt/c/Users/McPaul/decomps/pokeruby# make
arm-none-eabi-cpp -iquote include -Werror -Wno-trigraphs -D RUBY -D REVISION=0 -D ENGLISH -D=DEBUG_FIX0 -D DEBUG=0 -D MODERN=0 -I tools/agbcc/include -nostdinc -undef src/scrcmd.c -o build/ruby/src/scrcmd.i
tools/preproc/preproc build/ruby/src/scrcmd.i charmap.txt | tools/agbcc/bin/agbcc -mthumb-interwork -Wimplicit -Wparentheses -Wunused -Werror -O2 -fhex-asm -o build/ruby/src/scrcmd.s
src/scrcmd.c: In function `ScrCmd_checkpartymove':
src/scrcmd.c:1584: syntax error before `gSpecialVar_Result'
src/scrcmd.c:1591: `itemId' undeclared (first use in this function)
src/scrcmd.c:1591: (Each undeclared identifier is reported only once
src/scrcmd.c:1591: for each function it appears in.)
src/scrcmd.c:1591: `ITEM_TM01_FOCUS_PUNCH' undeclared (first use in this function)
src/scrcmd.c:1592: syntax error before `{'
src/scrcmd.c: At top level:
src/scrcmd.c:1598: syntax error before `return'
Makefile:206: recipe for target 'build/ruby/src/scrcmd.o' failed
make: *** [build/ruby/src/scrcmd.o] Error 1
root@McPC:/mnt/c/Users/McPaul/decomps/pokeruby#

 

[WiserVisor]

You'll need to put a semi-colon after

u16 itemId

or give the variable a value at that line, still ending the line with a semi-colon. You never give this variable a value before using it as an operand in

if (!GetMonData(&gPlayerParty[i], MON_DATA_IS_EGG) && !CanMonLearnTMHM(&gPlayerParty[i], itemId - ITEM_TM01_FOCUS_PUNCH)

Using a variable that has been declared but has no data as an operand will always produce an error.

 

[McPaul]

You'll need to put a semi-colon after

u16 itemId

or give the variable a value at that line, still ending the line with a semi-colon. You never give this variable a value before using it as an operand in

if (!GetMonData(&gPlayerParty[i], MON_DATA_IS_EGG) && !CanMonLearnTMHM(&gPlayerParty[i], itemId - ITEM_TM01_FOCUS_PUNCH)

Using a variable that has been declared but has no data as an operand will always produce an error.

Thanks! I didn't understand the second part about the the no data as an operand as English is not my mother tongue, I should add something more? As I want the game to check If the Pokémon can learn the HM instead of checking if it has actually learned it I need the function to check for (for example) ITEM_HM01_CUT in "checkattack" function and bypass all mons that cannot learn Cut.

 

[WiserVisor]

Thanks! I didn't understand the second part about the the no data as an operand as English is not my mother tongue, I should add something more? As I want the game to check If the Pokémon can learn the HM instead of checking if it has actually learned it I need the function to check for (for example) ITEM_HM01_CUT in "checkattack" function and bypass all mons that cannot learn Cut.

To explain that "no data as an operand" thing, you have a variable called "itemId", but you didn't give it a value, like

u16 itemId = 5;

This would give itemId the value of 5. Since you didn't do that, itemId has no value. Then, when you try to use itemId to do this

itemId - ITEM_TM01_FOCUS_PUNCH

You are trying to use a variable that has no value to do math. This results in an error.

You'll probably want something like this:

bool8 ScrCmd_checkpartymove(struct ScriptContext *ctx)
{
    u8 i;
    u16 itemId = ScriptReadHalfword(ctx);

    gSpecialVar_Result = 6;
    for (i = 0; i < PARTY_SIZE; i++)
    {
            u16 species = GetMonData(&gPlayerParty[i], MON_DATA_SPECIES, NULL);
            if (!species)
                break;
            // UB: GetMonData() arguments don't match function definition
            if (CanMonLearnTMHM(&gPlayerParty[i], itemId - ITEM_TM01)
            {
                gSpecialVar_Result = i;
                gSpecialVar_0x8004 = species;
                break;
            }
    }
    return FALSE;
}

Here are the changes I've made:

u16 itemId = ScriptReadHalfword(ctx);

This will give the variable itemId the number that is connected to the HM that you're checking for, like ITEM_HM01_CUT.

if (CanMonLearnTMHM(&gPlayerParty[i], itemId - ITEM_TM01)

Now the if-statement simply checks to see if the Pokemon can learn the HM that you passed in. I took out the

!GetMonData(&gPlayerParty[i], MON_DATA_IS_EGG)

because the CanMonLearnTMHM method already checks to see if the Pokemon is an egg or not. I also took out the exclamation mark before CanMonLearnTMHM, because that would make the method return true when a Pokemon that COULDN'T learn Cut was checked. Finally, I changed ITEM_TM01_FOCUS_PUNCH to ITEM_TM01, because in the most recent version of pokeemerald, this is how that TM is named.

 

[McPaul]

To explain that "no data as an operand" thing, you have a variable called "itemId", but you didn't give it a value, like

u16 itemId = 5;

This would give itemId the value of 5. Since you didn't do that, itemId has no value. Then, when you try to use itemId to do this

itemId - ITEM_TM01_FOCUS_PUNCH

You are trying to use a variable that has no value to do math. This results in an error.

You'll probably want something like this:

bool8 ScrCmd_checkpartymove(struct ScriptContext *ctx)
{
    u8 i;
    u16 itemId = ScriptReadHalfword(ctx);

    gSpecialVar_Result = 6;
    for (i = 0; i < PARTY_SIZE; i++)
    {
            u16 species = GetMonData(&gPlayerParty[i], MON_DATA_SPECIES, NULL);
            if (!species)
                break;
            // UB: GetMonData() arguments don't match function definition
            if (CanMonLearnTMHM(&gPlayerParty[i], itemId - ITEM_TM01)
            {
                gSpecialVar_Result = i;
                gSpecialVar_0x8004 = species;
                break;
            }
    }
    return FALSE;
}

Here are the changes I've made:

u16 itemId = ScriptReadHalfword(ctx);

This will give the variable itemId the number that is connected to the HM that you're checking for, like ITEM_HM01_CUT.

if (CanMonLearnTMHM(&gPlayerParty[i], itemId - ITEM_TM01)

Now the if-statement simply checks to see if the Pokemon can learn the HM that you passed in. I took out the

!GetMonData(&gPlayerParty[i], MON_DATA_IS_EGG)

because the CanMonLearnTMHM method already checks to see if the Pokemon is an egg or not. I also took out the exclamation mark before CanMonLearnTMHM, because that would make the method return true when a Pokemon that COULDN'T learn Cut was checked. Finally, I changed ITEM_TM01_FOCUS_PUNCH to ITEM_TM01, because in the most recent version of pokeemerald, this is how that TM is named.

Thanks a lot for your time!

I still get errors though.

Here is the report:

Spoiler:

root@McPC:/mnt/c/Users/McPaul/decomps/pokeruby# make
arm-none-eabi-cpp -iquote include -Werror -Wno-trigraphs -D RUBY -D REVISION=0 -D ENGLISH -D=DEBUG_FIX0 -D DEBUG=0 -D MODERN=0 -I tools/agbcc/include -nostdinc -undef src/scrcmd.c -o build/ruby/src/scrcmd.i
tools/preproc/preproc build/ruby/src/scrcmd.i charmap.txt | tools/agbcc/bin/agbcc -mthumb-interwork -Wimplicit -Wparentheses -Wunused -Werror -O2 -fhex-asm -o build/ruby/src/scrcmd.s
src/scrcmd.c: In function `ScrCmd_checkpartymove':
src/scrcmd.c:1591: `ITEM_TM01_FOCUS_PUNCH' undeclared (first use in this function)
src/scrcmd.c:1591: (Each undeclared identifier is reported only once
src/scrcmd.c:1591: for each function it appears in.)
src/scrcmd.c:1592: syntax error before `{'
src/scrcmd.c: At top level:
src/scrcmd.c:1598: syntax error before `return'
Makefile:206: recipe for target 'build/ruby/src/scrcmd.o' failed
make: *** [build/ruby/src/scrcmd.o] Error 1

I still used ITEM_TM01_FOCUS_PUNCH as I'm not in pokeemerald but in pokeruby. I tried with just ITEM_TM01 too though but still got the same errors.

 

[WiserVisor]

I still used ITEM_TM01_FOCUS_PUNCH as I'm not in pokeemerald but in pokeruby. I tried with just ITEM_TM01 too though but still got the same errors.

I see the error now. At the top of src/srcmd.c, add this to the end of the "#include" stuff:

#include "constants/items.h"

It should look like this:

.......
#include "shop.h"
#include "slot_machine.h"
#include "sound.h"
#include "string_util.h"
#include "tv.h"
#include "constants/maps.h"
#include "constants/items.h"

This should fix the error. You are right, pokeruby still uses ITEM_TM01_FOCUS_PUNCH, so keep using that.

 

[McPaul]

I'll test all this thanks a WHOLE lot!

 

[McPaul]

I see the error now. At the top of src/srcmd.c, add this to the end of the "#include" stuff:

#include "constants/items.h"

It should look like this:

.......
#include "shop.h"
#include "slot_machine.h"
#include "sound.h"
#include "string_util.h"
#include "tv.h"
#include "constants/maps.h"
#include "constants/items.h"

This should fix the error. You are right, pokeruby still uses ITEM_TM01_FOCUS_PUNCH, so keep using that.

THANKS! Everything looks like it got fixed! There is just one last thing that looks like a "ghost" error, do you or someone perhaps know what it is?

root@McPC:/mnt/c/Users/McPaul/decomps/pokeruby# make
arm-none-eabi-cpp -iquote include -Werror -Wno-trigraphs -D RUBY -D REVISION=0 -D ENGLISH -D=DEBUG_FIX0 -D DEBUG=0 -D MODERN=0 -I tools/agbcc/include -nostdinc -undef src/scrcmd.c -o build/ruby/src/scrcmd.i
tools/preproc/preproc build/ruby/src/scrcmd.i charmap.txt | tools/agbcc/bin/agbcc -mthumb-interwork -Wimplicit -Wparentheses -Wunused -Werror -O2 -fhex-asm -o build/ruby/src/scrcmd.s
src/scrcmd.c: In function `ScrCmd_checkpartymove':
src/scrcmd.c:1593: syntax error before `{'
src/scrcmd.c: At top level:
src/scrcmd.c:1599: syntax error before `return'
Makefile:206: recipe for target 'build/ruby/src/scrcmd.o' failed
make: *** [build/ruby/src/scrcmd.o] Error 1
root@McPC:/mnt/c/Users/McPaul/decomps/pokeruby#

I tried to delete and rewrite all the lines but it's still there!

Thanks!

 

[WiserVisor]

THANKS! Everything looks like it got fixed! There is just one last thing that looks like a "ghost" error, do you or someone perhaps know what it is?

root@McPC:/mnt/c/Users/McPaul/decomps/pokeruby# make
arm-none-eabi-cpp -iquote include -Werror -Wno-trigraphs -D RUBY -D REVISION=0 -D ENGLISH -D=DEBUG_FIX0 -D DEBUG=0 -D MODERN=0 -I tools/agbcc/include -nostdinc -undef src/scrcmd.c -o build/ruby/src/scrcmd.i
tools/preproc/preproc build/ruby/src/scrcmd.i charmap.txt | tools/agbcc/bin/agbcc -mthumb-interwork -Wimplicit -Wparentheses -Wunused -Werror -O2 -fhex-asm -o build/ruby/src/scrcmd.s
src/scrcmd.c: In function `ScrCmd_checkpartymove':
src/scrcmd.c:1593: syntax error before `{'
src/scrcmd.c: At top level:
src/scrcmd.c:1599: syntax error before `return'
Makefile:206: recipe for target 'build/ruby/src/scrcmd.o' failed
make: *** [build/ruby/src/scrcmd.o] Error 1
root@McPC:/mnt/c/Users/McPaul/decomps/pokeruby#

I tried to delete and rewrite all the lines but it's still there!

Thanks!

This line

if (CanMonLearnTMHM(&gPlayerParty[i], itemId - ITEM_TM01)

You need to add another parenthesis at the end. Like this:

if (CanMonLearnTMHM(&gPlayerParty[i], itemId - ITEM_TM01))

 

[McPaul]

This line

if (CanMonLearnTMHM(&gPlayerParty[i], itemId - ITEM_TM01)

You need to add another parenthesis at the end. Like this:

if (CanMonLearnTMHM(&gPlayerParty[i], itemId - ITEM_TM01))

Well thank you it worked lik a charm!

My next big step is the party menu!




I didn't touch anything, just caught some mons hahahaha. Well I'm not that disappointed as It's already a step towards what I want to achieve without even doing anything (getting HM in the party menu without teaching them), what's left is getting control over it!

 

[WiserVisor]

......what's left is getting control over it!

I think you should focus your attention on src/pokemon_menu.c, more specifically this function:

Spoiler:

static void sub_8089A8C(void)
{
    sPokeMenuOptionsNo = 0;
    // if checking pokemon is an egg, we can't give it an item and it doesn't know any move
    if (GetMonData(&gPlayerParty[gLastFieldPokeMenuOpened], MON_DATA_IS_EGG))
    {
        AppendToList(sPokeMenuOptionsOrder, &sPokeMenuOptionsNo, POKEMENU_SUMMARY);
        AppendToList(sPokeMenuOptionsOrder, &sPokeMenuOptionsNo, POKEMENU_SWITCH);
        AppendToList(sPokeMenuOptionsOrder, &sPokeMenuOptionsNo, POKEMENU_CANCEL);
    }
    else
    {
        u16 moveID, tableID;
        for (moveID = 0; moveID < 4; moveID++) // 4, max number of possible field moves
        {
            for (tableID = 0; sPokeMenuFieldMoves[tableID] != sFieldMovesTerminator; tableID++)
            {
                if (GetMonData(&gPlayerParty[gLastFieldPokeMenuOpened], MON_DATA_MOVE1 + moveID) == sPokeMenuFieldMoves[tableID])
                {
                    u8 fieldID = tableID + POKEMENU_FIRST_FIELD_MOVE_ID;
                    AppendToList(sPokeMenuOptionsOrder, &sPokeMenuOptionsNo, fieldID);
                    break;
                }
            }
        }
        AppendToList(sPokeMenuOptionsOrder, &sPokeMenuOptionsNo, POKEMENU_SUMMARY);

        // can't switch a pokemon if it's the only one in the party
        if (GetMonData(&gPlayerParty[1], MON_DATA_SPECIES) != 0)
            AppendToList(sPokeMenuOptionsOrder, &sPokeMenuOptionsNo, POKEMENU_SWITCH);

        if (ItemIsMail(GetMonData(&gPlayerParty[gLastFieldPokeMenuOpened], MON_DATA_HELD_ITEM)))
            AppendToList(sPokeMenuOptionsOrder, &sPokeMenuOptionsNo, POKEMENU_MAIL);
        else
            AppendToList(sPokeMenuOptionsOrder, &sPokeMenuOptionsNo, POKEMENU_ITEM);

        AppendToList(sPokeMenuOptionsOrder, &sPokeMenuOptionsNo, POKEMENU_CANCEL);
    }
}

The code that seems to deal with adding "CUT" or "SURF" or whatever to that list seems to be this part:

u16 moveID, tableID;
        for (moveID = 0; moveID < 4; moveID++) // 4, max number of possible field moves
        {
            for (tableID = 0; sPokeMenuFieldMoves[tableID] != sFieldMovesTerminator; tableID++)
            {
                if (GetMonData(&gPlayerParty[gLastFieldPokeMenuOpened], MON_DATA_MOVE1 + moveID) == sPokeMenuFieldMoves[tableID])
                {
                    u8 fieldID = tableID + POKEMENU_FIRST_FIELD_MOVE_ID;
                    AppendToList(sPokeMenuOptionsOrder, &sPokeMenuOptionsNo, fieldID);
                    break;
                }
            }
        }