[Error] Problems with z move addon

ShinyObstagoon88 · Nov 14, 2019

Hi, I'm entering the code for the addon script manually (I'm using the version adapted for 17.2) but it gives me an error in this line:

side=(pbIsOpposing?(self.index)) ? 1 : 0

It's in PokeBattle_Battler

Plz help me

ShinyObstagoon88 · Nov 15, 2019

I'm working on the 17.2

WolfPP · Nov 15, 2019

You need to post your entire error to us.

ShinyObstagoon88 · Nov 15, 2019

side=(pbIsOpposing?(self.index)) ? 1 : 0
[email protected](self.index)
if @battle.zMove[side]==self.index && (move.pbIsPhysical?(move.type) || move.pbIsSpecial?(move.type))
target=PBTargets::SingleNonUser
end

WolfPP · Nov 15, 2019

You didn't show to us what I asked. We need your errorlog.txt. Example:

Code:

[Pokémon Essentials version 17.2]
Exception: NameError
Message: undefined local variable or method `thismove' for #<PokeBattle_Battler:0x9a841c8>
PokeBattle_Battler:3291:in `pbDancerMoveCheck'
PokeBattle_Battler:3283:in `each'
PokeBattle_Battler:3283:in `pbDancerMoveCheck'
PokeBattle_Battler:3281:in `each'
PokeBattle_Battler:3281:in `pbDancerMoveCheck'
PokeBattle_Battler:3536:in `pbUseMove'
PokeBattle_Battler:3775:in `pbProcessTurn'
PokeBattle_Battler:3774:in `logonerr'
PokeBattle_Battler:3774:in `pbProcessTurn'
PokeBattle_Battle:2914:in `pbAttackPhase'

But here what I have:

Code:

  def pbTarget(move)
    target=move.target
    if move.function==0x10D && pbHasType?(:GHOST); target=PBTargets::OppositeOpposing; end # Curse
    side=(pbIsOpposing?(self.index)) ? 1 : 0; [email protected](self.index)
    if @battle.zMove[side][owner]==self.index && (move.pbIsPhysical?(move.type) || move.pbIsSpecial?(move.type))
      target=PBTargets::SingleNonUser
    end        
    return target
  end

Maybe you didn't paste correctly. Also, other code than I have and can help you:

Code:

  def pbUseMoveSimple(moveid,index=-1,target=-1)
    choice=[]
    choice[0]=1       # "Use move"
    choice[1]=index   # Index of move to be used in user's moveset
    choice[2]=PokeBattle_Move.pbFromPBMove(@battle,PBMove.new(moveid)) # PokeBattle_Move object of the move
    choice[2].pp=-1
    choice[3]=target  # Target (-1 means no target yet)
    if index>=0
      @battle.choices[@index][1]=index
    end
    PBDebug.log("#{pbThis} used simple move #{choice[2].name}")
    side=(@battle.pbIsOpposing?(self.index)) ? 1 : 0
    [email protected](self.index)
    if @battle.zMove[side][owner]==self.index
      crystal = pbZCrystalFromType(choice[2].type)
      PokeBattle_ZMoves.new(@battle,self,choice[2],crystal,choice)
    else
      pbUseMove(choice,true)
    end    
    return
  end

ShinyObstagoon88 · Nov 16, 2019

Sorry i'm a noob XD this is the errorlog:

Script 'PokeBattle_Battler' line 2658 NoMethodError occured.

undefined method 'index' for PokeBattle_Battler:Class

ShinyObstagoon88 · Nov 16, 2019

WolfPP said:

You didn't show to us what I asked. We need your errorlog.txt. Example:

Code:

[Pokémon Essentials version 17.2]
Exception: NameError
Message: undefined local variable or method `thismove' for #<PokeBattle_Battler:0x9a841c8>
PokeBattle_Battler:3291:in `pbDancerMoveCheck'
PokeBattle_Battler:3283:in `each'
PokeBattle_Battler:3283:in `pbDancerMoveCheck'
PokeBattle_Battler:3281:in `each'
PokeBattle_Battler:3281:in `pbDancerMoveCheck'
PokeBattle_Battler:3536:in `pbUseMove'
PokeBattle_Battler:3775:in `pbProcessTurn'
PokeBattle_Battler:3774:in `logonerr'
PokeBattle_Battler:3774:in `pbProcessTurn'
PokeBattle_Battle:2914:in `pbAttackPhase'

But here what I have:

Code:

  def pbTarget(move)
    target=move.target
    if move.function==0x10D && pbHasType?(:GHOST); target=PBTargets::OppositeOpposing; end # Curse
    side=(pbIsOpposing?(self.index)) ? 1 : 0; [email protected](self.index)
    if @battle.zMove[side][owner]==self.index && (move.pbIsPhysical?(move.type) || move.pbIsSpecial?(move.type))
      target=PBTargets::SingleNonUser
    end        
    return target
  end

Maybe you didn't paste correctly. Also, other code than I have and can help you:

Code:

  def pbUseMoveSimple(moveid,index=-1,target=-1)
    choice=[]
    choice[0]=1       # "Use move"
    choice[1]=index   # Index of move to be used in user's moveset
    choice[2]=PokeBattle_Move.pbFromPBMove(@battle,PBMove.new(moveid)) # PokeBattle_Move object of the move
    choice[2].pp=-1
    choice[3]=target  # Target (-1 means no target yet)
    if index>=0
      @battle.choices[@index][1]=index
    end
    PBDebug.log("#{pbThis} used simple move #{choice[2].name}")
    side=(@battle.pbIsOpposing?(self.index)) ? 1 : 0
    [email protected](self.index)
    if @battle.zMove[side][owner]==self.index
      crystal = pbZCrystalFromType(choice[2].type)
      PokeBattle_ZMoves.new(@battle,self,choice[2],crystal,choice)
    else
      pbUseMove(choice,true)
    end    
    return
  end

OK, but where I paste it?

WolfPP · Nov 16, 2019

If you read what I wrote, you will see the 'def's.

ShinyObstagoon88 · Nov 16, 2019

So I need to replace this?:

def pbTarget(move)
target=move.target
if move.function==0x10D && pbHasType?(:GHOST) # Curse
target=PBTargets::OppositeOpposing
end
return target
end
side=(pbIsOpposing?(self.index)) ? 1 : 0
[email protected](self.index)
if @battle.zMove[side]==self.index && (move.pbIsPhysical?(move.type) || move.pbIsSpecial?(move.type))
target=PBTargets::SingleNonUser
end

ShinyObstagoon88 · Nov 16, 2019

I solved it but i have another problem: when I use a normal move the game tells me this but it keeps going on:

Exeption: NoMethodError
Message: undefined method 'zmove' for

and after that there are a lot of lines

WolfPP · Nov 16, 2019

Pretty sure you didn't add the script correctly. Recommend you to check all over again and compare what you forgot to copy.

ShinyObstagoon88 · Nov 19, 2019

I think he doesn't recognizes the method, but I don't know how to make them calculate it

But I will follow your advice

The error is in Pokebattle_battle but I copied everything right

So the error is that doesn't recognizes the method

(The 'z move' method)

ShinyObstagoon88 said:
The error is in Pokebattle_battle but I copied everything right

So the error is that doesn't recognizes the method

(The 'z move' method)

mgriffin · Nov 19, 2019

@ShinyObstagoon88, did you know you can edit your posts instead of making new ones?
From the rules:

Double posting - Avoid making more than one post in a row. Edit posts if you need to add more content to them. See specific sectional rules for where this may not apply.

ShinyObstagoon88 · Nov 21, 2019

mgriffin said:
@ShinyObstagoon88, did you know you can edit your posts instead of making new ones?
From the rules:

Thanks for telling me it

ShinyObstagoon88 · Nov 21, 2019

Anyway this is the error image:

And that are the codes:(sorry if too long)

From line 313 to line 323:

@zMove = []
if @player.is_a?(Array)
@zMove[0]=[-1]*@player.length
else
@zMove[0]=[-1]
end
if @opponent.is_a?(Array)
@zMove[1]=[-1]*@opponent.length
else
@zMove[1]=[-1]
end

Line 461:

return true if pbIsZCrystal?(item)

From line 558 to line 566:

def pbHasZRing(battlerIndex)
return true if !pbBelongsToPlayer?(battlerIndex)
for i in MEGARINGS
next if !hasConst?(PBItems,i)
return true if $PokemonBag.pbQuantity(i)>0
end
return false
end

From line 813 at line 816:

def zMove
return @zMove
end

From line 1057 at line 1059:

if @choices[2].zmove && (@choices[2].pbIsPhysical?(@choices[2].type) || @choices[2].pbIsSpecial?(@choices[2].type))
pri=0
end

From line 1238 at line1240:

if @zMove[side]==idxPokemon
@zMove[side]=-1
end

From line 1516 at line 1518:

if @zMove[side]==idxPokemon
@zMove[side]=-1
end

From line 1777 at line 1810:

################################################################################
# Use Z-Move.
################################################################################
def pbCanZMove?(index)
return false if $game_switches[NO_Z_MOVE]
return false if !@battlers[index].hasZMove?
return false if !pbHasZRing(index)
side=(pbIsOpposing?(index)) ? 1 : 0
owner=pbGetOwnerIndex(index)
return false if @zMove[side]!=-1
return true
end

def pbRegisterZMove(index)
side=(pbIsOpposing?(index)) ? 1 : 0
owner=pbGetOwnerIndex(index)
@zMove[side]=index
end

def pbUseZMove(index,move,crystal)
return if !@battlers[index] || !@battlers[index].pokemon
return if !(@battlers[index].hasZMove? rescue false)
ownername=pbGetOwner(index).fullname
ownername=pbGetOwner(index).name if pbBelongsToPlayer?(index)
pbDisplay(_INTL("{1} surrounded itself with its Z-Power!",@battlers[index].pbThis))
pbCommonAnimation("ZPower",@battlers[index],nil)
PokeBattle_ZMoves.new(self,@battlers[index],move,crystal)
side=(pbIsOpposing?(index)) ? 1 : 0
owner=pbGetOwnerIndex(index)
@zMove[side]=-2
end

From line 2649 at line 2654:

for i in 0...@zMove[0].length
@zMove[0]=-1 if @zMove[0]>=0
end
for i in 0...@zMove[1].length
@zMove[1]=-1 if @zMove[1]>=0
end

In this see the red codes:

if @zMove[side]==i
@zMove[side]=-1
end
break
end
next if !pbRegisterMove(i,index)
if @doublebattle
thismove=@battlers.moves[index]
target=@battlers.pbTarget(thismove)
if target==PBTargets::SingleNonUser # single non-user
[email protected](i,target)
next if target<0
pbRegisterTarget(i,target)
elsif target==PBTargets::UserOrPartner # Acupressure
[email protected](i,target)
next if target<0 || (target&1)==1
pbRegisterTarget(i,target)
end
end
commandDone=true
end
else
pbAutoChooseMove(i)
commandDone=true
end
elsif cmd!=0 && @battlers.effects[PBEffects::SkyDrop]
pbDisplay(_INTL("Sky Drop won't let {1} go!",@battlers.pbThis(true)))
elsif cmd==1 # Bag
if !@internalbattle
if pbOwnedByPlayer?(i)
pbDisplay(_INTL("Items can't be used here."))
end
else
item=pbItemMenu(i)
if item[0]>0
if pbRegisterItem(i,item[0],item[1])
commandDone=true
end
end
end
elsif cmd==2 # Pokémon
pkmn=pbSwitchPlayer(i,false,true)
if pkmn>=0
commandDone=true if pbRegisterSwitch(i,pkmn)
end
elsif cmd==3 # Run
run=pbRun(i)
if run>0
commandDone=true
return
elsif run<0
commandDone=true
side=(pbIsOpposing?(i)) ? 1 : 0
owner=pbGetOwnerIndex(i)
if @megaEvolution[side]==i
@megaEvolution[side]=-1
end
if @zMove[side]==i
@zMove[side]=-1
end
end
elsif cmd==4 # Call
thispkmn=@battlers
@choices[0]=4 # "Call Pokémon"
@choices[1]=0
@choices[2]=nil
side=(pbIsOpposing?(i)) ? 1 : 0
owner=pbGetOwnerIndex(i)
if @megaEvolution[side]==i
@megaEvolution[side]=-1
end
if @zMove[side]==i
@zMove[side]=-1
end
commandDone=true
elsif cmd==-1 # Go back to first battler's choice
@megaEvolution[0][0]=-1 if @megaEvolution[0][0]>=0
@megaEvolution[1][0]=-1 if @megaEvolution[1][0]>=0
@zMove[0][0]=-1 if @zMove[0][0]>=0
@zMove[1][0]=-1 if @zMove[1][0]>=0
# Restore the item the player's first Pokémon was due to use
if @choices[0][0]==3 && $PokemonBag && $PokemonBag.pbCanStore?(@choices[0][1])
$PokemonBag.pbStoreItem(@choices[0][1])
end
pbCommandPhase
return
end
break if commandDone
end
end
end
end
end

################################################################################
# Attack phase.
################################################################################
def pbAttackPhase
@scene.pbBeginAttackPhase
for i in 0...4
@successStates.clear
if @choices[0]!=1 && @choices[0]!=2
@battlers.effects[PBEffects::DestinyBond]=false
@battlers.effects[PBEffects::Grudge]=false
end
@battlers.turncount+=1 if !@battlers.fainted?
@battlers.effects[PBEffects::Rage]=false if !pbChoseMove?(i,:RAGE)
end
# Prepare for Z Moves
for i in 0..3
next if @choices[0]!=1
side=(pbIsOpposing?(i)) ? 1 : 0
owner=pbGetOwnerIndex(i)
if @zMove[side]==i
@choices[2].zmove=true
end
end

ShinyObstagoon88 · Nov 23, 2019

The error is in line 1057 (I think, because I changed that line and the error message changed):

if @choices[2].zmove && (@choices[2].pbIsPhysical?(@choices[2].type) || @choices[2].pbIsSpecial?(@choices[2].type))

p.s.: The red word is where I think the error is

mgriffin · Nov 23, 2019

Yes, you're right about where the error is. The PokeBattle_Move class seems not to have one of: attr_reader :zmove, attr_writer :zmove, or def zmove. Unfortunately that's not enough information to know how to fix it—if you added one of those you'd still need to actually set zmove to something. I assume the problem here is that you were supposed to make changes in PokeBattle_Move but have either forgotten to, or accidentally made them somewhere else.

ShinyObstagoon88 · Nov 23, 2019

XD I don't paste the pokebattle_move codes, sorry for the waste of time

[Error] Problems with z move addon

More options

ShinyObstagoon88

ShinyObstagoon88

WolfPP

Spriter/ Pixel Artist

ShinyObstagoon88

WolfPP

Spriter/ Pixel Artist

ShinyObstagoon88

ShinyObstagoon88

WolfPP

Spriter/ Pixel Artist

ShinyObstagoon88

ShinyObstagoon88

WolfPP

Spriter/ Pixel Artist

ShinyObstagoon88

mgriffin

ShinyObstagoon88

ShinyObstagoon88

Attachments

ShinyObstagoon88

mgriffin

ShinyObstagoon88