Lathspell pretty much covered it, but I have a few things to add.
- PLEASE add the nature of your Pokes when wanting a rate. That makes a huge difference on most Pokes, as far as what moveset would be most effective for it.
- NEVER give two attacking moves of the same type to the same Poke. It is redundant and makes the Poke less effective. The only exceptions are Quick Attack and Mach Punch.
- NEVER give your Poke crappy hold items like Miracle Seed. They only boost one type of move by 10%, but don't do anything if you use one of the other three moves. Don't underestimate the power of berries.
- NEVER have the Pokes on your team learn HM moves not called Surf. The rest are utterly useless and should be placed on a crappy Poke like Zigzagoon, Wailmer, or Tropius and use it as your HM slave, pulling it out of your PC whenever you need it.
- NEVER teach Normal moves to non-Normal Pokes. Use a move that will at least give the Poke some advantage. An exception to this is Extremespeed and depending on the Poke, Quick Attack.
As for your team, fixes in
bold:
Hi can anyone rate my ruby team please:
Grovyle lv35
Item: Leftovers
Nature: Timid (+Spd, -Atk)
Moves:
- Leech Seed
- Substitute
- Thunderpunch/Crunch
- Leaf Blade
The great thing about this set is that after you Seed, your Subs are practically free with both Lefties and Seed replenishing its HP. TP can be bought in the Battle Frontier in Emerald. If you don't have access to Emerald, you can go with Crunch as it comes in quite handy in the E4.
Torkoal lv35
Items: None
Moves:
Ember (willing to change)
Body Slame
Rocksmash (willing to change)
Flamethrower
As Lathspell said, there aren't many Fire-types in RSE, but that is a good thing since Fire is highly over-rated and one of the worst types in the game. I would HIGHLY suggest you pick up Breloom or Ludicolo instead. Both would compliment your team nicely. Breloom is offensive while Ludicolo is defensive.
Swellow lv33
Items: Shell Bell
Nature: Jolly (+Spd, -SAtk)
Move:
- Aerial Ace/Wing Attack
- Facade
- Rest
- Sleep Talk
This thing is a monster. Not only does it heal itself, but when it is asleep, Guts kicks in boosts its attack power. When it is awake and gets statused, Facade will also boost its attack power.
Corphish lv32
Items: Everstone
Move:
Vicegrip
Surf
Bubblebeam
Protect
Meh. Lath's set is the most you are going to get out of this.
and there are 2 more to get to complete my team
Can someone also tell me the best place to find a feebass please
You will find Feebas ONLY on Route 119, and ONLY in SIX of the many water tiles in that route. I found mine with much patience. Use the Old Rod and fish 5-7 times in EVERY square. It takes time, but you will find one eventually. The reason they are so rare and hard to get is because Milotic is a great Poke to have. Super high SDef, and a complimentary moveset. Don't give up. Get one.