[Script] Script help, please

[GingerGuy173]

So... I'm hacking FireRed. I want to make an NPC that gives the player a Mystic Ticket (The item that lets you go to Navel Rock) if they have the National Pokedex. I did some research and found out that the flag for a National Pokedex is 16F. But for some reason, the NPC does not give the Ticket. Here's what I've written:

Spoiler:

'---------------
#org 0x166C17
faceplayer
lock
checkitem 0x172 0x1
compare LASTRESULT 0x1
if 0x1 goto @alreadyhas
checkflag 0x16F <===== This is where the problem seems to be.
compare LASTRESULT 0x1
if 0x1 goto 0x871E652
msgbox @MSGnotready MSG_FACE '"Gimme a sec... I saw something\nre..."
release
end

'---------
' Gotos
'---------
#org notready
msgbox @MSGnotready MSG_FACE '"Tell me what you find with\nthat t..."

#org @intro
msgbox @MSGintro MSG_YESNO '"Ah, there it is!......\nHuh? What ..."
compare LASTRESULT 0x0
if 0x1 goto @no
goto @yes

#org @no
msgbox 0x871E811 MSG_FACE '"Sigh... My hand is already getting..."

#org @yes
msgbox 0x871E7DA MSG_FACE '"Here you go! Tell me what\nyou fin..."
giveitem 0x172 0x1 MSG_OBTAIN
closeonkeypress

'---------
' Messages
'---------
#org @MSGnotready
= Gimme a sec... I saw something\nreally sparkly around here\psomewhere...

#org @MSGalreadyhas
= Tell me what you find with\nthat thing, alright?

#org @MSGintro
= Ah, there it is!......\nHuh? What was I looking for?\pWell, I found this really\nshiny ticket. I pressume\pit's for the VERMILION HARBOR\njust ahead. I'd use it, but you\psee, I'm kinda prone to sea-\nsickness.\pSo would you like\nto have it instead?

#org @MSGno
= Sigh... My hand is already getting\nsweaty holding this thing...

#org @MSGyes
= Here you go! Tell me what\nyou find with it, alright?

I see no reason why this shouldn't work. And the funny thing is, that when I delete the
"checkflag 0x16F
compare LASTRESULT 0x1
if 0x1 goto @intro"
part (the part that checks for the NatDex, the NPC gives you the Mystic Ticket just fine!

Any help would be greatly appreciated. I've been working quite literally all day to try to fix this, but to no avail.?

 

[GreatFlameFTW]

Can you give me non complied version?

According to my knowledge I don't think after checkflag compare command is required.

The pointer of if 0x1 seems to be missing.

 

[GingerGuy173]

Can you give me non complied version?

According to my knowledge I don't think after checkflag compare command is required.

The pointer of if 0x1 seems to be missing.

This is the non-compiled version. It looks that way because I got used to writing them that way. :P
And thank you, I will try taking the compare command out, and let you know if it works.

 

[PurpleOrange]

So... I'm hacking FireRed. I want to make an NPC that gives the player a Mystic Ticket (The item that lets you go to Navel Rock) if they have the National Pokedex. I did some research and found out that the flag for a National Pokedex is 16F. But for some reason, the NPC does not give the Ticket. Here's what I've written:

Spoiler:

'---------------
#org 0x166C17
faceplayer
lock
checkitem 0x172 0x1
compare LASTRESULT 0x1
if 0x1 goto @alreadyhas
checkflag 0x16F <===== This is where the problem seems to be.
compare LASTRESULT 0x1
if 0x1 goto 0x871E652
msgbox @MSGnotready MSG_FACE '"Gimme a sec... I saw something\nre..."
release
end

'---------
' Gotos
'---------
#org notready
msgbox @MSGnotready MSG_FACE '"Tell me what you find with\nthat t..."

#org @intro
msgbox @MSGintro MSG_YESNO '"Ah, there it is!......\nHuh? What ..."
compare LASTRESULT 0x0
if 0x1 goto @no
goto @yes

#org @no
msgbox 0x871E811 MSG_FACE '"Sigh... My hand is already getting..."

#org @yes
msgbox 0x871E7DA MSG_FACE '"Here you go! Tell me what\nyou fin..."
giveitem 0x172 0x1 MSG_OBTAIN
closeonkeypress

'---------
' Messages
'---------
#org @MSGnotready
= Gimme a sec... I saw something\nreally sparkly around here\psomewhere...

#org @MSGalreadyhas
= Tell me what you find with\nthat thing, alright?

#org @MSGintro
= Ah, there it is!......\nHuh? What was I looking for?\pWell, I found this really\nshiny ticket. I pressume\pit's for the VERMILION HARBOR\njust ahead. I'd use it, but you\psee, I'm kinda prone to sea-\nsickness.\pSo would you like\nto have it instead?

#org @MSGno
= Sigh... My hand is already getting\nsweaty holding this thing...

#org @MSGyes
= Here you go! Tell me what\nyou find with it, alright?

I see no reason why this shouldn't work. And the funny thing is, that when I delete the
"checkflag 0x16F
compare LASTRESULT 0x1
if 0x1 goto @intro"
part (the part that checks for the NatDex, the NPC gives you the Mystic Ticket just fine!

Any help would be greatly appreciated. I've been working quite literally all day to try to fix this, but to no avail.?

the compare is necessary, don't remove that at all.
the problem is, it isn't a flag that sets the national dex, it's a special command (0x16F) so you can't check if national dex is on using a checkflag (incidentally, flag 0x16F is used for an item in rocket hideout) you should replace the checkflag 0x16F etc. with this

special2 LASTRESULT 0x193
compare LASTRESULT 0x1
if 0x1 goto @intro

(on a side note if you want the mystic ticket to work at the ferry ports, make sure to setflag 0x84A :))

 

[GingerGuy173]

the compare is necessary, don't remove that at all.
the problem is, it isn't a flag that sets the national dex, it's a special command (0x16F) so you can't check if national dex is on using a checkflag (incidentally, flag 0x16F is used for an item in rocket hideout) you should replace the checkflag 0x16F etc. with this

special2 LASTRESULT 0x193
compare LASTRESULT 0x1
if 0x1 goto @intro

(on a side note if you want the mystic ticket to work at the ferry ports, make sure to setflag 0x84A :))

Oh, finally... it worked. Thank you a ton! I spent like 7 hours the other day trying to figure this out, lol, so you're a life-saver.

 

[Pinta87]

Couldn't you also just set an additional "regular" flag in the script that gives you the national dex and have it check for that?