[Scripting Question] Scripting tips

[0maewam0ushindeiru]

I am trying to get a script working, but I keep running into issues with the new sub-category of isSpecies?
If anyone can help, much appreciated. Code below.

def pbCelelocus
  def isDeterminedSpecies?(species,level)
    return @pokemon && @pokemon.isDeterminedSpecies?(species,level)
  end
  
  if isDeterminedSpecies?(:SOLROCK,40) && 
     isDeterminedSpecies?(:LUNATONE,40)
    pbMessage(_INTL("The experiment is beginning.\nHand over the sun and moon, please."))
    pbRemovePokemonAt(1)
    pbRemovePokemonAt(2)
    pbMessage(_INTL("The experiment worked. Here is your new Pokemon!"))
    pbAddPokemon(:CELELOCUS,40)
  else
    pbMessage(_INTL("Come back when you are ready, then."))
  end
end

 

[NettoHikari]

There are a lot of syntax issues with your script. Since you're trying to script things on your own, you should try to actually learn the basics of how to do so. Marin has a good Ruby tutorial here: (broken link removed).

It looks like you're trying to make a function to combine a level 40 Solrock and Lunatone into a new Pokemon Celelocus. The only thing I'm confused about is how the player chooses which 2 Pokemon from the party in the first place? It looks like you are just assuming the first two spots of the party should have the Solrock and Lunatone. In most programming languages, though, arrays or lists start at index 0, so the first two spots would actually be 0 and 1, not 1 and 2. Also, "pbRemovePokemonAt" fails if it's trying to remove the player's last unfainted Pokemon. This means that if the player tries to combine when they have ONLY Solrock and Lunatone in their party, and nothing else, the Lunatone will just stay in the party.

You can try rewriting your function like so:

def pbCelelocus
  poke1 = $Trainer.party[0]
  poke2 = $Trainer.party[1]
  # First must be Solrock, second must be Lunatone
  if poke1.level == 40 && poke2.level == 40 && poke1.isSpecies?(:SOLROCK) && poke2.isSpecies?(:LUNATONE) && !poke1.egg? && !poke2.egg?
    pbMessage(_INTL("The experiment is beginning.\nHand over the sun and moon, please."))
    $Trainer.party.delete_at(0)
    $Trainer.party.delete_at(0) # The Pokemon that used to be second is now first
    pbMessage(_INTL("The experiment worked. Here is your new Pokemon!"))
    pbAddPokemon(:CELELOCUS,40)
  else
    pbMessage(_INTL("Come back when you are ready, then."))
  end
end