[Scripting Question] Stealth Rock changes help

[Tommaniacal]

Hello, I'm trying to rebalance Stealth Rock so that it no longer takes quad ineffectiveness or quad effectiveness into account, instead dealing 1/16th if Rock is Not Very Effective, 1/8th if Neutral, and 1/4th if Super Effective. This is the script I have so far:

Spoiler:

      if pkmn.pbOwnSide.effects[PBEffects::StealthRock] && !pkmn.fainted?
        if !(pkmn.hasWorkingAbility(:MAGICGUARD) ||
            pkmn.hasWorkingItem(:HEAVYDUTYBOOTS))
          atype=getConst(PBTypes,:ROCK) || 0
          eff=PBTypes.getCombinedEffectiveness(atype,pkmn.type1,pkmn.type2,pkmn.effects[PBEffects::Type3])
          if eff>0
            PBDebug.log("[Entry hazard] #{pkmn.pbThis} triggered Stealth Rock")
            @scene.pbDamageAnimation(pkmn,0)
            if eff<8 
              pkmn.pbReduceHP((pkmn.totalhp/16).floor)
            elsif eff=8
              pkmn.pbReduceHP((pkmn.totalhp/8).floor)
            elsif eff>8
              pkmn.pbReduceHP((pkmn.totalhp/4).floor)
            end
            pbDisplayPaused(_INTL("Pointed stones dug into {1}!",pkmn.pbThis))
          end
        end
      end

It successfully deals 1/16th HP if Rock is Not Very Effective and 1/8th if neutral, however Super Effective also deals 1/8th damage. What changes should I make? Thanks!

 

[StCooler]

I have trouble understanding how type effectiveness works, so I can relate.

Fortunately, the module PBTypes has useful functions:

  def PBTypes.ineffective?(attackType,targetType1=nil,targetType2=nil,targetType3=nil)
  def PBTypes.notVeryEffective?(attackType,targetType1=nil,targetType2=nil,targetType3=nil)
  def PBTypes.resistant?(attackType,targetType1=nil,targetType2=nil,targetType3=nil)
  def PBTypes.normalEffective?(attackType,targetType1=nil,targetType2=nil,targetType3=nil)
  def PBTypes.superEffective?(attackType,targetType1=nil,targetType2=nil,targetType3=nil)

and all these functions can take the result of PBTypes.getCombinedEffectiveness() in place of attackType.

I suggest the following code:

      if pkmn.pbOwnSide.effects[PBEffects::StealthRock] && !pkmn.fainted?
        if !(pkmn.hasWorkingAbility(:MAGICGUARD) ||
            pkmn.hasWorkingItem(:HEAVYDUTYBOOTS))
          atype=getConst(PBTypes,:ROCK) || 0
          eff=PBTypes.getCombinedEffectiveness(atype,pkmn.type1,pkmn.type2,pkmn.effects[PBEffects::Type3])
          if eff>0
            PBDebug.log("[Entry hazard] #{pkmn.pbThis} triggered Stealth Rock")
            @scene.pbDamageAnimation(pkmn,0)
            if PBTypes.resistant?(eff)
              pkmn.pbReduceHP((pkmn.totalhp/16).floor)
            elsif PBTypes.superEffective?(eff)
              pkmn.pbReduceHP((pkmn.totalhp/4).floor)
            else # Normal effective 
              pkmn.pbReduceHP((pkmn.totalhp/8).floor)
            end
            pbDisplayPaused(_INTL("Pointed stones dug into {1}!",pkmn.pbThis))
          end
        end
      end

PS: Also, when you have several "if" and "elsif", it's good practice to leave one of these as a default case, just in case ^^

 

[Tommaniacal]

I have trouble understanding how type effectiveness works, so I can relate.

Fortunately, the module PBTypes has useful functions:

  def PBTypes.ineffective?(attackType,targetType1=nil,targetType2=nil,targetType3=nil)
  def PBTypes.notVeryEffective?(attackType,targetType1=nil,targetType2=nil,targetType3=nil)
  def PBTypes.resistant?(attackType,targetType1=nil,targetType2=nil,targetType3=nil)
  def PBTypes.normalEffective?(attackType,targetType1=nil,targetType2=nil,targetType3=nil)
  def PBTypes.superEffective?(attackType,targetType1=nil,targetType2=nil,targetType3=nil)

and all these functions can take the result of PBTypes.getCombinedEffectiveness() in place of attackType.

I suggest the following code:

      if pkmn.pbOwnSide.effects[PBEffects::StealthRock] && !pkmn.fainted?
        if !(pkmn.hasWorkingAbility(:MAGICGUARD) ||
            pkmn.hasWorkingItem(:HEAVYDUTYBOOTS))
          atype=getConst(PBTypes,:ROCK) || 0
          eff=PBTypes.getCombinedEffectiveness(atype,pkmn.type1,pkmn.type2,pkmn.effects[PBEffects::Type3])
          if eff>0
            PBDebug.log("[Entry hazard] #{pkmn.pbThis} triggered Stealth Rock")
            @scene.pbDamageAnimation(pkmn,0)
            if PBTypes.resistant?(eff)
              pkmn.pbReduceHP((pkmn.totalhp/16).floor)
            elsif PBTypes.superEffective?(eff)
              pkmn.pbReduceHP((pkmn.totalhp/4).floor)
            else # Normal effective 
              pkmn.pbReduceHP((pkmn.totalhp/8).floor)
            end
            pbDisplayPaused(_INTL("Pointed stones dug into {1}!",pkmn.pbThis))
          end
        end
      end

PS: Also, when you have several "if" and "elsif", it's good practice to leave one of these as a default case, just in case ^^

Thanks for the help! I tried using your code, but I get the following error:

Spoiler:

---------------------------
Pokemon Essentials
---------------------------
[Pokémon Essentials version 17.2]

Exception: NoMethodError

Message: undefined method `resistant?' for PBTypes:Class

PokeBattle_Battle:2152:in `pbOnActiveOne'

PokeBattle_Battle:1334:in `pbRecallAndReplace'

PokeBattle_Battle:2814:in `pbAttackPhase'

PokeBattle_Battle:2781:in `each'

PokeBattle_Battle:2781:in `pbAttackPhase'

PokeBattle_Battle:2582:in `pbStartBattleCore'

PokeBattle_Battle:2581:in `logonerr'

PokeBattle_Battle:2581:in `pbStartBattleCore'

PokeBattle_Battle:2567:in `loop'

PokeBattle_Battle:2590:in `pbStartBattleCore'

I'm using V17, is that an issue? I also tried using the following code:

Spoiler:

      if pkmn.pbOwnSide.effects[PBEffects::StealthRock] && !pkmn.fainted?
        if !(pkmn.hasWorkingAbility(:MAGICGUARD) ||
            pkmn.hasWorkingItem(:HEAVYDUTYBOOTS))
          atype=getConst(PBTypes,:ROCK) || 0
          eff=PBTypes.getCombinedEffectiveness(atype,pkmn.type1,pkmn.type2,pkmn.effects[PBEffects::Type3])
          if eff>0
            PBDebug.log("[Entry hazard] #{pkmn.pbThis} triggered Stealth Rock")
            @scene.pbDamageAnimation(pkmn,0)
            if PBTypes.[COLOR="Red"]isNotVeryEffective?[/COLOR](eff)
              pkmn.pbReduceHP((pkmn.totalhp/16).floor)
            elsif PBTypes.[COLOR="Red"]isSuperEffective?[/COLOR](eff)
              pkmn.pbReduceHP((pkmn.totalhp/4).floor)
            else # Normal effective 
              pkmn.pbReduceHP((pkmn.totalhp/8).floor)
            end
            pbDisplayPaused(_INTL("Pointed stones dug into {1}!",pkmn.pbThis))
          end
        end
      end

But received this error instead:

Spoiler:

---------------------------
Pokemon Essentials
---------------------------
[Pokémon Essentials version 17.2]

Exception: ArgumentError

Message: wrong number of arguments(1 for 2)

PokeBattle_Battle:2152:in `isNotVeryEffective?'

PokeBattle_Battle:2152:in `pbOnActiveOne'

PokeBattle_Battle:1334:in `pbRecallAndReplace'

PokeBattle_Battle:2814:in `pbAttackPhase'

PokeBattle_Battle:2781:in `each'

PokeBattle_Battle:2781:in `pbAttackPhase'

PokeBattle_Battle:2582:in `pbStartBattleCore'

PokeBattle_Battle:2581:in `logonerr'

PokeBattle_Battle:2581:in `pbStartBattleCore'

PokeBattle_Battle:2567:in `loop'

 

[StCooler]

Ah, v17, of course.
Check the module PBTypes, and check if there is any function that looks like those that I mentioned.

 

[Tommaniacal]

Ah, v17, of course.
Check the module PBTypes, and check if there is any function that looks like those that I mentioned.

I only see PBTypes_Extra, not PBTypes. It does have functions for PBTypes.isNotVeryEffective?, PBTypes.isNormalEffective?, and PBTypes.isSuperEffective?, which is what I based the last script I posted on, but they give me argument errors.

 

[StCooler]

I only see PBTypes_Extra, not PBTypes. It does have functions for PBTypes.isNotVeryEffective?, PBTypes.isNormalEffective?, and PBTypes.isSuperEffective?, which is what I based the last script I posted on, but they give me argument errors.

What what arguments do they expect? Please post the "def XXX.isSuperEffective?" and such.
What errors do they show? How do you call these functions?

 

[Tommaniacal]

What what arguments do they expect? Please post the "def XXX.isSuperEffective?" and such.
What errors do they show? How do you call these functions?

Here's the functions:

Spoiler:

  def PBTypes.isIneffective?(attackType,opponentType1,opponentType2=nil,opponentType3=nil)
    e = PBTypes.getCombinedEffectiveness(attackType,opponentType1,opponentType2,opponentType3)
    return e==0
  end

  def PBTypes.isNotVeryEffective?(attackType,opponentType1,opponentType2=nil,opponentType3=nil)
    e = PBTypes.getCombinedEffectiveness(attackType,opponentType1,opponentType2,opponentType3)
    return e>0 && e<8
  end

  def PBTypes.isNormalEffective?(attackType,opponentType1,opponentType2=nil,opponentType3=nil)
    e = PBTypes.getCombinedEffectiveness(attackType,opponentType1,opponentType2,opponentType3)
    return e==8
  end

And here's the error:

Spoiler:

---------------------------
Pokemon Essentials
---------------------------
[Pokémon Essentials version 17.2]

Exception: ArgumentError

Message: wrong number of arguments(1 for 2)

PokeBattle_Battle:2152:in `isNotVeryEffective?'

PokeBattle_Battle:2152:in `pbOnActiveOne'

PokeBattle_Battle:1334:in `pbRecallAndReplace'

PokeBattle_Battle:2814:in `pbAttackPhase'

PokeBattle_Battle:2781:in `each'

PokeBattle_Battle:2781:in `pbAttackPhase'

PokeBattle_Battle:2582:in `pbStartBattleCore'

PokeBattle_Battle:2581:in `logonerr'

PokeBattle_Battle:2581:in `pbStartBattleCore'

PokeBattle_Battle:2567:in `loop'

 

[StCooler]

Ok, it's because the new functions in v18 can take the "eff" as a parameter, while the old functions from v17 cannot.

The good news is that it's easy to fix:

      if pkmn.pbOwnSide.effects[PBEffects::StealthRock] && !pkmn.fainted?
        if !(pkmn.hasWorkingAbility(:MAGICGUARD) ||
            pkmn.hasWorkingItem(:HEAVYDUTYBOOTS))
          atype=getConst(PBTypes,:ROCK) || 0
          eff=PBTypes.getCombinedEffectiveness(atype,pkmn.type1,pkmn.type2,pkmn.effects[PBEffects::Type3])
          if eff>0
            PBDebug.log("[Entry hazard] #{pkmn.pbThis} triggered Stealth Rock")
            @scene.pbDamageAnimation(pkmn,0)
            if eff < 8
              pkmn.pbReduceHP((pkmn.totalhp/16).floor)
            elsif eff > 8
              pkmn.pbReduceHP((pkmn.totalhp/4).floor)
            else # Normal effective 
              pkmn.pbReduceHP((pkmn.totalhp/8).floor)
            end
            pbDisplayPaused(_INTL("Pointed stones dug into {1}!",pkmn.pbThis))
          end
        end
      end

 

[Tommaniacal]

Ok, it's because the new functions in v18 can take the "eff" as a parameter, while the old functions from v17 cannot.

The good news is that it's easy to fix:

      if pkmn.pbOwnSide.effects[PBEffects::StealthRock] && !pkmn.fainted?
        if !(pkmn.hasWorkingAbility(:MAGICGUARD) ||
            pkmn.hasWorkingItem(:HEAVYDUTYBOOTS))
          atype=getConst(PBTypes,:ROCK) || 0
          eff=PBTypes.getCombinedEffectiveness(atype,pkmn.type1,pkmn.type2,pkmn.effects[PBEffects::Type3])
          if eff>0
            PBDebug.log("[Entry hazard] #{pkmn.pbThis} triggered Stealth Rock")
            @scene.pbDamageAnimation(pkmn,0)
            if eff < 8
              pkmn.pbReduceHP((pkmn.totalhp/16).floor)
            elsif eff > 8
              pkmn.pbReduceHP((pkmn.totalhp/4).floor)
            else # Normal effective 
              pkmn.pbReduceHP((pkmn.totalhp/8).floor)
            end
            pbDisplayPaused(_INTL("Pointed stones dug into {1}!",pkmn.pbThis))
          end
        end
      end

This works! Thank you! I have a question, if I've already implemented all of the gen 7 mechanics into V17, would it still be worth it to update to 18? I only hesitate because I have quite a few custom scripts that would probably break

 

[StCooler]

This works! Thank you! I have a question, if I've already implemented all of the gen 7 mechanics into V17, would it still be worth it to update to 18? I only hesitate because I have quite a few custom scripts that would probably break

I would update to v18 if and only if I needed gen 8 stuff + some scripts that don't exist for v17 (Mid Battle Dialogue, Z-moves/Dynamax...).

However, v17 and v18 seem to be quite close, as far as I can tell. Some functions are altered, but it should be easy to debug.

You will spend a hard time making those changes though.

 

[NettoHikari]

I would update to v18 if and only if I needed gen 8 stuff + some scripts that don't exist for v17 (Mid Battle Dialogue, Z-moves/Dynamax...).

However, v17 and v18 seem to be quite close, as far as I can tell. Some functions are altered, but it should be easy to debug.

You will spend a hard time making those changes though.

The two versions are relatively close if you're NOT talking about battle scripts. For battle scripts, they are leagues apart (v18 broke nearly ALL battle scripts that used to be on v17).

This works! Thank you! I have a question, if I've already implemented all of the gen 7 mechanics into V17, would it still be worth it to update to 18? I only hesitate because I have quite a few custom scripts that would probably break

Ideally, you would want to move to v18. If you plan on working on your game for a long time, then you will only be making it harder on yourself by working on an outdated version of Essentials. Though, if you're just making a shorter game and are planning to release it soon, then it's more understandable if you decide to stay on v17. Either way, there are more advantages than disadvantages to upgrading your game, so I would strongly consider it.

 

[StCooler]

The two versions are relatively close if you're NOT talking about battle scripts. For battle scripts, they are leagues apart (v18 broke nearly ALL battle scripts that used to be on v17).

Oh, ok, I didn't know that! Thanks :)