[Scripting Question] Ultra Necrozma & Greninja-Ash

[Gemini_air]

Hello Guys!
I have two questions for you. Actually i'm using the 17.2 version and i have some problem with "Mega Evolution" Script. I would like to add Ultra-Necrozma and Greninja Ash but i have these problems:
Greninja-Ash.
First i add in Compiler this line

Spoiler:

"MegaAbility" => [59,"E",PBAbilities]

Then i wrote in MegaEvolution

Spoiler:

if !itemonly
pbDexDataOffset(dexdata,i,59)
megaability = dexdata.fgetw
if megaability>0 && self.hasWorkingAbility?(megaability)
ret = i; break
end
end

The problem is that the Mega Evolution not start. (I wrote in pokemonsform.txt)

Ultra Necrozma
in Mega Evolution i wrote this:

Spoiler:

MultipleForms.register(:NECROZMA,{
"getMegaForm"=>proc{|pokemon|
next 3 if isConst?(pokemon.item,PBItems,:ULTRANECROZIUMZ) && pokemon.form==1 || pokemon.form==2
next rand(2)+1 if pokemon.form==3 && !isConst?(pokemon.item,PBItems,:ULTRANECROZIUMZ)
}
})

The problem is when the battle ends, returns in the form 0 and not in 1/2 form. Can you help me?

 

[mybusiness]

I'll adress Greninja, for the moment, because Ultra-Necrozma is not at my disposal yet.
So, delete everything you have about Greninja in the scripts. Copy only what I've written with red. Let's go:

In PokeBattle_Battler:

Spoiler:

In def pbAbilitiesOnSwitchIn:

# Trace
    if self.hasWorkingAbility(:TRACE)
      choices=[]
      for i in 0...4
        [email protected][i]
        if pbIsOpposing?(i) && !foe.fainted?
          abil=foe.ability
          if abil>0 &&
             !isConst?(abil,PBAbilities,:TRACE) &&
             !isConst?(abil,PBAbilities,:MULTITYPE) &&
             !isConst?(abil,PBAbilities,:ILLUSION) &&
             !isConst?(abil,PBAbilities,:FLOWERGIFT) &&
             !isConst?(abil,PBAbilities,:IMPOSTER) &&
             !isConst?(abil,PBAbilities,:STANCECHANGE) &&
             !isConst?(abil,PBAbilities,:COMATOSE) &&
             [COLOR="Red"]!isConst?(abil,PBAbilities,:BATTLEBOND) &&[/COLOR]
             !isConst?(abil,PBAbilities,:POWERCONSTRUCT) &&
             !isConst?(abil,PBAbilities,:DISGUISE) &&
             !isConst?(abil,PBAbilities,:POWEROFALCHEMY) &&
             !isConst?(abil,PBAbilities,:RECEIVER) &&
             !isConst?(abil,PBAbilities,:RKSSYSTEM) &&
             !isConst?(abil,PBAbilities,:SCHOOLING) &&
             !isConst?(abil,PBAbilities,:SHIELDSDOWN)
            choices.push(i)
          end
        end
      end

In def pbEffectsOnDealingDamage:

if target.hasWorkingAbility(:MUMMY,true) && !user.fainted?
          if !isConst?(user.ability,PBAbilities,:MULTITYPE) &&
             !isConst?(user.ability,PBAbilities,:STANCECHANGE) &&
             !isConst?(user.ability,PBAbilities,:MUMMY) &&
             !isConst?(user.ability,PBAbilities,:DISGUISE) &&
             !isConst?(user.ability,PBAbilities,:COMATOSE) &&
             [COLOR="red"]!isConst?(user.ability,PBAbilities,:BATTLEBOND) &&[/COLOR]
             !isConst?(user.ability,PBAbilities,:RKSSYSTEM) &&
             !isConst?(user.ability,PBAbilities,:SCHOOLING) &&
             !isConst?(user.ability,PBAbilities,:SHIELDSDOWN)
            PBDebug.log("[Ability triggered] #{target.pbThis}'s Mummy copied onto #{user.pbThis(true)}")
            user.ability=getConst(PBAbilities,:MUMMY) || 0
            @battle.pbDisplay(_INTL("{1} was mummified by {2}!",
               user.pbThis,target.pbThis(true)))
          end
        end

In def pbEffectsAfterHit (if you don't have Power of Alchemy and/or Receiver, skip what's below # Battle Bond in this method):

# Moxie
    if user.hasWorkingAbility(:MOXIE) && target.fainted?
      if user.pbIncreaseStatWithCause(PBStats::ATTACK,1,user,PBAbilities.getName(user.ability))
        PBDebug.log("[Ability triggered] #{user.pbThis}'s Moxie")
      end
    end
    [COLOR="red"]# Battle Bond
    if isConst?(user.species,PBSpecies,:GRENINJA) && user.hasWorkingAbility(:BATTLEBOND)
      if target.fainted? && user.form!=1
        user.form=1
        pbUpdate(true)
        @battle.scene.pbChangePokemon(user,user.pokemon)
        @battle.pbDisplay(_INTL("{1} made a bond with his trainer!",user.pbThis))
        PBDebug.log("[Ability triggered] #{user.pbThis}'s Battle Bond")
        PBDebug.log("[Form changed] #{user.pbThis} changed to form #{self.form}")
      end
    end[/COLOR]
# Power of Alchemy, Receiver
    if (user.hasWorkingAbility(:POWEROFALCHEMY) ||
      user.hasWorkingAbility(:RECEIVER)) && @battle.doublebattle &&
       user.pbPartner.fainted?
      usable=false
      abil=user.pbPartner.ability
      if abil>0 &&
             !isConst?(abil,PBAbilities,:POWEROFALCHEMY) &&
             !isConst?(abil,PBAbilities,:TRACE) &&
             !isConst?(abil,PBAbilities,:MULTITYPE) &&
             !isConst?(abil,PBAbilities,:ILLUSION) &&
             !isConst?(abil,PBAbilities,:FLOWERGIFT) &&
             !isConst?(abil,PBAbilities,:IMPOSTER) &&
             !isConst?(abil,PBAbilities,:STANCECHANGE) &&
             !isConst?(abil,PBAbilities,:COMATOSE) &&
             [COLOR="red"]!isConst?(abil,PBAbilities,:BATTLEBOND) &&[/COLOR]
             !isConst?(abil,PBAbilities,:POWERCONSTRUCT) &&
             !isConst?(abil,PBAbilities,:RECEIVER) &&
             !isConst?(abil,PBAbilities,:FORECAST) &&
             !isConst?(abil,PBAbilities,:WONDERGUARD) &&
             !isConst?(abil,PBAbilities,:DISGUISE) &&
             !isConst?(abil,PBAbilities,:ZENMODE) &&
             !isConst?(abil,PBAbilities,:SCHOOLING) &&
             !isConst?(abil,PBAbilities,:SHIELDSDOWN) &&
             !isConst?(abil,PBAbilities,:RKSSYSTEM)
            usable=true
      end

In def pbFaint:

def pbFaint(showMessage=true)
    unless fainted?
      PBDebug.log("!!!***Can't faint with HP greater than 0")
      return true
    end
    if @fainted
#      PBDebug.log("!!!***Can't faint if already fainted")
      return true
    end
    @battle.scene.pbFainted(self)
    pbInitEffects(false)
    # Reset status
    self.status=0
    self.statusCount=0
    if @pokemon && @battle.internalbattle
      @pokemon.changeHappiness("faint")
    end
    @pokemon.makeUnmega if self.isMega?
    @pokemon.makeUnprimal if self.isPrimal?
    [COLOR="Red"]@pokemon.revertOtherForms[/COLOR]
    @fainted=true
    # reset choice
    @battle.choices[@index]=[0,0,nil,-1]
    pbOwnSide.effects[PBEffects::LastRoundFainted][email protected]
    @battle.pbDisplayPaused(_INTL("{1} fainted!",pbThis)) if showMessage
    PBDebug.log("[Pokémon fainted] #{pbThis}")
    return true
  end

In PokeBattle_MoveEffects:

Spoiler:

In Simple Beam:

    if isConst?(opponent.ability,PBAbilities,:MULTITYPE) ||
       isConst?(opponent.ability,PBAbilities,:SIMPLE) ||
       isConst?(opponent.ability,PBAbilities,:STANCECHANGE) ||
       isConst?(opponent.ability,PBAbilities,:TRUANT) ||
       isConst?(opponent.ability,PBAbilities,:DISGUISE) ||
       isConst?(opponent.ability,PBAbilities,:COMATOSE) ||
       [COLOR="red"]isConst?(opponent.ability,PBAbilities,:BATTLEBOND) ||[/COLOR]
       isConst?(opponent.ability,PBAbilities,:RKSSYSTEM) ||
       isConst?(opponent.ability,PBAbilities,:SCHOOLING) ||
       isConst?(opponent.ability,PBAbilities,:SHIELDSDOWN)
      @battle.pbDisplay(_INTL("But it failed!"))
      return -1
    end

In Worry Seed:

if isConst?(opponent.ability,PBAbilities,:MULTITYPE) ||
       isConst?(opponent.ability,PBAbilities,:INSOMNIA) ||
       isConst?(opponent.ability,PBAbilities,:STANCECHANGE) ||
       isConst?(opponent.ability,PBAbilities,:TRUANT) ||
       isConst?(opponent.ability,PBAbilities,:DISGUISE) ||
       isConst?(opponent.ability,PBAbilities,:COMATOSE) ||
       [COLOR="red"]isConst?(opponent.ability,PBAbilities,:BATTLEBOND) ||[/COLOR]
       isConst?(opponent.ability,PBAbilities,:RKSSYSTEM) ||
       isConst?(opponent.ability,PBAbilities,:SCHOOLING) ||
       isConst?(opponent.ability,PBAbilities,:SHIELDSDOWN)
      @battle.pbDisplay(_INTL("But it failed!"))
      return -1
    end

In Role Play:

if opponent.ability==0 ||
       attacker.ability==opponent.ability ||
       isConst?(attacker.ability,PBAbilities,:MULTITYPE) ||
       isConst?(attacker.ability,PBAbilities,:STANCECHANGE) ||
       isConst?(opponent.ability,PBAbilities,:FLOWERGIFT) ||
       isConst?(opponent.ability,PBAbilities,:FORECAST) ||
       isConst?(opponent.ability,PBAbilities,:ILLUSION) ||
       isConst?(opponent.ability,PBAbilities,:IMPOSTER) ||
       isConst?(opponent.ability,PBAbilities,:MULTITYPE) ||
       isConst?(opponent.ability,PBAbilities,:STANCECHANGE) ||
       isConst?(opponent.ability,PBAbilities,:TRACE) ||
       isConst?(opponent.ability,PBAbilities,:WONDERGUARD) ||
       isConst?(opponent.ability,PBAbilities,:ZENMODE) ||
       isConst?(opponent.ability,PBAbilities,:DISGUISE) ||
       isConst?(opponent.ability,PBAbilities,:COMATOSE) ||
       [COLOR="red"]isConst?(opponent.ability,PBAbilities,:BATTLEBOND) ||[/COLOR]
       isConst?(opponent.ability,PBAbilities,:POWEROFALCHEMY) ||
       isConst?(opponent.ability,PBAbilities,:RECEIVER) ||
       isConst?(opponent.ability,PBAbilities,:RKSSYSTEM) ||
       isConst?(opponent.ability,PBAbilities,:SCHOOLING) ||
       isConst?(opponent.ability,PBAbilities,:SHIELDSDOWN)
      @battle.pbDisplay(_INTL("But it failed!"))
      return -1
    end

In Entrainment:

if attacker.ability==0 ||
       attacker.ability==opponent.ability ||
       isConst?(opponent.ability,PBAbilities,:FLOWERGIFT) ||
       isConst?(opponent.ability,PBAbilities,:IMPOSTER) ||
       isConst?(opponent.ability,PBAbilities,:MULTITYPE) ||
       isConst?(opponent.ability,PBAbilities,:STANCECHANGE) ||
       isConst?(opponent.ability,PBAbilities,:TRACE) ||
       isConst?(opponent.ability,PBAbilities,:TRUANT) ||
       isConst?(opponent.ability,PBAbilities,:ZENMODE) ||
       isConst?(attacker.ability,PBAbilities,:FLOWERGIFT) ||
       isConst?(attacker.ability,PBAbilities,:FORECAST) ||
       isConst?(attacker.ability,PBAbilities,:ILLUSION) ||
       isConst?(attacker.ability,PBAbilities,:IMPOSTER) ||
       isConst?(attacker.ability,PBAbilities,:STANCECHANGE) ||
       isConst?(attacker.ability,PBAbilities,:TRACE) ||
       isConst?(attacker.ability,PBAbilities,:ZENMODE) ||
       isConst?(opponent.ability,PBAbilities,:COMATOSE) ||
       isConst?(attacker.ability,PBAbilities,:COMATOSE) ||
       [COLOR="red"]isConst?(opponent.ability,PBAbilities,:BATTLEBOND) ||
       isConst?(attacker.ability,PBAbilities,:BATTLEBOND) |[/COLOR]|
       isConst?(opponent.ability,PBAbilities,:POWERCONSTRUCT) ||
       isConst?(attacker.ability,PBAbilities,:POWERCONSTRUCT) ||
       isConst?(attacker.ability,PBAbilities,:POWEROFALCHEMY) ||
       isConst?(attacker.ability,PBAbilities,:RECEIVER) ||
       isConst?(opponent.ability,PBAbilities,:RKSSYSTEM) ||
       isConst?(opponent.ability,PBAbilities,:SCHOOLING) ||
       isConst?(opponent.ability,PBAbilities,:SHIELDSDOWN)

      @battle.pbDisplay(_INTL("But it failed!"))
      return -1
    end

In Skill Swap:

if (attacker.ability==0 && opponent.ability==0) ||
       (attacker.ability==opponent.ability && !USENEWBATTLEMECHANICS) ||
       isConst?(attacker.ability,PBAbilities,:ILLUSION) ||
       isConst?(opponent.ability,PBAbilities,:ILLUSION) ||
       isConst?(attacker.ability,PBAbilities,:MULTITYPE) ||
       isConst?(opponent.ability,PBAbilities,:MULTITYPE) ||
       isConst?(attacker.ability,PBAbilities,:STANCECHANGE) ||
       isConst?(opponent.ability,PBAbilities,:STANCECHANGE) ||
       isConst?(attacker.ability,PBAbilities,:WONDERGUARD) ||
       isConst?(opponent.ability,PBAbilities,:WONDERGUARD) ||
       isConst?(attacker.ability,PBAbilities,:COMATOSE) ||
       isConst?(opponent.ability,PBAbilities,:COMATOSE) ||
       [COLOR="red"]isConst?(attacker.ability,PBAbilities,:BATTLEBOND) ||
       isConst?(opponent.ability,PBAbilities,:BATTLEBOND) ||[/COLOR]
       isConst?(opponent.ability,PBAbilities,:POWERCONSTRUCT) ||
       isConst?(attacker.ability,PBAbilities,:POWERCONSTRUCT) ||
       isConst?(opponent.ability,PBAbilities,:RKSSYSTEM) ||
       isConst?(attacker.ability,PBAbilities,:RKSSYSTEM) ||
       isConst?(opponent.ability,PBAbilities,:SCHOOLING) ||
       isConst?(attacker.ability,PBAbilities,:SCHOOLING) ||
       isConst?(opponent.ability,PBAbilities,:SHIELDSDOWN) ||
       isConst?(attacker.ability,PBAbilities,:SHIELDSDOWN)
      @battle.pbDisplay(_INTL("But it failed!"))
      return -1
    end

In Gastro Acid:

if isConst?(opponent.ability,PBAbilities,:MULTITYPE) ||
       isConst?(opponent.ability,PBAbilities,:STANCECHANGE) ||
       isConst?(opponent.ability,PBAbilities,:DISGUISE) ||
       isConst?(opponent.ability,PBAbilities,:COMATOSE) ||
       [COLOR="red"]isConst?(opponent.ability,PBAbilities,:BATTLEBOND) ||[/COLOR]
       isConst?(opponent.ability,PBAbilities,:POWERCONSTRUCT) ||
       isConst?(opponent.ability,PBAbilities,:RKSSYSTEM) ||
       isConst?(opponent.ability,PBAbilities,:SCHOOLING) ||
       isConst?(opponent.ability,PBAbilities,:SHIELDSDOWN)
      @battle.pbDisplay(_INTL("But it failed!"))
      return -1
    end

In Core Enforcer (if you don't have this, skip):

if opponent.hasMovedThisRound? || @battle.choices[opponent.index][0]==3
      if isConst?(opponent.ability,PBAbilities,:MULTITYPE) ||
       isConst?(opponent.ability,PBAbilities,:STANCECHANGE) ||
       isConst?(opponent.ability,PBAbilities,:DISGUISE) ||
       isConst?(opponent.ability,PBAbilities,:COMATOSE) ||
       [COLOR="Red"]isConst?(opponent.ability,PBAbilities,:BATTLEBOND) ||[/COLOR]
       isConst?(opponent.ability,PBAbilities,:POWERCONSTRUCT) ||
       isConst?(opponent.ability,PBAbilities,:RKSSYSTEM) ||
       isConst?(opponent.ability,PBAbilities,:SCHOOLING) ||
       isConst?(opponent.ability,PBAbilities,:SHIELDSDOWN)
        return
      end
      opponent.effects[PBEffects::GastroAcid]=true
      opponent.effects[PBEffects::Truant]=false
      @battle.pbDisplay(_INTL("{1}'s ability was suppressed!",opponent.pbThis)) 
    end

In Pokemon_Forms, under def def initialize(*args):

Spoiler:

def initialize(*args)
    __mf_initialize(*args)
    f=MultipleForms.call("getFormOnCreation",self)
    if f
      self.form=f
      self.resetMoves
    end
  end
  
  [COLOR="red"]def revertOtherForms
    if isConst?(self.species,PBSpecies,:GRENINJA)[/COLOR] ||
       isConst?(self.species,PBSpecies,:MIMIKYU)
      [COLOR="red"]self.form=0[/COLOR] 
    elsif isConst?(self.species,PBSpecies,:ZYGARDE) && $zygardeform>=0
      self.form=$zygardeform
      $zygardeform=-1
    [COLOR="red"]end
  end[/COLOR]

In PokeBattle_Battle, in def pbThrowPokeBall:

Spoiler:

BallHandlers.onCatch(ball,self,pokemon)
        pokemon.ballused=pbGetBallType(ball)
        ((pokemon.makeUnmega if pokemon.isMega?) rescue nil)
        pokemon.makeUnprimal rescue nil
        [COLOR="red"]pokemon.revertOtherForms rescue nil[/COLOR]
        pokemon.pbRecordFirstMoves

In PField_Battles, in def pbAfterBattle:

Spoiler:

[SIZE="2"]for i in $Trainer.party
    (i.makeUnmega rescue nil); (i.makeUnprimal rescue nil); [COLOR="red"](i.revertOtherForms rescue nil);[/COLOR]
  end
  if $PokemonGlobal.partner
    pbHealAll
    for i in $PokemonGlobal.partner[3]
      i.heal
      (i.makeUnmega rescue nil); (i.makeUnprimal rescue nil); [COLOR="red"](i.revertOtherForms rescue nil);[/COLOR]
    end
  end[/SIZE]

Edit: Now I saw that Poq and WolfPP solved this before me, although we arrived independently to this conclusion.
Edit2: With this code, a Greninja with Battle Bond can activate its ability again in the same battle if it dies, revives and faints an opponent again, which Bulbapedia says it shouldn't happen.

 

[WolfPP]

I made to Ultra Burst (you need Z-move installed):
Z-MOVE:
https://www.pokecommunity.com/showthread.php?t=393813

ULTRA BURST:
https://www.pokecommunity.com/showthread.php?t=417349

 

[Poq]

With this code, a Greninja with Battle Bond can activate its ability again in the same battle if it dies, revives and faints an opponent again, which Bulbapedia says it shouldn't happen.

I've got solution for this! It's not exactly elegant, but it should work - and the good news is that it involves only a slight modification to mybusiness's code. What we need to do is give Greninja a dummy ability that looks just like Battle Bond, but doesn't do anything. I'll explain:

First things first, in abilities.txt, copy the line for Battle Bond at the bottom. Change the ability number to something unused, and change the internal name (the one in all caps) to something distinct but memorable, like XBATTLEBONDX. Leave the display name as is.

Next, in pokemon.txt, assign this ability to Greninja as a second hidden ability.

Now we're ready to get into the code. First, we'll go to PokeBattle_Battler and the code for pbFaint:

Spoiler:

def pbFaint(showMessage=true)
    unless fainted?
      PBDebug.log("!!!***Can't faint with HP greater than 0")
      return true
    end
    if @fainted
#      PBDebug.log("!!!***Can't faint if already fainted")
      return true
    end
    @battle.scene.pbFainted(self)
    pbInitEffects(false)
    # Reset status
    self.status=0
    self.statusCount=0
    if @pokemon && @battle.internalbattle
      @pokemon.changeHappiness("faint")
    end
    @pokemon.makeUnmega if self.isMega?
    @pokemon.makeUnprimal if self.isPrimal?
[COLOR="Red"]    if isConst?(@pokemon.species,PBSpecies,:GRENINJA) && self.form==1
      @pokemon.setability(3)
    @pokemon.revertOtherForms[/COLOR]
    @fainted=true

That will give Greninja it's dummy ability when it faints, but only if it has changed form. So in Greninja's summary, it will still look like it has the usual Battle Bond ability, but if the player revives the Greninja, the dummy ability will not trigger any of the other code to activate Battle Bond.

Next, we need to make it so that the REAL Battle Bond gets reset after battle. Back in PField_Battles, in def pbAfterBattle:

Spoiler:

for i in $Trainer.party
    (i.makeUnmega rescue nil); (i.makeUnprimal rescue nil); [COLOR="red"](i.revertOtherForms rescue nil);
    if isConst?(i.species,PBSpecies,:GRENINJA) && i.ability==3
      i.setAbility(2)[/COLOR]
    end
  end
  if $PokemonGlobal.partner
    pbHealAll
    for i in $PokemonGlobal.partner[3]
      i.heal
      (i.makeUnmega rescue nil); (i.makeUnprimal rescue nil); [COLOR="red"](i.revertOtherForms rescue nil);
      if isConst?(i.species,PBSpecies,:GRENINJA) && i.ability==3
        i.setAbility(2)[/COLOR]
      end
[/COLOR]
    end
  end

This should ensure that Greninja with Battle Bond can only change forms once per battle. I'm sure there is a more coherent way of accomplishing it, but this is what I came up with.

 

[SumiInk]

Poq's script for PokeBattle_Battler seems to be missing an end statement, causing a syntax error.

Here's a fixed version:

Spoiler:

def pbFaint(showMessage=true)
    unless fainted?
      PBDebug.log("!!!***Can't faint with HP greater than 0")
      return true
    end
    if @fainted
#      PBDebug.log("!!!***Can't faint if already fainted")
      return true
    end
    @battle.scene.pbFainted(self)
    pbInitEffects(false)
    # Reset status
    self.status=0
    self.statusCount=0
    if @pokemon && @battle.internalbattle
      @pokemon.changeHappiness("faint")
    end
    @pokemon.makeUnmega if self.isMega?
    @pokemon.makeUnprimal if self.isPrimal?
    if isConst?(@pokemon.species,PBSpecies,:GRENINJA) && self.form==1
      @pokemon.setability(3)
    end
    @pokemon.revertOtherForms
    @fainted=true

Basically, just add an end statement under @pokemon.setability(3) and it should work.