[Scripting Question] Using terrain tags to activate the headbutt tree event

[silentgamer64]

I'm trying to activate headbutt with a terrain tag instead of the usual event because copy/pasting the same headbutt event for more than 10 trees starts to lag my maps.

1. I set the tag for my headbutt trees in the tag editor as tag 20 and created a new terrain tag for HeadbuttTrees in PBTerrain here:

Spoiler:

module PBTerrain
  Ledge           = 1
  Grass           = 2
  Sand            = 3
  Rock            = 4
  DeepWater       = 5
  StillWater      = 6
  Water           = 7
  Waterfall       = 8
  WaterfallCrest  = 9
  TallGrass       = 10
  UnderwaterGrass = 11
  Ice             = 12
  Neutral         = 13
  SootGrass       = 14
  Bridge          = 15
  EncounterFloor  = 16
  SandFootprints  = 17
  Shoreline       = 18
  Puddle          = 19
  HeadbuttTree    = 20

I also created a definition for isHeadbuttTree? near the bottom of PBTerrain with these lines here:

Spoiler:

def PBTerrain.isHeadbuttTree?(tag)
    return tag==PBTerrain::HeadbuttTree
  end

2. In PField_HiddenMoves, I copy pasted a few lines from the waterfall code and changed/simplified it to function with headbutt trees here:

Spoiler:

Events.onAction+=proc{|sender,e|
   terrain=Kernel.pbFacingTerrainTag
   if PBTerrain.isHeadbuttTree?(terrain)
     [S-HIGHLIGHT]Kernel.pbHeadbutt(terrain)[/S-HIGHLIGHT]
     return
   end
}

It works fine up to the point where it prompts you to use headbutt. If you choose no, it's fine. But if you choose yes, it crashes with this error:

Spoiler:

I know I'm very close but I'm not exactly sure how to call the highlighted headbutt event. I've tried pbHeadbutt, pbHeadbuttEffect, etc.
Any help would be appreciated.

 

[Ego13]

pbHeadbuttEffect is responsible for the animation. Since you're not using events anymore it can't execute this script properly. The easiest solution would be to remove that line from def Kernel.pbHeadbutt(event).

 

[silentgamer64]

pbHeadbuttEffect is responsible for the animation. Since you're not using events anymore it can't execute this script properly. The easiest solution would be to remove that line from def Kernel.pbHeadbutt(event).

Thanks! I commented out the Kernel.pbHeadbuttEffect(event) and it stopped throwing the error, but now it looks like I'm not getting any encounters on maps I've defined headbutt encounters for.

Did I miss something?
Code:

Spoiler:

def Kernel.pbHeadbutt(event)
  movefinder=Kernel.pbCheckMove(:HEADBUTT)
  if $DEBUG || movefinder
    if Kernel.pbConfirmMessage(_INTL("A Pokémon could be in this tree. Would you like to use Headbutt?"))
      speciesname=!movefinder ? $Trainer.name : movefinder.name
      Kernel.pbMessage(_INTL("{1} used Headbutt!",speciesname))
      pbHiddenMoveAnimation(movefinder)
      #Kernel.pbHeadbuttEffect(event)
    end
  else
    Kernel.pbMessage(_INTL("A Pokémon could be in this tree. Maybe a Pokémon could shake it."))
  end
  Input.update
  return
end
###Terrain Check
Events.onAction+=proc{|sender,e|
   terrain=Kernel.pbFacingTerrainTag
   if PBTerrain.isHeadbuttTree?(terrain)
     Kernel.pbHeadbutt(terrain)
     return
   end
}
###

Edit: To clarify, it prompts me if I want to use headbutt, and selecting yes doesn't produce the "Nope! Nothing" text or a wild encounter.

 

[Ego13]

Sorry, I got it a bit wrong. What I thought would be for the animation, is actually for the encounters.
This line

a = (event.x+(event.x/24).floor+1)*(event.y+(event.y/24).floor+1)

in Kernel.pbHeadbuttEffect(event) is used to calculate the encounter chance, and which type of Headbutt encounter. It uses the events position (x and y). So you need to replace this with something different, an alternative. If you have done that, reenable the line and it should work

Edit: you could substitute the events x and y with the players x and y

 

[silentgamer64]

Sorry, I got it a bit wrong. What I thought would be for the animation, is actually for the encounters.
This line

a = (event.x+(event.x/24).floor+1)*(event.y+(event.y/24).floor+1)

in Kernel.pbHeadbuttEffect(event) is used to calculate the encounter chance, and which type of Headbutt encounter. It uses the events position (x and y). So you need to replace this with something different, an alternative. If you have done that, reenable the line and it should work

Edit: you could substitute the events x and y with the players x and y

Awesome! I replaced that long equation with a random number since it takes the remainder after dividing the value by 5 anyways:

Spoiler:

def Kernel.pbHeadbuttEffect(event)
  a=(([S-HIGHLIGHT]rand[/S-HIGHLIGHT])/5)%10
  b=($Trainer.id&0xFFFF)%10
  chance=1
  if a==b
    chance=8
  ...

It works like a charm! Thanks Ego!

 

[Ego13]

Awesome! I replaced that long equation with a random number since it takes the remainder after dividing the value by 5 anyways:

Spoiler:

def Kernel.pbHeadbuttEffect(event)
  a=(([S-HIGHLIGHT]rand[/S-HIGHLIGHT])/5)%10
  b=($Trainer.id&0xFFFF)%10
  chance=1
  if a==b
    chance=8
  ...

It works like a charm! Thanks Ego!

Glad i could help :)