Welcome to PokéCommunity! Register now and join one of the best fan communities on the 'net to talk Pokémon and more! We are not affiliated with The Pokémon Company or Nintendo.
I think I would have to say the GBA SP, since you could play all the old generation, also pre 3d GBA pokemon games, which I believe are better than the 3d ones...
ds is win in general for me. it technically can play all generations, frlg, hgss, rse and dpt. though i do love my sp and i prefer playing my gba games on it.