Simple Modifications Directory

[HackerL]

POKEEMERALD: HOW TO CHANGE PLAYER SPRITES/INITIAL SPRITES

In order to change the initial sprites, you need to go to src/field_player_avatar, search for these pointers and change the OBJ_EVENT_GFX to the sprite you want.

Examples: Changing OBJ_EVENT_GFX_BRENDAN_NORMAL to OBJ_EVENT_GFX_SCHOOL_KID

static const u16 sRivalAvatarGfxIds[][2] =

Spoiler:

{
{OBJ_EVENT_GFX_BRENDAN_NORMAL, OBJ_EVENT_GFX_MAY_NORMAL},
{OBJ_EVENT_GFX_BRENDAN_MACH_BIKE, OBJ_EVENT_GFX_MAY_MACH_BIKE},
{OBJ_EVENT_GFX_BRENDAN_ACRO_BIKE, OBJ_EVENT_GFX_MAY_ACRO_BIKE},
{OBJ_EVENT_GFX_BRENDAN_SURFING, OBJ_EVENT_GFX_MAY_SURFING},
{OBJ_EVENT_GFX_BRENDAN_UNDERWATER, OBJ_EVENT_GFX_MAY_UNDERWATER},
{OBJ_EVENT_GFX_BRENDAN_FIELD_MOVE, OBJ_EVENT_GFX_MAY_FIELD_MOVE},
{OBJ_EVENT_GFX_BRENDAN_FISHING, OBJ_EVENT_GFX_MAY_FISHING},
{OBJ_EVENT_GFX_BRENDAN_WATERING, OBJ_EVENT_GFX_MAY_WATERING},
};

static const u16 sRivalAvatarGfxIds[][2] =

Spoiler:

{
{OBJ_EVENT_GFX_RIVAL_BRENDAN_NORMAL, OBJ_EVENT_GFX_RIVAL_MAY_NORMAL},
{OBJ_EVENT_GFX_RIVAL_BRENDAN_MACH_BIKE, OBJ_EVENT_GFX_RIVAL_MAY_MACH_BIKE},
{OBJ_EVENT_GFX_RIVAL_BRENDAN_ACRO_BIKE, OBJ_EVENT_GFX_RIVAL_MAY_ACRO_BIKE},
{OBJ_EVENT_GFX_RIVAL_BRENDAN_SURFING, OBJ_EVENT_GFX_RIVAL_MAY_SURFING},
{OBJ_EVENT_GFX_BRENDAN_UNDERWATER, OBJ_EVENT_GFX_MAY_UNDERWATER},
{OBJ_EVENT_GFX_RIVAL_BRENDAN_FIELD_MOVE, OBJ_EVENT_GFX_RIVAL_MAY_FIELD_MOVE},
{OBJ_EVENT_GFX_BRENDAN_FISHING, OBJ_EVENT_GFX_MAY_FISHING},
{OBJ_EVENT_GFX_BRENDAN_WATERING, OBJ_EVENT_GFX_MAY_WATERING}
};

 

[Dr. POP]

POKEEMERALD: HOW TO CHANGE PLAYER SPRITES/INITIAL SPRITES

In order to change the initial sprites, you need to go to src/field_player_avatar, search for these pointers and change the OBJ_EVENT_GFX to the sprite you want.

Examples: Changing OBJ_EVENT_GFX_BRENDAN_NORMAL to OBJ_EVENT_GFX_SCHOOL_KID

static const u16 sRivalAvatarGfxIds[][2] =

Spoiler:

{
{OBJ_EVENT_GFX_BRENDAN_NORMAL, OBJ_EVENT_GFX_MAY_NORMAL},
{OBJ_EVENT_GFX_BRENDAN_MACH_BIKE, OBJ_EVENT_GFX_MAY_MACH_BIKE},
{OBJ_EVENT_GFX_BRENDAN_ACRO_BIKE, OBJ_EVENT_GFX_MAY_ACRO_BIKE},
{OBJ_EVENT_GFX_BRENDAN_SURFING, OBJ_EVENT_GFX_MAY_SURFING},
{OBJ_EVENT_GFX_BRENDAN_UNDERWATER, OBJ_EVENT_GFX_MAY_UNDERWATER},
{OBJ_EVENT_GFX_BRENDAN_FIELD_MOVE, OBJ_EVENT_GFX_MAY_FIELD_MOVE},
{OBJ_EVENT_GFX_BRENDAN_FISHING, OBJ_EVENT_GFX_MAY_FISHING},
{OBJ_EVENT_GFX_BRENDAN_WATERING, OBJ_EVENT_GFX_MAY_WATERING},
};

static const u16 sRivalAvatarGfxIds[][2] =

Spoiler:

{
{OBJ_EVENT_GFX_RIVAL_BRENDAN_NORMAL, OBJ_EVENT_GFX_RIVAL_MAY_NORMAL},
{OBJ_EVENT_GFX_RIVAL_BRENDAN_MACH_BIKE, OBJ_EVENT_GFX_RIVAL_MAY_MACH_BIKE},
{OBJ_EVENT_GFX_RIVAL_BRENDAN_ACRO_BIKE, OBJ_EVENT_GFX_RIVAL_MAY_ACRO_BIKE},
{OBJ_EVENT_GFX_RIVAL_BRENDAN_SURFING, OBJ_EVENT_GFX_RIVAL_MAY_SURFING},
{OBJ_EVENT_GFX_BRENDAN_UNDERWATER, OBJ_EVENT_GFX_MAY_UNDERWATER},
{OBJ_EVENT_GFX_RIVAL_BRENDAN_FIELD_MOVE, OBJ_EVENT_GFX_RIVAL_MAY_FIELD_MOVE},
{OBJ_EVENT_GFX_BRENDAN_FISHING, OBJ_EVENT_GFX_MAY_FISHING},
{OBJ_EVENT_GFX_BRENDAN_WATERING, OBJ_EVENT_GFX_MAY_WATERING}
};

Chance has it that I am working on this right now. This simple change, however, results in a buggy palette for the player overworld sprite. The correct overworld sprite is displayed, but it appears in blacks, reds and transparent colors. Did I miss something?

Edit: Actually, after a while, the sprites started displaying less weird colors. In fact, it seems to switch through a number of palettes, changing the colors of some details (hat, clothes) but not the color of the skin. The palette switches either at warp points or randomly in the middle of a map, there doesn't seem to be a pattern to it. I have implemented the dynamic overworld palette system, but I'm not sure if that matters.

Edit 2: Solution (as well as addition to the instructions of HackerL):

In pokeemerald\src\data\object_events\object_events_graphics_info.h, change the palette slot of the overworld sprite you want to use for the player to 0 (zero). The palette slot is the number that follows the width and height of the sprite, and precedes the sprite's shadow size. I the example below it is marked in bold, so you find it back easily. Most sprites have a palette slot between 2 and 6 or something. Change it to zero. This is the palette slot reserved for the player avatar. (Note that this will probably mean that the sprite cannot be used for regular NPCs anymore, so if you want to use the sprite for both, you may want to duplicate it. This is done in-game as well for the rival and player sprites of Brendan and May.)

This also applies if you have implemented the dynamic overworld palette system. If you change the sprite of the rival, make sure to change its (so of the new sprite you will use) palette slot to 10 (ten).

For example, I want to use the "artist" sprite as the player avatar:

In field_player_avatar.c :

static const u8 sRivalAvatarGfxIds[][2] =
{
    {[B]OBJ_EVENT_GFX_ARTIST[/B],     				 OBJ_EVENT_GFX_RIVAL_MAY_NORMAL},
    {OBJ_EVENT_GFX_RIVAL_BRENDAN_MACH_BIKE,  OBJ_EVENT_GFX_RIVAL_MAY_MACH_BIKE},
    {OBJ_EVENT_GFX_RIVAL_BRENDAN_ACRO_BIKE,  OBJ_EVENT_GFX_RIVAL_MAY_ACRO_BIKE},
    {OBJ_EVENT_GFX_RIVAL_BRENDAN_SURFING,    OBJ_EVENT_GFX_RIVAL_MAY_SURFING},
    {OBJ_EVENT_GFX_BRENDAN_UNDERWATER,       OBJ_EVENT_GFX_MAY_UNDERWATER},
    {OBJ_EVENT_GFX_RIVAL_BRENDAN_FIELD_MOVE, OBJ_EVENT_GFX_RIVAL_MAY_FIELD_MOVE},
    {OBJ_EVENT_GFX_BRENDAN_FISHING,          OBJ_EVENT_GFX_MAY_FISHING},
    {OBJ_EVENT_GFX_BRENDAN_WATERING,         OBJ_EVENT_GFX_MAY_WATERING}
};

static const u8 sPlayerAvatarGfxIds[][2] =
{
    {[B]OBJ_EVENT_GFX_ARTIST[/B],     		   OBJ_EVENT_GFX_MAY_NORMAL}, // edited
    {OBJ_EVENT_GFX_BRENDAN_MACH_BIKE,  OBJ_EVENT_GFX_MAY_MACH_BIKE},
    {OBJ_EVENT_GFX_BRENDAN_ACRO_BIKE,  OBJ_EVENT_GFX_MAY_ACRO_BIKE},
    {OBJ_EVENT_GFX_BRENDAN_SURFING,    OBJ_EVENT_GFX_MAY_SURFING},
    {OBJ_EVENT_GFX_BRENDAN_UNDERWATER, OBJ_EVENT_GFX_MAY_UNDERWATER},
    {OBJ_EVENT_GFX_BRENDAN_FIELD_MOVE, OBJ_EVENT_GFX_MAY_FIELD_MOVE},
    {OBJ_EVENT_GFX_BRENDAN_FISHING,    OBJ_EVENT_GFX_MAY_FISHING},
    {OBJ_EVENT_GFX_BRENDAN_WATERING,   OBJ_EVENT_GFX_MAY_WATERING},

In object_events_graphics_info.h :

const struct ObjectEventGraphicsInfo gObjectEventGraphicsInfo_Artist = {0xFFFF, OBJ_EVENT_PAL_TAG_3, OBJ_EVENT_PAL_TAG_NONE, 256, 16, 32, [B]0[/B], SHADOW_SIZE_M, FALSE, FALSE, TRACKS_FOOT, &gObjectEventBaseOam_16x32, gObjectEventSpriteOamTables_16x32, gObjectEventImageAnimTable_Standard, gObjectEventPicTable_Artist, gDummySpriteAffineAnimTable};

 

[Buffel Saft]

Berry Trees No Longer Disappear (Emerald)​

Once fully grown, berry trees in Gen III and IV regrow a set number of times and then disappear forever. In XY this was changed so that once they have berries on them, they stay that way until the player picks them.
To implement this in pokeemerald, go to src/berry.c and make the following changes:

In function BerryTreeGrow, remove the entire BERRY_STAGE_BERRIES case:

Spoiler:

[COLOR="Green"]/*     case BERRY_STAGE_BERRIES:
        tree->watered1 = 0;
        tree->watered2 = 0;
        tree->watered3 = 0;
        tree->watered4 = 0;
        tree->berryYield = 0;
        tree->stage = BERRY_STAGE_SPROUTED;
        if (++tree->regrowthCount == 10)
            *tree = gBlankBerryTree;
        break;  */[/COLOR]

In function BerryTreeTimeUpdate, add another condition to the first if statement (shown in bold) and remove the if statement that checks how long ago the berry tree was planted.

Spoiler:

void BerryTreeTimeUpdate(s32 minutes)
{
    int i;
    struct BerryTree *tree;

    for (i = 0; i < BERRY_TREES_COUNT; i++)
    {
        tree = &gSaveBlock1Ptr->berryTrees[i];

        if (tree->berry && tree->stage && !tree->growthSparkle [B]&& (tree->stage != BERRY_STAGE_BERRIES)[/B])
        {
[COLOR="Green"]/*              if (minutes >= GetStageDurationByBerryType(tree->berry) * 71)
            {
                *tree = gBlankBerryTree;
            }
            else */[/COLOR]
                s32 time = minutes;

                while (time != 0)
                {
                    if (tree->minutesUntilNextStage > time)
                    {
                        tree->minutesUntilNextStage -= time;
                        break;
                    }
                    time -= tree->minutesUntilNextStage;
                    tree->minutesUntilNextStage = GetStageDurationByBerryType(tree->berry);
                    if (!BerryTreeGrow(tree))
                        break;
                    if (tree->stage == BERRY_STAGE_BERRIES)
                        tree->minutesUntilNextStage *= 4;
                }
        }
    }
}

These changes can also be viewed as a commit here.

 

[dazblue]

Make eggs hatch at level 1 instead of 5

I noticed no one posted this already, to do this go to 'include/constants/daycare.h'

Line 17:

#define EGG_HATCH_LEVEL 5

Fairly self-explanatory lol change the 5 to 1

 

[ghoulslash]

[Pokefirered] Dive

A lot of the code already existed in FR and the rest could be copied from pokeem so I didn't think this deserved its own thread. However, gamefreak decided to be super dumb and make sPlayerAvatarGfxIds inconsistent with the player avatar flags, so I ended up changing almost all of the calls to GetPlayerAvatarGraphicsIdByStateId. So I won't be posting the code changes, instead just the repo

Here's a GIF:

How to Add

• git remote add ghoulslash https://github.com/ghoulslash/pokefirered.git
• git pull ghoulslash dive

How to customize dive sprite:
The default dive sprite is the player surfing (with no surf blob). To change this, change the OBJ_EVENT_GFX defines next to PLAYER_AVATAR_STATE_UNDERWATER in sPlayerAvatarGfxIds, as well as the second OBJ_EVENT_GFX surf defines in sPlayerAvatarGfxToStateFlag. Both of these are found in src/field_player_avatar.c

Please report any problems. I tested most of the avatar flag related stuff to make sure it worked properly, but there could be a case I overlooked.

 

[DragonKiller707]

Allow specifying multi-choice options in scripts (Pokeemerald):

Not sure if anyone has posted something like this.

Code Modifications:

Spoiler:

Add a new event macro:

asm/macros/event.inc

	.macro bufferitemnameplural out:req, item:req, quantity:req
	.byte 0xe2
	.byte \out
	.2byte \item
	.2byte \quantity
	.endm

[COLOR="Red"]	.macro multichoice_dynamic x:req, y:req, list:req, b:req, default=0
	.byte 0xe3
	.byte \x
	.byte \y
	.byte \b
	.byte \default
	.4byte \list
	.endm[/COLOR]

Add a new source command, as we need to be able to read in a full word:

data/script_cmd_table.inc

	.4byte ScrCmd_bufferitemnameplural
[COLOR="Red"]	.4byte ScrCmd_multichoice_dynamic[/COLOR]

include/script_menu.h

bool8 ScriptMenu_MultichoiceWithDefault(u8 left, u8 top, u8 multichoiceId, bool8 ignoreBPress, u8 defaultChoice);
[COLOR="Red"]bool8 ScriptMenu_MultichoiceDynamic(u8 left, u8 top, const u8 **multichoiceTexts, u8 multichoiceCount, bool8 ignoreBPress, u8 defaultChoice);[/COLOR]

src/srcmd.c

bool8 ScrCmd_multichoice(struct ScriptContext *ctx)
{
...
}

[COLOR="Red"]bool8 ScrCmd_multichoice_dynamic(struct ScriptContext *ctx)
{
    u8 left = ScriptReadByte(ctx);
    u8 top = ScriptReadByte(ctx);
    u8 ignoreBPress = ScriptReadByte(ctx);
    u8 defaultChoice = ScriptReadByte(ctx);
    const u8 **options = (const u8 **)ScriptReadWord(ctx);
    u8 count = 0;
    while (options[count])
        ++count;

    if (ScriptMenu_MultichoiceDynamic(left, top, options, count,
                                      ignoreBPress, defaultChoice) == TRUE)
    {
        ScriptContext1_Stop();
        return TRUE;
    }
    return FALSE;
}[/COLOR]

Add a handler in the script menu:
This is mostly just refactoring the code a bit to allow for calling with a dynamic option count.

src/script_menu.c

[COLOR="Red"]static void DrawMultichoiceMenuImpl(u8 left, u8 top, u8 count, const struct MenuAction *actions,
                                    u8 multichoiceId, bool8 ignoreBPress, u8 cursorPos);[/COLOR]
static void DrawMultichoiceMenu(u8 left, u8 top, u8 multichoiceId, bool8 ignoreBPress, u8 cursorPos);

...

bool8 ScriptMenu_Multichoice(u8 left, u8 top, u8 multichoiceId, bool8 ignoreBPress)
{
...
}

[COLOR="Red"]bool8 ScriptMenu_MultichoiceDynamic(u8 left, u8 top, const u8 **multichoiceTexts, u8 multichoiceCount, bool8 ignoreBPress, u8 defaultChoice)
{
    struct MenuAction actions[multichoiceCount];
    int i;
    if (FuncIsActiveTask(Task_HandleMultichoiceInput) == TRUE)
        return FALSE;
    gSpecialVar_Result = 0xFF;
    for (i = 0; i < multichoiceCount; i++)
        actions[i].text = multichoiceTexts[i];
    DrawMultichoiceMenuImpl(left, top, multichoiceCount, actions, MULTI_UNUSED_9, ignoreBPress, defaultChoice);
    return TRUE;
}[/COLOR]

...

static void DrawMultichoiceMenu(u8 left, u8 top, u8 multichoiceId, bool8 ignoreBPress, u8 cursorPos)
{
[COLOR="Red"]    u8 count = sMultichoiceLists[multichoiceId].count;
    const struct MenuAction *actions = sMultichoiceLists[multichoiceId].list;
    DrawMultichoiceMenuImpl(left, top, count, actions, multichoiceId, ignoreBPress, cursorPos);
}

static void DrawMultichoiceMenuImpl(u8 left, u8 top, u8 count, const struct MenuAction *actions,
                                    u8 multichoiceId, bool8 ignoreBPress, u8 cursorPos)
{
    int i;
    u8 windowId;
    int width = 0;
    u8 newWidth;

    for (i = 0; i < count; i++)
        width = DisplayTextAndGetWidth(actions[i].text, width);

    newWidth = ConvertPixelWidthToTileWidth(width);
    left = ScriptMenu_AdjustLeftCoordFromWidth(left, newWidth);
    windowId = CreateWindowFromRect(left, top, newWidth, count * 2);
    SetStandardWindowBorderStyle(windowId, 0);
    PrintMenuTable(windowId, count, actions);
    InitMenuInUpperLeftCornerPlaySoundWhenAPressed(windowId, count, cursorPos);
    schedule_bg_copy_tilemap_to_vram(0);
    InitMultichoiceCheckWrap(ignoreBPress, count, windowId, multichoiceId);
}[/COLOR]

Example usage:

Spoiler:

Test_EventScript_TestOptions::
	lockall
	faceplayer
	multichoice_dynamic 20, 8, Test_Options, 1
	releaseall
	end

@ Options are specified as a null-terminated list of text references.
	.align 4
Test_Options:
	.4byte Text_Option1
	.4byte Text_Option2
	.4byte 0

Text_Option1::
	.string "This is option 1.$"
Text_Option2::
	.string "This is option 2.$"

 

[Robinlukke]

[EM] Always inherit nature when holding an Everstone​

Pretty simple. At src/daycare.c search for :

if (GetBoxMonData(&daycare->mons[parent].mon, MON_DATA_HELD_ITEM) != ITEM_EVERSTONE
|| Random() >= USHRT_MAX / 2)

Then delete " / 2"

It should look like this:

if (GetBoxMonData(&daycare->mons[parent].mon, MON_DATA_HELD_ITEM) != ITEM_EVERSTONE
|| Random() >= USHRT_MAX)

Now when a parent is holding an Everstone, the offspring will inherit its nature 100% of the time (only females or Ditto tough, I'm still trying to figure how to change that).

 

[takyon]

(only females or Ditto tough, I'm still trying to figure how to change that).

[EM] Always inherit nature when holding an Everstone​

That's because in vanilla code Emerald checks only if female parents or Dittos to hold everstones.

static u8 GetParentToInheritNature(struct DayCare *daycare)
{
    u16 motherItem = GetBoxMonData(&daycare->mons[0].mon, MON_DATA_HELD_ITEM);
    u16 fatherItem = GetBoxMonData(&daycare->mons[1].mon, MON_DATA_HELD_ITEM);
    if(motherItem == ITEM_EVERSTONE && fatherItem == ITEM_EVERSTONE)
    {
    	if (Random() >= USHRT_MAX / 2)
            return 0;
        else
            return 1;
    }else
    {
    	if(motherItem == ITEM_EVERSTONE)
    	{
    		return 0;
    	}
    	if(fatherItem == ITEM_EVERSTONE)
    	{
    		return 1;
    	}
    }
    return 2;
}

I also changed the code to have it return u8 instead of s32, because I didn't find any reason for it to have that.
This means _TriggerPendingDaycareEgg has to be changed. Only two lines need to be changed.

static void _TriggerPendingDaycareEgg(struct DayCare *daycare)
{
    [COLOR="DarkRed"]u8 parent;[/COLOR]
    s32 natureTries = 0;

    SeedRng2(gMain.vblankCounter2);
    parent = GetParentToInheritNature(daycare);

    // don't inherit nature
    [COLOR="DarkRed"]if (parent > 1)[/COLOR]
    {
        daycare->offspringPersonality = (Random2() << 16) | ((Random() % 0xfffe) + 1);
    }
    // inherit nature
    else
    {
        u8 wantedNature = GetNatureFromPersonality(GetBoxMonData(&daycare->mons[parent].mon, MON_DATA_PERSONALITY, NULL));
        
        u32 personality;

        do
        {
            personality = (Random2() << 16) | (Random());
            if (wantedNature == GetNatureFromPersonality(personality) && personality != 0)
                break; // found a personality with the same nature

            natureTries++;
        } while (natureTries <= 2400);

        daycare->offspringPersonality = personality;
    }

    FlagSet(FLAG_PENDING_DAYCARE_EGG);
}

 

[ghoulslash]

[Pokeemerald] New Movement Actions

This adds new scripting movements, including walking and jumping backwards. See asm/macros/movement.inc for the names to use in scripts. New diagonal movements were not added since some diagonal movements already exist in emerald. This should also be relatively easy to add to pokefirered, if there are interested parties.

Here is the repo.

How to Add:

• git remote add ghoulslash https://github.com/ghoulslash/pokeemerald
• git pull ghoulslash new_movement_actions

Credits:
jiangzhengwenjzw for the source

 

[PokemonCrazy]

IV Checker NPC [EM]​

If there's a better way to do this, please let me know! I'm rather new to decomp stuff, but wanted to try this out.​

In data\scripts.inc, add these lines:

	def_special GetHpIV
	def_special GetAtkIV
	def_special GetDefIV
	def_special GetSpAtkIV
	def_special GetSpDefIV
	def_special GetSpeedIV

In src\pokemon.c (or any file in src that has access to pokemon.h), add these lines:

u16 GetHpIV(void)
{
	return GetMonData(&gPlayerParty[GetLeadMonIndex()], MON_DATA_HP_IV, NULL);
}
u16 GetAtkIV(void)
{
	return GetMonData(&gPlayerParty[GetLeadMonIndex()], MON_DATA_ATK_IV, NULL);
}
u16 GetDefIV(void)
{
	return GetMonData(&gPlayerParty[GetLeadMonIndex()], MON_DATA_DEF_IV, NULL);
}
u16 GetSpAtkIV(void)
{
	return GetMonData(&gPlayerParty[GetLeadMonIndex()], MON_DATA_SPATK_IV, NULL);
}
u16 GetSpDefIV(void)
{
	return GetMonData(&gPlayerParty[GetLeadMonIndex()], MON_DATA_SPDEF_IV, NULL);
}
u16 GetSpeedIV(void)
{
	return GetMonData(&gPlayerParty[GetLeadMonIndex()], MON_DATA_SPEED_IV, NULL);
}

Then, add these scripts to whatever map's scripts.inc that you want the IV Checker to be in.

Script_IVChecker::
	lock
	faceplayer
	bufferpartymonnick 0, 0
	msgbox Text_IVChecker_1, MSGBOX_DEFAULT
	specialvar VAR_RESULT, GetHpIV
	buffernumberstring 0, VAR_RESULT
	specialvar VAR_RESULT, GetAtkIV
	buffernumberstring 1, VAR_RESULT
	specialvar VAR_RESULT, GetDefIV
	buffernumberstring 2, VAR_RESULT
	msgbox Text_IVChecker_2, MSGBOX_DEFAULT
	specialvar VAR_RESULT, GetSpAtkIV
	buffernumberstring 0, VAR_RESULT
	specialvar VAR_RESULT, GetSpDefIV
	buffernumberstring 1, VAR_RESULT
	specialvar VAR_RESULT, GetSpeedIV
	buffernumberstring 2, VAR_RESULT
	msgbox Text_IVChecker_3, MSGBOX_DEFAULT
	release
	end

Text_IVChecker_1:
	.string "Your {STR_VAR_1}...$"

Text_IVChecker_2:
	.string "Its HP IV is {STR_VAR_1}.\p"
	.string "Its Attack IV is {STR_VAR_2}.\p"
	.string "Its Defense IV is {STR_VAR_3}.$"

Text_IVChecker_3:
	.string "Its Special Attack IV is {STR_VAR_1}.\p"
	.string "Its Special Defense IV is {STR_VAR_2}.\p"
	.string "Its Speed IV is {STR_VAR_3}.\n"
	.string "You're welcome.$"

Add Script_IVChecker to an NPC (I used PoryMap to do this), and talk to the NPC. Your result should look like this!

 

[ghoulslash]

[Pokeemerald] Auto-Run

Toggle an Auto-Run feature with the R-Button!

The repo.

• git remote add ghoulslash https://github.com/ghoulslash/pokeemerald
• git pull ghoulslash auto-run

Notes:

Spoiler:

• To keep it consistent with the base game, nothing will happen from pressing R until FLAG_SYS_B_DASH is set.
  • To remove this, remove the following code from src/field_control_avatar.c at line 1017:
    

    if (!FlagGet(FLAG_SYS_B_DASH))
        return FALSE;

  • And the following code from src/field_player_avatar.c at like 645:
    

    && FlagGet(FLAG_SYS_B_DASH)

• To change the activating button from R to L, for example, change the following:
  • bool8 pressedRButton:1; to bool8 pressedLButton:1; in include/field_control_avatar.h at line 14
  • input->pressedRButton = FALSE; to input->pressedLButton = FALSE; in src/control_avatar.c at line 84
  • The following in src/field_control_avatar.c at line 110:
    

    if (newKeys & R_BUTTON)
        input->pressedRButton = TRUE;

    To:
    

    if (newKeys & L_BUTTON)
        input->pressedLButton = TRUE;

  • And finally, the following in src/field_control_avatar.c at line 195
    

    if (input->pressedRButton && EnableAutoRun())

    To:
    

    if (input->pressedLButton && EnableAutoRun())

• I've been asked a couple times how to replace the Button Mode options feature with a Run Mode feature. Here's a big quote from me on how to do that:
  Spoiler:

  The text is easy enough to replace so I won't go into detail. But the main functions you need to change are [i]ButtonMode_ProcessInput[/i] and [i]ButtonMode_DrawChoices[/i] in [i]src/options.c[/i].
  in the processinput one, change [i]if (selection <= 1)[/i] to [i]if (selection < 1)[/i] and [i]selection = 2;[/i] to [i]selection = 1;[/i] to limit the choices from 3 to 2.  in [i]ButtonMode_DrawChoices[/i], remove [i]widthLA = GetStringWidth(1, gText_ButtonTypeLEqualsA, 0);[/i], change [i]xLR = (widthNormal - widthLR - widthLA) / 2 + 104;[/i] to [i]DrawOptionMenuChoice(gText_ButtonTypeLR, GetStringRightAlignXOffset(1, gText_ButtonTypeLR, 198), YPOS_BUTTONMODE, styles[1]);[/i] and remove [i]DrawOptionMenuChoice(gText_ButtonTypeLEqualsA, GetStringRightAlignXOffset(1, gText_ButtonTypeLEqualsA, 198), YPOS_BUTTONMODE, styles[2]);[/i] And obviously change [i]gText_ButtonTypeNormal[/i] and others to what you want
  finally, any instance of [i]gSaveBlock2Ptr->optionsButtonMode[/i] change to [i]gSaveBlock2Ptr->autoRun[/i]. you can change [i]TD_BUTTONMODE[/i] to [i]TD_RUNMODE[/i] or something too  for consistency.
  that changes the options menu. Then, in [i]src/field_player_avatar.c[/i] line 645 you'll want to replace [i](heldKeys & B_BUTTON || gSaveBlock2Ptr->autoRun)[/i] with a function like [i]IsPlayerTryingToRun(u16 heldKeys)[/i] or something, that would look like:
  [code]
  static bool8 IsPlayerTryingToRun(u16 heldKeys)
  {
    if (gSaveBlock2Ptr->autoRun)
      return TRUE;
    else if (heldKeys & B_BUTTON)
        return TRUE;
    return FALSE;
  }

  so, if gSaveBlock2Ptr->autoRun is in toggle mode, the player runs if they can. otherwise, they have to hold B. Add this function somewhere above PlayerNotOnBikeMoving and compile!
  [/code]

 

[takyon]

in ButtonMode_DrawChoices, remove widthLA = GetStringWidth(1, gText_ButtonTypeLEqualsA, 0);, change xLR = (widthNormal - widthLR - widthLA) / 2 + 104; to xLR = (widthNormal - widthLR) / 2 + 104; (maybe? this is just an x position so you can play around with the 104 value).

I'd change it to

 DrawOptionMenuChoice(gText_ButtonTypeLR, GetStringRightAlignXOffset(1, gText_ButtonTypeLR, 198), YPOS_BUTTONMODE, styles[1]);

So that it is aligned at the right side of the screen like the rest of the options

 

[Lunos]

DPPt Bike (a 2-in-1 Bike) [Em]
This is pretty nice and simple. It allows you to swap between the Mach Bike and the Acro Bike by pressing the R Button in the overworld.
The code was originally written by Blurose, so the credits go to him. I simply checked if it worked in Pokeemerald, and since it does, I decided to come and share it here with his permission.

Do note that the Mach Bike breaks with this implementation. The correct bike to use is the Acro Bike specifically.
Needless to say, things like the Sound Effect casted when swapping from a bike mode to the other or even the button you have to press to change modes can be changed as y'all see fit.

To incorporate this feature branch into your project execute the following commands:

git remote add lunos https://github.com/LOuroboros/pokeemerald
git pull lunos gen4_bike

Video:


And that's pretty much it.

Bugs:
-When entering a menu while riding a bike, the latter always resets to the Acro Bike (reported by Bidoof right here)
Fixed: https://github.com/LOuroboros/pokeemerald/commit/881b033603fa899d96e3bc9133a4afecc990f26a
​

 

[takyon]

Destiny Knot IV Inheritance Implementation[Em]
​

This should work with DizzyEgg's item_expansion repo, and should also work as long as you have ITEM_DESTINY_KNOT
All you need to edit is include/constants/daycare.h and have:

#define DESTINY_KNOT_INHERITED_IV_COUNT 5

And next, go to src/daycare.c and add this before u8 i on static void InheritIVs

    u32 motherItem = GetBoxMonData(&daycare->mons[0].mon, MON_DATA_HELD_ITEM);
    u32 fatherItem = GetBoxMonData(&daycare->mons[1].mon, MON_DATA_HELD_ITEM);
    u8 inheritNum = (motherItem == ITEM_DESTINY_KNOT || fatherItem == ITEM_DESTINY_KNOT) ? DESTINY_KNOT_INHERITED_IV_COUNT: INHERITED_IV_COUNT;

Then change any instance of INHERITED_IV_COUNT in InheritIVs to inheritNum (after u8 i obviously)
That's about it. Here's the entire code for static void InheritIVs if it was difficult to follow.

Spoiler:

static void InheritIVs(struct Pokemon *egg, struct DayCare *daycare)
{
    u32 motherItem = GetBoxMonData(&daycare->mons[0].mon, MON_DATA_HELD_ITEM);
    u32 fatherItem = GetBoxMonData(&daycare->mons[1].mon, MON_DATA_HELD_ITEM);
    u8 inheritNum = (motherItem == ITEM_DESTINY_KNOT || fatherItem == ITEM_DESTINY_KNOT) ? DESTINY_KNOT_INHERITED_IV_COUNT: INHERITED_IV_COUNT;
    
    u8 i;
    u8 selectedIvs[inheritNum];
    u8 availableIVs[NUM_STATS];
    u8 whichParents[inheritNum];
    u8 iv;

    // Initialize a list of IV indices.
    for (i = 0; i < NUM_STATS; i++)
    {
        availableIVs[i] = i;
    }

    // Select the 3 IVs that will be inherited.
    for (i = 0; i < inheritNum; i++)
    {
        // Randomly pick an IV from the available list and stop from being chosen again.
        selectedIvs[i] = availableIVs[Random() % (NUM_STATS - i)];
        RemoveIVIndexFromList(availableIVs, i);
    }

    // Determine which parent each of the selected IVs should inherit from.
    for (i = 0; i < inheritNum; i++)
    {
        whichParents[i] = Random() % DAYCARE_MON_COUNT;
    }

    // Set each of inherited IVs on the egg mon.
    for (i = 0; i < inheritNum; i++)
    {
        switch (selectedIvs[i])
        {
            case 0:
                iv = GetBoxMonData(&daycare->mons[whichParents[i]].mon, MON_DATA_HP_IV);
                SetMonData(egg, MON_DATA_HP_IV, &iv);
                break;
            case 1:
                iv = GetBoxMonData(&daycare->mons[whichParents[i]].mon, MON_DATA_ATK_IV);
                SetMonData(egg, MON_DATA_ATK_IV, &iv);
                break;
            case 2:
                iv = GetBoxMonData(&daycare->mons[whichParents[i]].mon, MON_DATA_DEF_IV);
                SetMonData(egg, MON_DATA_DEF_IV, &iv);
                break;
            case 3:
                iv = GetBoxMonData(&daycare->mons[whichParents[i]].mon, MON_DATA_SPEED_IV);
                SetMonData(egg, MON_DATA_SPEED_IV, &iv);
                break;
            case 4:
                iv = GetBoxMonData(&daycare->mons[whichParents[i]].mon, MON_DATA_SPATK_IV);
                SetMonData(egg, MON_DATA_SPATK_IV, &iv);
                break;
            case 5:
                iv = GetBoxMonData(&daycare->mons[whichParents[i]].mon, MON_DATA_SPDEF_IV);
                SetMonData(egg, MON_DATA_SPDEF_IV, &iv);
                break;
        }
    }
}

If someone could test this out I'd appreciate it.

 

[PokemonCrazy]

If someone could test this out I'd appreciate it.

Funny enough, I was working on this last night with very similar code. For some reason, it was only inheriting 4 IVs instead of 5. I'll give your code a shot and see if it's any different.

EDIT: Tried your code instead of mine, it still only inherits 4 IVs.
Also, apologies for double-post, my first post wasn't showing. Second post is deleted.

 

[PokemonCrazy]

Showing IVs/EVs in Summary Screen [EM]​

All of the code for this belongs in src\pokemon_summary_screen.c.

Find sStatsLeftColumnLayout (line 773 for me) and paste this below it:

static const u8 sStatsLeftColumnLayoutIVEV[] = _("{DYNAMIC 0}\n{DYNAMIC 1}\n{DYNAMIC 2}");

This is pretty much just to get rid of the "/" in the HP value.

Old way, where the stats are shown based on holding L/R as the stats screen loads:

Spoiler:

Now, find BufferLeftColumnStats(void).
If you are using DizzyEgg's colored-nature mod, replace that method with this:

Spoiler:

static void BufferLeftColumnStats(void)
{
	u8 *currentHPString = Alloc(20);
	u8 *maxHPString = Alloc(20);
	u8 *attackString = Alloc(20);
	u8 *defenseString = Alloc(20);

	u8 hpIV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_HP_IV);
	u8 atkIV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_ATK_IV);
	u8 defIV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_DEF_IV);

	u8 hpEV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_HP_EV);
	u8 atkEV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_ATK_EV);
	u8 defEV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_DEF_EV);

	const s8 *natureMod = gNatureStatTable[sMonSummaryScreen->summary.nature];

	DynamicPlaceholderTextUtil_Reset();

	if (gMain.heldKeys & R_BUTTON) {
		BufferStat(currentHPString, 0, hpIV, 0, 7);
		BufferStat(attackString, 0, atkIV, 1, 7);
		BufferStat(defenseString, 0, defIV, 2, 7);
		DynamicPlaceholderTextUtil_ExpandPlaceholders(gStringVar4, sStatsLeftColumnLayoutIVEV);
	}
	else if (gMain.heldKeys & L_BUTTON) {
		BufferStat(currentHPString, 0, hpEV, 0, 7);
		BufferStat(attackString, 0, atkEV, 1, 7);
		BufferStat(defenseString, 0, defEV, 2, 7);
		DynamicPlaceholderTextUtil_ExpandPlaceholders(gStringVar4, sStatsLeftColumnLayoutIVEV);
	}
	else {
		BufferStat(currentHPString, 0, sMonSummaryScreen->summary.currentHP, 0, 3);
		BufferStat(maxHPString, 0, sMonSummaryScreen->summary.maxHP, 1, 3);
		BufferStat(attackString, natureMod[STAT_ATK - 1], sMonSummaryScreen->summary.atk, 2, 7);
		BufferStat(defenseString, natureMod[STAT_DEF - 1], sMonSummaryScreen->summary.def, 3, 7);
		DynamicPlaceholderTextUtil_ExpandPlaceholders(gStringVar4, sStatsLeftColumnLayout);
	}

    Free(currentHPString);
    Free(maxHPString);
    Free(attackString);
    Free(defenseString);
}

If you're not using DizzyEgg's colored-nature mod, use this code instead:

Spoiler:

static void BufferLeftColumnStats(void)
{
    u8 *currentHPString = Alloc(8);
    u8 *maxHPString = Alloc(8);
    u8 *attackString = Alloc(8);
    u8 *defenseString = Alloc(8);
    
    u8 hpIV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_HP_IV);
    u8 atkIV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_ATK_IV);
    u8 defIV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_DEF_IV);

    u8 hpEV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_HP_EV);
    u8 atkEV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_ATK_EV);
    u8 defEV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_DEF_EV);
    
    DynamicPlaceholderTextUtil_Reset();

    if (gMain.heldKeys & R_BUTTON) {
        ConvertIntToDecimalStringN(currentHPString, hpIV, STR_CONV_MODE_RIGHT_ALIGN, 7);
        ConvertIntToDecimalStringN(attackString, atkIV, STR_CONV_MODE_RIGHT_ALIGN, 7);
        ConvertIntToDecimalStringN(defenseString, defIV, STR_CONV_MODE_RIGHT_ALIGN, 7);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(0, currentHPString);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(1, attackString);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(2, defenseString);
        DynamicPlaceholderTextUtil_ExpandPlaceholders(gStringVar4, sStatsLeftColumnLayoutIVEV);
    }
    else if (gMain.heldKeys & L_BUTTON) {
        ConvertIntToDecimalStringN(currentHPString, hpEV, STR_CONV_MODE_RIGHT_ALIGN, 7);
        ConvertIntToDecimalStringN(attackString, atkEV, STR_CONV_MODE_RIGHT_ALIGN, 7);
        ConvertIntToDecimalStringN(defenseString, defEV, STR_CONV_MODE_RIGHT_ALIGN, 7);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(0, currentHPString);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(1, attackString);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(2, defenseString);
        DynamicPlaceholderTextUtil_ExpandPlaceholders(gStringVar4, sStatsLeftColumnLayoutIVEV);
    }
    else {
        ConvertIntToDecimalStringN(currentHPString, sMonSummaryScreen->summary.currentHP, STR_CONV_MODE_RIGHT_ALIGN, 3);
        ConvertIntToDecimalStringN(maxHPString, sMonSummaryScreen->summary.maxHP, STR_CONV_MODE_RIGHT_ALIGN, 3);
        ConvertIntToDecimalStringN(attackString, sMonSummaryScreen->summary.atk, STR_CONV_MODE_RIGHT_ALIGN, 7);
        ConvertIntToDecimalStringN(defenseString, sMonSummaryScreen->summary.def, STR_CONV_MODE_RIGHT_ALIGN, 7);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(0, currentHPString);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(1, maxHPString);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(2, attackString);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(3, defenseString);
        DynamicPlaceholderTextUtil_ExpandPlaceholders(gStringVar4, sStatsLeftColumnLayout);
    }

    Free(currentHPString);
    Free(maxHPString);
    Free(attackString);
    Free(defenseString);
}

Now, find BufferRightColumnStats(void).
Again, if you are using DizzyEgg's colored-nature mod, replace that method with this:

Spoiler:

static void BufferRightColumnStats(void)
{
	u8 spAIV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPATK_IV);
	u8 spDIV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPDEF_IV);
	u8 speIV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPEED_IV);

	u8 spAEV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPATK_EV);
	u8 spDEV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPDEF_EV);
	u8 speEV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPEED_EV);

    const s8 *natureMod = gNatureStatTable[sMonSummaryScreen->summary.nature];

    DynamicPlaceholderTextUtil_Reset();    
	
	if (gMain.heldKeys & R_BUTTON) {
		BufferStat(gStringVar1, 0, spAIV, 0, 3);
		BufferStat(gStringVar2, 0, spDIV, 1, 3);
		BufferStat(gStringVar3, 0, speIV, 2, 3);
	}
	else if (gMain.heldKeys & L_BUTTON) {
		BufferStat(gStringVar1, 0, spAEV, 0, 3);
		BufferStat(gStringVar2, 0, spDEV, 1, 3);
		BufferStat(gStringVar3, 0, speEV, 2, 3);
	}
	else {
		BufferStat(gStringVar1, natureMod[STAT_SPATK - 1], sMonSummaryScreen->summary.spatk, 0, 3);
		BufferStat(gStringVar2, natureMod[STAT_SPDEF - 1], sMonSummaryScreen->summary.spdef, 1, 3);
		BufferStat(gStringVar3, natureMod[STAT_SPEED - 1], sMonSummaryScreen->summary.speed, 2, 3);
	}
	
	DynamicPlaceholderTextUtil_ExpandPlaceholders(gStringVar4, sStatsRightColumnLayout);
}

If you're not using DizzyEgg's colored-nature mod, use this code instead:

Spoiler:

static void BufferRightColumnStats(void)
{
    u8 spAIV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPATK_IV);
    u8 spDIV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPDEF_IV);
    u8 speIV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPEED_IV);

    u8 spAEV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPATK_EV);
    u8 spDEV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPDEF_EV);
    u8 speEV = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPEED_EV);

    DynamicPlaceholderTextUtil_Reset();

    if (gMain.heldKeys & R_BUTTON) {
        ConvertIntToDecimalStringN(gStringVar1, spAIV, STR_CONV_MODE_RIGHT_ALIGN, 3);
        ConvertIntToDecimalStringN(gStringVar2, spDIV, STR_CONV_MODE_RIGHT_ALIGN, 3);
        ConvertIntToDecimalStringN(gStringVar3, speIV, STR_CONV_MODE_RIGHT_ALIGN, 3);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(0, gStringVar1);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(1, gStringVar2);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(2, gStringVar3);
        DynamicPlaceholderTextUtil_ExpandPlaceholders(gStringVar4, sStatsRightColumnLayout);
    }
    else if (gMain.heldKeys & L_BUTTON) {
        ConvertIntToDecimalStringN(gStringVar1, spAEV, STR_CONV_MODE_RIGHT_ALIGN, 3);
        ConvertIntToDecimalStringN(gStringVar2, spDEV, STR_CONV_MODE_RIGHT_ALIGN, 3);
        ConvertIntToDecimalStringN(gStringVar3, speEV, STR_CONV_MODE_RIGHT_ALIGN, 3);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(0, gStringVar1);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(1, gStringVar2);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(2, gStringVar3);
        DynamicPlaceholderTextUtil_ExpandPlaceholders(gStringVar4, sStatsRightColumnLayout);
    }
    else {
        ConvertIntToDecimalStringN(gStringVar1, sMonSummaryScreen->summary.spatk, STR_CONV_MODE_RIGHT_ALIGN, 3);
        ConvertIntToDecimalStringN(gStringVar2, sMonSummaryScreen->summary.spdef, STR_CONV_MODE_RIGHT_ALIGN, 3);
        ConvertIntToDecimalStringN(gStringVar3, sMonSummaryScreen->summary.speed, STR_CONV_MODE_RIGHT_ALIGN, 3);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(0, gStringVar1);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(1, gStringVar2);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(2, gStringVar3);
        DynamicPlaceholderTextUtil_ExpandPlaceholders(gStringVar4, sStatsRightColumnLayout);
    }
}

Now, when loading the stat screen, if you hold R, IVs will be shown, and if you hold L, EVs will be shown. Otherwise, the regular stats will be shown.

Here's a quick demonstration of how it looks (the EV display works, this Treecko just doesn't have any EVs lmao):

​

New way, where pressing L/R/Start while on the stats screen changes the numbers to IVs/EVs/stats immediately (thanks to AkimotoBubble for their original code):

Spoiler:

Declare a new method at the top of the file (mine is at line 302 to be exact):

static void BufferIvOrEvStats(u8 mode);

Search for static void Task_HandleInput(u8 taskId), and add these else if statements at the end of the method:

Spoiler:

// show IVs/EVs/stats on button presses
else if (gMain.newKeys & R_BUTTON)
{
    if (sMonSummaryScreen->currPageIndex == PSS_PAGE_SKILLS)
    {
        BufferIvOrEvStats(0);
    }
}
else if (gMain.newKeys & L_BUTTON)
{
    if (sMonSummaryScreen->currPageIndex == PSS_PAGE_SKILLS)
    {
        BufferIvOrEvStats(1);
    }
}
else if (gMain.newKeys & START_BUTTON)
{
    if (sMonSummaryScreen->currPageIndex == PSS_PAGE_SKILLS)
    {
        BufferIvOrEvStats(2);
    }
}

Now, search for static void BufferLeftColumnStats(void). Above it, paste one of these two methods:

If you are using DizzyEgg's nature-color mod, use this one:

Spoiler:

static void BufferIvOrEvStats(u8 mode)
{
    u16 hp, hp2, atk, def, spA, spD, spe;
    u8 *currHPString = Alloc(20);
    const s8 *natureMod = gNatureStatTable[sMonSummaryScreen->summary.nature];

    switch (mode)
    {
    case 0: // iv mode
        hp = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_HP_IV);
        atk = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_ATK_IV);
        def = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_DEF_IV);

        spA = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPATK_IV);
        spD = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPDEF_IV);
        spe = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPEED_IV);
        break;
    case 1: // ev mode
        hp = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_HP_EV);
        atk = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_ATK_EV);
        def = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_DEF_EV);

        spA = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPATK_EV);
        spD = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPDEF_EV);
        spe = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPEED_EV);
        break;
    case 2: // stats mode
    default:
        hp = sMonSummaryScreen->summary.currentHP;
        hp2 = sMonSummaryScreen->summary.maxHP;
        atk = sMonSummaryScreen->summary.atk;
        def = sMonSummaryScreen->summary.def;

        spA = sMonSummaryScreen->summary.spatk;
        spD = sMonSummaryScreen->summary.spdef;
        spe = sMonSummaryScreen->summary.speed;
        break;
    }

    FillWindowPixelBuffer(sMonSummaryScreen->windowIds[PSS_DATA_WINDOW_SKILLS_STATS_LEFT], 0);
    FillWindowPixelBuffer(sMonSummaryScreen->windowIds[PSS_DATA_WINDOW_SKILLS_STATS_RIGHT], 0);

    switch (mode)
    {
    case 0:
    case 1:
        BufferStat(gStringVar1, 0, hp, 0, 7);
        BufferStat(gStringVar2, 0, atk, 1, 7);
        BufferStat(gStringVar3, 0, def, 2, 7);
        DynamicPlaceholderTextUtil_ExpandPlaceholders(gStringVar4, sStatsLeftColumnLayoutIVEV);
        PrintLeftColumnStats();

        BufferStat(gStringVar1, 0, spA, 0, 3);
        BufferStat(gStringVar2, 0, spD, 1, 3);
        BufferStat(gStringVar3, 0, spe, 2, 3);
        DynamicPlaceholderTextUtil_ExpandPlaceholders(gStringVar4, sStatsRightColumnLayout);
        PrintRightColumnStats();
        break;
    case 2:
    default:
        BufferStat(currHPString, 0, hp, 0, 3);
        BufferStat(gStringVar1, 0, hp2, 1, 3);
        BufferStat(gStringVar2, natureMod[STAT_ATK - 1], atk, 2, 7);
        BufferStat(gStringVar3, natureMod[STAT_DEF - 1], def, 3, 7);
        DynamicPlaceholderTextUtil_ExpandPlaceholders(gStringVar4, sStatsLeftColumnLayout);
        PrintLeftColumnStats();

        BufferStat(gStringVar1, natureMod[STAT_SPATK - 1], spA, 0, 3);
        BufferStat(gStringVar2, natureMod[STAT_SPDEF - 1], spD, 1, 3);
        BufferStat(gStringVar3, natureMod[STAT_SPEED - 1], spe, 2, 3);
        DynamicPlaceholderTextUtil_ExpandPlaceholders(gStringVar4, sStatsRightColumnLayout);
        PrintRightColumnStats();
        break;
    }

    Free(currHPString);
}

If you are not using DizzyEgg's nature-color mod, use this one:

Spoiler:

static void BufferIvOrEvStats(u8 mode)
{
    u16 hp, hp2, atk, def, spA, spD, spe;
    u8 *currHPString = Alloc(20);
    const s8 *natureMod = gNatureStatTable[sMonSummaryScreen->summary.nature];

    switch (mode)
    {
    case 0: // IV mode
        hp = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_HP_IV);
        atk = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_ATK_IV);
        def = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_DEF_IV);

        spA = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPATK_IV);
        spD = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPDEF_IV);
        spe = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPEED_IV);
        break;
    case 1: // EV mode
        hp = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_HP_EV);
        atk = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_ATK_EV);
        def = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_DEF_EV);

        spA = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPATK_EV);
        spD = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPDEF_EV);
        spe = GetMonData(&sMonSummaryScreen->currentMon, MON_DATA_SPEED_EV);
        break;
    case 2: // stats mode
    default:
        hp = sMonSummaryScreen->summary.currentHP;
        hp2 = sMonSummaryScreen->summary.maxHP;
        atk = sMonSummaryScreen->summary.atk;
        def = sMonSummaryScreen->summary.def;

        spA = sMonSummaryScreen->summary.spatk;
        spD = sMonSummaryScreen->summary.spdef;
        spe = sMonSummaryScreen->summary.speed;
        break;
    }

    FillWindowPixelBuffer(sMonSummaryScreen->windowIds[PSS_DATA_WINDOW_SKILLS_STATS_LEFT], 0);
    FillWindowPixelBuffer(sMonSummaryScreen->windowIds[PSS_DATA_WINDOW_SKILLS_STATS_RIGHT], 0);

    switch (mode)
    {
    case 0:
    case 1:
        ConvertIntToDecimalStringN(gStringVar1, hp, STR_CONV_MODE_RIGHT_ALIGN, 7);
        ConvertIntToDecimalStringN(gStringVar2, atk, STR_CONV_MODE_RIGHT_ALIGN, 7);
        ConvertIntToDecimalStringN(gStringVar3, def, STR_CONV_MODE_RIGHT_ALIGN, 7);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(0, gStringVar1);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(1, gStringVar2);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(2, gStringVar3);
        DynamicPlaceholderTextUtil_ExpandPlaceholders(gStringVar4, sStatsLeftColumnLayoutIVEV);
        PrintLeftColumnStats();

        ConvertIntToDecimalStringN(gStringVar1, spA, STR_CONV_MODE_RIGHT_ALIGN, 3);
        ConvertIntToDecimalStringN(gStringVar2, spD, STR_CONV_MODE_RIGHT_ALIGN, 3);
        ConvertIntToDecimalStringN(gStringVar3, spe, STR_CONV_MODE_RIGHT_ALIGN, 3);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(0, gStringVar1);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(1, gStringVar2);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(2, gStringVar3);
        DynamicPlaceholderTextUtil_ExpandPlaceholders(gStringVar4, sStatsRightColumnLayout);
        PrintRightColumnStats();
        break;
    case 2:
    default:
        ConvertIntToDecimalStringN(currHPString, hp, STR_CONV_MODE_RIGHT_ALIGN, 3);
        ConvertIntToDecimalStringN(gStringVar1, hp2, STR_CONV_MODE_RIGHT_ALIGN, 3);
        ConvertIntToDecimalStringN(gStringVar2, atk, STR_CONV_MODE_RIGHT_ALIGN, 7);
        ConvertIntToDecimalStringN(gStringVar3, def, STR_CONV_MODE_RIGHT_ALIGN, 7);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(0, currHPString);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(1, gStringVar1);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(2, gStringVar2);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(3, gStringVar3);
        DynamicPlaceholderTextUtil_ExpandPlaceholders(gStringVar4, sStatsLeftColumnLayout);
        PrintLeftColumnStats();

        ConvertIntToDecimalStringN(gStringVar1, spA, STR_CONV_MODE_RIGHT_ALIGN, 3);
        ConvertIntToDecimalStringN(gStringVar2, spD, STR_CONV_MODE_RIGHT_ALIGN, 3);
        ConvertIntToDecimalStringN(gStringVar3, spe, STR_CONV_MODE_RIGHT_ALIGN, 3);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(0, gStringVar1);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(1, gStringVar2);
        DynamicPlaceholderTextUtil_SetPlaceholderPtr(2, gStringVar3);
        DynamicPlaceholderTextUtil_ExpandPlaceholders(gStringVar4, sStatsRightColumnLayout);
        PrintRightColumnStats();
        break;
    }

    Free(currHPString);
}

Here's a quick demonstration of how it looks:

​

Just like in the older version, the nature coloring is only shown when the regular stats are being displayed (this Grovyle is Docile, so that's why there's no coloring here). This can be changed by editing the second value in BufferStat calls for cases 0 and 1. See the calls in case 2 to see how they work.

If you'd like, you can use both the old and the new methods in tandem, as they don't conflict with each other. Thanks again to AkimotoBubble for their code.

 

[Lunos]

Showing IVs/EVs in Summary Screen [EM]​

I decided to give this a shot as I need it to showcase something, but I'm getting an error upon trying to build a ROM.

The branch I tried to insert the code on doesn't have Egg's nature-based colors, fwiw, so I used the respective versions of each function that you posted.

Btw, it's not something super important, but you seem to be mixing tabs and spaces for the indentation in your code. It's good practice to stick to one or the other :)
Usually, you should stick to whichever is used the most times in the file that is being modified. In the case of src/pokemon_summary_screen.c, that'd be 4 spaces.
You can check that stuff easily with something like Notepad++, by going to View > Show Symbol > Show White Space and TAB.

It may look just fine normally, but if you ever decide to jump to web services that make use of Git like GitHub or GitLab, you'll notice your code will look quite misaligned in your commits.

 

[PokemonCrazy]

The branch I tried to insert the code on doesn't have Egg's nature-based colors, fwiw, so I used the respective versions of each function that you posted.

Oh, interesting, I have no idea where BufferStat comes from as pokemon_summary_screen.c uses something different by default. Must've been in some branch I added and I didn't notice. I'll edit the code ASAP.

EDIT: BufferStat comes from, you guessed it, the nature color mod. Code is now updated and should 100% work.

Btw, it's not something super important, but you seem to be mixing tabs and spaces for the indentation in your code. It's good practice to stick to one or the other :)

Totally didn't notice--that was caused by me jumping between Notepad++ (which is set up for spaces) and Visual Studio (tabs). I'll try to fix it next time around, thanks for pointing it out!

 

[Lunos]

Setting a Pokémon's EVs with 6 Scripting Specials (Emerald/Fire Red)​

Note: This is just one of the many ways in which you can most likely implement a feature like this.

With these code changes, we'll add 6 new specials to use in a script.
What they do, is to take the values written in the Vars 0x8000, 0x8001, 0x8002, 0x8003, 0x8005 and 0x8006 and rewrite the EVs of the Pokémon stored in the var 0x8004 accordingly.
Each special uses one of these 6 vars, and each one of them affect a specific Pokémon's stat, as you can tell by looking at the code.

Without further ado:
https://github.com/LOuroboros/pokeemerald/commit/0d418ab3a1070e8f36c5ba3513bba8549f0571a8

For reference, I also decided to throw in a script that I wrote showing how do I use them.
https://github.com/LOuroboros/pokeemerald/commit/4f0efab900f03876c67775ff98d4d02366fc75b1

It can be called by adding call SetEVs in a script and it's pretty simple to understand how it works.
special ChoosePartyMon makes the Player select a Pokémon whose slot in the party gets stored in the var 0x8004, then I set the values of the vars 0x8000, 0x8001, 0x8002, 0x8003, 0x8005 and 0x8006 to 252, and then I proceed to call the 6 specials that will affect the EVs of the Pokémon in the party slot that was chosen according to the values of the aforementioned vars.
The script won't work if the Player decided to cancel while in the Choose Pokémon screen, or if they chose an Egg.
And naturally, y'all can change the amount of EVs that are being set as you see fit.

Here's a quick video showing it off, thanks to the feature written and posted above by PokemonCrazy.


And that's pretty much it.​

 

[ghoulslash]

[Pokeemerald] Change Object Event Movement Type in Real Time

I was searching for a way to change NPCs movement type in a script, and found none, so I decided to write my own. Its pretty simple:

• Add the following code to src/event_object_movement.c
  

  void SetObjectMovementType(void)
  {
      struct ObjectEvent *objectEvent = &gObjectEvents[GetObjectEventIdByLocalId(gSpecialVar_0x8005)];
      u8 movementType = gSpecialVar_0x8006;
      
      objectEvent->movementType = movementType;
      objectEvent->directionSequenceIndex = 0;
      objectEvent->playerCopyableMovement = 0;
      gSprites[objectEvent->spriteId].callback = sMovementTypeCallbacks[movementType];
      gSprites[objectEvent->spriteId].data[1] = 0;
  }

  
  Then add the following to the end of data/specials.inc
  

  def_special SetObjectMovementType

How to Use:

lock    @ lock and release are needed to get the movement types to work with applymovement. (Or ScriptMovement_UnfreezeObjectEvents(); in the function - credit to Disturbo for testing this)
setvar VAR_0x8005, "localId"   @the local Id of the object event in question ("event_object Id" field in porymap)
setvar VAR_0x8006, "movementType"   @the movement type to change to (eg. MOVEMENT_TYPE_WANDER_AROUND)
special  SetObjectMovementType
release

Here's a macro you can throw into events.inc, and you can just call setobjectnewmovementtype "localId", "movementType" to the same as above:

    .macro setobjectnewmovementtype localId:req, movementType:req
    setvar VAR_0x8005, \localId
    setvar VAR_0x8006, \movementType
    special SetObjectMovementType
    .endm