This was the first time I found a problem with one of your textboxes. In the top left corner there is a black box that appears all over the place in dialogue and in battles. You've edited the other textboxes in this hack, so this shouldn't graphical glitch shouldn't be too hard to fix.
Another reoccurring problem that I spotted early on. You've got two different ways of having NPCs speak. In regular conversation they have coloured text like in the right screenshot, while in scripted segments, named characters like your family members, Gym Leaders and Rocket Grunts have coloured names to indicate who is talking, but black text. The base FRLG game isn't consistent with text colours either, but I think it will help to add polish if you choose a style of colouring and stick with it.
The first screenshot is pretty obviously bugged. It seems like you wrote a script for the town sign and then accidentally overwrote it when you inserted the second screenshot's text. Also, its a bit weird that the sign outside your grandparent's house says that its "
Your grandparent's house". It makes the sign a personal and subjective thing, I can just imagine a traveller coming along, reading the sign and getting confused because their grandparents are three cities over. Maybe change it to something like "Village Elders" to make seems like a regular sign to anybody other than the player.
When I try to name Cubone after receiving it the sprite doesn't properly show up and the nickname isn't applied at the end. Special 0x9E works off the value of variable 0x8004 - 0x0 is the first Pokemon in the party, 0x1 is the second etc. You need to include the command 'setvar 0x8004 0x0' before proceeding with the nicknaming function.
Initially I took this screenshot so I could say something humorous like "this guy is
super lost", but it eventually became apparent that a lot of NPC dialogue is recycled. I strongly suggest writing custom scripts for every NPC as it adds so much more to the game and avoids strange conversations with characters who think they're back in Kanto.
Movement permission errors on this route. The three tiles directly in front of me in the first screenshot are impassable.
After my first one or two battles I thought that my Cubone was doing a lot more damage than it should for its level, only to see that it was holding a Thick Club. Thick Club is probably one of the most OP items in the game as it
doubles Cubone and Marowak's attack stat, making your grandpa's comment about giving you a tough Pokemon to raise pretty tone deaf.. Its just too much for early game mons. I'd suggest removing it from your starter and giving it somewhere in the mid game. Maybe the equivalent of beating Silph Co or something.
Tile errors when you enter Route 1 from Hendlin City.
Movement permission errors in Hendlin City.
Comparison between two types of Pokemon. First-Gen Pokemon are decapitalised while Second-Gen plus are in all caps.
Movement permission errors on Route 2.
More inconsistencies. Pokeballs are spelt and capitalised differently.
Rogue signpost.
I find the first two screenshots to be really weird. Is there are reason why you chose to change NidoranM's name and remove NidoranF's gender? I mean, everybody knows their names and what they are, I just find it incredibly odd and slightly offputting. The third screenshot doesn't reflect the changes you made.
Border block error when you go as far south as possible in Route 2.
Tile error in the top right corner of the gym. There's a tree behind it, but the tile has a grass background.
Somebody's Gym has been stolen :3
While the issue of coloured text use remains, I'd like to point out that the red text is used for female NPCs and blue for males.
Zu
tbat?
Movement permission errors on Route 3. The second screenshot in particular has a lot of movement errors around there.
The bottom segments of this bridge overlap the player's head. Change their background bytes to 20.
lol
When you exit caves the player has to physically move out of the hole. You need to use the tile behaviour byte 60 to get the player to move down one tile automatically upon warping in.
Both of Riley's Gym Trainers have issues with their after battle texts.
While it isn't impossible, its pretty hard to see Riley's name colour on a plain white background.
