Let's see...
I like most of the older ones, like Olivine, the lighthouse, Burned Tower, the cave theme, the surfing and bicycle theme from RBY, Lavender Town... this list could go on forever~
And from DP my favorites are the Pokemon League, Lake Cave, Mesprit/Azelf/Uxie's theme, and the music...