Hands down, my favorite game is Pokemon Platinum. I think its enhanced story line and beefed up battles are epic.
After Platinum, FireRed and/or LeafGreen would probably be my favorites. Then Diamond and Pearl, HeartGold/SoulSilver, Gold/Silver/Crystal, Red/Blue/Yellow, and finally...