Simple Modifications Directory

TheXaman said:

[Pokeemerald] DS-Style party screen (2 versions)
Changes the party screen to one similar to the DS versions. 2 different layouts available!
V1:

V2:

How to:
V1: Have a look at the following commit for the main implementation LINK.
V2: Implement the first version and the have a look at the commit LINK

Or clone it into your repo:

Code:

git remote add xaman https://github.com/TheXaman/pokeemerald/

For version 1:

Code:

git pull xaman party_screen_ds_style

For version 2:

Code:

git pull xaman party_screen_ds_style2

Thats it! If you find any bugs, let me know.
If you want to change the look of the windows you need to alter graphics/interface/party_menu_bg.png

Eggs:

Double battles:

Known bugs ONLY V1: Healing via potion "breaks" the slash between hp and maxHp


Credits:
TheXaman
visually inpsired by Lunos binary version, but no code or assets used.

Click to expand...

TheXaman said:

Running Indoors (EM)​

Simply remove the following from /src/bike.c and you should be able to use your running shoes inside any building.

Inside the file search for:

Code:

bool32 IsRunningDisallowed(u8 metatile)

and delete the following:

Code:

!(gMapHeader.flags & MAP_ALLOW_RUNNING) ||

Thats it, now you should be good to go (or run in this case).

CREDIT:
None needed

Click to expand...

MaceHairdu said:

My original file looks like this:

bool32 IsRunningDisallowed(u8 metatile)
{
if (!gMapHeader.allowRunning || IsRunningDisallowedByMetatile(metatile) == TRUE)
return TRUE;
else
return FALSE;
}

What do I need to delete?

Click to expand...

Lunos said:

Found some issues with the v2 layout in the Battle Tower.

Click to expand...

Lunos said:

Nicknaming as an option in the Pokémon Party Screen (Emerald)​

This code allows you to change the nickname of a Pokémon in your party on the Pokémon Party Screen with a new option called "Nickname".
Honestly, the idea of requiring the service of an NPC in X Town or City to change a Pokémon's nickname is silly.
You should always be able to nickname your own Pokémon, in my opinion.

The code can be found in this commit, it's super easy stuff.
https://github.com/shinny456/pokeemerald/commit/c92e5861e3ba85abaf53af81aa0bb70acae505af

Quick demonstration:

Bugs:

Spoiler:

-You can't nickname a Pokémon that knows 4 Field Moves.
To fix this, simply change u8 actions[8]; in the Line 123 of src/party_menu.c to u8 actions[9]; instead.
Credits to Ghoulslash for this fix.

The credits for this feature go to Shinny456. I'm just reposting it here because he wanted to share it with y'all.

And that's pretty much it.​

Click to expand...

ScyrousFX said:

While this is great and does exactly what it says on the tin, I'd like to report a small issue (and I know you're just sharing this on someone else's behalf, but they're not too active on github anymore, so perhaps you or someone else knows how to fix it).

After renaming your Pokemon (or backing out from the naming interface) you're immediately returned back to the field, rather than back to the party menu. Notice how in your demonstration GIF, you're forced to open the party menu again to verify the change you've made. This is not intuitive. Ideally, you should be returned back to the party menu, with the renamed Pokemon being selected again. Virtually every other menu/bag option in the game will return you back to where you came from, and it only makes sense this commit does too.

So the problem with the commit is that ChangePokemonNickname is being referenced in tv.c, which always returns you to the field (it's not designed to be used from within the party menu, after all). I think you'd need to create a copy of this function (as well as ChangePokemonNickname_CB) and edit it accordingly. That being said, I know little of C, so this is where my contribution ends. I tried fixing this commit a few times, but no luck. :(

If anyone else has any ideas, that'd be great!

Click to expand...

Diego Mertens said:

POKEEMERALD
PSS IN THE START MENU​

First, we add a new Flag in include/constants/flags.h

Code:

FLAG_POKEMONPCMENU

(this will be used after)
Then, we go to include/pokemon_storage_system.h
There, we add anywhere:

Code:

void Cb2_EnterPSS(u8 boxOption);

Then we go to src/pokemon_storage_system.c, and we delete

Code:

static void Cb2_EnterPSS(u8 boxOption);

(when its definied, the first one)
and we search for "static void Cb2_EnterPSS(u8 boxOption) ", then we erase the "static " (the second one)
Then, we search for:

Code:

static void FieldCb_ReturnToPcMenu(void)

And we replace it entirely for this:

Code:

static void FieldCb_ReturnToPcMenu(void)
{
    u8 taskId;
    MainCallback vblankCb = gMain.vblankCallback;
	if (FlagGet(FLAG_POKEMONPCMENU)==TRUE)
	{
		SetVBlankCallback(NULL);
		taskId = CreateTask(Task_PokemonStorageSystemPC, 80);
		gTasks[taskId].data[0] = 0;
		gTasks[taskId].data[1] = sPreviousBoxOption;
		Task_PokemonStorageSystemPC(taskId);
		SetVBlankCallback(vblankCb);
		FadeInFromBlack();
	}
	else
	{
	    SetVBlankCallback(CB2_ReturnToField);
		FadeInFromBlack();
		DisableInterrupts(FLAG_POKEMONPCMENU);
	}
}

Then, we go to src/start_menu.c, and we search for: static bool8 StartMenuBagCallback(void);, and right after, we add:
static bool8 StartMenuPCCallback(void);
Then, we go to "{gText_MenuBag, {.u8_void = StartMenuBagCallback}}," and again we add bellow:
{gText_MenuPC, {.u8_void = StartMenuPCCallback}},
Then, we go to "static bool8 StartMenuBagCallback(void)" and after the whole funcion we add:

Code:

static bool8 StartMenuPCCallback(void)
{
	u8 taskId;
    if (!gPaletteFade.active)
    {
        PlayRainStoppingSoundEffect();
        RemoveExtraStartMenuWindows();
		Cb2_EnterPSS(x);
        return TRUE;
    }

    return FALSE;
}

(in my case, its "0" the number for the Move Pokémon System, but I have made some changes {I changed the Move option to the first place}, and I'm sure the original number for the option is "2"...)

Then, we search for: "MENU_ACTION_BAG"
And after we add: "MENU_ACTION_PC,"

Now we go to: "if (FlagGet(FLAG_SYS_POKEMON_GET) == TRUE)" and inside there we add:
AddStartMenuAction(MENU_ACTION_PC);
Like this:

Code:

    if (FlagGet(FLAG_SYS_POKEMON_GET) == TRUE)
    {
        AddStartMenuAction(MENU_ACTION_POKEMON);
		AddStartMenuAction(MENU_ACTION_PC);
    }

Then, we go to "AddStartMenuAction(MENU_ACTION_BAG);" and right after we add:
AddStartMenuAction(MENU_ACTION_PC);

Then, we go to data/scripts/pc.inc and we add this after "playse SE_PC_ON" in "EventScript_PC:: @ 8271D92":
setflag FLAG_POKEMONPCMENU
Now, after "special DoPCTurnOffEffect", in "EventScript_TurnOffPC:: @ 8271E47" we add:
clearflag FLAG_POKEMONPCMENU

Lastly, we need to add the strings for the PC in the Start Menu, (thanks, Lunos)
We go to include/strings.h and we add this somewhere:

extern const u8 gText_MenuPC[];

And this is the last step. We go to src/strings.c and we add this somewhere:
const u8 gText_MenuPC[] = _("PC");

And we're done! this time, we are We should be able to enter the Move Pokémon PC, and the Pokécenter PC's won't be affected.

Click to expand...

setvar VAR_0x8003, 1 // enable battle points routine, change battle transition
setvar VAR_0x8004, 15 // set amount of battle points won to be 15
trainerbattle_no_intro TRAINER_STEVEN, MeteorFalls_StevensCave_Text_StevenDefeat

Click to expand...

TheXaman said:

[Pokeemerald] Fully functional debug menu with Flags, Vars, Items, custom scripts, Pokemon and more!
This is my implementation of a debug menu based on Ketsuban's tutorial and some code from Pyredrid, AsparagusEduardo and Ghoulslash.

Features:

Spoiler:

Utility:
Heal player party
Clock: check and set

Fly to all cities: ----------------------------Warp to any map warp: --------------Check saveblock space:

Check weekday: does nothing, left in as a simple spot to add some test stuff for you guys

Change Trainer name, gender and OIT:

Flags:
Added some usefull debug flags like ignore collision, no wild encounters (Inmortal) and no trainers attacking you.
Toggle any flag ingame: -------------Toggle specific usefull flags

Vars:
Read and change any vars ingame:

Give:
Items:

All TMs:

Pokemon in 2 versions:
---Simple: only takes the ID (source code, not ingame) and a level:

---Complex: ID, level, shiny?, nature and ability (including hidden with PE), individual IVs and up to 4 custom moves.

How to:
Add and clone it into your repo:

Code:

git remote add xaman https://github.com/TheXaman/pokeemerald/
git pull xaman tx_debug_system
make clean
make debugging

Access ingame:
From now one if you want the menu to show up you have to run your make command with the addition parameter: debugging or debugging _modern, for example make debugging -j8. Those parameters already include DINFO=1.
To access ingame press R + Start.



That it, now enjoy and if you find any bugs or if you write some cool additions you think others could profit from, please let me know in this threat, via pm or over on github!


Credits: If you use this, you have to give credit to all following people!
TheXaman
Ketsuban
Pyredrid
AsparagusEduardo
Ghoulslash
ExboSeed
Sierraffinity
Jaizu

Click to expand...

Hiroshi Sotomura said:

A previous post in this thread addresses Emerald's broken RNG by replacing the code in SeedRngAndSetTrainerId with something that uses the RTC to seed the RNG. The issue with it though is that on a newly-initialised game, the RTC is unset and hence unused, so any randomness won't actually occur until the clock has been started. It has the unfortunate consequence of having the Trainer ID no longer be randomly generated (or, it ends up being something predictable around the 10000 range).

For those who have pulled from the repo recently, the fixes simply require uncommenting of these code portions in main.c:

Declarations:

Code:

//static void SeedRngWithRtc(void);

Within the AgbMain() codeblock:

Code:

//SeedRngWithRtc(); see comment at SeedRngWithRtc declaration below

A function in the code commented out:

Code:

// oops! FRLG commented this out to remove RTC, however Emerald didnt undo this!
//static void SeedRngWithRtc(void)
//{
//    u32 seed = RtcGetMinuteCount();
//    seed = (seed >> 16) ^ (seed & 0xFFFF);
//    SeedRng(seed);
//}

For those with older clones that don't have these, simply put them in (without the comments).

Click to expand...

Buffel Saft said:

Remove the need to water berries on rainy Routes (Emerald)​

Ever watered berry trees in the thunderstorm on Route 119 and thought "this makes no sense"?

This little tweak will make any berry trees on specified routes give out their maximum number of berries all the time, as if the weather watered them for you!

Go to src\berry.c and find the function named GetBerryCountByBerryTreeId().
Replace it with the following:

Code:

static u8 GetBerryCountByBerryTreeId(u8 id)
{
    struct BerryTree *tree = GetBerryTreeInfo(id);
    const struct Berry *berry = GetBerryInfo(tree->berry);
    u16 currentMap = gMapHeader.regionMapSectionId;

    if (currentMap == MAPSEC_ROUTE_119 || currentMap == MAPSEC_ROUTE_120 || currentMap == MAPSEC_ROUTE_123)
        return berry->maxYield;
    else
        return gSaveBlock1Ptr->berryTrees[id].berryYield;
}

Then you'll probably need to add #include constants/map_groups.h at the top of src\berry.c so the compiler recognizes the map names.

The maps used here are just examples, so you can change them to whatever condition you want.

Click to expand...

TheXaman said:

[Pokeemerald] Improved scrolling options menu with faster text, HP and EXP bar speeds and a metric unit option!
This is an improved options menu with the ability to scroll for more than the standard amount of options, developed by DizzyEgg.

Spoiler:

Features:

Text speed: Slow, Mid, Fast, Fatser (based on the work of ella_trifle)
Unit system: Metric, Imperial
HP bar speed: 0-10(instant)
Exp bar speed: 0-10(instant)


How to:

Code:

git remote add xaman https://github.com/TheXaman/pokeemerald/
git pull xaman tx_optionsPlus
make clean

Warning:
This implementations slighty changes SaveBlock2, but I've been extra carefull and as far as I can tell no problems with old savegames should occure.


I hope you enjoy and if you find any bugs, please let me know in this threat, via pm or over on github!


Credits: If you use this, you have to give credit to all following people!
DizzyEgg
Lunos
AsparagusEduardo
ella_trifle

Click to expand...

Whitlaphobia said:

Hello! This code worked with no errors, however I get a loud screeching sound when exiting the pc that is continuous until i join a battle screen. Any idea how i might resolve this?

Click to expand...