Mega Mewthree's Achievements System

ardicoozer said:

can I add a prize for each achievement ??

Click to expand...

Vendily said:

Not by default, no. at least I never saw any sort of system like that when I updated it.

how do you plan on implementing these prizes? I can certainly update for a quality of life feature.

Click to expand...

Vendily said:

This script is an update of Mega Mewthree's Achievements System to work in v17, as well as simplifying and streamlining installation.

The Achievement Procs section has to be the one right above main, as it aliases a number of methods just to ensure that it will call the Achievement progress update in the right spot at the right time. The effect of these methods is not changed, it just passes the message along.

Please read "README.txt" for instructions.

Credits:
Mega Mewthree for the original Script
(broken link removed)

Vendily for updating

Get it Here!

Click to expand...

YashPokeFan123 said:

Plz also make for essentials 18.1

Click to expand...

  def pbUseItemOnPokemon(item,pkmnIndex,userPkmn,scene)
    ret=achieve_pbUseItemOnPokemon(item,pkmnIndex,userPkmn,scene)
    if pbOwnedByPlayer?(userPkmn.index) && ret
      Achievements.incrementProgress("ITEMS_USED",1)
      Achievements.incrementProgress("ITEMS_USED_IN_BATTLE",1)
    end
  end

  def pbUseItemOnPokemon(item,pkmn,scene)
    ret=achieve_pbUseItemOnPokemon(item,pkmn,scene)
    if pbOwnedByPlayer?(pkmn.index) && ret
      Achievements.incrementProgress("ITEMS_USED",1)
      Achievements.incrementProgress("ITEMS_USED_IN_BATTLE",1)
    end
  end

  def pbUseItemOnBattler(item,index,userPkmn,scene)
    ret=achieve_pbUseItemOnBattler(item,index,userPkmn,scene)
    if pbOwnedByPlayer?(userPkmn.index) && ret
      Achievements.incrementProgress("ITEMS_USED",1)
      Achievements.incrementProgress("ITEMS_USED_IN_BATTLE",1)
    end
  end

  def pbUseItemOnBattler(item,idxBattler,userBattler)
    ret=achieve_pbUseItemOnBattler(item,idxBattler,userBattler)
    if pbOwnedByPlayer?(idxBattler) && ret
      Achievements.incrementProgress("ITEMS_USED",1)
      Achievements.incrementProgress("ITEMS_USED_IN_BATTLE",1)
    end
  end

StCooler said:

You know, V18.1 is not a complete rewriting of v17 that changes everything...
You can put this script in your game, make experiments and solve the few bugs that you'll find. They should be easy to solve, the way the script is written.

I looked at the code, and I think that the only functions that will create bugs are the following:

Spoiler:

Code:

  def pbUseItemOnPokemon(item,pkmnIndex,userPkmn,scene)
    ret=achieve_pbUseItemOnPokemon(item,pkmnIndex,userPkmn,scene)
    if pbOwnedByPlayer?(userPkmn.index) && ret
      Achievements.incrementProgress("ITEMS_USED",1)
      Achievements.incrementProgress("ITEMS_USED_IN_BATTLE",1)
    end
  end

which should be rewritten as:

Code:

  def pbUseItemOnPokemon(item,pkmn,scene)
    ret=achieve_pbUseItemOnPokemon(item,pkmn,scene)
    if pbOwnedByPlayer?(pkmn.index) && ret
      Achievements.incrementProgress("ITEMS_USED",1)
      Achievements.incrementProgress("ITEMS_USED_IN_BATTLE",1)
    end
  end

and

Code:

  def pbUseItemOnBattler(item,index,userPkmn,scene)
    ret=achieve_pbUseItemOnBattler(item,index,userPkmn,scene)
    if pbOwnedByPlayer?(userPkmn.index) && ret
      Achievements.incrementProgress("ITEMS_USED",1)
      Achievements.incrementProgress("ITEMS_USED_IN_BATTLE",1)
    end
  end

which should be replaced with:

Code:

  def pbUseItemOnBattler(item,idxBattler,userBattler)
    ret=achieve_pbUseItemOnBattler(item,idxBattler,userBattler)
    if pbOwnedByPlayer?(idxBattler) && ret
      Achievements.incrementProgress("ITEMS_USED",1)
      Achievements.incrementProgress("ITEMS_USED_IN_BATTLE",1)
    end
  end

Of course I didn't test any of this, but these changes are the most obvious.

Click to expand...

YashPokeFan123 said:

Can you tell me how to add achievements system I don't understand should the script give by vendily I want to add or did we want to add some more script by mewthree.

Also the script given by vendily can you tell where to add

Click to expand...

StCooler said:

The post + README are perfectly clear.
Put the scripts above your Main, with Achievement Procs being the last (the order doesn't matter for the other two) + make the edits in the README + make the edits I gave you.

Click to expand...

YashPokeFan123 said:

I think Pscreen achievement to be placed u nder all Pscreen scripts and where module one and procs above main

Click to expand...

StCooler said:

You know, V18.1 is not a complete rewriting of v17 that changes everything...
You can put this script in your game, make experiments and solve the few bugs that you'll find. They should be easy to solve, the way the script is written.

I looked at the code, and I think that the only functions that will create bugs are the following:

Spoiler:

Code:

  def pbUseItemOnPokemon(item,pkmnIndex,userPkmn,scene)
    ret=achieve_pbUseItemOnPokemon(item,pkmnIndex,userPkmn,scene)
    if pbOwnedByPlayer?(userPkmn.index) && ret
      Achievements.incrementProgress("ITEMS_USED",1)
      Achievements.incrementProgress("ITEMS_USED_IN_BATTLE",1)
    end
  end

which should be rewritten as:

Code:

  def pbUseItemOnPokemon(item,pkmn,scene)
    ret=achieve_pbUseItemOnPokemon(item,pkmn,scene)
    if pbOwnedByPlayer?(pkmn.index) && ret
      Achievements.incrementProgress("ITEMS_USED",1)
      Achievements.incrementProgress("ITEMS_USED_IN_BATTLE",1)
    end
  end

and

Code:

  def pbUseItemOnBattler(item,index,userPkmn,scene)
    ret=achieve_pbUseItemOnBattler(item,index,userPkmn,scene)
    if pbOwnedByPlayer?(userPkmn.index) && ret
      Achievements.incrementProgress("ITEMS_USED",1)
      Achievements.incrementProgress("ITEMS_USED_IN_BATTLE",1)
    end
  end

which should be replaced with:

Code:

  def pbUseItemOnBattler(item,idxBattler,userBattler)
    ret=achieve_pbUseItemOnBattler(item,idxBattler,userBattler)
    if pbOwnedByPlayer?(idxBattler) && ret
      Achievements.incrementProgress("ITEMS_USED",1)
      Achievements.incrementProgress("ITEMS_USED_IN_BATTLE",1)
    end
  end

Of course I didn't test any of this, but these changes are the most obvious.

Click to expand...

YashPokeFan123 said:

Spoiler:

It happens when you Open Pause menu?

Click to expand...

MessiDuvidoso said:

No, I open the menu normally, only when I run it happens ...

Click to expand...

MessiDuvidoso said:

I'm trying to add to v18, I made these changes that you said, when I try to run the script from the menu, it gives this error:

Spoiler:

---------------------------
Error
---------------------------
Script '[[Menu Modular]]' line 116: NameError occurred.

uninitialized constant PokemonAchievementsScene

from '[Menu Modular]' line 116
from '[Menu Modular]' line 115 in `call'
from eval line 48 in `runAction'
from eval line 322 in `pbStartPokemonMenu'
from eval line 305 in `loop'
from eval line 325 in `pbStartPokemonMenu'
from 'Scene_Map' line 107 in `call_menu'
from 'Scene_Map' line 206 in `follow_update'
from '[Follower_Main]' line 1172 in `update'
from 'Scene_Map' line 229 in `main'
from 'Scene_Map' line 226 in `loop'
from 'Scene_Map' line 231 in `main'
---------------------------
OK
---------------------------

Would you help me? I did the step by step correctly!
I added the script sections:
Achievement Procs
Achievement_Module
Above main
and PScreen_Achievements along with all other scripts called PScreen.
I made the changes in the EXTRA EDITS section and made the changes you indicated, but gave this error, what would it be and how do I fix it?

I use v18 Essentials

Click to expand...

MessiDuvidoso said:

I'm trying to add to v18, I made these changes that you said, when I try to run the script from the menu, it gives this error:

Spoiler:

---------------------------
Error
---------------------------
Script '[[Menu Modular]]' line 116: NameError occurred.

uninitialized constant PokemonAchievementsScene

from '[Menu Modular]' line 116
from '[Menu Modular]' line 115 in `call'
from eval line 48 in `runAction'
from eval line 322 in `pbStartPokemonMenu'
from eval line 305 in `loop'
from eval line 325 in `pbStartPokemonMenu'
from 'Scene_Map' line 107 in `call_menu'
from 'Scene_Map' line 206 in `follow_update'
from '[Follower_Main]' line 1172 in `update'
from 'Scene_Map' line 229 in `main'
from 'Scene_Map' line 226 in `loop'
from 'Scene_Map' line 231 in `main'
---------------------------
OK
---------------------------

Would you help me? I did the step by step correctly!
I added the script sections:
Achievement Procs
Achievement_Module
Above main
and PScreen_Achievements along with all other scripts called PScreen.
I made the changes in the EXTRA EDITS section and made the changes you indicated, but gave this error, what would it be and how do I fix it?

I use v18 Essentials

Click to expand...

StCooler said:

The error is not in this script, but in the [[Menu Modular]] (I don't know what that script is).
The error says that the system doesn't know what PokemonAchievementsScene is, and it's normal, because this class is not defined in the Achievement scripts. What is defined actually, is PokemonAchievements_Scene (with the tiny "_").
So find any references to PokemonAchievementsScene in your scripts (hopefully there aren't too many) and replace them with PokemonAchievements_Scene.

You should probably report this error to the authors of Menu Modular though, it may help people :)

Click to expand...