[Scripting Question] A specified enhancement

[0maewam0ushindeiru]

I want to make an item that maxes out the EVs and IVs of a Pokemon, but under the condition they are a non-Shadow Bug-type. If they are not a Bug-type or are a Shadow Pokemon, then the item will fail. Only issue is, I have no clue how to go about this. Any help would be appreciated, but you do not have to.

 

[ThatWelshOne_]

I think this is fairly straightforward to do, at least for IVs. EVs would be more tricky because these cap at 510. I don't think you can throw 252 EVs into every stat and call it good, so this step would need to give the player the choice of which EVs to maximise. Is that what you had in mind?

 

[0maewam0ushindeiru]

I think this is fairly straightforward to do, at least for IVs. EVs would be more tricky because these cap at 510. I don't think you can throw 252 EVs into every stat and call it good, so this step would need to give the player the choice of which EVs to maximise. Is that what you had in mind?

Yeah, that works well.

 

[ThatWelshOne_]

I can try this. I'll keep you updated. Maybe someone else will come along in the meantime.

 

[ThatWelshOne_]

I've been able to create an item that maximises an IV of the player's choice. Here's the code:

Spoiler:

ItemHandlers::UseOnPokemon.add(:ULTRAIVTRAINER,proc { |item,pkmn,scene|
  if !isConst?(pkmn.type1,PBTypes,:BUG) && !isConst?(pkmn.type2,PBTypes,:BUG) ||
    pkmn.shadowPokemon? || pkmn.isEgg?
    scene.pbDisplay(_INTL("This item cannot be used on that type of Pokémon."))
    next false
  end
  commands = []
  cmdHP     = -1
  cmdAtk    = -1
  cmdDef    = -1
  cmdSpAtk  = -1
  cmdSpDef  = -1
  cmdSpd    = -1
  cmdQuit   = -1
  #
  commands[cmdHP = commands.length]  = _INTL("HP")
  commands[cmdAtk = commands.length] = _INTL("Attack")
  commands[cmdDef = commands.length] = _INTL("Defense")
  commands[cmdSpAtk = commands.length]  = _INTL("Sp. Atk")
  commands[cmdSpDef = commands.length] = _INTL("Sp. Def")
  commands[cmdSpd = commands.length] = _INTL("Speed")
  commands[cmdQuit = commands.length] = _INTL("Cancel")
  #
  cmd = scene.pbShowCommands(_INTL("Do what with {1}?",pkmn.name),commands)
    if cmdHP>=0 && cmd==cmdHP
      if pkmn.iv[0] == 31 # Max HP IV
        scene.pbMessage(_INTL("Your {1} already has a perfect HP IV.",pkmn.name))
        next false
      else
        pkmn.iv[0] = 31
        pkmn.calcStats
        scene.pbMessage(_INTL("Your {1} now has a perfect HP IV!",pkmn.name))
      end
    elsif cmdAtk>=0 && cmd==cmdAtk
      if pkmn.iv[1] == 31 # Max Attack IV
        scene.pbMessage(_INTL("Your {1} already has a perfect Attack IV.",pkmn.name))
        next false
      else
        pkmn.iv[1] = 31
        pkmn.calcStats
        scene.pbMessage(_INTL("Your {1} now has a perfect Attack IV!",pkmn.name))
      end
    elsif cmdDef>=0 && cmd==cmdDef
      if pkmn.iv[2] == 31 # Max Defense IV
        scene.pbMessage(_INTL("Your {1} already has a perfect Defense IV.",pkmn.name))
        next false
      else
        pkmn.iv[2] = 31
        pkmn.calcStats
        scene.pbMessage(_INTL("Your {1} now has a perfect Defense IV!",pkmn.name))
      end
    elsif cmdSpAtk>=0 && cmd==cmdSpAtk
      if pkmn.iv[4] == 31 # Max Sp. Atk IV
        scene.pbMessage(_INTL("Your {1} already has a perfect Sp. Atk IV.",pkmn.name))
        next false
      else
        pkmn.iv[4] = 31
        pkmn.calcStats
        scene.pbMessage(_INTL("Your {1} now has a perfect Sp. Atk IV!",pkmn.name))
      end
    elsif cmdSpDef>=0 && cmd==cmdSpDef
      if pkmn.iv[5] == 31 # Max Sp. Def IV
        scene.pbMessage(_INTL("Your {1} already has a perfect Sp. Def IV.",pkmn.name))
        next false
      else
        pkmn.iv[5] = 31
        pkmn.calcStats
        scene.pbMessage(_INTL("Your {1} now has a perfect Sp. Def IV!",pkmn.name))
      end
    elsif cmdSpd>=0 && cmd==cmdSpd
      if pkmn.iv[3] == 31 # Max Speed IV
        scene.pbMessage(_INTL("Your {1} already has a perfect Speed IV.",pkmn.name))
        next false
      else
        pkmn.iv[3] = 31
        pkmn.calcStats
        scene.pbMessage(_INTL("Your {1} now has a perfect Speed IV!",pkmn.name))
      end
    else
      next false
    end
  cmd = scene.pbShowCommands(_INTL("Do what with {1}?",pkmn.name),commands)
  scene.pbRefresh
  next true
})

The code is not pretty and I'm fairly certain there are better ways to do this, but it does work in v18.1. Put this in PItem_ItemEffects (I put it just below Rare Candy, but I don't think it matters).

You'll then need to define the item in your items.txt file, e.g.

XXX,ULTRAIVTRAINER,Ultra IV Trainer,Ultra IV Trainers,1,0,"This is a test.",1,0,0,

Tweak this as you want. You'll need a graphic as well.

Let me know it it doesn't work for you.