[Script✓] Broken trainerbattle_ event scripts

[Meister_anon~Master_o f_None]

So I'm using pokefirered and to save space, I removed the help system, union room stuff, and the famechecker & vs seeker.

I thought it was a smooth process, but now I've found an odd issue, in gym leader battles,
when the trainerbattle type, is the uses the trainerbattle_single continue script it fails and goes to a black screen,
instead of returning from the battle scene back to the overworld.

this is what I'm talking about, its from the event.inc file

I'm not 100%, but I think the issue has to do with the changes to do with the vs seeker.
My guess is somewhere each of the types were listed in an enum or defined somewhere,
and removing the rematch stuff shifted things.

Spoiler:

@ If the Trainer flag for Trainer index is not set, this command does absolutely nothing.
	.macro trainerbattle type:req, trainer:req, word:req, pointer1:req, pointer2, pointer3, pointer4
		.byte 0x5c
		.byte \type
		.2byte \trainer
		.2byte \word
		.if \type == TRAINER_BATTLE_SINGLE
			.4byte \pointer1 @ text
			.4byte \pointer2 @ text
		.elseif \type == TRAINER_BATTLE_CONTINUE_SCRIPT_NO_MUSIC
			.4byte \pointer1 @ text
			.4byte \pointer2 @ text
			.4byte \pointer3 @ event script
		.elseif \type == TRAINER_BATTLE_CONTINUE_SCRIPT
			.4byte \pointer1 @ text
			.4byte \pointer2 @ text
			.4byte \pointer3 @ event script
		.elseif \type == TRAINER_BATTLE_SINGLE_NO_INTRO_TEXT
			.4byte \pointer1 @ text
		.elseif \type == TRAINER_BATTLE_DOUBLE
			.4byte \pointer1 @ text
			.4byte \pointer2 @ text
			.4byte \pointer3 @ text
		.elseif \type == TRAINER_BATTLE_REMATCH
			.4byte \pointer1 @ text
			.4byte \pointer2 @ text
		.elseif \type == TRAINER_BATTLE_CONTINUE_SCRIPT_DOUBLE
			.4byte \pointer1 @ text
			.4byte \pointer2 @ text
			.4byte \pointer3 @ text
			.4byte \pointer4 @ event script
		.elseif \type == TRAINER_BATTLE_REMATCH_DOUBLE
			.4byte \pointer1 @ text
			.4byte \pointer2 @ text
			.4byte \pointer3 @ text
		.elseif \type == TRAINER_BATTLE_CONTINUE_SCRIPT_DOUBLE_NO_MUSIC
			.4byte \pointer1 @ text
			.4byte \pointer2 @ text
			.4byte \pointer3 @ text
			.4byte \pointer4 @ event script
		.elseif \type == TRAINER_BATTLE_EARLY_RIVAL
			.4byte \pointer1 @ text
			.4byte \pointer2 @ text
		.endif
	.endm

 

[McPaul]

Not really good with FRLG but maybe you deleted some strings used to reload the map after a battle. You should maybe search in vanilla pokefirered for some command called loadmap or reloadmap (just suggesting it could be this, I don't know actually) and restore the ones deleted in your process.

 

[Meister_anon~Master_o f_None]

Not really good with FRLG but maybe you deleted some strings used to reload the map after a battle. You should maybe search in vanilla pokefirered for some command called loadmap or reloadmap (just suggesting it could be this, I don't know actually) and restore the ones deleted in your process.

thanks for the response, was able to get a solution with some help.

Turns out brocks event script/battlestring overflows the space, and GameFreak used a weird work around to make it work,
which happened to be something I removed for ewram space, because it otherwise seemed to be unused.

guess the lesson is, anyone working in firered, never remove this line from the battle_main.c file.

static EWRAM_DATA u32 gUnknown_2022AE8[25] = {0};

 

[Lunos]

thanks for the response, was able to get a solution with some help.

Turns out brocks event script/battlestring overflows the space, and GameFreak used a weird work around to make it work,
which happened to be something I removed for ewram space, because it otherwise seemed to be unused.

guess the lesson is, anyone working in firered, never remove this line from the battle_main.c file.

static EWRAM_DATA u32 gUnknown_2022AE8[25] = {0};

An alternative solution is to expand the size of gDisplayedStringBattle from 300 bytes to something like 400 instead, and then getting rid of gUnknown_2022AE8 entirely.