[Scripting Question] Displaying Pokémon’s icon in the Battle Databox

[HM100]

Hello. I'm trying to add Pokémon 's icon to be displayed in the battle databox but when I try to do that, it causes the game to crash. Is there a way to achieve this without causing the game to crash

 

[Maruno]

Do you want to show us the error message you got? How about the code you've changed? I don't feel like reading your mind at the moment.

 

[HM100]

It displayed that Sprite Resizer couldn't convert it into viewport. The only code I added is in the def refresh of the databox code to display Pokémon's icon.

 

[Vendily]

That doesn't really tell us what you changed. Can you show us the def refresh of the database class? Perhaps you've passed a bad argument.

 

[HM100]

That doesn't really tell us what you changed. Can you show us the def refresh of the database class? Perhaps you've passed a bad argument.

Later. Just added after the shiny icon display for shony Pokémon, three lines that set a variable to be a Pokémon Icon, then set its x and y and it crashed giving a sprite_resizer error. I will give the code once I use my PC for the internet. I can't while using my tab.

 

[HM100]

Here's some code of the Databox I use (See Spoilers for code)

Spoiler:

  def initialize(battler,doublebattle,viewport=nil)
    super(viewport)
    @explevel=0
    @battler=battler
    @selected=0
    @frame=0
    @showhp=false
    @showexp=false
    @appearing=false
    @animatingHP=false
    @dark=false
    @starthp=0
    @currenthp=0
    @endhp=0
    @expflash=0
    if (@battler.index&1)==0 # if player's Pokémon
      @spritebaseX=34
    else
      @spritebaseX=16
    end
    $inbattle=true
    if doublebattle
      $dbattle=true
      case @battler.index
      when 0
        @databox=AnimatedBitmap.new("Graphics/Global Pictures/databox_D")
        @spriteX=PokeBattle_SceneConstants::PLAYERBOXD1_X
        @spriteY=PokeBattle_SceneConstants::PLAYERBOXD1_Y
      when 1 
        @databox=AnimatedBitmap.new("Graphics/Global Pictures/databox_D1")
        @spriteX=PokeBattle_SceneConstants::FOEBOXD1_X
        @spriteY=PokeBattle_SceneConstants::FOEBOXD1_Y
        @dark=true
      when 2 
        @databox=AnimatedBitmap.new("Graphics/Global Pictures/databox_D2")
        @spriteX=PokeBattle_SceneConstants::PLAYERBOXD2_X
        @spriteY=PokeBattle_SceneConstants::PLAYERBOXD2_Y
        @dark=true
      when 3 
        @databox=AnimatedBitmap.new("Graphics/Global Pictures/databox_D3")
        @spriteX=PokeBattle_SceneConstants::FOEBOXD2_X
        @spriteY=PokeBattle_SceneConstants::FOEBOXD2_Y
      end
    else
      $dbattle=false
      case @battler.index
      when 0
        @databox=AnimatedBitmap.new("Graphics/Global Pictures/databox_S")
        @spriteX=PokeBattle_SceneConstants::PLAYERBOX_X
        @spriteY=PokeBattle_SceneConstants::PLAYERBOX_Y
        @showhp=true
        #@showexp=true Goodbye!!!
      when 1 
        @databox=AnimatedBitmap.new("Graphics/Global Pictures/databox_S1")
        @spriteX=PokeBattle_SceneConstants::FOEBOX_X
        @spriteY=PokeBattle_SceneConstants::FOEBOX_Y
				@showhp=true
        @dark=true
      end
    end
    @statuses=AnimatedBitmap.new(_INTL("Graphics/Global Pictures/battleStatuses"))
    @contents=BitmapWrapper.new(@databox.width,@databox.height)
    self.bitmap=@contents
    self.visible=false
    self.z=50
    @pokeicon=PokemonIconSprite.new(@battler.pokemon,viewport) # ADDED
    refreshExpLevel
    refresh
  end

  def dispose
    @statuses.dispose
    @databox.dispose
    @contents.dispose
    @pokeicon.dispose # ADDED
    super
  end

  def refresh
    self.bitmap.clear
    return if [email protected]
    self.bitmap.blt(0,0,@databox.bitmap,Rect.new(0,0,@databox.width,@databox.height))
    if @dark
    base=PokeBattle_SceneConstants::BOXTEXTBASECOLOR
    shadow=PokeBattle_SceneConstants::BOXTEXTSHADOWCOLOR
    outline=Color.new(7,16,39)
    else
    base=PokeBattle_SceneConstants::BOXTEXTBASECOLOR2
    shadow=PokeBattle_SceneConstants::BOXTEXTSHADOWCOLOR2
    outline=Color.new(248,248,216)
    end
    [email protected]
    pbSetSystemFont(self.bitmap)
    pbSetSmallFont2(self.bitmap)
    textpos=[
       [pokename,@spritebaseX+8,8,false,base]
    ]
    imagepos=[]
    genderX=self.bitmap.text_size(pokename).width
    genderX+=@spritebaseX+14
    case @battler.displayGender
    when 0 # Male
 #     textpos.push([_INTL("♂"),genderX,6,false,outline,Color.new(48,96,216),1])
    imagepos.push(["Graphics/Pictures/gender_male",genderX,14,0,0,-1,-1])
    when 1 # Female
 #     textpos.push([_INTL("♀"),genderX,6,false,outline,Color.new(248,88,40),1])
    imagepos.push(["Graphics/Pictures/gender_female",genderX,14,0,0,-1,-1])
    end
    pbDrawTextPositions(self.bitmap,textpos)
    pbSetSmallFont(self.bitmap)
    if @dark
    imagepos.push(["Graphics/Pictures/white_lv2",
       @spritebaseX+180-self.bitmap.text_size(@battler.level.to_s).width,16,0,0,-1,-1])
    else
    imagepos.push(["Graphics/Pictures/storage_lv2",
       @spritebaseX+180-self.bitmap.text_size(@battler.level.to_s).width,16,0,0,-1,-1])
    end
    textpos=[
       [_INTL("{1}",@battler.level),@spritebaseX+202,8,true,base,shadow]
    ]
    if @showhp
      hpstring=_ISPRINTF("{1: 2d}/{2: 2d}",self.hp,@battler.totalhp)
      textpos.push([hpstring,@spritebaseX+8,48,false,base,shadow]) # Was 188
    end
    pbDrawTextPositions(self.bitmap,textpos)
    if @battler.isShiny?
      shinyX=206
      shinyX=-6 if (@battler.index&1)==0 # If player's Pokémon
      imagepos.push(["Graphics/Pictures/shiny.png",@spritebaseX+shinyX,12,0,0,-1,-1])
    end
   # CHANGE START
    shinyX=206
    shinyX=-6 if (@battler.index&1)==0 # If player's Pokémon
    @iconx=@spritebaseX+shinyX
    if @pokeicon
      @pokeicon.x=@iconx
      @pokeicon.y=36
      @pokeicon.update
    end
   # CHANGE END
    if @battler.isMega?
      imagepos.push(["Graphics/Pictures/battleMegaEvoBox.png",@spritebaseX+8,34,0,0,-1,-1])
    elsif @battler.isPrimal?
      if isConst?(@battler.pokemon.species,PBSpecies,:KYOGRE)
        imagepos.push(["Graphics/Pictures/battlePrimalKyogreBox.png",@spritebaseX+140,4,0,0,-1,-1])
      elsif isConst?(@battler.pokemon.species,PBSpecies,:GROUDON)
        imagepos.push(["Graphics/Pictures/battlePrimalGroudonBox.png",@spritebaseX+140,4,0,0,-1,-1])
      end
    end
    if @battler.owned && (@battler.index&1)==1
      imagepos.push(["Graphics/Pictures/battleBoxOwned.png",@spritebaseX+8,36,0,0,-1,-1])
    end
    pbDrawImagePositions(self.bitmap,imagepos)
    if @battler.status>0
      self.bitmap.blt(@spritebaseX+24,36,@statuses.bitmap,
         Rect.new(0,(@battler.status-1)*16,44,16))
    end
    hpGaugeSize=PokeBattle_SceneConstants::HPGAUGESIZE
    [email protected]==0 ? 0 : (self.hp*hpGaugeSize/@battler.totalhp)
    hpgauge=2 if hpgauge==0 && self.hp>0
    hpzone=0
    hpzone=1 if self.hp<=(@battler.totalhp/2).floor
    hpzone=2 if self.hp<=(@battler.totalhp/4).floor
    hpcolors=[
       PokeBattle_SceneConstants::HPCOLORGREENDARK,
       PokeBattle_SceneConstants::HPCOLORGREEN,
       PokeBattle_SceneConstants::HPCOLORYELLOWDARK,
       PokeBattle_SceneConstants::HPCOLORYELLOW,
       PokeBattle_SceneConstants::HPCOLORREDDARK,
       PokeBattle_SceneConstants::HPCOLORRED
    ]
    # fill with black (shows what the HP used to be)
    hpGaugeX=PokeBattle_SceneConstants::HPGAUGE_X
    hpGaugeY=PokeBattle_SceneConstants::HPGAUGE_Y
    if @animatingHP && self.hp>0
      self.bitmap.fill_rect(@spritebaseX+hpGaugeX,hpGaugeY,
         @starthp*hpGaugeSize/@battler.totalhp,6,Color.new(0,0,0))
    end
    # fill with HP color
    self.bitmap.fill_rect(@spritebaseX+hpGaugeX,hpGaugeY,hpgauge,2,hpcolors[hpzone*2])
    self.bitmap.fill_rect(@spritebaseX+hpGaugeX,hpGaugeY+2,hpgauge,4,hpcolors[hpzone*2+1])
    if @showexp
      # fill with EXP color
      expGaugeX=PokeBattle_SceneConstants::EXPGAUGE_X
      expGaugeY=PokeBattle_SceneConstants::EXPGAUGE_Y
      self.bitmap.fill_rect(@spritebaseX+expGaugeX,expGaugeY,self.exp,2,
         PokeBattle_SceneConstants::EXPCOLORSHADOW)
      self.bitmap.fill_rect(@spritebaseX+expGaugeX,expGaugeY+2,self.exp,2,
         PokeBattle_SceneConstants::EXPCOLORBASE)
    end
  end

Please note that it also has some other working changes I did barring the icon addition to the battle hud databoxes

 

[Vendily]

So here's the thing. The icon code by itself works completely fine, in both v17.2 and v16.2 (since the latter is what you are using).

Can you post the full stack trace? I don't think it was the icon that caused this error. Or at the very least, there's more to be seen here.

 

[HM100]

So here's the thing. The icon code by itself works completely fine, in both v17.2 and v16.2 (since the latter is what you are using).

Can you post the full stack trace? I don't think it was the icon that caused this error. Or at the very least, there's more to be seen here.

The problem must be with the viewport parameter. I used self.bitmap but it crashed when using that as viewport

 

[Maruno]

To be blunt, if you knew what the problem was, you wouldn't be asking for help. You have also repeatedly failed to show us the error message you get. We want to actually see it, not have you tell us very little about it.

You say you used self.bitmap as a viewport (which is just wrong, of course; a bitmap isn't a viewport), but your code doesn't show this. Again, you're not showing us all the information we might need to actually help you.

 

[HM100]

In the end I tried several methods and it seems that I have fixed that problem without any errors. Only bug is that it is displayed as if the viewport was the entire window size. Now no errors appear!