[Scripting Question] Form Change on Evolution

[StCooler]

EDIT: Check this post of the complete answer.

actually, one slight issue here. the evolution scene works perfectly, but now the message afterwards asking if it would like to learn a move doesn't display a name. i tried to paste in the code you have there, tweaking it a little bit, but no dice.

Can you screen?
I don't have this bug.

 

[Foxx_Gaming]

i believe it might also be affecting my other form sprites as well, as necrozma_1 doesn't appear with the dusk mane sprite in battle or in summary, and when it changes to ultra necrozma (i have it set as a similar process to mega evo) it doesn't change the sprite either.
edit: just confirmed it. by commenting out the new script, necrozma shows up with the right form.

raichu error

Spoiler:

necrozma error

Spoiler:

 

[StCooler]

EDIT: Check this post of the complete answer.


For Necrozma, this is my bad.
In my code for the function:

def pbCheckPokemonBitmapFiles(params)

replace the line:

  params[4] = sp[1]

with

  params[4] = sp[1] if !params[4] || sp[1] != 0

For the missing name of Raichu, can you post the entire code of the function:

def pbLearnMove(pkmn,move,ignoreifknown=false,bymachine=false,&block)

 

[Foxx_Gaming]

here you go

Spoiler:

def pbLearnMove(pkmn,move,ignoreifknown=false,bymachine=false,&block)
  return false if !pkmn
  movename = PBMoves.getName(move)
  if pkmn.egg? && !$DEBUG
    pbMessage(_INTL("Eggs can't be taught any moves."),&block)
    return false
  end
  if pkmn.shadowPokemon?
    pbMessage(_INTL("Shadow Pokémon can't be taught any moves."),&block)
    return false
  end
  pkmnname = pkmn.name
  if pkmn.hasMove?(move)
    pbMessage(_INTL("{1} already knows {2}.",pkmnname,movename),&block) if !ignoreifknown
    return false
  end
  if pkmn.numMoves<4
    pkmn.pbLearnMove(move)
    pbMessage(_INTL("\\se[]{1} learned {2}!\\se[Pkmn move learnt]",pkmnname,movename),&block)
    return true
  end
  loop do
    pbMessage(_INTL("{1} wants to learn {2}, but it already knows four moves.\1",pkmnname,movename),&block) if !bymachine
    pbMessage(_INTL("Please choose a move that will be replaced with {1}.",movename),&block)
    forgetmove = pbForgetMove(pkmn,move)
    if forgetmove>=0
      oldmovename = PBMoves.getName(pkmn.moves[forgetmove].id)
      oldmovepp   = pkmn.moves[forgetmove].pp
      pkmn.moves[forgetmove] = PBMove.new(move)   # Replaces current/total PP
      if bymachine && !NEWEST_BATTLE_MECHANICS
        pkmn.moves[forgetmove].pp = [oldmovepp,pkmn.moves[forgetmove].totalpp].min
      end
      pbMessage(_INTL("1,\\wt[16] 2, and\\wt[16]...\\wt[16] ...\\wt[16] ... Ta-da!\\se[Battle ball drop]\1"),&block)
      pbMessage(_INTL("{1} forgot how to use {2}.\\nAnd...\1",pkmnname,oldmovename),&block)
      pbMessage(_INTL("\\se[]{1} learned {2}!\\se[Pkmn move learnt]",pkmnname,movename),&block)
      pkmn.changeHappiness("machine") if bymachine
      return true
    elsif pbConfirmMessage(_INTL("Give up on learning {1}?",movename),&block)
      pbMessage(_INTL("{1} did not learn {2}.",pkmnname,movename),&block)
      return false
    end
  end
end

also, i'm not sure how to color things like how you do

 

[StCooler]

EDIT: Check this post of the complete answer.

here you go

Spoiler:

def pbLearnMove(pkmn,move,ignoreifknown=false,bymachine=false,&block)
  return false if !pkmn
  movename = PBMoves.getName(move)
  if pkmn.egg? && !$DEBUG
    pbMessage(_INTL("Eggs can't be taught any moves."),&block)
    return false
  end
  if pkmn.shadowPokemon?
    pbMessage(_INTL("Shadow Pokémon can't be taught any moves."),&block)
    return false
  end
  pkmnname = pkmn.name
  if pkmn.hasMove?(move)
    pbMessage(_INTL("{1} already knows {2}.",pkmnname,movename),&block) if !ignoreifknown
    return false
  end
  if pkmn.numMoves<4
    pkmn.pbLearnMove(move)
    pbMessage(_INTL("\\se[]{1} learned {2}!\\se[Pkmn move learnt]",pkmnname,movename),&block)
    return true
  end
  loop do
    pbMessage(_INTL("{1} wants to learn {2}, but it already knows four moves.\1",pkmnname,movename),&block) if !bymachine
    pbMessage(_INTL("Please choose a move that will be replaced with {1}.",movename),&block)
    forgetmove = pbForgetMove(pkmn,move)
    if forgetmove>=0
      oldmovename = PBMoves.getName(pkmn.moves[forgetmove].id)
      oldmovepp   = pkmn.moves[forgetmove].pp
      pkmn.moves[forgetmove] = PBMove.new(move)   # Replaces current/total PP
      if bymachine && !NEWEST_BATTLE_MECHANICS
        pkmn.moves[forgetmove].pp = [oldmovepp,pkmn.moves[forgetmove].totalpp].min
      end
      pbMessage(_INTL("1,\\wt[16] 2, and\\wt[16]...\\wt[16] ...\\wt[16] ... Ta-da!\\se[Battle ball drop]\1"),&block)
      pbMessage(_INTL("{1} forgot how to use {2}.\\nAnd...\1",pkmnname,oldmovename),&block)
      pbMessage(_INTL("\\se[]{1} learned {2}!\\se[Pkmn move learnt]",pkmnname,movename),&block)
      pkmn.changeHappiness("machine") if bymachine
      return true
    elsif pbConfirmMessage(_INTL("Give up on learning {1}?",movename),&block)
      pbMessage(_INTL("{1} did not learn {2}.",pkmnname,movename),&block)
      return false
    end
  end
end

also, i'm not sure how to color things like how you do

Sorry, I had completely forgotten about this thread!
Your code here is perfectly fine.
Can you post the entire code for:

def pbEvolutionSuccess

?

 

[Foxx_Gaming]

no worries! glad you came to check in ^^
here you go, x2

Spoiler:

  def pbEvolutionSuccess
    # Play cry of evolved species
    frames = pbCryFrameLength(@newspecies,@pokemon.form)
    pbBGMStop
    pbPlayCrySpecies(@newspecies,@pokemon.form)
    frames.times do
      Graphics.update
      pbUpdate
    end
    # Success jingle/message
    pbMEPlay("Evolution success")
    newspeciesname = PBSpecies.getName(@newspecies)
    if !newspeciesname || newspeciesname == ""
      formname = pbGetMessage(MessageTypes::FormNames, @newspecies)
      newspeciesname = PBSpecies.getName(pbGetSpeciesFromFSpecies(@newspecies)[0])
      newspeciesname = newspeciesname + " - " + formname if formname != ""
    end
    oldspeciesname = PBSpecies.getName(@pokemon.species)
    pbMessageDisplay(@sprites["msgwindow"],
       _INTL("\\se[]Congratulations! Your {1} evolved into {2}!\\wt[80]",
       @pokemon.name,newspeciesname)) { pbUpdate }
    @sprites["msgwindow"].text = ""
    # Check for consumed item and check if Pokémon should be duplicated
    pbEvolutionMethodAfterEvolution
    # Modify Pokémon to make it evolved
    @pokemon.species = @newspecies
    @pokemon.name    = newspeciesname if @pokemon.name==oldspeciesname
    @pokemon.form    = 0 if @pokemon.isSpecies?(:MOTHIM)
    @pokemon.calcStats
    # See and own evolved species
    $Trainer.seen[@newspecies]  = true
    $Trainer.owned[@newspecies] = true
    pbSeenForm(@pokemon)
    # Learn moves upon evolution for evolved species
    movelist = @pokemon.getMoveList
    for i in movelist
      next if i[0]!=0 && i[0][email protected]   # 0 is "learn upon evolution"
      pbLearnMove(@pokemon,i[1],true) { pbUpdate }
    end
  end

 

[StCooler]

EDIT: Check this post of the complete answer.

no worries! glad you came to check in ^^
here you go, x2

First, I introduced a bug where, if it all went well, your Pokémon would be named Raichu - Alolan, instead of simply Raichu lol. (Solved in the code below)

I don't see an error in your code. Actually I'm looking for a missing pokemon.name = newspeciesname somewhere.
The fact that your game shows:

Congratulation, your Pikachu evolved into Raichu - Alolan Form!

means that, in the function

  def pbEvolutionSuccess

we have the values:

@pokemon.name = "Pikachu"
newspeciesname  = "Raichu - Alolan"

Later, in the line:

    @pokemon.name    = newspeciesname if @pokemon.name==oldspeciesname

we should have the values:

@pokemon.name    = "Raichu - Alolan" # With your original code
@pokemon.name    = "Raichu" # With the fixed code

but in

def pbLearnMove(pkmn,move,ignoreifknown=false,bymachine=false,&block)

your bug basically says that we have the value:

pkmn.name    = "" # Instead of "Raichu" / "Raichu - Alolan"

but I don't see where that would be changed...

This is my last attempt; if it fails, we will have to enter critical mode. (It's not an official term lol). Critical mode means we need to track variables, and thus, add display messages anywhere suspicious. I have included many "pbMessage" lines; uncomment them if that code doesn't work.

Spoiler:

  def pbEvolutionSuccess
    # Evolution in a different form:
    newfspecies = @newspecies
    sp = pbGetSpeciesFromFSpecies(@newspecies)
    form = @pokemon.form 
    if sp[1] != 0 
      # This means that the Pokémon is evolving into another form.
      form = sp[1]
      @newspecies = sp[0]
    end 
    # Play cry of evolved species
    frames = pbCryFrameLength(@newspecies,form)
    pbBGMStop
    pbPlayCrySpecies(@newspecies,form)
    frames.times do
      Graphics.update
      pbUpdate
    end
    # Success jingle/message
    pbMEPlay("Evolution success")
    # pbMessage(_INTL("Step 1.  @pokemon.name = {1}", @pokemon.name))
    # Display the name of the Species + form when applicable.
    newspeciesname = PBSpecies.getName(@newspecies)
    newspeciesnamecomplete = newspeciesname
    formname = pbGetMessage(MessageTypes::FormNames, newfspecies)
    newspeciesnamecomplete = newspeciesname + " - " + formname if formname != ""
    # pbMessage(_INTL("Step 2. @pokemon.name = {1}", @pokemon.name))
    oldspeciesname = PBSpecies.getName(@pokemon.species)
    pbMessageDisplay(@sprites["msgwindow"],
       _INTL("\\se[]Congratulations! Your {1} evolved into {2}!\\wt[80]",
       @pokemon.name,newspeciesnamecomplete)) { pbUpdate }
    @sprites["msgwindow"].text = ""
    # Check for consumed item and check if Pokémon should be duplicated
    pbEvolutionMethodAfterEvolution
    # Modify Pokémon to make it evolved
    @pokemon.species = @newspecies
    @pokemon.name    = newspeciesname if @pokemon.name==oldspeciesname
    # pbMessage(_INTL("Step 3. @pokemon.name = {1}", @pokemon.name))
    @pokemon.form    = form
    @pokemon.form    = 0 if @pokemon.isSpecies?(:MOTHIM)
    @pokemon.calcStats
    # See and own evolved species
    $Trainer.seen[@newspecies]  = true
    $Trainer.owned[@newspecies] = true
    pbSeenForm(@pokemon)
    # pbMessage(_INTL("Step 4. @pokemon.name = {1}", @pokemon.name))
    # Learn moves upon evolution for evolved species
    movelist = @pokemon.getMoveList
    for i in movelist
      next if i[0]!=0 && i[0][email protected]   # 0 is "learn upon evolution"
      # pbMessage(_INTL("Step 5. @pokemon.name = {1}", @pokemon.name))
      pbLearnMove(@pokemon,i[1],true) { pbUpdate }
    end
  end

 

[Foxx_Gaming]

that did it! made sure it worked for if the pokemon had a nickname and if it was another species (exeggcute) and it all works like a charm!
thank you so much for your help (once again). this was something i had tried to figure out way earlier on in the dev cycle and it's been bugging me for like 2 or so years.

 

[StCooler]

Wonderful :D

I'm making this final post to sum up the answer, to anyone who opens this thread might see a unique post. (Please add a link to this post in your original post too)

TUTORIAL (ESSENTIALS V18)

HOW TO MAKE A POKEMON EVOLVE IN A DIFFERENT FORM

This only works for Essentials v18. Essentials v19 has its own way of handling this.

Let's say you want Pikachu to evolve into Raichu with a Thunderstone, and into Alolan Raichu with a Sunstone.
You can always adapt this to any evolution method you want.

1. Make a new script, and add this code in it:
   
   Spoiler:

   
   

   class PokemonEvolutionScene
     def pbEvolutionSuccess
       # Evolution in a different form:
       newfspecies = @newspecies
       sp = pbGetSpeciesFromFSpecies(@newspecies)
       form = @pokemon.form 
       if sp[1] != 0 
         # This means that the Pokémon is evolving into another form.
         form = sp[1]
         @newspecies = sp[0]
       end 
       # Play cry of evolved species
       frames = pbCryFrameLength(@newspecies,form)
       pbBGMStop
       pbPlayCrySpecies(@newspecies,form)
       frames.times do
         Graphics.update
         pbUpdate
       end
       # Success jingle/message
       pbMEPlay("Evolution success")
       # Display the name of the Species + form when applicable.
       newspeciesname = PBSpecies.getName(@newspecies)
       newspeciesnamecomplete = newspeciesname
       formname = pbGetMessage(MessageTypes::FormNames, newfspecies)
       newspeciesnamecomplete = newspeciesname + " - " + formname if formname != ""
       oldspeciesname = PBSpecies.getName(@pokemon.species)
       pbMessageDisplay(@sprites["msgwindow"],
          _INTL("\\se[]Congratulations! Your {1} evolved into {2}!\\wt[80]",
          @pokemon.name,newspeciesnamecomplete)) { pbUpdate }
       @sprites["msgwindow"].text = ""
       # Check for consumed item and check if Pokémon should be duplicated
       pbEvolutionMethodAfterEvolution
       # Modify Pokémon to make it evolved
       @pokemon.species = @newspecies
       @pokemon.name    = newspeciesname if @pokemon.name==oldspeciesname
       @pokemon.form    = form
       @pokemon.form    = 0 if @pokemon.isSpecies?(:MOTHIM)
       @pokemon.calcStats
       # See and own evolved species
       $Trainer.seen[@newspecies]  = true
       $Trainer.owned[@newspecies] = true
       pbSeenForm(@pokemon)
       # Learn moves upon evolution for evolved species
       movelist = @pokemon.getMoveList
       for i in movelist
         next if i[0]!=0 && i[0][email protected]   # 0 is "learn upon evolution"
         pbLearnMove(@pokemon,i[1],true) { pbUpdate }
       end
     end
   end

   
   
   
2. In your PBS file pokemonforms.txt, check out the form number of the form you want to evolve to. Alolan Raichu is already defined, and its header says:
   

   [RAICHU, 1]

   The form number is 1.
3. In the PBS file pokemon.txt, add the evolution to this form.
   

   Evolutions = RAICHU,Item,THUNDERSTONE,RAICHU_1,Item,SUNSTONE

   You can always adapt this to any evolution method you want.

 

[Kowi]

Sorry to barge in like that, but:

Essentials v19 has its own way of handling this.

Do you know exactly how? I've been trying to get something like this working for a while but I feel like I'm running in circles with this.

 

[StCooler]

Sorry to barge in like that, but:

Essentials v19 has its own way of handling this.

Do you know exactly how? I've been trying to get something like this working for a while but I feel like I'm running in circles with this.

Apparently, the first post by burningplain seems to say that it should work without any script edit:

It should just be RAICHU_1 in the evolutions section to denote the second form. Make sure your pokemonforms.txt has raichu alola defined.

Note that base essentials 19.1 doesnt have a graphic for raichu alolan, so it will look like raichu, so check your pokemons stats to see if it is a psychic type.

 

[Kowi]

I've tried that already, to no avail sadly

 

[StCooler]

I've tried that already, to no avail sadly

I don't use v19.1. You'll have to make a different thread ^^"

 

[Loremaster Teach]

EDIT: NVM I didn't actually get it to work. all i changed was the @pokemon.form = 0 if @pokemon.isSpecies?(:MOTHIM) to @pokemon.form = 0 if @pokemon.isSpecies?(:PIKACHU). it worked for a minute where i was able to go into game and test the evolution. however i am no longer able to do that even after reverting the documents and replicating my exact steps. any thoughts as to why this might be?
So after a bit of finagling with the form evolutions I managed to get it to work. however I am running into an issue where during the evolution animation it only shows a question mark for the form. However I have uploaded battler images into the graphics folder corresponding to the mon. and the images are showing up fine in the party screen and in battle against a wild mon.