Gen 8 V18

[KyureJL]

You can find this in Maruno's Github.

CREDITS: Vendily, TheToxic, HM100, Aioross, WolfPP, MFilice, lolface, Golisopod User, KyureJL, DarrylBD99, Turn20Negate, Zerokid, TheKandinavian, ErwanBeurier, Mutant Yoshi, Maruno.
If you have an old version CREDITS TO: Jonas930 and Marin too

 

[Aioross]

was waiting for someone to create a post like this :p
this is what i got:

####Steely Spirit - adapted from WolfPP

#In Battle_Handlers_Abilities, in the section: DamageCalcUserAllyAbility handlers, add:

BattleHandlers::DamageCalcUserAllyAbility.add(:STEELYSPIRIT,
  proc { |ability,user,target,move,mults,baseDmg,type|
#      mults[ATK_MULT] = (mults[ATK_MULT]*1.5).round if isConst?(type,PBTypes,:STEEL)
      mults[ATK_MULT] = (mults[ATK_MULT]*1.5).round if baseDmg == 8 
  }
)

#In Battle_Handlers_Abilities, in the section: DamageCalcUserAbility handlers, add:

BattleHandlers::DamageCalcUserAbility.add(:STEELYSPIRIT,
  proc { |ability,user,target,move,mults,baseDmg,type|
#      mults[ATK_MULT] = (mults[ATK_MULT]*1.5).round if isConst?(type,PBTypes,:STEEL)
      mults[ATK_MULT] = (mults[ATK_MULT]*1.5).round if baseDmg == 8
  }
)


########################################################################################
####Steam Engine - adapted from WolfPP

#In Battle_Handlers_Abilities, in the section: # TargetAbilityOnHit handlers, add:

BattleHandlers::TargetAbilityOnHit.add(:STEAMENGINE,
  proc { |ability,user,target,move,battle|
    next if !isConst?(move.calcType,PBTypes,:WATER) && !isConst?(move.calcType,PBTypes,:FIRE)
    target.pbRaiseStatStageByAbility(PBStats::SPEED,6,target)
  }
)

#Bug: Steam Engine speed up applies BEFORE move speed down effect, should apply after.

in steely spirit there's 2 similar lines, 1 is commented and the other isnt
the one that is commented is how it should work when the bug is fixed, the one that is not commented out is fully working now but should be obsolete when it gets fixed

steam engine has 1 bug, i tested this by using a 100% slow chance bubblebeam on a coalossal and steam engine speed was activating always before the bubble beam speed down, i kinda got frustrated a bit so i gave up on it xD but i think instead of handling this ability in battle_handlers maybe it would work properly in battle_use_move after the move effects are applied

 

[Aioross]

i'm testing the abilitys u got 1 by 1
so far i tested sand spit, works as it should
doesn't work when the move used against it doesn't do dmg, tried with growl, then with swagger, self confusion dmg also doesn't trigger it, but if there's already a sandstorm up (or if it triggers 2 times) it will bug, and make the ability graphic popup permanently stay in screen
idk if it should refresh or not work entirely if a sandstorm is already up (or other weathers, ill look now) but a simple fix would be to add smth like
if weather != sandstorm
do a sandstorm
else
refresh weather duration

there's also an item that boosts the duration to 8 turns, idk if its auto handled or we need to specify, in case of sandstream isnt specified so i assume its not needed

edit: ok, accidently found out another bug, if u overwrite weather the ability pop up img gets stuck on screen, i just tried to use a tyranitar sand stream, switched out tyranitar and switched him in again and the bug replicates just fine

 

[KyureJL]

can you reproduce this with the sand stream? if you can, it's a v18 bug, report this on the official essentials github

 

[Aioross]

yes, was bugging with sand stream, i didn't test with all weathers, just used sand stream
but if i put ttar in, then switch him out then switch him in again same bug occurs
then i tested taking turns using ttar and kyogre and it was fine it only happens if u try to proc a weather when same weather is already up

i fiddled with it a bit and fixed it (idk if i didnt break other stuff with this tho)

in

def pbBattleWeatherAbility(weather,battler,battle,ignorePrimal=false)

after

return if battle.field.weather==weather && battle.field.weatherDuration==-1

i added

return if battle.field.weather==weather

it had a failsafe to avoid overwriting permanent weather (when it was same weather and duration was -1), but didn't have a failsafe to overwrite normal weather i think the weather duration check could be removed and it would be fine, but im afraid it breaks other stuff so i just added a return in the case of the weather the ability is trying to proc is already up
(tested with both sand spit and sand stream after this "fix") and both work fine

 

[KyureJL]

Aioross find it strange that you say your Steam Engine is buggy, if it is wrong the ability Rattled is also

 

[Aioross]

Aioross find it strange that you say your Steam Engine is buggy, if it is wrong the ability Rattled is also

yeah... well in bulbapedia it specifically says that steam engine will activate after a speed down effect, i've been looking at all the stat changing abilities and rattled is the one that looks most like steam engine, if rattled effect is supposed to trigger after the speed down too then i suppose it will also be bugged

it's just a weird mechanic in this ability... it barely even matters, i think the only situation it matters is when the pokemon is at -6 speed, cuz it will gain +6 then lose being at -1 speed in the end as opposed to -6 + -1 (this one fails cuz it cant go lower) +6 and it's at 0 in the end

 

[KyureJL]

i just corrected something that i found impressive that no one has reported so far since it was a syntax error... i had made a separate file with abilities and moves using the class and forgot to remove an end...

 

[Aioross]

Power Spot, Punk Rock, Stalwart, Propeller Tail

Spoiler:

####Power Spot - Aioros 

#In Battle_Handlers_Abilities, in the section: DamageCalcUserAllyAbility handlers, add:

BattleHandlers::DamageCalcUserAllyAbility.add(:POWERSPOT,
  proc { |ability,user,target,move,mults,baseDmg,type|
    mults[FINAL_DMG_MULT] = (mults[FINAL_DMG_MULT]*1.3).round
  }
)

####Punk Rock - Aioros adapted from WolfPP

#In Battle_Handlers_Abilities, in the section: DamageCalcTargetAbility handlers, add:

BattleHandlers::DamageCalcTargetAbility.add(:PUNKROCK,
  proc { |ability,user,target,move,mults,baseDmg,type|
    mults[DEF_MULT] *= 2 if move.soundMove?
  }
)

#In Battle_Handlers_Abilities, in the section: DamageCalcUserAbility handlers, add:

BattleHandlers::DamageCalcUserAbility.add(:PUNKROCK,
  proc { |ability,user,target,move,mults,baseDmg,type|
      mults[ATK_MULT] = (mults[ATK_MULT]*1.3).round if move.soundMove?
  }
)


####Stalwart + Propeller Tail - Aioros

#In Battler_UseMove_Targeting, in: def pbChangeTargets(move,user,targets), add:

return targets if user.hasActiveAbility?(:STALWART) || user.hasActiveAbility?(:PROPELLERTAIL)

#right after:     
#return targets if !PBTargets.canChooseOneFoeTarget?(targetType) || targets.length!=1

I'm still working on the easy abilities. Gotta love how organized Maruno made the scripts... adding Stalwart / Proller Tail was a piece of cake thanks to it.
Also I tested icy scales, its working 100%, but that psyshock reference is obsolete since it's a special move.

And yeah I think libero is exactly like protean, on the old gen 8 topic WolfPP just added it on protean code. So that's it.


edit: I SPOKE TOO EARLY! Apparently Protean is bugged...
edit2: to fix protean / libero bug:
find

if (user.hasActiveAbility?(:PROTEAN) || user.hasActiveAbility?(:LIBERO)) && !move.callsAnotherMove? && !move.snatched

or

if user.hasActiveAbility?(:PROTEAN) && !move.callsAnotherMove? && !move.snatched

and replace the very next line by

if user.pbHasOtherType?(move.calcType) && !PBTypes.isPseudoType?(move.calcType)

edit: Gorilla Tactics:

Spoiler:

####Gorilla Tactics - Aioros adapted from WolfPP
#Add in PBEffects after yawn(?)
GorillaTactics      = 114 #use the highest number

#In Battler_Initialize
#after    @effects[PBEffects::Yawn]                = 0
    @effects[PBEffects::GorillaTactics]      = -1
	
#In Battle_Handlers_Abilities, in DamageCalcUserAbility
BattleHandlers::DamageCalcUserAbility.add(:GORILLATACTICS,
  proc { |ability,user,target,move,mults,baseDmg,type|
    mults[ATK_MULT] = (mults[ATK_MULT]*1.5).round if move.physicalMove?
  }
)

#In Battler_UseMove, in def pbEndTurn add:
#  def pbEndTurn(choice)
#    @lastRoundMoved = @battle.turnCount   # Done something this round
    if @effects[PBEffects::GorillaTactics]<0 && @lastMoveUsed>=0 && hasActiveAbility?(:GORILLATACTICS)
      @effects[PBEffects::GorillaTactics]=@lastMoveUsed
    end
	
#And in Battler_UseMove_SuccessChecks before "#Choice Band" inside def pbCanChooseMove?....
    if @effects[PBEffects::GorillaTactics]>=0
      if hasActiveAbility?(:GORILLATACTICS)
        if move.id!=@effects[PBEffects::GorillaTactics]
          if showMessages
            msg = _INTL("{1} allows the use of only {2} !",abilityName,PBMoves.getName(@effects[PBEffects::GorillaTactics]))
            (commandPhase) ? @battle.pbDisplayPaused(msg) : @battle.pbDisplay(msg)
          end
          return false
        end
      else
        @effects[PBEffects::GorillaTactics] = -1        
      end
    end

 

[KyureJL]

Aioross report these bugs at Essentials oficial Github in "Issues"
github.com/Maruno17/pokemon-essentials/issues

 

[TheToxic7326]

Also I tested icy scales, its working 100%, but that psyshock reference is obsolete since it's a special move.

From Bulbapedia:

"Ice Scales halves damage from special moves that hit Pokémon with this Ability, including from special moves that use the target's Defense stat (like Psyshock). It has no effect on moves that deal direct damage."

 

[ChaosandCalamity]

Absolute legend.

 

[KyureJL]

Updated with the latest fixes from Essentials official github.

 

[Aioross]

In moves.pbs psyshock is set as a special move, since ice scales checks for special moves, it's not needed to check again for psyshock since it's included in special moves.

Ball Fetch: (this was done sub optimally with a global variable)

Spoiler:

########################################################################################
####Ball Fetch - Aioros (i based this ability on WolfPP's but remade it my way cuz i had trouble adapting his
#Add in PBEffects after gorilla tactics(?)
	BallFetch           = 115 #use the highest number

#In Battler_Initialize
#after    @effects[PBEffects::Yawn] / or gorillatactics  add:
    @effects[PBEffects::BallFetch]           = 0
	
#In Pokebattle_ActiveField add after @effects[PBEffects::WonderRoom]- tbh could be in other places, but here will do the work too
$BallRetrieved                       = 0
#I lost my sanity trying to get this to work with normal variables, since I couldn't I just used a global variable which is kinda sub optimal

#In PokeBattle_BattleCommon, right before def pbThrowPokeBall(idxBattler,ball,rareness=nil,showPlayer=false), add:
  def pbBallFetch(ball)
    if $BallRetrieved == 0 
      $BallRetrieved=ball if ball != 268
    end    
  end

#Inside def pbThrowPokeBall(idxBattler,ball,rareness=nil,showPlayer=false), after each of these lines:
pbDisplay(_INTL("But there was no target..."))

pbDisplay(_INTL("The Trainer blocked your Poké Ball! Don't be a thief!"))

pbDisplay(_INTL("Oh no! The Pokémon broke free!"))
BallHandlers.onFailCatch(ball,self,battler)
 
pbDisplay(_INTL("Aww! It appeared to be caught!"))
BallHandlers.onFailCatch(ball,self,battler)
	  
pbDisplay(_INTL("Aargh! Almost had it!"))
BallHandlers.onFailCatch(ball,self,battler)
	  
pbDisplay(_INTL("Gah! It was so close, too!"))
BallHandlers.onFailCatch(ball,self,battler)

#Add:
pbBallFetch(ball)
##So: Locate every line I mentioned and add pbBallFech(ball) right below it, example:
pbDisplay(_INTL("Gah! It was so close, too!"))
BallHandlers.onFailCatch(ball,self,battler)
pbBallFetch(ball)

#Finally in BattleHandlers_Abilities in EOREffectAbility handlers, add:
BattleHandlers::EOREffectAbility.add(:BALLFETCH,
  proc { |ability,battler,battle|
    if battler.item == 0 && battler.effects[PBEffects::BallFetch]==0 && $BallRetrieved != 0
      battle.pbShowAbilitySplash(battler)
      battler.effects[PBEffects::BallFetch]=1
      battler.item = $BallRetrieved
      battler.setInitialItem($BallRetrieved)
      $BallRetrieved = 0
      battler.battle.pbDisplay(_INTL("{1}'s {2} fetched the {3}!",battler.pbThis,battler.abilityName,battler.itemName))
      battle.pbHideAbilitySplash(battler)
    end    
  }
)

 

[MFilice]

Ice Face, Quick Draw and Ripen:

Spoiler:

Ice Face:

#Ice Face - Michael
#In BattleHandlers::TargetItemOnHit.add(:ENIGMABERRY, add
      target.damageState.iceface
#to the target.damageState.substitute line - do the same in BattleHandlers::TargetItemOnHit.add(:WEAKNESSPOLICY,

#In class PokeBattle_DamageState, add
  attr_accessor :iceface         # Ice Face ability used  
#In def resetPerHit, add
    @iceface       = false 

#In def pbCheckFormOnWeatherChange, under Cherrim, add
    # Eiscue - Ice Face
    if isConst?(@species,PBSpecies,:EISCUE)
      if hasActiveAbility?(:ICEFACE)
        case @battle.pbWeather
        when PBWeather::Hail
          if @form!=0
            @battle.pbShowAbilitySplash(self,true)
            @battle.pbHideAbilitySplash(self)
            pbChangeForm(0,_INTL("{1} transformed!",pbThis))
            self.damageState.iceface = false
          end 
        end
      end

#In  def pbCheckDamageAbsorption(user,target), under Disguise, add 
    # Ice Face will take the damage
    if [email protected] && isConst?(target.species,PBSpecies,:EISCUE) &&
       target.form==0 && isConst?(target.ability,PBAbilities,:ICEFACE) && physicalMove?
      target.damageState.iceface = true
      return
    end   

#In def pbReduceDamage(user,target), under Disguise, add
    # Ice Face takes the damage
    return if target.damageState.iceface  

#In def pbEffectivenessMessage(user,target,numTargets=1), under return if target.damageState.disguise, add
    return if target.damageState.iceface
#Add the same line in def pbHitEffectivenessMessages(user,target,numTargets=1)

#In def pbEndureKOMessage(target), under the if target.damageState.disguise code, add
    elsif target.damageState.iceface
      @battle.pbShowAbilitySplash(target)
      target.pbChangeForm(1,_INTL("{1} transformed!",target.pbThis))
      @battle.pbHideAbilitySplash(target)

#In def pbCalcDamage(user,target,numTargets=1), change if target.damageState.disguise to
    if target.damageState.disguise || target.damageState.iceface
      target.damageState.calcDamage = 1
      return
    end

#Obviously there's all the negation blacklists for moves like gastro acid and role play as well, I just didn't include them because I was lazy

Quick Draw:

#In PriorityBracketChangeAbility handlers, add
BattleHandlers::PriorityBracketChangeAbility.add(:QUICKDRAW,
  proc { |ability,battler,subPri,battle|
    next 1 if subPri<1 && battle.pbRandom(10)<3
  }
)

#Next, in PriorityBracketUseAbility handlers, add
BattleHandlers::PriorityBracketUseAbility.add(:QUICKDRAW,
  proc { |ability,battler,battle|
    battle.pbDisplay(_INTL("{1}'s {2} let it move first!",battler.pbThis,battler.abilityName))
  }
)

Ripen:

# In def pbBattleConfusionBerry(battler,battle,item,forced,flavor,confuseMsg), under amt = (NEWEST_BATTLE_MECHANICS) ? battler.pbRecoverHP(battler.totalhp/2) : battler.pbRecoverHP(battler.totalhp/8), add
  if battler.hasActiveAbility?(:RIPEN)
    amt *= 2
  end

 # In def pbBattleStatIncreasingBerry(battler,battle,item,forced,stat,increment=1), under  itemName = PBItems.getName(item), add
  if battler.hasActiveAbility?(:RIPEN)
    increment *=2
  end  

# In def pbBattleTypeWeakingBerry(type,moveType,target,mults), replace mults[FINAL_DMG_MULT] = (mults[FINAL_DMG_MULT]/2).round with
  if target.hasActiveAbility?(:RIPEN)
    mults[FINAL_DMG_MULT] = (mults[FINAL_DMG_MULT]/4).round
  else
    mults[FINAL_DMG_MULT] = (mults[FINAL_DMG_MULT]/2).round
  end  

# In BattleHandlers::HPHealItem.add(:ORANBERRY, replace battler.pbRecoverHP(10) with 
    if battler.hasActiveAbility?(:RIPEN)
      battler.pbRecoverHP(20)
    else
      battler.pbRecoverHP(10)
    end  

# In BattleHandlers::HPHealItem.add(:SITRUSBERRY, replace battler.pbRecoverHP(battler.totalhp/4) with 
    if battler.hasActiveAbility?(:RIPEN)
      battler.pbRecoverHP?(battler.totalhp/2)
    else
      battler.pbRecoverHP(battler.totalhp/4)
    end  

#In BattleHandlers::HPHealItem.add(:STARFBERRY, replace next pbBattleStatIncreasingBerry(battler,battle,item,forced,stat,2) with
    if battler.hasActiveAbility(:RIPEN)
      next pbBattleStatIncreasingBerry(battler,battle,item,forced,stat,4)
    else
      next pbBattleStatIncreasingBerry(battler,battle,item,forced,stat,2)
   end  

# In BattleHandlers::TargetItemOnHit.add(:JABOCABERRY, replace user.pbReduceHP(user.totalhp/8,false) with 
    if target.hasActiveAbility?(:RIPEN)
      user.pbReduceHP(user.totalhp/4,false)
    else
      user.pbReduceHP(user.totalhp/8,false)
    end   

# In BattleHandlers::TargetItemOnHit.add(:ROWAPBERRY, replace user.pbReduceHP(user.totalhp/8,false) with
    if target.hasActiveAbility?(:RIPEN)
      user.pbReduceHP(user.totalhp/4,false)
    else
      user.pbReduceHP(user.totalhp/8,false)
    end  
 
# In BattleHandlers::TargetItemOnHitPositiveBerry.add(:ENIGMABERRY, replace battler.pbRecoverHP(battler.totalhp/4) with 
    if battler.hasActiveAbility?(:RIPEN)
      battler.pbRecoverHP(battler.totalhp/2)
    else
      battler.pbRecoverHP(battler.totalhp/4)
    end  

# Replace all of BattleHandlers::TargetItemOnHitPositiveBerry.add(:KEEBERRY, with 
BattleHandlers::TargetItemOnHitPositiveBerry.add(:KEEBERRY,
  proc { |item,battler,battle,forced|
    increment=1
    next false if !forced && battle.pbCheckOpposingAbility(:UNNERVE,battler.index)
    next false if !battler.pbCanRaiseStatStage?(PBStats::DEFENSE,battler)
    itemName = PBItems.getName(item)
    if battler.hasActiveAbility?(:RIPEN)
      increment *=2
    end      
    if !forced
      battle.pbCommonAnimation("EatBerry",battler)
      next battler.pbRaiseStatStageByCause(PBStats::DEFENSE,increment,battler,itemName)
    end
    PBDebug.log("[Item triggered] #{battler.pbThis}'s #{itemName}")
    next battler.pbRaiseStatStage(PBStats::DEFENSE,increment,battler)
  }
)

# Replace all of BattleHandlers::TargetItemOnHitPositiveBerry.add(:MARANGABERRY, with 
  proc { |item,battler,battle,forced|
    increment=1
    next false if !forced && battle.pbCheckOpposingAbility(:UNNERVE,battler.index)
    next false if !battler.pbCanRaiseStatStage?(PBStats::SPDEF,battler)
    itemName = PBItems.getName(item)
    if battler.hasActiveAbility?(:RIPEN)
      increment*=2
    end  
    if !forced
      battle.pbCommonAnimation("EatBerry",battler)
      next battler.pbRaiseStatStageByCause(PBStats::SPDEF,increment,battler,itemName)
    end
    PBDebug.log("[Item triggered] #{battler.pbThis}'s #{itemName}")
    next battler.pbRaiseStatStage(PBStats::SPDEF,increment,battler)
  }
)

# (As a side note, the Enigma, Kee and Maranga berries are not consumed - I've already reported it but to fix this, just add target.pbConsumeItem to each of their respective BattleHandlers::TargetItemOnHit sections.)

 

[Aioross]

I'm adding and testing abilities 1 by 1.
Ripen and Pastel Veil are working perfectly.

The Mimicry in github changes forms instead of types... idk it could work. I did a version where it changes types (unecessary)

Spoiler:

########################################################################################
####Mimicry - Aioros adapted from Vendily and WolfPP
#In Battle_Handlers_Abilities, in EOREffectAbility handlers add:

BattleHandlers::EOREffectAbility.add(:MIMICRY,
  proc { |ability,battler,battle|
    battler.pbCheckTypeOnTerrainChange(battler)
  }
)
#Makes sure it reverts type when terrain expires

#In Battle_Handlers_Abilities, in AbilityOnSwitchIn handlers add:

BattleHandlers::AbilityOnSwitchIn.add(:MIMICRY,
  proc { |ability,battler,battle|
    battler.pbCheckTypeOnTerrainChange(battler)
  }
)
#Makes sure it gets the right type when it switches in if there's any terrain active

##In Battler_ChangeSelf, before def pbCheckForm(endOfRound=false) add:
  def pbCheckTypeOnTerrainChange(battler)
    a=battler.type1
    b=battler.type2
    if isConst?(@species,PBSpecies,:STUNFISK) && @form==1 && hasActiveAbility?(:MIMICRY)
      case @battle.field.terrain
      when PBBattleTerrains::Electric
          battler.type1=getConst(PBTypes,:ELECTRIC)
          battler.type2=getConst(PBTypes,:ELECTRIC)
          battler.effects[PBEffects::Type3]=-1
          c = "Electric"
      when PBBattleTerrains::Grassy
          battler.type1=getConst(PBTypes,:GRASS)
          battler.type2=getConst(PBTypes,:GRASS)
          battler.effects[PBEffects::Type3]=-1
          c = "Grass"
      when PBBattleTerrains::Misty
          battler.type1=getConst(PBTypes,:FAIRY)
          battler.type2=getConst(PBTypes,:FAIRY)
          battler.effects[PBEffects::Type3]=-1
          c = "Fairy"
      when PBBattleTerrains::Psychic
          battler.type1=getConst(PBTypes,:PSYCHIC)
          battler.type2=getConst(PBTypes,:PSYCHIC)
          battler.effects[PBEffects::Type3]=-1
          c = "Psychic"
      else 
          battler.type1=getConst(PBTypes,:GROUND)
          battler.type2=getConst(PBTypes,:STEEL)
          battler.effects[PBEffects::Type3]=-1
      end
      if (battler.type1 != a && battler.type2 != b)
          @battle.pbShowAbilitySplash(self,true)
          if battler.type1 == getConst(PBTypes,:GROUND)
            @battle.pbDisplay(_INTL("{1}'s type changed back to normal!",battler.pbThis))
          else
            @battle.pbDisplay(_INTL("{1}'s type changed to {2}!",battler.pbThis,c))
          end
          @battle.pbHideAbilitySplash(self)
      end
    end
  end
  
#In Pokebattle_battle: inside def pbStartTerrain(user,newTerrain,fixedDuration=true), right at the end
# and before Check for terrain seeds that boost stats in a terrain, add:
    for i in @battlers
[B]      next if !i[/B]
      i.pbCheckTypeOnTerrainChange(i)
    end
#Makes sure the ability procs without having to switch in, if any terrain is activated

Cotton Down just needed a minor tweaks, it was proccing the ability graphic in the user (the one who is atacking) instead of target (who has cotton down) and there's no need to check if move is damaging, these abilities only proc if the move is damaging, its already hardcoded in it.

Spoiler:

########################################################################################
####Cotton Down - Aioros slightly tweaked from Vendily
#In Battle_Handlers_Abilities, in TargetAbilityOnHit handlers add:

BattleHandlers::TargetAbilityOnHit.add(:COTTONDOWN,
  proc { |ability,user,target,move,battle|
    battle.pbShowAbilitySplash(target)
    target.eachOpposing{|b|
      b.pbLowerStatStage(PBStats::SPEED,1,target)
    }
    target.eachAlly{|b|
      b.pbLowerStatStage(PBStats::SPEED,1,target)
    }
    battle.pbHideAbilitySplash(target)
  }
)

Perish Body wasn't working as intended so I remade it

Spoiler:

########################################################################################
####PerishBody - Aioros adapted from Vendily and WolfPP
#In Battle_Handlers_Abilities, in TargetAbilityOnHit handlers add:

BattleHandlers::TargetAbilityOnHit.add(:PERISHBODY,
  proc { |ability,user,target,move,battle|
    next if !move.pbContactMove?(user)
    next if !user.affectedByContactEffect?
    next if user.hasMoldBreaker?
    next if user.effects[PBEffects::PerishBody] > 0
    battle.pbShowAbilitySplash(target)
    if target.effects[PBEffects::PerishBody] == 0
      battle.pbDisplay(_INTL("Both Pokémon will faint in three turns!"))
    else
      battle.pbDisplay(_INTL("{1} will faint in three turns!",user.pbThis))
    end    
    user.effects[PBEffects::PerishBody] = 3
    target.effects[PBEffects::PerishBody] = 3 if target.effects[PBEffects::PerishBody] == 0
    battle.pbHideAbilitySplash(target)
  }
)

#In PBEffects, below yawn / ballfetch, add:
    PerishBody          = 116

#In Battler_Initialize, below yawn / ball fetch, add:
    @effects[PBEffects::PerishBody]          = 0
	
#In Battle_Action_Switching, right after: pbDisplayBrief(_INTL("{1} withdrew {2}!",owner,battler.name)), add:
pbDisplayBrief(_INTL("{1} withdrew {2}!",owner,battler.name))

#In Battle_Phase_EndOfRound, after perish song and before "# Check for end of battle", add:
    priority.each do |b|
      next if b.fainted? || b.effects[PBEffects::PerishBody]==0
        b.effects[PBEffects::PerishBody]-=1
        pbDisplay(_INTL("{1}'s perish count fell to {2}!",b.pbThis,b.effects[PBEffects::PerishBody]))
        if b.effects[PBEffects::PerishBody]==0
          b.pbReduceHP(b.hp)
        end
      b.pbFaint if b.fainted?
    end

I still have to test Iceface... but I think I'll save it for another time, I'm a bit tired already and I don't wanna test anything before completely understanding what every part of it does, which I cannot do atm.

!!! The author of Pastel Veil is missing.
edit:
!!! The author of Wandering Spirit from github is also missing.
edit2: Tested now that wandering spirit its functionally 100% but instead of showing
"ABC swapped Abilities with its target!"
it's showing:
"User ability became wandering spirit"
I'm not even sure whats the official way of displaying the ability, just pointing it out here.
edit3: saw this video https://www.youtube.com/watch?v=WBcAQ6vlGS0
apparently the official display is "target(cofragigus in this case) swapped abilities with its target!"
which imo looks awful, since a team mate can proc it and its not rly a target, it should be smth like with its *attacker


Hunger Switch:

Spoiler:

########################################################################################################
########## Hunger Switch - Aioros adapted from WolfPP
#In BattleHandlers::EOREffectAbility add:

BattleHandlers::EOREffectAbility.add(:HUNGERSWITCH,
  proc { |ability,battler,battle|
    if isConst?(battler.species,PBSpecies,:MORPEKO)
      battle.pbShowAbilitySplash(battler)
      battler.form=(battler.form==0) ? 1 : 0
      battler.pbUpdate(true)
      battle.scene.pbChangePokemon(battler,battler.pokemon)
      battle.pbDisplay(_INTL("{1} transformed!",battler.pbThis))
      battle.pbHideAbilitySplash(battler)
    end
  }
)

#In Battler_ChangeSelf, look for #Reset Form and after
#    @pokemon.makeUnprimal if primal?, add:

    if @pokemon.species == isConst?(@pokemon.species,PBSpecies,:MORPEKO) && @pokemon.form!=0
      @pokemon.form = 0
    end
	
#In PokeBattle_BattleCommon, look for "# Modify the Pokémon's properties because of the capture"
#a couple lines down from there u'll find @pokemon.makeUnprimal if primal?, add right after:
      if pkmn.species == isConst?(pkmn.species,PBSpecies,:MORPEKO) && pkmn.form!=0
        pkmn.form = 0
      end
	  
#In PField_Battles, in def pbAfterBattle(decision,canLose)
def pbAfterBattle(decision,canLose)      
  $Trainer.party.each do |pkmn|
    pkmn.statusCount = 0 if pkmn.status==PBStatuses::POISON   # Bad poison becomes regular
    pkmn.makeUnmega
    pkmn.makeUnprimal
    if pkmn.species == isConst?(pkmn.species,PBSpecies,:MORPEKO) && pkmn.form!=0  ##add this
      pkmn.form = 0  ##add this
    end  ##add this

This will also reset Morpeko to form 0 when:
A wild morpeko is captured
A battle is over
Morpeko faints
(i think I've covered all the cases)

edit:
Notes on Ice Face:
As far as I tested it's functioning with just 1 minor error.
You can set up more then 1 Ice Face per Hail by switching out.
I believe this is a direct consequence of hijacking cherrim code, one possible fix would be call the form change just when hail is started. But then in this scenario:
Turn 1: Hail starts
Turn 2: Ice face breaks : - Here it should restore its iceface and won't, so that would be equally bugged.
I think think adding a battler effect that increases to 1 when iceface is triggered once, and adding that check on the iceface transformation + reseting that battler efect when hail expires would do the trick.

 

[KyureJL]

660 people downloaded, only 8 are contributing and only Aioross report bugs..... people download and don't even test it... i will remember this next time. Changing the subject i cleaned up the code comparing the changes with the original branch. Next update on my part is to update all pbs to facilitate the supposed tests that should be taking place...

 

[Aioross]

Gulp Missile (apparently v18 handles form reverts automatically so that part wasn't needed - also he will change form even if he's move does no damage because I found no information saying otherwise):

Spoiler:

########################################################################################################
########## Gulp Missile - Aioros adapted from WolfPP
#Find class PokeBattle_Move_0CB < PokeBattle_TwoTurnMove
#add after @battle.pbDisplay(_INTL("{1} hid underwater!",user.pbThis)):
    if isConst?(user.species,PBSpecies,:CRAMORANT) && 
      user.hasActiveAbility?(:GULPMISSILE) && user.form==0
      user.form=2
      user.form=1 if user.hp>(user.totalhp/2) 
      @battle.scene.pbChangePokemon(user,user.pokemon)
    end    
#goes to form 1 or 2 when it dives
#Find class PokeBattle_Move_075 < PokeBattle_Move
#after: 
#  def pbModifyDamage(damageMult,user,target)
#    damageMult *= 2 if target.inTwoTurnAttack?("0CB")   # Dive
#    return damageMult
#  end
#add:
  def pbEffectAfterAllHits(user,target)
    if isConst?(user.species,PBSpecies,:CRAMORANT) && 
      user.hasActiveAbility?(:GULPMISSILE) && user.form==0
      user.form=2
      user.form=1 if user.hp>(user.totalhp/2) 
      @battle.scene.pbChangePokemon(user,user.pokemon)
    end
  end
 #goes to form 1 or 2 when it uses surf, regardless if the move hits cuz even if he does no dmg he stil surfed and captured smth
 
 #Add blacklist exceptions to:
 #Wandering Spirit, Mummy?, Trace, power of alchemy in abilities
 #Gastro Acid, Worry Seed, Simple Beam
 #Role Play, Skill Swap, Entrainment if either pokemon has this ability
 
 #In Battle_Handlers_Abilities, in TargetAbilityOnHit, add:
 
BattleHandlers::TargetAbilityOnHit.add(:GULPMISSILE,
  proc { |ability,user,target,move,battle|
    next if target.form==0
    if isConst?(target.species,PBSpecies,:CRAMORANT)
      battle.pbShowAbilitySplash(target)
      gulpform=target.form
      target.form = 0
      battle.scene.pbChangePokemon(target,target.pokemon)
      if user.takesIndirectDamage?(PokeBattle_SceneConstants::USE_ABILITY_SPLASH)
        battle.scene.pbDamageAnimation(user)
        user.pbReduceHP(user.totalhp/4,false)
        if gulpform==1
          user.pbLowerStatStageByAbility(PBStats::DEFENSE,1,target,false)
        elsif gulpform==2
          msg = nil
          user.pbParalyze(target,msg)
        end        
      end
      battle.pbHideAbilitySplash(target)
    end
  }
)

Gonna try to Mirror Armor now,... then only Neutralizing Gas will be left from the abilities... but that's a hornet's nest i'd rather not touch.

 

[भाग्य ज्योति]

good work man. Gonna download it and see what can I do.

 

[Aioross]

Mirror Armor:

Spoiler:

########################################################################################################
########## Mirror Armor - Aioros with help from Golisopod User
#In Battler_StatStages, find def pbLowerStatStage(stat,increment,user,showAnim=true,ignoreContrary=false)
#after:
#    # Contrary
#    if hasActiveAbility?(:CONTRARY) && !ignoreContrary && [email protected]
#      return pbRaiseStatStage(stat,increment,user,showAnim,true)
#    end
#add:
    # Mirror Armor
    if hasActiveAbility?(:MIRRORARMOR) && (!user || user.index!=@index) && [email protected]
      battle.pbShowAbilitySplash(self)
      @battle.pbDisplay(_INTL("{1}'s Mirror Armor activated!",pbThis))
[B]      if !user  ##failsafe against stats down with no user (ie doing physical move on kingshield)
        battle.pbHideAbilitySplash(self)
        return false 
      end[/B]
      if user.pbCanLowerStatStage?(stat) && !user.hasActiveAbility?(:MIRRORARMOR)
        user.pbLowerStatStageByAbility(stat,increment,user,splashAnim=false,checkContact=false)
      end
      battle.pbHideAbilitySplash(self)
      return false
    end