[Scripting Question] HELP ME FIX THIS CODE!!! :(

[Golisopod User]

But which newspecies do I replace? The one near if pokemon.hp>0 or the other one?

Both

 

[clawort]

Both

Example of fixed code please?

 

[clawort]

I also thought of using this version of the code:

Spoiler:

ItemHandlers::UseOnPokemon.add(:REVEALGLASS,proc{|item,pokemon,scene|
if (isConst?(pokemon.species,PBSpecies,:TORNADUS) ||
isConst?(pokemon.species,PBSpecies,:THUNDURUS) ||
isConst?(pokemon.species,PBSpecies,:LANDORUS))
if pokemon.hp>0
pokemon.form=(pokemon.form==0) ? 1 : 0
scene.pbRefresh
scene.pbDisplay(_INTL("{1} changed Forme!",pokemon.name))
next true
elsif (isConst?(pokemon.species,PBSpecies,:ELDISH))
if pokemon.hp>0
evo = PokemonEvolutionScene.new
evo.pbStartScreen(pokemon,newspecies)
evo.pbEvolution
evo.pbEndScreen
end
next true
else
scene.pbDisplay(_INTL("This can't be used on the fainted Pokémon."))
end
else
scene.pbDisplay(_INTL("It had no effect."))
next false
end
})

 

[clawort]

Well there ya go. You have two instances of "newspecies" (bolded), but you dont have that variable set to anything. "Newspecies" doesn't mean anything on its own. You probably just copied something from elsewhere in the script that uses "newspecies" as a variable for something.

Oh! I forgot to tell you, I used the evolution stone's script for the new Reveal Glass code!

Spoiler:

ItemHandlers::UseOnPokemon.addIf(proc{|item| pbIsEvolutionStone?(item)},
proc{|item,pokemon,scene|
if (pokemon.isShadow? rescue false)
scene.pbDisplay(_INTL("It won't have any effect."))
next false
end
newspecies=pbCheckEvolution(pokemon,item)
if newspecies<=0
scene.pbDisplay(_INTL("It won't have any effect."))
next false
else
pbFadeOutInWithMusic(99999){
evo=PokemonEvolutionScene.new
evo.pbStartScreen(pokemon,newspecies)
evo.pbEvolution(false)
evo.pbEndScreen
if scene.is_a?(PokemonBag_Scene)
scene.pbRefreshAnnotations(proc{|p| pbCheckEvolution(p,item)>0 })
scene.pbRefresh
end
}
next true
end
})

 

[clawort]

I've solved my issue myself! All I did was set the Reveal Glass to behave like an evolution stone, but not disappear after use, and made another item to change Tornadus, Thururus and Landorus's forms!